Skip to contentSkip to conversation

arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'

PATCH Applied Fabio Estevam 3 participants 4 messages Jul 1, 2024 – Jul 2, 2024

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp: Remove 'snps,rx-sched-sp'

From: Fabio Estevam <[email protected]>

According to nxp,dwmac-imx.yaml, 'snps,rx-sched-sp' is not a valid property.

Remove it from the imx8mp board devicetree files to avoid dt-schema warnings:

... 'snps,tx-sched-sp' does not match any of the regexes

---
 arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 2 --
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts         | 1 -
 arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi     | 2 --
 3 files changed, 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi +0 -2
index 8be251b69378..15f7ab58db36 100644
@@ -71,7 +71,6 @@ ethphy0: ethernet-phy@3 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -106,7 +105,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
arch/arm64/boot/dts/freescale/imx8mp-evk.dts +0 -1
index c2c708c492c0..35e0ed23bbdb 100644
@@ -294,7 +294,6 @@ ethphy0: ethernet-phy@1 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +0 -2
index c96e74684e03..d23a3942174d 100644
@@ -241,7 +241,6 @@ ethphy0: ethernet-phy@7 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -276,7 +275,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

According to nxp,dwmac-imx.yaml, 'snps,rx-sched-sp' is not a valid property.

Quoted 7 lines

Remove it from the imx8mp board devicetree files to avoid dt-schema warnings:

... 'snps,tx-sched-sp' does not match any of the regexes

---

No sure why Krzysztof NACK a similar patch

https://lore.kernel.org/imx/[email protected]/#t

Frank

Quoted 60 lines
 arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 2 --
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts         | 1 -
 arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi     | 2 --
 3 files changed, 5 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi +0 -2
index 8be251b69378..15f7ab58db36 100644
@@ -71,7 +71,6 @@ ethphy0: ethernet-phy@3 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -106,7 +105,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
arch/arm64/boot/dts/freescale/imx8mp-evk.dts +0 -1
index c2c708c492c0..35e0ed23bbdb 100644
@@ -294,7 +294,6 @@ ethphy0: ethernet-phy@1 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +0 -2
index c96e74684e03..d23a3942174d 100644
@@ -241,7 +241,6 @@ ethphy0: ethernet-phy@7 {
 
 	mtl_rx_setup: rx-queues-config {
 		snps,rx-queues-to-use = <5>;
-		snps,rx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -276,7 +275,6 @@ queue4 {
 
 	mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <5>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
Signature · 1 line
2.34.1
author reviewer
#2 lore raw
Quoted 1 line · Frank Li

No sure why Krzysztof NACK a similar patch

If I understood correctly, he did not provide a Reviewed-by tag on that patch.