arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
--- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso | 5 ----- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso | 5 ----- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso | 6 ------ 3 files changed, 16 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso +0 -5
@@ -14,11 +14,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &gpio3 { pinctrl-names = "default"; pinctrcl-0 = <&pinctrl_gpio3_hog>;
arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso +0 -5
@@ -15,11 +15,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &gpio3 { pinctrl-names = "default"; pinctrcl-0 = <&pinctrl_gpio3_hog>;
arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso +0 -6
@@ -14,12 +14,6 @@ /dts-v1/; /plugin/; - -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &uart2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart2>;
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH 2/2 arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
--- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ---- 3 files changed, 12 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso +0 -4
@@ -15,10 +15,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso +0 -4
@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso +0 -4
@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;
Signature · 1 line
2.34.1
Re: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
Hi,
I missed it, thanks for fixing it.
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by Fabio Estevam <[email protected]>
Thanks,
Parthiban N
Quoted 51 lines
--- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ---- 3 files changed, 12 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso +0
-4@@ -15,10 +15,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso +0
-4@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso +0
-4@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;
Re: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
In reply to Fabio EstevamQuoted 61 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by Fabio Estevam <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ---- .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ---- 3 files changed, 12 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso +0
-4@@ -15,10 +15,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso +0
-4@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog;arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso +0
-5@@ -18,10 +18,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "gw,imx8mm-gw72xx-0x"; -}; - &gpio4 { rs485_en { gpio-hog; --
Quoted 2 lines
2.34.1
Hi Fabio,
Thanks for the fixup. Is there a warning now that detects these?
The same likely needs to be done to imx8mm-venice-gw73xx-*.dtso and imx8mp-venice-gw74xx*.dtso. My original intention with the compatible strings was to define what the overlay is compatible with but this certainly was not the right way to do that (i'm not sure what is honestly).
Best Regards,
Tim
Fabio Estevam
reviewerRe: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
Hi Tim,
Quoted 3 lines · Tim Harvey
Hi Fabio,
Thanks for the fixup. Is there a warning now that detects these?
Yes, super massive warning when running "make dtbs_check":
Here it goes:
https://paste.to/?89f9844dc5b8f637#7s2w1yEc84cwkZVPTZmiqarkrsn99x9mVsjsSgXXukrm
Hi,
I missed this as well, Thanks for fixing it.
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by Fabio Estevam <[email protected]>
Thanks,
Parthiban N
Quoted 55 lines
--- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso | 5 ----- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso | 5 ----- .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso | 6 ------ 3 files changed, 16 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso +0
-5@@ -14,11 +14,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &gpio3 { pinctrl-names = "default"; pinctrcl-0 = <&pinctrl_gpio3_hog>;arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso +0
-5@@ -15,11 +15,6 @@ /dts-v1/; /plugin/; -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &gpio3 { pinctrl-names = "default"; pinctrcl-0 = <&pinctrl_gpio3_hog>;arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso +0
-6@@ -14,12 +14,6 @@ /dts-v1/; /plugin/; - -&{/} { - compatible = "phytec,imx8mm-phygate-tauri-l"; - -}; - &uart2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart2>;
Shawn Guo
AppliedQuoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to describe the compatible string inside a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by Fabio Estevam <[email protected]>
Applied both, thanks!