Skip to contentSkip to conversation

power: supply: add support for MAX1720x standalone fuel

PATCH Applied Dimitri Fedrau 2 participants 4 messages Jul 2, 2024 – Jul 4, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v6 cover power: supply: add support for MAX1720x standalone fuel

Changes to max1721x_battery.c:
- reading manufacturer, model name and serial number is only possible when SBS functions of the IC are enabled.(nNVCfg0.enSBS) Factory default is off. Manufacturer is "Maxim Integrated" and the model name can be derived by register MAX172XX_DEV_NAME. Serial number is not available anymore.
- According to the datasheet MAX172XX_BAT_PRESENT is at BIT(3) not BIT(4). Furthermore the naming is misleading, when BIT(3) is set the battery is not present.
- Removed DeviceName, ManufacturerName and SerialNumber from struct

    max17211_device_info

Changes in V2:
- Changed E-Mail in Patch (2/2) Signed-Off

Changes in V3:
- Changed E-Mail in Patch (2/2) Author

Changes in V4:
- add compatibles "maxim,max17201, "maxim,max17205" in bindings
- use generic node name fuel-gauge@36 instead of max17201@36 in bindings
- remove status in bindings
- fix spelling mistakes in commit message
- fix indentation in Kconfig
- fix typos in max1720x_battery.c
- Drop bat and bat_desc from info struct.
- MAX172XX_DEV_NAME and MAX172XX_DESIGN_CAP aren't volatile, adjust regmap
- constify max1720x_manufacturer, max17201_model, max17205_model
- constify max1720x_battery_props
- Remove braces around reg in max172xx_current_to_voltage
- Skip initialization of reg_val in max1720x_battery_get_property
- Remove braces around FIELD_GET() in max1720x_battery_get_property
- In case POWER_SUPPLY_PROP_PRESENT there is an early return if ret < 0. Return 0 if regmap_read fails, device is not responding in case battery is not inserted
- Implement multi-byte readings instead of i2c_smbus_read_word_data
- Drop ancillary from info
- Drop both calls to i2c_set_clientdata in max1720x_probe
- Get rid of max1720x_remove
- Remove comma after sentinel in max1720x_of_match
- Fix alignment of max1720x_i2c_driver
- Fix return value of dev_err_probe after max1720x_probe_sense_resistor

    to use ret instead of PTR_ERR(info->bat)

Changes in V5:
- oneOf with list and fallback in bindings
- unevaluatedProperties: false in bindings
- switch back to i2c_smbus_read_word_data when reading from ancillary
- add psy_cfg.fwnode = dev_fwnode(dev) in max1720x_probe
- set max_register in max1720x_regmap_cfg to MAX172XX_ATAVCAP
- fix typo in define: MAX1720X_NRSENSE instead of MAX1720_NRSENSE

Changes in V6:
- s/1720x/17201/ in title and in the filename of the bindings
- remove compatible "maxim,max17205" from max1720x_of_match
- Added Reviewed-by: Sebastian Reichel <[email protected]>, hope this is still okay due to changes in V5 and V6

Dimitri Fedrau (2):
dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel
gauge
power: supply: add support for MAX1720x standalone fuel gauge

 .../bindings/power/supply/maxim,max17201.yaml |  58 +++
 drivers/power/supply/Kconfig                  |  12 +
 drivers/power/supply/Makefile                 |   1 +
 drivers/power/supply/max1720x_battery.c       | 337 ++++++++++++++++++
 4 files changed, 408 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml
 create mode 100644 drivers/power/supply/max1720x_battery.c
Signature · 1 line
2.39.2
#1 lore raw

PATCH v6 1/2 dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel gauge

Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge.

---
 .../bindings/power/supply/maxim,max17201.yaml | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml
Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml new file +58 -0
new file mode 100644
index 000000000000..fe3dd9bd5585
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX17201 fuel gauge
+
+maintainers:
+  - Dimitri Fedrau <[email protected]>
+
+allOf:
+  - $ref: power-supply.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - const: maxim,max17201
+      - items:
+          - enum:
+              - maxim,max17205
+          - const: maxim,max17201
+
+  reg:
+    items:
+      - description: ModelGauge m5 registers
+      - description: Nonvolatile registers
+
+  reg-names:
+    items:
+      - const: m5
+      - const: nvmem
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - reg-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fuel-gauge@36 {
+        compatible = "maxim,max17201";
+        reg = <0x36>, <0xb>;
+        reg-names = "m5", "nvmem";
+        interrupt-parent = <&gpio0>;
+        interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+      };
+    };
Signature · 1 line
2.39.2
#2 lore raw

PATCH v6 2/2 power: supply: add support for MAX1720x standalone fuel gauge

In reply to Dimitri Fedrau

The MAX17201 monitors a single cell pack. The MAX17205 monitors and balances a 2S or 3S pack or monitors a multiple-series cell pack. Both devices use a I2C interface.

---
 drivers/power/supply/Kconfig            |  12 +
 drivers/power/supply/Makefile           |   1 +
 drivers/power/supply/max1720x_battery.c | 337 ++++++++++++++++++++++++
 3 files changed, 350 insertions(+)
 create mode 100644 drivers/power/supply/max1720x_battery.c
drivers/power/supply/Kconfig +12 -0
index 3e31375491d5..9294520b64a3 100644
@@ -402,6 +402,18 @@ config BATTERY_MAX17042
 
 	  Driver can be build as a module (max17042_battery).
 
+config BATTERY_MAX1720X
+	tristate "Maxim MAX17201/MAX17205 Fuel Gauge"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	  MAX1720x is a family of fuel-gauge systems for lithium-ion (Li+)
+	  batteries in handheld and portable equipment. MAX17201 are
+	  configured to operate with a single lithium cell, the MAX17205
+	  can operate with multiple cells.
+
+	  Say Y to include support for the MAX17201/MAX17205 Fuel Gauges.
+
 config BATTERY_MAX1721X
 	tristate "MAX17211/MAX17215 standalone gas-gauge"
 	depends on W1
drivers/power/supply/Makefile +1 -0
index 58b567278034..6f02d0248826 100644
@@ -52,6 +52,7 @@ obj-$(CONFIG_CHARGER_DA9150)	+= da9150-charger.o
 obj-$(CONFIG_BATTERY_DA9150)	+= da9150-fg.o
 obj-$(CONFIG_BATTERY_MAX17040)	+= max17040_battery.o
 obj-$(CONFIG_BATTERY_MAX17042)	+= max17042_battery.o
+obj-$(CONFIG_BATTERY_MAX1720X)	+= max1720x_battery.o
 obj-$(CONFIG_BATTERY_MAX1721X)	+= max1721x_battery.o
 obj-$(CONFIG_BATTERY_RT5033)	+= rt5033_battery.o
 obj-$(CONFIG_CHARGER_RT5033)	+= rt5033_charger.o
drivers/power/supply/max1720x_battery.c new file +337 -0

337 lines not on this page · raw message

Signature · 1 line
2.39.2
#3 lore raw
In reply to Dimitri Fedrau
Quoted 10 lines · Dimitri Fedrau

Changes to max1721x_battery.c:
- reading manufacturer, model name and serial number is only possible when SBS functions of the IC are enabled.(nNVCfg0.enSBS) Factory default is off. Manufacturer is "Maxim Integrated" and the model name can be derived by register MAX172XX_DEV_NAME. Serial number is not available anymore.
- According to the datasheet MAX172XX_BAT_PRESENT is at BIT(3) not BIT(4). Furthermore the naming is misleading, when BIT(3) is set the battery is not present.
- Removed DeviceName, ManufacturerName and SerialNumber from struct

Quoted 3 lines
    max17211_device_info

[...]

Applied, thanks!

[1/2] dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel gauge

      commit: ad0aa2361c8c0d1f29db3d6da4a11be41813296d
[2/2] power: supply: add support for MAX1720x standalone fuel gauge
      commit: 479b6d04964b5abe66c9f5080fad3389b34e2a70

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>