Skip to contentSkip to conversation

package/linux-firmware: change Amlogic Bluetooth binary path

PATCH In review Yang Li 3 participants 4 messages Jul 2, 2024 – Jul 13, 2024

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 package/linux-firmware: change Amlogic Bluetooth binary path

remove bluetooth subdirectory, and use generic pattern aml_* to install all bluetooth binary.

---
 package/linux-firmware/linux-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/linux-firmware/linux-firmware.mk +1 -1
index 13dbc6d98c..22ebecf6c6 100644
@@ -53,7 +53,7 @@ endif
 
 # Amlogic SoC Bluetooth
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amlogic
 endif
 
Signature · 6 lines
2.42.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Yang,

Thanks for your patch, which I have applied, after doing some changes, see below.

Quoted 2 lines · On Tue, 2 Jul 2024 20:17:37 +0800 Yang Li <[email protected]> wrote:

remove bluetooth subdirectory, and use generic pattern aml_* to install all bluetooth binary.

This commit log was not sufficient. It does not explain since when the bluetooth/ directory has been removed. This information is absolutely *critical* as it allows us to figure out whether this fix needs to be backported or not to previous version of Buildroot. Therefore, I have changed the commit log to:

package/linux-firmware: change Amlogic Bluetooth binary path

Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which first appeared in linux-firmware 20240709, the amlogic bluetooth firmware files have been moved from amlogic/bluetooth/ to directly amlogic/.

package/linux-firmware/linux-firmware.mk endif · line 56

Quoted 4 lines

# Amlogic SoC Bluetooth
ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)

package/linux-firmware/linux-firmware.mk +1 -1
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*

The change from *.bin to aml_* looked unnecessary. As far as I can see, all files still have a .bin extension, so this change looked gratuitous, and was not explained in the commit log. So I kept the *.bin for now. If needed a future commit can be made, with a proper explanation as to why aml_* is a better wildcard.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#2 lore raw

Dear Thomas

Thanks for your help.

Quoted 20 lines · Thomas Petazzoni

[????????? [email protected] ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]

[ EXTERNAL EMAIL ]

Hello Yang,

Thanks for your patch, which I have applied, after doing some changes, see below.

Quoted 2 lines · On Tue, 2 Jul 2024 20:17:37 +0800 Yang Li <[email protected]> wrote:

remove bluetooth subdirectory, and use generic pattern aml_* to install all bluetooth binary.

This commit log was not sufficient. It does not explain since when the bluetooth/ directory has been removed. This information is absolutely *critical* as it allows us to figure out whether this fix needs to be backported or not to previous version of Buildroot. Therefore, I have changed the commit log to:

Quoted 6 lines

package/linux-firmware: change Amlogic Bluetooth binary path

Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which first appeared in linux-firmware 20240709, the amlogic bluetooth firmware files have been moved from amlogic/bluetooth/ to directly amlogic/.

It's great!

Quoted 9 lines

package/linux-firmware/linux-firmware.mk endif · line 56

Quoted 4 lines
  # Amlogic SoC Bluetooth
  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_AMLOGIC),y)
package/linux-firmware/linux-firmware.mk +1 -1
-LINUX_FIRMWARE_FILES += amlogic/bluetooth/*.bin
+LINUX_FIRMWARE_FILES += amlogic/aml_*

The change from *.bin to aml_* looked unnecessary. As far as I can see, all files still have a .bin extension, so this change looked gratuitous, and was not explained in the commit log. So I kept the *.bin for now. If needed a future commit can be made, with a proper explanation as to why aml_* is a better wildcard.

Well, It's all right with me.

Thanks again.

Quoted 7 lines

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

Hello Yang,
Thanks for your patch, which I have applied, after doing some changes, see below.

Quoted 2 lines · On Tue, 2 Jul 2024 20:17:37 +0800 Yang Li <[email protected]> wrote:

remove bluetooth subdirectory, and use generic pattern aml_* to install all bluetooth binary.

This commit log was not sufficient. It does not explain since when the bluetooth/ directory has been removed. This information is absolutely *critical* as it allows us to figure out whether this fix needs to be backported or not to previous version of Buildroot. Therefore, I have changed the commit log to:

Quoted 6 lines

package/linux-firmware: change Amlogic Bluetooth binary path

Since upstream commit 7d931f8afa51d83e9eaee3a3f449bc2f86a5edf3, which first appeared in linux-firmware 20240709, the amlogic bluetooth firmware files have been moved from amlogic/bluetooth/ to directly amlogic/.

How does that work? Master has LINUX_FIRMWARE_VERSION = 20240410, E.G. an earlier version than that?

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot