Skip to contentSkip to conversation

KVM: s390: remove useless include

PATCH In review Claudio Imbrenda 3 participants 3 messages Jul 2, 2024 – Jul 3, 2024

Subsystems (3)
lore
Share & tools
lore

Claudio Imbrenda

author maintainer
#0 lore raw

PATCH 1/1 KVM: s390: remove useless include

arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but linux/kvm_host.h includes asm/kvm_host.h .

It turns out that arch/s390/include/asm/kvm_host.h only needs linux/kvm_types.h, which it already includes.

Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .

Due to the #ifdef guards, the code works as it is today, but it's ugly and it will get in the way of future patches.

---
 arch/s390/include/asm/kvm_host.h | 1 -
 1 file changed, 1 deletion(-)
arch/s390/include/asm/kvm_host.h +0 -1
index 95990461888f..736cc88f497d 100644
@@ -15,7 +15,6 @@
 #include <linux/hrtimer.h>
 #include <linux/interrupt.h>
 #include <linux/kvm_types.h>
-#include <linux/kvm_host.h>
 #include <linux/kvm.h>
 #include <linux/seqlock.h>
 #include <linux/module.h>
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw

Quoting Claudio Imbrenda (2024-07-02 17:56:06)

Quoted 6 lines

arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but linux/kvm_host.h includes asm/kvm_host.h .

It turns out that arch/s390/include/asm/kvm_host.h only needs linux/kvm_types.h, which it already includes.

Quoted 6 lines

Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .

Due to the #ifdef guards, the code works as it is today, but it's ugly and it will get in the way of future patches.

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Claudio Imbrenda
Quoted 10 lines · Claudio Imbrenda

arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but linux/kvm_host.h includes asm/kvm_host.h .

It turns out that arch/s390/include/asm/kvm_host.h only needs linux/kvm_types.h, which it already includes.

Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .

Due to the #ifdef guards, the code works as it is today, but it's ugly and it will get in the way of future patches.