Skip to contentSkip to conversation

ARM: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

PATCH In review Marek Vasut 5 participants 17 messages Jun 30, 2024 – Jul 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";

---
Cc: Conor Dooley <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Khuong Dinh <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
Note: this closes only part of the report

---
 arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts +1 -2
index cd2324b8e8ffb..41b1dbcfba100 100644
@@ -95,8 +95,7 @@ &ether1 {
 	renesas,no-ether-link;
 	phy-handle = <&phy1>;
 	phy1: ethernet-phy@1 {
-		compatible = "ethernet-phy-id001c.c816",
-			     "ethernet-phy-ieee802.3-c22";
+		compatible = "ethernet-phy-id001c.c816";
 		reg = <0>;
 	};
 };
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";

---
Cc: Conor Dooley <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Khuong Dinh <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
Note: this closes only part of the report

---
 arch/arm64/boot/dts/renesas/cat875.dtsi           | 3 +--
 arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi   | 3 +--
 arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/renesas/cat875.dtsi +1 -2
index 8c9da8b4bd60b..502764aef210b 100644
@@ -22,8 +22,7 @@ &avb {
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		compatible = "ethernet-phy-id001c.c915",
-			     "ethernet-phy-ieee802.3-c22";
+		compatible = "ethernet-phy-id001c.c915";
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi +1 -2
index ad898c6db4e62..d7a8de2619263 100644
@@ -24,8 +24,7 @@ &avb {
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		compatible = "ethernet-phy-id001c.c915",
-			     "ethernet-phy-ieee802.3-c22";
+		compatible = "ethernet-phy-id001c.c915";
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts +1 -2
index 39fe3f94991e3..07147743de93f 100644
@@ -100,8 +100,7 @@ &avb {
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-		compatible = "ethernet-phy-id001c.c916",
-			     "ethernet-phy-ieee802.3-c22";
+		compatible = "ethernet-phy-id001c.c916";
 		reg = <0>;
 	};
 };
Signature · 1 line
2.43.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 13 lines · Marek Vasut

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";
Quoted 3 lines

"ethernet-phy-ieee802.3-c22" is pretty much pointless. I don't remember seeing a DT description which actually needs it. It is in the binding more for completion, since "ethernet-phy-ieee802.3-c45" is needed sometimes, and -c22 just completes the list.

Andrew

#3 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

In reply to Marek Vasut

Hi Marek,

Quoted 13 lines · Marek Vasut

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";
Quoted 3 lines

Thanks for your patch!

Quoted 1 line

Note: this closes only part of the report

In that case you should use a Link: instead of a Closes: tag?

arch/arm64/boot/dts/renesas/cat875.dtsi &avb { · line 28

Quoted 12 lines
arch/arm64/boot/dts/renesas/cat875.dtsi +1 -2
@@ -22,8 +22,7 @@ &avb {
        status = "okay";
 
        phy0: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c915",
-                            "ethernet-phy-ieee802.3-c22";
+               compatible = "ethernet-phy-id001c.c915";
                reg = <0>;
                interrupt-parent = <&gpio2>;
                interrupts = <21 IRQ_TYPE_LEVEL_LOW>;

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

[1] https://lore.kernel.org/linux-renesas-soc/[email protected]
[2] commit d45ba2a5f718346e ("arm64: dts: renesas: Add compatible properties to RTL8211E Ethernet PHYs").

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#4 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 18 lines · Marek Vasut
Quoted 13 lines

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
       1 ethernet-phy-id001c.c816",
       2 ethernet-phy-id001c.c915",
       2 ethernet-phy-id001c.c915";
       5 ethernet-phy-id001c.c916",
      13 ethernet-phy-id001c.c916";
Quoted 3 lines
Quoted 5 lines

Thanks for your patch!

Quoted 1 line

Note: this closes only part of the report

In that case you should use a Link: instead of a Closes: tag?

But which patch would be the one that Closes that report then ?

Quoted 17 lines

arch/arm64/boot/dts/renesas/cat875.dtsi &avb { · line 28

Quoted 12 lines
arch/arm64/boot/dts/renesas/cat875.dtsi +1 -2
@@ -22,8 +22,7 @@ &avb {
         status = "okay";
 
         phy0: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c915",
-                            "ethernet-phy-ieee802.3-c22";
+               compatible = "ethernet-phy-id001c.c915";
                 reg = <0>;
                 interrupt-parent = <&gpio2>;
                 interrupts = <21 IRQ_TYPE_LEVEL_LOW>;

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

Quoted 3 lines

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

#5 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Hi Marek,

Quoted 19 lines · Marek Vasut
Quoted 18 lines · Geert Uytterhoeven
Quoted 16 lines · Marek Vasut

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
       1 ethernet-phy-id001c.c816",
       2 ethernet-phy-id001c.c915",
       2 ethernet-phy-id001c.c915";
       5 ethernet-phy-id001c.c916",
      13 ethernet-phy-id001c.c916";
Quoted 7 lines
Quoted 5 lines

Thanks for your patch!

Quoted 1 line

Note: this closes only part of the report

In that case you should use a Link: instead of a Closes: tag?

But which patch would be the one that Closes that report then ?

The "last" one that goes in (in parallel with the others)? Yes, this is not easy to automate...

Quoted 21 lines
Quoted 17 lines

arch/arm64/boot/dts/renesas/cat875.dtsi &avb { · line 28

Quoted 12 lines
arch/arm64/boot/dts/renesas/cat875.dtsi +1 -2
@@ -22,8 +22,7 @@ &avb {
         status = "okay";
 
         phy0: ethernet-phy@0 {
-               compatible = "ethernet-phy-id001c.c915",
-                            "ethernet-phy-ieee802.3-c22";
+               compatible = "ethernet-phy-id001c.c915";
                 reg = <0>;
                 interrupt-parent = <&gpio2>;
                 interrupts = <21 IRQ_TYPE_LEVEL_LOW>;

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

Quoted 3 lines

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

Does the rtl82xx PHY have special reset sequencing requirements?

Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

2. The PHY node does not have a compatible value, and a different PHY is mounted:
a. The new PHY does not need specific reset sequencing,
and the existing reset-gpios is fine: the new PHY will just work, as it is auto-detected.
b. The new PHY does need specific reset sequencing: the
new PHY will not work.

Which case is preferable? Case 1 or 2?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#6 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 3 lines · Geert Uytterhoeven

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

It's possible to have a rest-gpios property both in the mdio node and the phy node. The former resets the whole bus while the later a single PHY, at least that's my understanding.

I think it would be more correct to move the reset-gpios up one level for r8a779g0. However as it already was in the PHY node and this functioned as it should I kept it there.

The need for the mdio node was to avoid a device specific property added in the BSP to reset the whole bus. At the moment I can't recall the two different call sites for when the two resets are called. Maybe if we move it to the mdio node we can avoid setting the PHY id in the compatible string as we could then always probe the PHY correctly. I will look into it.

Signature · 2 lines
Kind Regards,
Niklas Söderlund
#7 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 8 lines · Niklas Söderlund
Quoted 3 lines · Geert Uytterhoeven

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

It's possible to have a rest-gpios property both in the mdio node and the phy node. The former resets the whole bus while the later a single PHY, at least that's my understanding.

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

Quoted 10 lines

I think it would be more correct to move the reset-gpios up one level for r8a779g0. However as it already was in the PHY node and this functioned as it should I kept it there.

The need for the mdio node was to avoid a device specific property added in the BSP to reset the whole bus. At the moment I can't recall the two different call sites for when the two resets are called. Maybe if we move it to the mdio node we can avoid setting the PHY id in the compatible string as we could then always probe the PHY correctly. I will look into it

Thanks

#8 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 6 lines · Marek Vasut
Quoted 5 lines · Niklas Söderlund
Quoted 3 lines · Geert Uytterhoeven

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

Quoted 7 lines
Quoted 3 lines

It's possible to have a rest-gpios property both in the mdio node and the phy node. The former resets the whole bus while the later a single PHY, at least that's my understanding.

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

There is a use-case for a single PHY on the MDIO bus too, at least in Linux as I understand it. If the boot process leave the PHY in a bad state which prevents it from being probed. A GPIO reset in the MDIO node is used when the MDIO bus is registered thus resetting all (in this use-case the one) PHYs which later allows them to be probed. A GPIO reset on the PHY node is only used after a PHY have been probed, at least that is my understanding.

This is the use-case for adding a MDIO node to the AVB driver and WhiteHawk.

Signature · 2 lines
Kind Regards,
Niklas Söderlund
#9 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Hi Niklas,

Quoted 15 lines · Niklas Söderlund
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Niklas Söderlund
Quoted 3 lines · Geert Uytterhoeven

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

Quoted 7 lines
Quoted 3 lines

It's possible to have a rest-gpios property both in the mdio node and the phy node. The former resets the whole bus while the later a single PHY, at least that's my understanding.

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

Quoted 7 lines

There is a use-case for a single PHY on the MDIO bus too, at least in Linux as I understand it. If the boot process leave the PHY in a bad state which prevents it from being probed. A GPIO reset in the MDIO node is used when the MDIO bus is registered thus resetting all (in this use-case the one) PHYs which later allows them to be probed. A GPIO reset on the PHY node is only used after a PHY have been probed, at least that is my understanding.

The reset is also asserted on driver unbind.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#10 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

In reply to Geert Uytterhoeven
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

[...]

Quoted 15 lines
Quoted 8 lines
Quoted 7 lines

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

Quoted 4 lines

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

That's a different use case, that commit uses generic "ethernet-phy-ieee802.3-c45" compatible string and the PHY type is determined by reading out the PHY ID registers after the reset is released.

This here uses specific compatible string, so the kernel can determine the PHY ID from the DT before the reset is released .

Quoted 5 lines

Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices") did keep the reset-gpios property in the PHY node. I guess it should be moved one level up?

Does the rtl82xx PHY have special reset sequencing requirements?

Aside from reset timing, which does not seem to be in use here, not that I am aware of.

Quoted 10 lines
Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

What is the likelihood of such PHY exchange happening with these three specific boards ? I think close to none, as that would require a board redesign to swap in a different PHY.

Quoted 5 lines

2. The PHY node does not have a compatible value, and a different PHY is mounted:
a. The new PHY does not need specific reset sequencing,
and the existing reset-gpios is fine: the new PHY will just work, as it is auto-detected.

Or maybe, it will work by sheer chance, the reset timing would be off for the new PHY, but nobody will notice until much later. At least with the specific compatible string, such a PHY exchange would be detected outright.

Quoted 4 lines

b. The new PHY does need specific reset sequencing: the
new PHY will not work.

Which case is preferable? Case 1 or 2?

I think 1 because that is the well defined option which always works or always fails.

#11 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Hi Marek,

Quoted 21 lines · Marek Vasut
Quoted 15 lines · Geert Uytterhoeven
Quoted 8 lines
Quoted 7 lines

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

Quoted 4 lines

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

Quoted 6 lines

That's a different use case, that commit uses generic "ethernet-phy-ieee802.3-c45" compatible string and the PHY type is determined by reading out the PHY ID registers after the reset is released.

This here uses specific compatible string, so the kernel can determine the PHY ID from the DT before the reset is released .

I am suggesting removing the specific compatible string here, too, introducing an mdio subnode, so the kernel can read it from the PHY ID registers after the reset is released?

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

Quoted 7 lines
Quoted 3 lines

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

What is the likelihood of such PHY exchange happening with these three specific boards ? I think close to none, as that would require a board redesign to swap in a different PHY.

I don't know about the likelihood for these boards.
It did happen before on other boards, e.g. commit a0d23b8645b2d577 ("arm64: dts: renesas: beacon-renesom: Update Ethernet PHY ID").

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#12 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 26 lines · Marek Vasut
Quoted 25 lines · Geert Uytterhoeven
Quoted 15 lines
Quoted 8 lines
Quoted 7 lines

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

Quoted 4 lines

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

That's a different use case, that commit uses generic "ethernet-phy-ieee802.3-c45" compatible string and the PHY type is determined by reading out the PHY ID registers after the reset is released.

Quoted 6 lines
Quoted 2 lines

This here uses specific compatible string, so the kernel can determine the PHY ID from the DT before the reset is released .

I am suggesting removing the specific compatible string here, too, introducing an mdio subnode, so the kernel can read it from the PHY ID registers after the reset is released?

I wrote this to Niklas already, so let me expand on it:

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

In this case, the reset is connected to this single PHY, so the reset line connection is a property of the PHY and should be described in the PHY node.

You could argue that in this case, because there is only one PHY and only one reset line, it fits both categories, PHY reset and MDIO reset.

And then, there is the future-proofing aspect.

If the compatible string is retained, then if in the future there is some problem discovered related to the reset of this PHY, the PHY driver can match on the compatible string and apply a fix up. But it prevents future PHY replacement (which is unlikely in my opinion).

If the compatible string is removed and the reset is moved to MDIO node, then replacement of the PHY in the future is likely possible (assuming it does not have any special reset timing requirements), but if there is a problem related to the reset of the current PHY model, the PHY driver cannot fix it up because there is no compatible to match on.

I think that about sums the pros and cons up, right ?

I also think there is no good solution here, only two bad ones, with different issues each.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

Quoted 7 lines
Quoted 3 lines

What is the likelihood of such PHY exchange happening with these three specific boards ? I think close to none, as that would require a board redesign to swap in a different PHY.

I don't know about the likelihood for these boards.
It did happen before on other boards, e.g. commit a0d23b8645b2d577 ("arm64: dts: renesas: beacon-renesom: Update Ethernet PHY ID").

I had that happen too. The solution there was to upstream the newer PHY ID and apply backward compatibility DTO that rewrote the PHY ID for the few older boards. The DTO application decision was done in U-Boot scripting.

It was not possible to auto-detect the PHY after deasserting its reset in my case, I had to determine whether to apply DTO or not based on strap resistors on the board.

#13 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 89 lines · Marek Vasut
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 26 lines · Marek Vasut
Quoted 25 lines · Geert Uytterhoeven
Quoted 15 lines
Quoted 8 lines
Quoted 7 lines

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

Quoted 4 lines

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

That's a different use case, that commit uses generic "ethernet-phy-ieee802.3-c45" compatible string and the PHY type is determined by reading out the PHY ID registers after the reset is released.

Quoted 6 lines
Quoted 2 lines

This here uses specific compatible string, so the kernel can determine the PHY ID from the DT before the reset is released .

I am suggesting removing the specific compatible string here, too, introducing an mdio subnode, so the kernel can read it from the PHY ID registers after the reset is released?

I wrote this to Niklas already, so let me expand on it:

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

In this case, the reset is connected to this single PHY, so the reset line connection is a property of the PHY and should be described in the PHY node.

You could argue that in this case, because there is only one PHY and only one reset line, it fits both categories, PHY reset and MDIO reset.

And then, there is the future-proofing aspect.

If the compatible string is retained, then if in the future there is some problem discovered related to the reset of this PHY, the PHY driver can match on the compatible string and apply a fix up. But it prevents future PHY replacement (which is unlikely in my opinion).

If the compatible string is removed and the reset is moved to MDIO node, then replacement of the PHY in the future is likely possible (assuming it does not have any special reset timing requirements), but if there is a problem related to the reset of the current PHY model, the PHY driver cannot fix it up because there is no compatible to match on.

I think that about sums the pros and cons up, right ?

I also think there is no good solution here, only two bad ones, with different issues each.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

Quoted 7 lines
Quoted 3 lines

What is the likelihood of such PHY exchange happening with these three specific boards ? I think close to none, as that would require a board redesign to swap in a different PHY.

I don't know about the likelihood for these boards.
It did happen before on other boards, e.g. commit a0d23b8645b2d577 ("arm64: dts: renesas: beacon-renesom: Update Ethernet PHY ID").

Quoted 7 lines

I had that happen too. The solution there was to upstream the newer PHY ID and apply backward compatibility DTO that rewrote the PHY ID for the few older boards. The DTO application decision was done in U-Boot scripting.

It was not possible to auto-detect the PHY after deasserting its reset in my case, I had to determine whether to apply DTO or not based on strap resistors on the board.

Beacon had to swap the phy due to the great part shortage of 2021 and having the hard-code ID's prevented backwards compatibility. For the Beacon downstream kernel, we removed the PHY ID and kept the generic 'ethernet-phy-ieee802.3-c22' because it could auto-detect what we needed and both PHY's appear to come out of reset and register properly. I don't know if we could make a generic phy-ieee802.3-c22 handle the reset, wait a moment and then try to auto-detect, but it would be nice to not have to jump through hoops if/when people need to change PHY's.

adam

Quoted 1 line
#14 lore raw

Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards

Quoted 94 lines · Adam Ford
Quoted 93 lines · Marek Vasut
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 26 lines · Marek Vasut
Quoted 25 lines · Geert Uytterhoeven
Quoted 15 lines
Quoted 8 lines
Quoted 7 lines

What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions.

According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2].

Quoted 6 lines

My understanding is that the compatible string is necessary if the PHY needs clock/reset sequencing of any kind. Without the compatible string, it is not possible to select the correct PHY driver which would handle that sequencing according to the PHY requirements. This board here does use reset-gpio property in the PHY node (it is not visible in this diff context), so I believe a compatible string should be present here.

Quoted 4 lines

With the introduction of an mdio subnode, the reset-gpios would move from the PHY node to the mio subnode, cfr. commit b4944dc7b7935a02 ("arm64: dts: renesas: white-hawk: ethernet: Describe AVB1 and AVB2") in linux-next.

That's a different use case, that commit uses generic "ethernet-phy-ieee802.3-c45" compatible string and the PHY type is determined by reading out the PHY ID registers after the reset is released.

Quoted 6 lines
Quoted 2 lines

This here uses specific compatible string, so the kernel can determine the PHY ID from the DT before the reset is released .

I am suggesting removing the specific compatible string here, too, introducing an mdio subnode, so the kernel can read it from the PHY ID registers after the reset is released?

I wrote this to Niklas already, so let me expand on it:

My understanding of reset GPIO in the MDIO node is that it is used in case there might be multiple PHYs with shared reset GPIO on the same MDIO bus. Like on the NXP iMX28 .

In this case, the reset is connected to this single PHY, so the reset line connection is a property of the PHY and should be described in the PHY node.

You could argue that in this case, because there is only one PHY and only one reset line, it fits both categories, PHY reset and MDIO reset.

And then, there is the future-proofing aspect.

If the compatible string is retained, then if in the future there is some problem discovered related to the reset of this PHY, the PHY driver can match on the compatible string and apply a fix up. But it prevents future PHY replacement (which is unlikely in my opinion).

If the compatible string is removed and the reset is moved to MDIO node, then replacement of the PHY in the future is likely possible (assuming it does not have any special reset timing requirements), but if there is a problem related to the reset of the current PHY model, the PHY driver cannot fix it up because there is no compatible to match on.

I think that about sums the pros and cons up, right ?

I also think there is no good solution here, only two bad ones, with different issues each.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

What would happen if this board got a revision with another PHY with different PHY reset sequencing requirements ? The MDIO node level reset handling might no longer be viable.

True. However, please consider these two cases, both assuming reset-gpios is in the MDIO node:

1. The PHY node has a compatible value, and a different PHY is
mounted: the new PHY will not work, as the wrong PHY driver is used.

Quoted 7 lines
Quoted 3 lines

What is the likelihood of such PHY exchange happening with these three specific boards ? I think close to none, as that would require a board redesign to swap in a different PHY.

I don't know about the likelihood for these boards.
It did happen before on other boards, e.g. commit a0d23b8645b2d577 ("arm64: dts: renesas: beacon-renesom: Update Ethernet PHY ID").

I had that happen too. The solution there was to upstream the newer PHY ID and apply backward compatibility DTO that rewrote the PHY ID for the few older boards. The DTO application decision was done in U-Boot scripting.

Quoted 5 lines
Quoted 3 lines

It was not possible to auto-detect the PHY after deasserting its reset in my case, I had to determine whether to apply DTO or not based on strap resistors on the board.

Beacon had to swap the phy due to the

Oh ...

Quoted 1 line

great part shortage of 2021

... I'll borrow this quote.

Quoted 9 lines

and
having the hard-code ID's prevented backwards compatibility. For the Beacon downstream kernel, we removed the PHY ID and kept the generic 'ethernet-phy-ieee802.3-c22' because it could auto-detect what we needed and both PHY's appear to come out of reset and register properly. I don't know if we could make a generic phy-ieee802.3-c22 handle the reset, wait a moment and then try to auto-detect, but it would be nice to not have to jump through hoops if/when people need to change PHY's.

The reset handling and clock handling is the main issue here. Maybe we should cross that bridge when we come to it ? I.e. when someone needs to replace a PHY, let's deal with the requirement then ?

Reviewed-by on v1 1/2
#15 lore raw
In reply to Marek Vasut
Quoted 13 lines · Marek Vasut

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";
Quoted 3 lines

Andrew

#16 lore raw
In reply to Marek Vasut

Hi Marek,

Thanks for your patch!

Quoted 2 lines · Marek Vasut

The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the

Why not?

Quoted 3 lines

Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users:

Ah, the self-fulfilling collection of patches ;-)

Let's move the discussion to the actual patch that causes this
https://lore.kernel.org/all/[email protected]/

Quoted 9 lines
$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
      1 ethernet-phy-id001c.c816",
      2 ethernet-phy-id001c.c915",
      2 ethernet-phy-id001c.c915";
      5 ethernet-phy-id001c.c916",
     13 ethernet-phy-id001c.c916";

Hmm, nothing about r7s9210-rza2mevb in that report.

Quoted 12 lines

---
Cc: Conor Dooley <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Khuong Dinh <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
Note: this closes only part of the report

Please do not use the "Closes" tag if it does not fix everything in the report. "Link" (pointing to the correct report!) is fine, though.

arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts &ether1 { · line 101

Quoted 12 lines
arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts +1 -2
@@ -95,8 +95,7 @@ &ether1 {
        renesas,no-ether-link;
        phy-handle = <&phy1>;
        phy1: ethernet-phy@1 {
-               compatible = "ethernet-phy-id001c.c816",
-                            "ethernet-phy-ieee802.3-c22";
+               compatible = "ethernet-phy-id001c.c816";
                reg = <0>;
        };
 };

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds