Skip to contentSkip to conversation

ice: Fix field vector array data type

PATCH In review Marcin Szycik 2 participants 2 messages Jul 3, 2024 – Jul 4, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: Fix field vector array data type

Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8 instead of u16. This array contents are used solely to be later passed to lkup_indx in struct ice_aqc_recipe_content, which is u8.

Fixes 6d82b8eda4c7 ("ice: Optimize switch recipe creation")

---
Targeting next, as the commit to be fixed is on dev-queue.
Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")

---
 drivers/net/ethernet/intel/ice/ice_switch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_switch.h +1 -1
index 3e4af531b875..671d7a5f359f 100644
@@ -226,7 +226,7 @@ struct ice_sw_recipe {
 	 */
 	struct ice_fv_word ext_words[ICE_MAX_CHAIN_WORDS];
 	u16 word_masks[ICE_MAX_CHAIN_WORDS];
-	u16 fv_idx[ICE_MAX_CHAIN_WORDS];
+	u8 fv_idx[ICE_MAX_CHAIN_WORDS];
 	u16 fv_mask[ICE_MAX_CHAIN_WORDS];
 
 	/* Bit map specifying the IDs associated with this group of recipe */
Signature · 1 line
2.45.0
reviewer
#1 lore raw
Quoted 10 lines · Marcin Szycik

Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8 instead of u16. This array contents are used solely to be later passed to lkup_indx in struct ice_aqc_recipe_content, which is u8.

Fixes 6d82b8eda4c7 ("ice: Optimize switch recipe creation")

---
Targeting next, as the commit to be fixed is on dev-queue.
Tony, please squash this with commit 6d82b8eda4c7 ("ice: Optimize switch recipe creation")

FWIIW, this LGTM.

...