Skip to contentSkip to conversation

drm/vkms: Remove event from vkms_output

PATCH Applied Lyude Paul 3 participants 4 messages Jul 3, 2024 – Jul 7, 2024

Subsystems (3)
lore
Share & tools
lore

Lyude Paul

author
#0 lore raw

PATCH 1/1 drm/vkms: Remove event from vkms_output

While working on rvkms, I noticed that there's no code that actually uses the drm_pending_vblank_event that's embedded in vkms_output. So, just drop the member from the struct.

---
 drivers/gpu/drm/vkms/vkms_drv.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/vkms/vkms_drv.h +0 -1
index 8f5710debb1eb..5e46ea5b96dcc 100644
@@ -103,7 +103,6 @@ struct vkms_output {
 	struct drm_writeback_connector wb_connector;
 	struct hrtimer vblank_hrtimer;
 	ktime_t period_ns;
-	struct drm_pending_vblank_event *event;
 	/* ordered wq for composer_work */
 	struct workqueue_struct *composer_workq;
 	/* protects concurrent access to composer */
Signature · 1 line
2.45.2
maintainer Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 3 lines · Lyude Paul

While working on rvkms, I noticed that there's no code that actually uses the drm_pending_vblank_event that's embedded in vkms_output. So, just drop the member from the struct.

This seems to be a leftover of the work on the introduction on vblank, if you look at the V1 [1] you can see it was used, but not removed on the last iteration [2].

It apply properly on drm-misc-next and igt test kms_flip/kms_vblank are success.

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/5d9ca7b3884c1995bd4a983b1d2ff1b840eb7f1a.1531402095.git.rodrigosiqueiramelo@gmail.com/

Quoted 21 lines
---
 drivers/gpu/drm/vkms/vkms_drv.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/vkms/vkms_drv.h +0 -1
index 8f5710debb1eb..5e46ea5b96dcc 100644
@@ -103,7 +103,6 @@ struct vkms_output {
 	struct drm_writeback_connector wb_connector;
 	struct hrtimer vblank_hrtimer;
 	ktime_t period_ns;
-	struct drm_pending_vblank_event *event;
 	/* ordered wq for composer_work */
 	struct workqueue_struct *composer_workq;
 	/* protects concurrent access to composer */
Signature · 1 line
2.45.2
Signature · 3 lines
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Reviewed-by on v1 1/1
#2 lore raw
In reply to Lyude Paul
Quoted 5 lines · Lyude Paul

While working on rvkms, I noticed that there's no code that actually uses the drm_pending_vblank_event that's embedded in vkms_output. So, just drop the member from the struct.

Feel free to apply it to drm-misc/drm-misc-next! Otherwise, I'll apply it over the weekend.

Best Regards,
- Maíra

Quoted 16 lines
---
  drivers/gpu/drm/vkms/vkms_drv.h | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/vkms/vkms_drv.h +0 -1
index 8f5710debb1eb..5e46ea5b96dcc 100644
@@ -103,7 +103,6 @@ struct vkms_output {
  	struct drm_writeback_connector wb_connector;
  	struct hrtimer vblank_hrtimer;
  	ktime_t period_ns;
-	struct drm_pending_vblank_event *event;
  	/* ordered wq for composer_work */
  	struct workqueue_struct *composer_workq;
  	/* protects concurrent access to composer */
Applied
#3 lore raw
In reply to Lyude Paul
Quoted 5 lines · Lyude Paul

While working on rvkms, I noticed that there's no code that actually uses the drm_pending_vblank_event that's embedded in vkms_output. So, just drop the member from the struct.

Applied to drm-misc/drm-misc-next!

Best Regards,
- Maíra

Quoted 16 lines
---
  drivers/gpu/drm/vkms/vkms_drv.h | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/vkms/vkms_drv.h +0 -1
index 8f5710debb1eb..5e46ea5b96dcc 100644
@@ -103,7 +103,6 @@ struct vkms_output {
  	struct drm_writeback_connector wb_connector;
  	struct hrtimer vblank_hrtimer;
  	ktime_t period_ns;
-	struct drm_pending_vblank_event *event;
  	/* ordered wq for composer_work */
  	struct workqueue_struct *composer_workq;
  	/* protects concurrent access to composer */