Skip to contentSkip to conversation

spi: dt-bindings: fsl-dspi: add dmas and dma-names properties

PATCH In review Frank Li 2 participants 3 messages Jul 3, 2024 – Jul 8, 2024

Subsystems (4)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v2 1/2 spi: dt-bindings: fsl-dspi: add dmas and dma-names properties

Add dmas and dma-names properties because dspi support dma transfer.
Fix below warnings:
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected)
from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml#

---
Change from v1 to v2
- Add Krzysztof's review tag

---
 Documentation/devicetree/bindings/spi/fsl,dspi.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)
Documentation/devicetree/bindings/spi/fsl,dspi.yaml +10 -0
index bd28335a6ac86..f16ac22291456 100644
@@ -48,6 +48,16 @@ properties:
     items:
       - const: dspi
 
+  dmas:
+    items:
+      - description: DMA controller phandle and request line for TX
+      - description: DMA controller phandle and request line for RX
+
+  dma-names:
+    items:
+      - const: tx
+      - const: rx
+
   spi-num-chipselects:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH v2 2/2 spi: dt-bindings: fsl-dspi: add compatible string 'fsl,lx2160a-dspi'

Add compatible string 'fsl,lx2160a-dspi' and allow fall back to 'fsl,ls2085a-dspi'.
Fix below CHECK_DTBS warning.

arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: spi@2100000: compatible: 'oneOf' conditional failed, one must be fixed:

        ['fsl,lx2160a-dspi', 'fsl,ls2085a-dspi'] is too long

---
Change from v1 to v2
- new patch

---
 Documentation/devicetree/bindings/spi/fsl,dspi.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/spi/fsl,dspi.yaml +3 -0
index f16ac22291456..7ca8fceda7179 100644
@@ -34,6 +34,9 @@ properties:
       - items:
           - const: fsl,ls2080a-dspi
           - const: fsl,ls2085a-dspi
+      - items:
+          - const: fsl,lx2160a-dspi
+          - const: fsl,ls2085a-dspi
 
   reg:
     maxItems: 1
Signature · 1 line
2.34.1
maintainer
#2 lore raw
In reply to Frank Li
Quoted 6 lines · Frank Li

Add dmas and dma-names properties because dspi support dma transfer.
Fix below warnings:
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected)
from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml#

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: dt-bindings: fsl-dspi: add dmas and dma-names properties

      commit: 2de9ae2044c4f6490dbbfb8d93fe6b8cc60c91d1
[2/2] spi: dt-bindings: fsl-dspi: add compatible string 'fsl,lx2160a-dspi'
      commit: 0f17a12787573dda66d2528fff27cd7362b34bfd

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark