fuse: Disable the combination of passthrough and writeback cache
Subsystems (2)
PATCH 1/1 fuse: Disable the combination of passthrough and writeback cache
Current design and handling of passthrough is without fuse caching and with that FUSE_WRITEBACK_CACHE is conflicting.
Fixes 7dc4e97a4f9a ("fuse: introduce FUSE_PASSTHROUGH capability")
Signed-off-by Bernd Schubert <[email protected]>
--- fs/fuse/inode.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
fs/fuse/inode.c +6 -1
@@ -1320,11 +1320,16 @@ static void process_init_reply(struct fuse_mount *fm, struct fuse_args *args,* on a stacked fs (e.g. overlayfs) themselves and with * max_stack_depth == 1, FUSE fs can be stacked as the * underlying fs of a stacked fs (e.g. overlayfs). +* +* Also don't allow the combination of FUSE_PASSTHROUGH +* and FUSE_WRITEBACK_CACHE, current design doesn't handle +* them together. */ if (IS_ENABLED (CONFIG_FUSE_PASSTHROUGH ) && (flags &FUSE_PASSTHROUGH ) && arg->max_stack_depth >0 && - arg->max_stack_depth <=FILESYSTEM_MAX_STACK_DEPTH ) { + arg->max_stack_depth <=FILESYSTEM_MAX_STACK_DEPTH && + !(flags &FUSE_WRITEBACK_CACHE )) { fc->passthrough =1 ; fc->max_stack_depth = arg->max_stack_depth; fm->sb->s_stack_depth = arg->max_stack_depth;
Signature · 1 line
2.43.0
Quoted 6 lines · Bernd Schubert
Current design and handling of passthrough is without fuse caching and with that
FUSE_WRITEBACK_CACHEis conflicting.Fixes 7dc4e97a4f9a ("fuse: introduce FUSE_PASSTHROUGH capability")Signed-off-by Bernd Schubert <[email protected]>
Reviewed-by Josef Bacik <[email protected]>
Thanks,
Josef
Quoted 7 lines · Bernd Schubert
Current design and handling of passthrough is without fuse caching and with that
FUSE_WRITEBACK_CACHEis conflicting.Fixes 7dc4e97a4f9a ("fuse: introduce FUSE_PASSTHROUGH capability")Signed-off-by Bernd Schubert <[email protected]>
Applied, thanks.
Miklos