Skip to contentSkip to conversation

drm/amdgpu: remove redundant semicolons in RAS_EVENT_LOG

PATCH In review Yang Wang 3 participants 3 messages Jul 4, 2024

Subsystems (2)
lore
Share & tools
lore

Yang Wang

author
#0 lore raw

PATCH 1/1 drm/amdgpu: remove redundant semicolons in RAS_EVENT_LOG

remove redundant semicolons in RAS_EVENT_LOG to avoid code format check warning.

Fixes 951c09c88fca ("drm/amdgpu: fix compiler 'side-effect' check issue for RAS_EVENT_LOG()")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h +1 -1
index 9224fc6418e4..518b10f190ec 100644
@@ -72,7 +72,7 @@ struct amdgpu_iv_entry;
 #define RAS_EVENT_ID_IS_VALID(x)	(!((x) & BIT_ULL(63)))
 
 #define RAS_EVENT_LOG(adev, id, fmt, ...)	\
-	amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__);
+	amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__)
 
 #define amdgpu_ras_mark_ras_event(adev, type)	\
 	(amdgpu_ras_mark_ras_event_caller((adev), (type), __builtin_return_address(0)))
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Quoted 37 lines

-----Original Message-----
From: Wang, Yang(Kevin) <[email protected]>
Sent: Thursday, July 4, 2024 1:53 PM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>
Subject: [PATCH] drm/amdgpu: remove redundant semicolons in RAS_EVENT_LOG

remove redundant semicolons in RAS_EVENT_LOG to avoid code format check warning.

Fixes 951c09c88fca ("drm/amdgpu: fix compiler 'side-effect' check issue for

RAS_EVENT_LOG()")

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h +1 -1
index 9224fc6418e4..518b10f190ec 100644
@@ -72,7 +72,7 @@ struct amdgpu_iv_entry;
 #define RAS_EVENT_ID_IS_VALID(x)     (!((x) & BIT_ULL(63)))
 
 #define RAS_EVENT_LOG(adev, id, fmt, ...)    \
-     amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__);
+     amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__)
 
 #define amdgpu_ras_mark_ras_event(adev, type)        \
      (amdgpu_ras_mark_ras_event_caller((adev), (type),

__builtin_return_address(0)))
--
2.34.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Yang Wang

Am 04.07.24 um 07:52 schrieb Yang Wang:

Quoted 6 lines

remove redundant semicolons in RAS_EVENT_LOG to avoid code format check warning.

Fixes 951c09c88fca ("drm/amdgpu: fix compiler 'side-effect' check issue for RAS_EVENT_LOG()")

Ah, yes one of the most common mistakes of all times :)

Quoted 17 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h +1 -1
index 9224fc6418e4..518b10f190ec 100644
@@ -72,7 +72,7 @@ struct amdgpu_iv_entry;
  #define RAS_EVENT_ID_IS_VALID(x)	(!((x) & BIT_ULL(63)))
 
  #define RAS_EVENT_LOG(adev, id, fmt, ...)	\
-	amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__);
+	amdgpu_ras_event_log_print((adev), (id), (fmt), ##__VA_ARGS__)
 
  #define amdgpu_ras_mark_ras_event(adev, type)	\
  	(amdgpu_ras_mark_ras_event_caller((adev), (type), __builtin_return_address(0)))