Skip to contentSkip to conversation

xen/arm: dom0less: Add #redistributor-regions property to GICv3 node

PATCH In review Michal Orzel 3 participants 4 messages Jul 4, 2024 – Aug 6, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/arm: dom0less: Add #redistributor-regions property to GICv3 node

Dom0less domain using host memory layout may use more than one re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen will add them in a "reg" property of a GICv3 domU node. Guest needs to know how many regions to search for, and therefore the GICv3 dt binding
[1] specifies that "#redistributor-regions" property is required if more than one redistributor region is present. However, Xen does not add this property which makes guest believe, there is just one such region. This can lead to guest boot failure when doing GIC SMP initialization. Fix it by adding this property, which matches what we do for hwdom.

[1] Linux: Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml

Fixes 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for GICv3")

---
Tested with Qemu 8.2, virt machine with nr cpus > 123 which requires to use a second redistributor region.

---
 xen/arch/arm/dom0less-build.c | 5 +++++
 1 file changed, 5 insertions(+)
xen/arch/arm/dom0less-build.c +5 -0
index f919d3acf976..09b65e44aed3 100644
@@ -176,6 +176,11 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
     if ( res )
         return res;
 
+    res = fdt_property_cell(fdt, "#redistributor-regions",
+                            d->arch.vgic.nr_regions);
+    if ( res )
+        return res;
+
     /* reg specifies all re-distributors and Distributor. */
     len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
           (d->arch.vgic.nr_regions + 1) * sizeof(__be32);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Michal Orzel

Dom0less domain using host memory layout may use more than one re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen will add them in a "reg" property of a GICv3 domU node. Guest needs to know how many regions to search for, and therefore the GICv3 dt binding
[1] specifies that "#redistributor-regions" property is required if more than one redistributor region is present. However, Xen does not add this property which makes guest believe, there is just one such region. This can lead to guest boot failure when doing GIC SMP initialization. Fix it by adding this property, which matches what we do for hwdom.

Quoted 5 lines

[1] Linux: Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml

Fixes 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for GICv3")

---

Looks good to me!

Acked-by
#2 lore raw

Hi,

Quoted 16 lines · Luca Fancellu
Quoted 16 lines · Michal Orzel

Dom0less domain using host memory layout may use more than one re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen will add them in a "reg" property of a GICv3 domU node. Guest needs to know how many regions to search for, and therefore the GICv3 dt binding
[1] specifies that "#redistributor-regions" property is required if more than one redistributor region is present. However, Xen does not add this property which makes guest believe, there is just one such region. This can lead to guest boot failure when doing GIC SMP initialization. Fix it by adding this property, which matches what we do for hwdom.

[1] Linux: Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml

Quoted 7 lines
Quoted 3 lines
Fixes 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for GICv3")

---

Looks good to me!

Cheers,

Signature · 1 line
Julien Grall
#3 lore raw

Hi,

Quoted 23 lines · Julien Grall

Hi,

Quoted 20 lines · Luca Fancellu
Quoted 19 lines · Michal Orzel

Dom0less domain using host memory layout may use more than one re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen will add them in a "reg" property of a GICv3 domU node. Guest needs to know how many regions to search for, and therefore the GICv3 dt binding
[1] specifies that "#redistributor-regions" property is required if more than one redistributor region is present. However, Xen does not add this property which makes guest believe, there is just one such region. This can lead to guest boot failure when doing GIC SMP initialization. Fix it by adding this property, which matches what we do for hwdom.

[1] Linux: Documentation/devicetree/bindings/interrupt-controller/ arm,gic-v3.yaml

Fixes 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for GICv3")

---

Quoted 5 lines
Quoted 3 lines

Looks good to me!

This is now committed.

Cheers,

Signature · 1 line
Julien Grall