ROCK 5 ITX devicetree
Subsystems (2)
Heiko Stuebner
maintainerv2 cover ROCK 5 ITX devicetree
Add a basic support for the Rock 5 ITX board.
After struggling a bit with the pcie3 ports, thankfully they seem to run pretty nice now thanks to me finding the property for the shared-rx-clk for the pcie3 phy.
changes in v2:
- update naming to include a space/dash between 5 and ITX. As Dragan wrote "the name of this board deviates from the standard Radxa naming scheme, which is something like "ROCK <number><letter>" thus, "rock-5a" is fine, but it should be "rock-5-itx", simply because there's a space between "5" and "ITX" in "ROCK 5 ITX"
- spelling fixes (Dragan)
- removed status from adc-keys (Krzysztof)
- added Krzysztof's binding Ack, after asking on IRC about the added "-"
- updated copyright statement to something correct
Heiko Stuebner (2):
dt-bindings: arm: rockchip: Add ROCK 5 ITX board
arm64: dts: rockchip: add rock5 itx board
.../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3588-rock-5-itx.dts | 1186 +++++++++++++++++ 3 files changed, 1192 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
Signature · 1 line
2.39.2
Heiko Stuebner
maintainerPATCH v2 1/2 dt-bindings: arm: rockchip: Add ROCK 5 ITX board
Add devicetree binding for the ROCK 5 ITX board, built around the rk3588.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -816,6 +816,11 @@ properties: - const: radxa,rock-3c - const: rockchip,rk3566 + - description: Radxa ROCK 5 ITX + items: + - const: radxa,rock-5-itx + - const: rockchip,rk3588 + - description: Radxa ROCK 5A items: - const: radxa,rock-5a
Signature · 1 line
2.39.2
Heiko Stuebner
maintainerPATCH v2 2/2 arm64: dts: rockchip: add ROCK 5 ITX board
In reply to Heiko StuebnerThe ROCK 5 ITX as the name suggests is made in the ITX form factor and actually built in a form to be used in a regular case even providing connectors for regular front-panel io.
It can be powered either by 12V, ATX power-supply or PoE.
Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot, 2*2.5Gb PCIe-connected Ethernet NICs.
As of yet unsupported display options consist of 2*HDMI, DP via USB-c, eDP + 2*DSI via PCB connectors.
USB ports are 4*USB3 + 2*USB2 on the back panel and 2-port front-panel connector.
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3588-rock-5-itx.dts | 1186 +++++++++++++++++ 2 files changed, 1187 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -129,6 +129,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-plus.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-quartzpro64.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5-itx.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-ep.dtbo dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-srns.dtbo
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts new file +1186 -0
1,186 lines not on this page · raw message
Signature · 1 line
2.39.2
Heiko Stübner
maintainerRe: [PATCH v2 2/2] arm64: dts: rockchip: add ROCK 5 ITX board
Am Donnerstag, 4. Juli 2024, 11:55:24 CEST schrieb Heiko Stuebner:
Quoted 40 lines
The ROCK 5 ITX as the name suggests is made in the ITX form factor and actually built in a form to be used in a regular case even providing connectors for regular front-panel io.
It can be powered either by 12V, ATX power-supply or PoE.
Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot, 2*2.5Gb PCIe-connected Ethernet NICs.
As of yet unsupported display options consist of 2*HDMI, DP via USB-c, eDP + 2*DSI via PCB connectors.
USB ports are 4*USB3 + 2*USB2 on the back panel and 2-port front-panel connector.
Signed-off-by Heiko Stuebner <[email protected]>--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3588-rock-5-itx.dts | 1186 +++++++++++++++++ 2 files changed, 1187 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dtsarch/arm64/boot/dts/rockchip/Makefile +1
-0@@ -129,6 +129,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-plus.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-quartzpro64.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5-itx.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-ep.dtbo dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-srns.dtboarch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts new file +0
-0@@ -0,0 +1,1186 @@
[...]
Quoted 16 lines
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts new file +16
-0+/* FUSB302 and LCD1 connector */ +&i2c8 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c8m4_xfer>; + status = "okay"; + + usbc0: usb-typec@22 { + compatible = "fcs,fusb302"; + reg = <0x22>; + interrupt-parent = <&gpio3>; + interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&usbc0_int>; + vbus-supply = <&typec_vin>; + + usb_con: connector {
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts line 398
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts new file +10
-0+ compatible = "usb-c-connector"; + label = "USB-C"; + data-role = "dual"; + power-role = "dual"; + try-power-role = "sink"; + op-sink-microwatt = <1000000>; + sink-pdos = + <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>; + source-pdos = + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
as sigmaris noted on IRC:
I think the usb-c-connector on the Rock 5 ITX dts should not be a PD sink. The schematic from Radxa shows TYPEC_VIN only connected to the output of regulator U2603, there is no power path I can see for it to power the board [...] and powering via USB-C isn't mentioned in the other docs
and I'd remove try-power-role and sink-pdos (try-power-role seems optional if power-role is not dual)
and also remove op-sink-microwatt