mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem
Subsystems (3)
PATCH v3 1/1 mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem
After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for anonymous shmem"), we can configure different policies through the multi-size THP sysfs interface for anonymous shmem. But currently "THPeligible" indicates only whether the mapping is eligible for allocating THP-pages as well as the THP is PMD mappable or not for anonymous shmem, we need to support semantics for mTHP with anonymous shmem similar to those for mTHP with anonymous memory.
---
Changes since v2 [2]:
- Move shmem_allowable_huge_orders() to shmem_fs.h (per Baolin)
- clean up these coding style issues (per Ryan)
Changes since v1 [1]:
- Put anonymous shmem mthp related logic into
thp_vma_allowable_orders() (per David)
[1] https://lore.kernel.org/linux-mm/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/
include/linux/shmem_fs.h | 9 +++++++++ mm/huge_memory.c | 13 +++++++++---- mm/shmem.c | 9 +-------- 3 files changed, 19 insertions(+), 12 deletions(-)
include/linux/shmem_fs.h +9 -0
@@ -113,12 +113,21 @@ int shmem_unuse(unsigned int type);#ifdef CONFIG_TRANSPARENT_HUGEPAGE extern bool shmem_is_huge (struct inode *inode,pgoff_t index,bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags); +unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge);#else static __always_inline bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags) {return false; } +static inline unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge) +{ +return 0 ; +}#endif #ifdef CONFIG_SHMEM
mm/huge_memory.c +9 -4
@@ -151,10 +151,15 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,* Must be done before hugepage flags check since shmem has its * own flags. */ -if (!in_pf &&shmem_file (vma->vm_file)) -return shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, - !enforce_sysfs, vma->vm_mm, vm_flags) - ? orders :0 ; +if (!in_pf &&shmem_file (vma->vm_file)) { +bool global_huge =shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, + !enforce_sysfs, vma->vm_mm, vm_flags); + +if (!vma_is_anon_shmem (vma)) +return global_huge ? orders :0 ; +return shmem_allowable_huge_orders (file_inode (vma->vm_file), + vma, vma->vm_pgoff, global_huge); + }if (!vma_is_anonymous (vma)) {/*
mm/shmem.c +1 -8
@@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) }#ifdef CONFIG_TRANSPARENT_HUGEPAGE -static unsigned long shmem_allowable_huge_orders (struct inode *inode, +unsigned long shmem_allowable_huge_orders (struct inode *inode,struct vm_area_struct *vma,pgoff_t index,bool global_huge) {
@@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault return orders; }#else -static unsigned long shmem_allowable_huge_orders (struct inode *inode, -struct vm_area_struct *vma,pgoff_t index, -bool global_huge) -{ -return 0 ; -} -static unsigned long shmem_suitable_orders (struct inode *inode,struct vm_fault *vmf,struct address_space *mapping,pgoff_t index,unsigned long orders)
Signature · 1 line
2.19.1.6.gb485710b
Quoted 10 lines · Bang Li
After the commit
7fb1b252afb5("mm: shmem: add mTHP support for anonymous shmem"), we can configure different policies through the multi-size THP sysfs interface for anonymous shmem. But currently "THPeligible" indicates only whether the mapping is eligible for allocating THP-pages as well as the THP is PMD mappable or not for anonymous shmem, we need to support semantics for mTHP with anonymous shmem similar to those for mTHP with anonymous memory.Signed-off-by Bang Li <[email protected]>
So far, it looks good to me.
Quoted 94 lines
---
Changes since v2 [2]:
- Moveshmem_allowable_huge_orders()toshmem_fs.h(per Baolin)
- clean up these coding style issues (per Ryan)Changes since v1 [1]:
- Put anonymous shmem mthp related logic into
thp_vma_allowable_orders()(per David)[1] https://lore.kernel.org/linux-mm/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/include/linux/shmem_fs.h | 9 +++++++++ mm/huge_memory.c | 13 +++++++++---- mm/shmem.c | 9 +-------- 3 files changed, 19 insertions(+), 12 deletions(-)include/linux/shmem_fs.h +9
-0@@ -113,12 +113,21 @@ int shmem_unuse(unsigned int type);#ifdef CONFIG_TRANSPARENT_HUGEPAGE extern bool shmem_is_huge (struct inode *inode,pgoff_t index,bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags); +unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge);#else static __always_inline bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags) {return false; } +static inline unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge) +{ +return 0 ; +}#endif #ifdef CONFIG_SHMEM mm/huge_memory.c +9
-4@@ -151,10 +151,15 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,* Must be done before hugepage flags check since shmem has its * own flags. */ -if (!in_pf &&shmem_file (vma->vm_file)) -return shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, - !enforce_sysfs, vma->vm_mm, vm_flags) - ? orders :0 ; +if (!in_pf &&shmem_file (vma->vm_file)) { +bool global_huge =shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, + !enforce_sysfs, vma->vm_mm, vm_flags); + +if (!vma_is_anon_shmem (vma)) +return global_huge ? orders :0 ; +return shmem_allowable_huge_orders (file_inode (vma->vm_file), + vma, vma->vm_pgoff, global_huge); + }if (!vma_is_anonymous (vma)) {/* mm/shmem.c +1
-8@@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) }#ifdef CONFIG_TRANSPARENT_HUGEPAGE -static unsigned long shmem_allowable_huge_orders (struct inode *inode, +unsigned long shmem_allowable_huge_orders (struct inode *inode,struct vm_area_struct *vma,pgoff_t index,bool global_huge) {@@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault return orders; }#else -static unsigned long shmem_allowable_huge_orders (struct inode *inode, -struct vm_area_struct *vma,pgoff_t index, -bool global_huge) -{ -return 0 ; -} -static unsigned long shmem_suitable_orders (struct inode *inode,struct vm_fault *vmf,struct address_space *mapping,pgoff_t index,unsigned long orders)
Quoted 10 lines · Bang Li
After the commit
7fb1b252afb5("mm: shmem: add mTHP support for anonymous shmem"), we can configure different policies through the multi-size THP sysfs interface for anonymous shmem. But currently "THPeligible" indicates only whether the mapping is eligible for allocating THP-pages as well as the THP is PMD mappable or not for anonymous shmem, we need to support semantics for mTHP with anonymous shmem similar to those for mTHP with anonymous memory.Signed-off-by Bang Li <[email protected]>
LGTM!
Quoted 94 lines
---
Changes since v2 [2]:
- Moveshmem_allowable_huge_orders()toshmem_fs.h(per Baolin)
- clean up these coding style issues (per Ryan)Changes since v1 [1]:
- Put anonymous shmem mthp related logic into
thp_vma_allowable_orders()(per David)[1] https://lore.kernel.org/linux-mm/[email protected]/
[2] https://lore.kernel.org/linux-mm/[email protected]/include/linux/shmem_fs.h | 9 +++++++++ mm/huge_memory.c | 13 +++++++++---- mm/shmem.c | 9 +-------- 3 files changed, 19 insertions(+), 12 deletions(-)include/linux/shmem_fs.h +9
-0@@ -113,12 +113,21 @@ int shmem_unuse(unsigned int type);#ifdef CONFIG_TRANSPARENT_HUGEPAGE extern bool shmem_is_huge (struct inode *inode,pgoff_t index,bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags); +unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge);#else static __always_inline bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force,struct mm_struct *mm,unsigned long vm_flags) {return false; } +static inline unsigned long shmem_allowable_huge_orders (struct inode *inode, +struct vm_area_struct *vma,pgoff_t index, +bool global_huge) +{ +return 0 ; +}#endif #ifdef CONFIG_SHMEM mm/huge_memory.c +9
-4@@ -151,10 +151,15 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,* Must be done before hugepage flags check since shmem has its * own flags. */ -if (!in_pf &&shmem_file (vma->vm_file)) -return shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, - !enforce_sysfs, vma->vm_mm, vm_flags) - ? orders :0 ; +if (!in_pf &&shmem_file (vma->vm_file)) { +bool global_huge =shmem_is_huge (file_inode (vma->vm_file), vma->vm_pgoff, + !enforce_sysfs, vma->vm_mm, vm_flags); + +if (!vma_is_anon_shmem (vma)) +return global_huge ? orders :0 ; +return shmem_allowable_huge_orders (file_inode (vma->vm_file), + vma, vma->vm_pgoff, global_huge); + }if (!vma_is_anonymous (vma)) {/* mm/shmem.c +1
-8@@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) }#ifdef CONFIG_TRANSPARENT_HUGEPAGE -static unsigned long shmem_allowable_huge_orders (struct inode *inode, +unsigned long shmem_allowable_huge_orders (struct inode *inode,struct vm_area_struct *vma,pgoff_t index,bool global_huge) {@@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault return orders; }#else -static unsigned long shmem_allowable_huge_orders (struct inode *inode, -struct vm_area_struct *vma,pgoff_t index, -bool global_huge) -{ -return 0 ; -} -static unsigned long shmem_suitable_orders (struct inode *inode,struct vm_fault *vmf,struct address_space *mapping,pgoff_t index,unsigned long orders)