Skip to contentSkip to conversation

Display Global Histogram

PATCH Superseded Arun R Murthy 6 participants 30 messages Jul 5, 2024 – Sep 17, 2024

Subsystems (4)

v1 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

cover Display Global Histogram

Display histogram is a hardware functionality where a statistics for 'x' number of frames is generated to form a histogram data. This is notified to the user via histogram event. Compositor will then upon sensing the histogram event will read the histogram data from KMD via crtc property. A library can be developed to take this generated histogram as an input and apply some algorithm to generate an Image EnhancemenT(IET). This is further fed back to the KMD via crtc property. KMD will use this IET as a multiplicand factor to multiply with the incoming pixels at the end of the pipe which is then pushed onto the display.

One such library Global Histogram Enhancement(GHE) will take the histogram as input and applied the algorithm to enhance the density and then return the enhanced factor. This library can be located @
https://github.com/intel/ghe

The corresponding mutter changes to enable/disable histogram, read the
histogram data, communicate with the library and write the enhanced data
back to the KMD is also pushed for review at https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3873
The IGT changes for validating the histogram event and reading the
histogram is also pushed for review at https://patchwork.freedesktop.org/series/135789/

Test-with: [email protected]

Arun R Murthy (5):
drm/i915/display: Add support for histogram drm/i915/display: histogram interrupt handling
Add crtc properties for global histogram drm/i915/histogram: histogram delay counter doesnt reset drm/i915/display/histogram: Histogram changes for Display LNL+

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 +
 .../gpu/drm/i915/display/intel_display_irq.c  |   6 +-
 .../drm/i915/display/intel_display_types.h    |  20 +
 .../gpu/drm/i915/display/intel_histogram.c    | 380 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    | 120 ++++++
 drivers/gpu/drm/i915/i915_reg.h               |   5 +-
 drivers/gpu/drm/xe/Makefile                   |   1 +
 11 files changed, 754 insertions(+), 4 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/5 drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
drivers/gpu/drm/i915/Makefile +1 -0
index c63fa2133ccb..03caf3a24966 100644
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +187 -0

187 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_histogram.h new file +91 -0

91 lines not on this page · raw message

drivers/gpu/drm/xe/Makefile +1 -0
index 628c245c4822..1881e3e1f4a9 100644
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

kernel test robot noticed the following build errors:

Hi Arun,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip drm-xe/drm-xe-next linus/master v6.10-rc6 next-20240703] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-display-Add-support-for-histogram/20240705-233245
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240705095551.1244154-2-arun.r.murthy%40intel.com
patch subject: [PATCH 1/5] drm/i915/display: Add support for histogram
config: i386-randconfig-061-20240706 (https://download.01.org/0day-ci/archive/20240706/[email protected]/config)
compiler: gcc-8 (Ubuntu 8.4.0-3ubuntu2) 8.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240706/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

ld: drivers/gpu/drm/i915/display/intel_histogram.o: in function `intel_histogram_enable':

>> drivers/gpu/drm/i915/display/intel_histogram.c:68:(.text+0x2b6): undefined reference to `__udivdi3'

vim +68 drivers/gpu/drm/i915/display/intel_histogram.c

    30	
    31	static int intel_histogram_enable(struct intel_crtc *intel_crtc)
    32	{
    33		struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
    34		struct intel_histogram *histogram = intel_crtc->histogram;
    35		int pipe = intel_crtc->pipe;
    36		u64 res;
    37		u32 gbandthreshold;
    38	
    39		if (!histogram->can_enable) {
    40			drm_err(&i915->drm,
    41				"Histogram not supported, compute config failed\n");
    42			return -EINVAL;
    43		}
    44	
    45		if (histogram->enable)
    46			return 0;
    47	
    48		/* Pipe Dithering should be enabled with GLOBAL_HIST */
    49		intel_histogram_enable_dithering(i915, pipe);
    50	
    51		/*
    52		 * enable DPST_CTL Histogram mode
    53		 * Clear DPST_CTL Bin Reg function select to TC
    54		 */
    55		intel_de_rmw(i915, DPST_CTL(pipe),
    56			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
    57			     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
    58			     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
    59			     DPST_CTL_HIST_MODE_HSV |
    60			     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
    61	
    62		/* Re-Visit: check if wait for one vblank is required */
    63		drm_crtc_wait_one_vblank(&intel_crtc->base);
    64	
    65		/* TODO: one time programming: Program GuardBand Threshold */
    66		res = (intel_crtc->config->hw.adjusted_mode.vtotal *
    67					intel_crtc->config->hw.adjusted_mode.htotal);
  > 68		gbandthreshold = (res *	HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
    69					HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
    70	
    71		/* Enable histogram interrupt mode */
    72		intel_de_rmw(i915, DPST_GUARD(pipe),
    73			     DPST_GUARD_THRESHOLD_GB_MASK |
    74			     DPST_GUARD_INTERRUPT_DELAY_MASK | DPST_GUARD_HIST_INT_EN,
    75			     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
    76			     DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DELAY) |
    77			     DPST_GUARD_HIST_INT_EN);
    78	
    79		/* Clear pending interrupts has to be done on separate write */
    80		intel_de_rmw(i915, DPST_GUARD(pipe),
    81			     DPST_GUARD_HIST_EVENT_STATUS, 1);
    82	
    83		histogram->enable = true;
    84	
    85		return 0;
    86	}
    87	
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#3 lore raw

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

In reply to Arun R Murthy
kernel test robot noticed the following build errors:

Hi Arun,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip drm-xe/drm-xe-next linus/master v6.10-rc6 next-20240703] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-display-Add-support-for-histogram/20240705-233245
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240705095551.1244154-2-arun.r.murthy%40intel.com
patch subject: [PATCH 1/5] drm/i915/display: Add support for histogram
config: i386-buildonly-randconfig-004-20240707 (https://download.01.org/0day-ci/archive/20240707/[email protected]/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

ld: drivers/gpu/drm/i915/display/intel_histogram.o: in function `intel_histogram_update':

>> intel_histogram.c:(.text+0x2b3): undefined reference to `__udivdi3'
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#4 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

In reply to Arun R Murthy
Quoted 16 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 1/5] drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data.
This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

Quoted 10 lines
---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h

I see that this patch is doing 3 things, histogram enable, setting lut and also enable dithering. See if they can be split into sub patches.

Also on a generic note, there are a lot of TODO comments, are they waiting on something or you have newer Version of these patches.
Otherwise it will be better to make a note in the comments what will be the corner cases that would be hit with these TODO comments not fixed.

Quoted 41 lines
drivers/gpu/drm/i915/Makefile +1 -0
index c63fa2133ccb..03caf3a24966 100644
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
new file mode 100644
index 000000000000..1a603445fc29
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>

drivers/gpu/drm/i915/display/intel_histogram.c line 17

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */

More info on what kind of restrictions we are talking about here, will be helpful.

Quoted 160 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+	histogram->can_enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe),

PIPE_MISC_DITHER_ENABLE,

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+		     PIPE_MISC_DITHER_ENABLE);
+}
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config

failed\n");

drivers/gpu/drm/i915/display/intel_histogram.c new file +16 -0
+		return -EINVAL;
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config-
Quoted 1 line

hw.adjusted_mode.htotal);

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DEL AY) |

drivers/gpu/drm/i915/display/intel_histogram.c new file +22 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN |

DPST_GUARD_HIST_EVENT_STATUS, 0);

drivers/gpu/drm/i915/display/intel_histogram.c new file +40 -0
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable)
+{
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32
+*data) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is NULL");
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |

DPST_CTL_BIN_REG_MASK,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_IE |

DPST_CTL_BIN_REG_CLEAR);

drivers/gpu/drm/i915/display/intel_histogram.c new file +9 -0
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i, data[i]);
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK |

DPST_CTL_IE_MODI_TABLE_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_EN_MULTIPLICATIVE |

DPST_CTL_IE_MODI_TABLE_EN);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL,

DPST_CTL_BIN_REG_FUNC_TC);

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+
+	return 0;
+}
+
+void intel_histogram_deinit(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);
+}
+

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+int intel_histogram_init(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram;
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");
+		kfree(histogram);

This Kfree is not needed, as it is already inside a NULL check.

Quoted 106 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +17 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)
	_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK
	REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE
	REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT
	REG_BIT(15)
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC

REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK

	REG_GENMASK(6, 0)

+#define DPST_CTL_BIN_REG_CLEAR
REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_GUARD_A					0x490C8
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)				_MMIO_PIPE(pipe,

_DPST_GUARD_A, _DPST_GUARD_B)

drivers/gpu/drm/i915/display/intel_histogram.h new file +3 -0
+#define DPST_GUARD_HIST_INT_EN				REG_BIT(31)
+#define DPST_GUARD_HIST_EVENT_STATUS			REG_BIT(30)
+#define DPST_GUARD_INTERRUPT_DELAY_MASK
	REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)
	REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK
	REG_GENMASK(21, 0)

+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)
	_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK
	REG_GENMASK(23, 0)
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+#define DPST_BIN_BUSY					REG_BIT(31)
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
+						     INTEL_HISTOGRAM_PIPEA,

\

drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+						     INTEL_HISTOGRAM_PIPEB)
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    // 3.0% of

the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000 // Precision
factor for threshold guardband.

drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,

drivers/gpu/drm/i915/display/intel_histogram.h line 76

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
+};
+
+enum intel_global_hist_lut {
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+

Description on this new structure and its new members with comments will be better.

Quoted 29 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +15 -0
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT];
+};
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc); int
+intel_histogram_update(struct intel_crtc *intel_crtc, bool enable); int
+intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data);
+int intel_histogram_init(struct intel_crtc *intel_crtc); void
+intel_histogram_deinit(struct intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
drivers/gpu/drm/xe/Makefile +1 -1
index 628c245c4822..1881e3e1f4a9 100644
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
--

2.25.1

#5 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 34 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Monday, August 5, 2024 12:16 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 16 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 1/5] drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

Quoted 10 lines
---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
Quoted 8 lines

I see that this patch is doing 3 things, histogram enable, setting lut and also enable dithering.
See if they can be split into sub patches.

Also on a generic note, there are a lot of TODO comments, are they waiting on something or you have newer Version of these patches.
Otherwise it will be better to make a note in the comments what will be the corner cases that would be hit with these TODO comments not fixed.

TODO has been added in places where we don’t need them for now but required. As of now we are enabling just the basic histogram, going forward we will need to have this TODO implemented as the driver enhances. So just to keep an eye and we don’t loose track on this TODO has been added in the code itself.

Quoted 46 lines
Quoted 46 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/Makefile index c63fa2133ccb..03caf3a24966 100644

drivers/gpu/drm/i915/Makefile +1 -0
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
new file mode 100644
index 000000000000..1a603445fc29
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 18

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */

More info on what kind of restrictions we are talking about here, will be helpful.

These restrictions can be more confined to the algorithm that we use. We have the basic GHE algorithm now and going forward some restrictions will come.

Quoted 163 lines
Quoted 163 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+	histogram->can_enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe),

PIPE_MISC_DITHER_ENABLE,

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+		     PIPE_MISC_DITHER_ENABLE);
+}
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config

failed\n");

drivers/gpu/drm/i915/display/intel_histogram.c new file +16 -0
+		return -EINVAL;
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config-
Quoted 1 line

hw.adjusted_mode.htotal);

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DEL AY) |

drivers/gpu/drm/i915/display/intel_histogram.c new file +22 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN |

DPST_GUARD_HIST_EVENT_STATUS, 0);

drivers/gpu/drm/i915/display/intel_histogram.c new file +40 -0
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable) {
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32
+*data) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is NULL");
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |

DPST_CTL_BIN_REG_MASK,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_IE |

DPST_CTL_BIN_REG_CLEAR);

drivers/gpu/drm/i915/display/intel_histogram.c new file +9 -0
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i, data[i]);
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK |

DPST_CTL_IE_MODI_TABLE_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_EN_MULTIPLICATIVE |

DPST_CTL_IE_MODI_TABLE_EN);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL,

DPST_CTL_BIN_REG_FUNC_TC);

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+
+	return 0;
+}
+
+void intel_histogram_deinit(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);
+}
+
+int intel_histogram_init(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram;
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");
+		kfree(histogram);

This Kfree is not needed, as it is already inside a NULL check.

Done!

Quoted 110 lines
Quoted 110 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +16 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)
	_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK
	REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE
	REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT
	REG_BIT(15)
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC

REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK

	REG_GENMASK(6, 0)

+#define DPST_CTL_BIN_REG_CLEAR
REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_GUARD_A					0x490C8
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)				_MMIO_PIPE(pipe,

_DPST_GUARD_A, _DPST_GUARD_B)

drivers/gpu/drm/i915/display/intel_histogram.h new file +3 -0
+#define DPST_GUARD_HIST_INT_EN				REG_BIT(31)
+#define DPST_GUARD_HIST_EVENT_STATUS			REG_BIT(30)
+#define DPST_GUARD_INTERRUPT_DELAY_MASK
	REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)
	REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK
	REG_GENMASK(21, 0)

+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)
	_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK
	REG_GENMASK(23, 0)
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+#define DPST_BIN_BUSY					REG_BIT(31)
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
+						     INTEL_HISTOGRAM_PIPEA,

\

drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+						     INTEL_HISTOGRAM_PIPEB)
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    // 3.0% of

the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000 // Precision
factor for threshold guardband.

drivers/gpu/drm/i915/display/intel_histogram.h new file +9 -0
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h line 76

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+};
+
+enum intel_global_hist_lut {
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+

Description on this new structure and its new members with comments will be better.

This is internal to only this file and not exposed and the names are self explanatory. Please let me know if the headers are still required will add them in the next series.

Quoted 22 lines
Quoted 22 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +15 -0
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT];
+};
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc); int
+intel_histogram_update(struct intel_crtc *intel_crtc, bool enable);
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32
+*data); int intel_histogram_init(struct intel_crtc *intel_crtc); void
+intel_histogram_deinit(struct intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
drivers/gpu/drm/xe/Makefile +0 -0
index 628c245c4822..1881e3e1f4a9 100644
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/Makefile +1 -1
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
--

2.25.1

Thanks and Regards,
Arun R Murthy
-------------------

#6 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 114 lines

-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Thursday, August 22, 2024 12:07 PM
To: Kulkarni, Vandita <[email protected]>; intel- [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 28 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Monday, August 5, 2024 12:16 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 20 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 1/5] drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187

++++++++++++++++++

Quoted 6 lines
Quoted 6 lines
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
Quoted 8 lines

I see that this patch is doing 3 things, histogram enable, setting lut and also enable dithering.
See if they can be split into sub patches.

Also on a generic note, there are a lot of TODO comments, are they waiting on something or you have newer Version of these patches. Otherwise it will be better to make a note in the comments what will be the corner cases that would be hit with these TODO comments not

fixed.

TODO has been added in places where we don’t need them for now but required. As of now we are enabling just the basic histogram, going forward we will need to have this TODO implemented as the driver enhances. So just to keep an eye and we don’t loose track on this TODO has been added in the code itself.

Quoted 46 lines
Quoted 46 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/Makefile index c63fa2133ccb..03caf3a24966 100644

drivers/gpu/drm/i915/Makefile +1 -0
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
new file mode 100644
index 000000000000..1a603445fc29
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 18

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */

More info on what kind of restrictions we are talking about here, will be helpful.

Quoted 3 lines

These restrictions can be more confined to the algorithm that we use. We have the basic GHE algorithm now and going forward some restrictions will come.

I see that from the IGT patch that has been testing this series, the tests are skipped on non eDP panels.
https://patchwork.freedesktop.org/patch/602381/?series=135789&rev=1 (picked from cover letter)
if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)
+ continue;
Is this a miss from the IGT , if not
is the behavior known, on the how part if non eDP panels are tested with this feature? Or is this something that we would want to restrict from the driver, considering the gains from this feature?
I am not sure if I missed but I do not see this part documented or addressed in the patches.

Thanks,
Vandita

Quoted 341 lines
Quoted 55 lines
Quoted 55 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+	histogram->can_enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct
+drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe),

PIPE_MISC_DITHER_ENABLE,

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+		     PIPE_MISC_DITHER_ENABLE);
+}
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config

failed\n");

drivers/gpu/drm/i915/display/intel_histogram.c new file +16 -0
+		return -EINVAL;
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config-
Quoted 1 line

hw.adjusted_mode.htotal);

Quoted 13 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 13 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DE L

Quoted 64 lines
Quoted 64 lines

AY) |

drivers/gpu/drm/i915/display/intel_histogram.c new file +22 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN |

DPST_GUARD_HIST_EVENT_STATUS, 0);

drivers/gpu/drm/i915/display/intel_histogram.c new file +40 -0
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable) {
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32
+*data) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is NULL");
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines

DPST_CTL_BIN_REG_MASK,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_IE |

DPST_CTL_BIN_REG_CLEAR);

drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i,

data[i]);

Quoted 25 lines
Quoted 25 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK |

DPST_CTL_IE_MODI_TABLE_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_EN_MULTIPLICATIVE |

DPST_CTL_IE_MODI_TABLE_EN);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL,

DPST_CTL_BIN_REG_FUNC_TC);

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+
+	return 0;
+}
+
+void intel_histogram_deinit(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);
+}
+
+int intel_histogram_init(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram;
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");
+		kfree(histogram);

This Kfree is not needed, as it is already inside a NULL check.

Done!

Quoted 57 lines
Quoted 57 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +16 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)
	_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK
	REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE
	REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT
	REG_BIT(15)
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC

REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK

	REG_GENMASK(6, 0)

+#define DPST_CTL_BIN_REG_CLEAR
REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)

Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 8 lines

+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)

drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+
+#define _DPST_GUARD_A
	0x490C8
Quoted 2 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)

_MMIO_PIPE(pipe,

Quoted 2 lines
Quoted 2 lines

_DPST_GUARD_A, _DPST_GUARD_B)
+#define DPST_GUARD_HIST_INT_EN

	REG_BIT(31)
Quoted 1 line
Quoted 1 line

+#define DPST_GUARD_HIST_EVENT_STATUS

	REG_BIT(30)
Quoted 20 lines
Quoted 20 lines

+#define DPST_GUARD_INTERRUPT_DELAY_MASK

	REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)
	REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK
	REG_GENMASK(21, 0)

+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)
	_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK
	REG_GENMASK(23, 0)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_BIN_BUSY					REG_BIT(31)
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +1 -0
+						     INTEL_HISTOGRAM_PIPEA,

\

drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+						     INTEL_HISTOGRAM_PIPEB)
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    //

3.0% of

Quoted 2 lines
Quoted 2 lines

the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000 //

Precision

Quoted 10 lines
Quoted 10 lines

factor for threshold guardband.

drivers/gpu/drm/i915/display/intel_histogram.h new file +9 -0
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h line 76

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+};
+
+enum intel_global_hist_lut {
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+

Description on this new structure and its new members with comments will be better.

This is internal to only this file and not exposed and the names are self explanatory. Please let me know if the headers are still required will add them in the next series.

Quoted 23 lines
Quoted 23 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +15 -0
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT];
+};
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc); int
+intel_histogram_update(struct intel_crtc *intel_crtc, bool enable);
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32
+*data); int intel_histogram_init(struct intel_crtc *intel_crtc);
+void intel_histogram_deinit(struct intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
(quoted diff) +0 -0

b/drivers/gpu/drm/xe/Makefile index 628c245c4822..1881e3e1f4a9 100644

drivers/gpu/drm/xe/Makefile +0 -0
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/Makefile +1 -1
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
--

2.25.1

Thanks and Regards,
Arun R Murthy
-------------------

#7 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 130 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Thursday, August 22, 2024 4:24 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 114 lines

-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Thursday, August 22, 2024 12:07 PM
To: Kulkarni, Vandita <[email protected]>; intel- [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 28 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Monday, August 5, 2024 12:16 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 20 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 1/5] drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187

++++++++++++++++++

Quoted 6 lines
Quoted 6 lines
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)  create mode 100644
drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
Quoted 8 lines

I see that this patch is doing 3 things, histogram enable, setting lut and also enable dithering.
See if they can be split into sub patches.

Also on a generic note, there are a lot of TODO comments, are they waiting on something or you have newer Version of these patches. Otherwise it will be better to make a note in the comments what will be the corner cases that would be hit with these TODO comments not

fixed.

TODO has been added in places where we don’t need them for now but required. As of now we are enabling just the basic histogram, going forward we will need to have this TODO implemented as the driver enhances. So just to keep an eye and we don’t loose track on this TODO has been added in the code itself.

Quoted 46 lines
Quoted 46 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/Makefile index c63fa2133ccb..03caf3a24966 100644

drivers/gpu/drm/i915/Makefile +1 -0
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
new file mode 100644
index 000000000000..1a603445fc29
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 18

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */

More info on what kind of restrictions we are talking about here, will be helpful.

Quoted 3 lines

These restrictions can be more confined to the algorithm that we use. We have the basic GHE algorithm now and going forward some restrictions will come.

I see that from the IGT patch that has been testing this series, the tests are skipped on non eDP panels.
https://patchwork.freedesktop.org/patch/602381/?series=135789&rev=1
(picked from cover letter) if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)

(quoted diff) +1 -0
+			continue;
Quoted 7 lines

Is this a miss from the IGT , if not
is the behavior known, on the how part if non eDP panels are tested with this feature? Or is this something that we would want to restrict from the driver, considering the gains from this feature?
I am not sure if I missed but I do not see this part documented or addressed in the patches.

Histogram is as such generic and can be used on any connector.

Thanks and Regards,
Arun R Murthy
--------------------

Quoted 345 lines

Thanks,
Vandita

Quoted 342 lines
Quoted 55 lines
Quoted 55 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+	histogram->can_enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct
+drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe),

PIPE_MISC_DITHER_ENABLE,

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+		     PIPE_MISC_DITHER_ENABLE);
+}
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config

failed\n");

drivers/gpu/drm/i915/display/intel_histogram.c new file +16 -0
+		return -EINVAL;
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config-
Quoted 1 line

hw.adjusted_mode.htotal);

Quoted 13 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 13 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DE L

Quoted 65 lines
Quoted 65 lines

AY) |

drivers/gpu/drm/i915/display/intel_histogram.c new file +22 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN |

DPST_GUARD_HIST_EVENT_STATUS, 0);

drivers/gpu/drm/i915/display/intel_histogram.c new file +41 -0
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable) {
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc,
+u32
+*data) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is NULL");
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines

DPST_CTL_BIN_REG_MASK,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_IE |

DPST_CTL_BIN_REG_CLEAR);

drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i,

data[i]);

Quoted 25 lines
Quoted 25 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK |

DPST_CTL_IE_MODI_TABLE_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_EN_MULTIPLICATIVE |

DPST_CTL_IE_MODI_TABLE_EN);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL,

DPST_CTL_BIN_REG_FUNC_TC);

drivers/gpu/drm/i915/display/intel_histogram.c new file +13 -0
+
+	return 0;
+}
+
+void intel_histogram_deinit(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);
+}
+
+int intel_histogram_init(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram;
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");
+		kfree(histogram);

This Kfree is not needed, as it is already inside a NULL check.

Done!

Quoted 57 lines
Quoted 57 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +16 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)
	_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK
	REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE
	REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT
	REG_BIT(15)
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC

REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK

	REG_GENMASK(6, 0)

+#define DPST_CTL_BIN_REG_CLEAR
REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)

Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 8 lines

+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)

drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+
+#define _DPST_GUARD_A
	0x490C8
Quoted 2 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)

_MMIO_PIPE(pipe,

Quoted 2 lines
Quoted 2 lines

_DPST_GUARD_A, _DPST_GUARD_B)
+#define DPST_GUARD_HIST_INT_EN

	REG_BIT(31)
Quoted 1 line
Quoted 1 line

+#define DPST_GUARD_HIST_EVENT_STATUS

	REG_BIT(30)
Quoted 20 lines
Quoted 20 lines

+#define DPST_GUARD_INTERRUPT_DELAY_MASK

	REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)
	REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK
	REG_GENMASK(21, 0)

+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)
	_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK
	REG_GENMASK(23, 0)
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+#define DPST_BIN_BUSY					REG_BIT(31)
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +1 -0
+						     INTEL_HISTOGRAM_PIPEA,

\

drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+						     INTEL_HISTOGRAM_PIPEB)
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    //

3.0% of

Quoted 2 lines
Quoted 2 lines

the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000 //

Precision

Quoted 10 lines
Quoted 10 lines

factor for threshold guardband.

drivers/gpu/drm/i915/display/intel_histogram.h new file +9 -0
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h line 76

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+};
+
+enum intel_global_hist_lut {
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+

Description on this new structure and its new members with comments will be better.

This is internal to only this file and not exposed and the names are self explanatory. Please let me know if the headers are still required will add them in the next series.

Quoted 23 lines
Quoted 23 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +15 -0
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT]; };
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc);
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable); int intel_histogram_set_iet_lut(struct intel_crtc
+*intel_crtc, u32 *data); int intel_histogram_init(struct
+intel_crtc *intel_crtc); void intel_histogram_deinit(struct
+intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
(quoted diff) +0 -0

b/drivers/gpu/drm/xe/Makefile index 628c245c4822..1881e3e1f4a9 100644

drivers/gpu/drm/xe/Makefile +0 -0
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/Makefile +1 -1
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
--

2.25.1

Thanks and Regards,
Arun R Murthy
-------------------

#8 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 134 lines

-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Thursday, August 22, 2024 4:30 PM
To: Kulkarni, Vandita <[email protected]>; intel- [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 127 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Thursday, August 22, 2024 4:24 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 119 lines

-----Original Message-----
From: Murthy, Arun R <[email protected]>
Sent: Thursday, August 22, 2024 12:07 PM
To: Kulkarni, Vandita <[email protected]>; intel- [email protected]
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 29 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Monday, August 5, 2024 12:16 PM
To: Murthy, Arun R <[email protected]>; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 20 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 1/5] drm/i915/display: Add support for histogram

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187

++++++++++++++++++

Quoted 11 lines
Quoted 7 lines
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)  create mode 100644
drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644

drivers/gpu/drm/i915/display/intel_histogram.h

I see that this patch is doing 3 things, histogram enable, setting lut and also enable dithering.
See if they can be split into sub patches.

Quoted 5 lines

Also on a generic note, there are a lot of TODO comments, are they waiting on something or you have newer Version of these patches. Otherwise it will be better to make a note in the comments what will be the corner cases that would be hit with these TODO comments not

fixed.

TODO has been added in places where we don’t need them for now but required. As of now we are enabling just the basic histogram, going forward we will need to have this TODO implemented as the driver enhances. So just to keep an eye and we don’t loose track on this TODO has been added in the code itself.

Quoted 45 lines
Quoted 45 lines
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/Makefile index c63fa2133ccb..03caf3a24966 100644

drivers/gpu/drm/i915/Makefile +1 -0
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index 8713835e2307..e0a9c6d8c9b2 100644
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;  #endif diff --git

a/drivers/gpu/drm/i915/display/intel_histogram.c
b/drivers/gpu/drm/i915/display/intel_histogram.c
new file mode 100644
index 000000000000..1a603445fc29

drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 18

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +6 -0
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */

More info on what kind of restrictions we are talking about here, will be helpful.

These restrictions can be more confined to the algorithm that we use. We have the basic GHE algorithm now and going forward some restrictions will come.

Quoted 16 lines
Quoted 6 lines

I see that from the IGT patch that has been testing this series, the tests are skipped on non eDP panels.
https://patchwork.freedesktop.org/patch/602381/?series=135789&rev=1
(picked from cover letter) if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)

(quoted diff) +1 -0
+			continue;
Quoted 7 lines

Is this a miss from the IGT , if not
is the behavior known, on the how part if non eDP panels are tested with this feature? Or is this something that we would want to restrict from the driver, considering the gains from this feature?
I am not sure if I missed but I do not see this part documented or addressed in the patches.

Histogram is as such generic and can be used on any connector.

Thanks for the clarification, Looks like the IGT needs an update.

Regards,
Vandita

Quoted 367 lines

Thanks and Regards,
Arun R Murthy
--------------------

Quoted 37 lines

Thanks,
Vandita

Quoted 17 lines
Quoted 17 lines
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+	histogram->can_enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct
+drm_i915_private

*dev_priv,

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe),

PIPE_MISC_DITHER_ENABLE,

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+		     PIPE_MISC_DITHER_ENABLE); }
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc-

base.dev);

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config

failed\n");

drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+		return -EINVAL;
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |

DPST_CTL_IE_HIST_EN |

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_TC |

DPST_CTL_IE_HIST_EN |

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_CTL_HIST_MODE_HSV |
+

DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand

Threshold */

Quoted 17 lines
Quoted 17 lines
Quoted 16 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config-
Quoted 1 line

hw.adjusted_mode.htotal);

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DE

Quoted 5 lines
Quoted 5 lines

L

Quoted 4 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 4 lines

AY) |

drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write

*/

Quoted 44 lines
Quoted 10 lines
Quoted 10 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc-

base.dev);

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +9 -0
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN |

DPST_GUARD_HIST_EVENT_STATUS, 0);

drivers/gpu/drm/i915/display/intel_histogram.c new file +14 -0
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable) {
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc,
+u32
+*data) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc-

base.dev);

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is

NULL");

Quoted 83 lines
Quoted 34 lines
Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +9 -0
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL |
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines

DPST_CTL_BIN_REG_MASK,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_BIN_REG_FUNC_IE |

DPST_CTL_BIN_REG_CLEAR);

drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i,

data[i]);

Quoted 16 lines
Quoted 16 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK |

DPST_CTL_IE_MODI_TABLE_EN,

drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		     DPST_CTL_EN_MULTIPLICATIVE |

DPST_CTL_IE_MODI_TABLE_EN);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL,

DPST_CTL_BIN_REG_FUNC_TC);

drivers/gpu/drm/i915/display/intel_histogram.c new file +4 -0
+
+	return 0;
+}
+
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+void intel_histogram_deinit(struct intel_crtc *intel_crtc) {
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);
+}
+
+int intel_histogram_init(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc-

base.dev);

Quoted 40 lines
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+	struct intel_histogram *histogram;
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");
+		kfree(histogram);

This Kfree is not needed, as it is already inside a NULL check.

Done!

Quoted 29 lines
Quoted 29 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation  */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)
	_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)

+#define DPST_CTL_IE_HIST_EN

	REG_BIT(31)
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN
	REG_BIT(27)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+#define DPST_CTL_HIST_MODE

	REG_BIT(24)
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

+#define DPST_CTL_ENHANCEMENT_MODE_MASK

	REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE
	REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT
	REG_BIT(15)

+#define DPST_CTL_BIN_REG_FUNC_SEL

	REG_BIT(11)
Quoted 19 lines
Quoted 19 lines
Quoted 10 lines
Quoted 10 lines

+#define DPST_CTL_BIN_REG_FUNC_TC
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE
REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK

	REG_GENMASK(6, 0)

+#define DPST_CTL_BIN_REG_CLEAR
REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)

Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 8 lines

+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV
REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)

drivers/gpu/drm/i915/display/intel_histogram.h new file +2 -0
+
+#define _DPST_GUARD_A
	0x490C8
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+#define _DPST_GUARD_B

	0x491C8
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line

+#define DPST_GUARD(pipe)

_MMIO_PIPE(pipe,

Quoted 2 lines
Quoted 2 lines

_DPST_GUARD_A, _DPST_GUARD_B)
+#define DPST_GUARD_HIST_INT_EN

	REG_BIT(31)
Quoted 1 line
Quoted 1 line

+#define DPST_GUARD_HIST_EVENT_STATUS

	REG_BIT(30)
Quoted 16 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

+#define DPST_GUARD_INTERRUPT_DELAY_MASK

	REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)
	REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK
	REG_GENMASK(21, 0)

+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +4 -0
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)
	_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK
	REG_GENMASK(23, 0)

+#define DPST_BIN_BUSY

	REG_BIT(31)
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/i915/display/intel_histogram.h line 56

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
+

INTEL_HISTOGRAM_PIPEA,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

\
+

INTEL_HISTOGRAM_PIPEB)

Quoted 66 lines
Quoted 66 lines
Quoted 5 lines

drivers/gpu/drm/i915/display/intel_histogram.h

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +5 -0
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    //

3.0% of

Quoted 2 lines
Quoted 2 lines

the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000 //

Precision

Quoted 10 lines
Quoted 10 lines

factor for threshold guardband.

drivers/gpu/drm/i915/display/intel_histogram.h new file +9 -0
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_histogram.h line 76

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +6 -0
+};
+
+enum intel_global_hist_lut {
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+

Description on this new structure and its new members with comments will be better.

This is internal to only this file and not exposed and the names are self explanatory. Please let me know if the headers are still required will add them in the next series.

Quoted 23 lines
Quoted 23 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +15 -0
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT]; };
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc);
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool
+enable); int intel_histogram_set_iet_lut(struct intel_crtc
+*intel_crtc, u32 *data); int intel_histogram_init(struct
+intel_crtc *intel_crtc); void intel_histogram_deinit(struct
+intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
(quoted diff) +0 -0

b/drivers/gpu/drm/xe/Makefile index 628c245c4822..1881e3e1f4a9 100644

drivers/gpu/drm/xe/Makefile +0 -0
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/Makefile +1 -1
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
--

2.25.1

Thanks and Regards,
Arun R Murthy
-------------------

maintainer
#9 lore raw

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

In reply to Arun R Murthy
Quoted 35 lines · Arun R Murthy

Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This enhancement factor can be multiplied/added with the incoming pixel data frame.

---
 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 .../gpu/drm/i915/display/intel_histogram.c    | 187 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  91 +++++++++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_histogram.h
drivers/gpu/drm/i915/Makefile +1 -0
index c63fa2133ccb..03caf3a24966 100644
@@ -264,6 +264,7 @@ i915-y += \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
+	display/intel_histogram.o \
 	display/intel_hotplug.o \
 	display/intel_hotplug_irq.o \
 	display/intel_hti.o \
drivers/gpu/drm/i915/display/intel_display_types.h +0 -0
index 8713835e2307..e0a9c6d8c9b2 100644

drivers/gpu/drm/i915/display/intel_display_types.h struct intel_crtc { · line 1540

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1537,6 +1537,9 @@ struct intel_crtc {
 	/* for loading single buffered registers during vblank */
 	struct pm_qos_request vblank_pm_qos;
 
+	/* histogram data */

Does the comment add value?

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display_types.h +2 -0
+	struct intel_histogram *histogram;
+
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
 #endif
drivers/gpu/drm/i915/display/intel_histogram.c new file +0 -0
new file mode 100644
index 000000000000..1a603445fc29

drivers/gpu/drm/i915/display/intel_histogram.c line 7

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>

Blank line here.

drivers/gpu/drm/i915/display/intel_histogram.c line 19

Quoted 12 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +12 -0
+#include "i915_reg.h"
+#include "i915_drv.h"
+#include "intel_display_types.h"
+#include "intel_de.h"
+#include "intel_histogram.h"
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc)
+{
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	/* TODO: Restrictions for enabling histogram */
+	histogram->can_enable = true;

A function named _can_enable() sounds like a predicate function that does not have side effects.

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+
+	return 0;
+}
+
+static void intel_histogram_enable_dithering(struct drm_i915_private *dev_priv,
+					     enum pipe pipe)
+{
+	intel_de_rmw(dev_priv, PIPE_MISC(pipe), PIPE_MISC_DITHER_ENABLE,
+		     PIPE_MISC_DITHER_ENABLE);
+}

drivers/gpu/drm/i915/display/intel_histogram.c line 39

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+
+static int intel_histogram_enable(struct intel_crtc *intel_crtc)
+{
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {

intel_crtc->histogram may be NULL. Ditto everywhere.

drivers/gpu/drm/i915/display/intel_histogram.c line 42

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config failed\n");
+		return -EINVAL;

Seems iffy to log that as an error.

Quoted 31 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +31 -0
+	}
+
+	if (histogram->enable)
+		return 0;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config->hw.adjusted_mode.htotal);
+	gbandthreshold = (res *	HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /
+				HISTOGRAM_GUARDBAND_PRECISION_FACTOR;
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |

drivers/gpu/drm/i915/display/intel_histogram.c line 83

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+		     DPST_GUARD_INTERRUPT_DELAY_MASK | DPST_GUARD_HIST_INT_EN,
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+		     DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DELAY) |
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;

What do you need this for?

Compute config should be used to decide what to do.

Old and new state should be used to check whether it's already enabled.

Quoted 12 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +12 -0
+
+	return 0;
+}
+
+static void intel_histogram_disable(struct intel_crtc *intel_crtc)
+{
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);

drivers/gpu/drm/i915/display/intel_histogram.c line 105

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+
+	/* Clear pending interrupts and disable interrupts */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_INT_EN | DPST_GUARD_HIST_EVENT_STATUS, 0);
+
+	/* disable DPST_CTL Histogram mode */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_IE_HIST_EN, 0);
+
+	histogram->enable = false;

Ditto.

Quoted 58 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +58 -0
+}
+
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable)
+{
+	if (enable)
+		return intel_histogram_enable(intel_crtc);
+
+	intel_histogram_disable(intel_crtc);
+	return 0;
+}
+
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data)
+{
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	int pipe = intel_crtc->pipe;
+	int i = 0;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm, "histogram not enabled");
+		return -EINVAL;
+	}
+
+	if (!data) {
+		drm_err(&i915->drm, "enhancement LUT data is NULL");
+		return -EINVAL;
+	}
+
+	/*
+	 * Set DPST_CTL Bin Reg function select to IE
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK,
+		     DPST_CTL_BIN_REG_FUNC_IE | DPST_CTL_BIN_REG_CLEAR);
+
+	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+		intel_de_rmw(i915, DPST_BIN(pipe),
+			     DPST_BIN_DATA_MASK, data[i]);
+		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i, data[i]);
+	}
+
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_ENHANCEMENT_MODE_MASK | DPST_CTL_IE_MODI_TABLE_EN,
+		     DPST_CTL_EN_MULTIPLICATIVE | DPST_CTL_IE_MODI_TABLE_EN);
+
+	/* Once IE is applied, change DPST CTL to TC */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL, DPST_CTL_BIN_REG_FUNC_TC);
+
+	return 0;
+}
+
+void intel_histogram_deinit(struct intel_crtc *intel_crtc)
+{
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	kfree(histogram);

drivers/gpu/drm/i915/display/intel_histogram.c line 173

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+}
+
+int intel_histogram_init(struct intel_crtc *intel_crtc)
+{
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram;
+
+	/* Allocate histogram internal struct */
+	histogram = kzalloc(sizeof(*histogram), GFP_KERNEL);
+	if (unlikely(!histogram)) {

Please never use likely/unlikely unless you can show it has a meaningful perf impact.

drivers/gpu/drm/i915/display/intel_histogram.c line 175

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +2 -0
+		drm_err(&i915->drm,
+			"Failed to allocate HISTOGRAM event\n");

Please never log allocation failures.

drivers/gpu/drm/i915/display/intel_histogram.c line 176

Quoted 1 line
drivers/gpu/drm/i915/display/intel_histogram.c new file +1 -0
+		kfree(histogram);

Allocation of histogram just failed...?

Quoted 18 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		return -ENOMEM;
+	}
+
+	intel_crtc->histogram = histogram;
+	histogram->pipe = intel_crtc->pipe;
+	histogram->can_enable = false;
+
+	histogram->i915 = i915;
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_histogram.h new file +1 -0
new file mode 100644
index 000000000000..632116c52882
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT

drivers/gpu/drm/i915/display/intel_histogram.h line 11

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+#ifndef __INTEL_HISTOGRAM_H__
+#define __INTEL_HISTOGRAM_H__
+
+#include <drm/drm_device.h>
+#include <drm/drm_file.h>
+#include "intel_display.h"

Please use forward declarations instead of includes in headers whenever possible. You don't need *any* of those includes.

Quoted 41 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +41 -0
+#include "i915_reg.h"
+
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)					_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK			REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE			REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT			REG_BIT(15)
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC			REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE			REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK				REG_GENMASK(6, 0)
+#define DPST_CTL_BIN_REG_CLEAR				REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC	REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC	REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV				REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV				REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)
+
+#define _DPST_GUARD_A					0x490C8
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)				_MMIO_PIPE(pipe, _DPST_GUARD_A, _DPST_GUARD_B)
+#define DPST_GUARD_HIST_INT_EN				REG_BIT(31)
+#define DPST_GUARD_HIST_EVENT_STATUS			REG_BIT(30)
+#define DPST_GUARD_INTERRUPT_DELAY_MASK			REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)			REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK			REG_GENMASK(21, 0)
+#define DPST_GUARD_THRESHOLD_GB(val)			REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)					_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK				REG_GENMASK(23, 0)
+#define DPST_BIN_BUSY					REG_BIT(31)
+
+#define INTEL_HISTOGRAM_PIPEA			0x90000000
+#define INTEL_HISTOGRAM_PIPEB			0x90000002

drivers/gpu/drm/i915/display/intel_histogram.h line 62

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
+#define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
+						     INTEL_HISTOGRAM_PIPEA, \
+						     INTEL_HISTOGRAM_PIPEB)
+
+#define HISTOGRAM_BIN_COUNT			32
+#define HISTOGRAM_IET_LENGTH			33
+
+#define HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT 300    // 3.0% of the pipe's current pixel count.
+#define HISTOGRAM_GUARDBAND_PRECISION_FACTOR 10000   // Precision factor for threshold guardband.
+#define HISTOGRAM_DEFAULT_GUARDBAND_DELAY 0x04

Register macros belong in their own files. We never shove them in the regular headers like this.

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +11 -0
+
+enum intel_global_hist_status {
+	INTEL_HISTOGRAM_ENABLE,
+	INTEL_HISTOGRAM_DISABLE,
+};
+
+enum intel_global_histogram {
+	INTEL_HISTOGRAM,
+};
+
+enum intel_global_hist_lut {

drivers/gpu/drm/i915/display/intel_histogram.h line 83

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
+	INTEL_HISTOGRAM_PIXEL_FACTOR,
+};
+
+struct intel_histogram {
+	struct drm_i915_private *i915;
+	bool enable;
+	bool can_enable;
+	enum pipe pipe;
+	u32 bindata[HISTOGRAM_BIN_COUNT];
+};

These should probably be internal to intel_histogram.c.

Quoted 20 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +8 -0
+
+int intel_histogram_can_enable(struct intel_crtc *intel_crtc);
+int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable);
+int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data);
+int intel_histogram_init(struct intel_crtc *intel_crtc);
+void intel_histogram_deinit(struct intel_crtc *intel_crtc);
+
+#endif /* __INTEL_HISTOGRAM_H__ */
drivers/gpu/drm/xe/Makefile +1 -0
index 628c245c4822..1881e3e1f4a9 100644
@@ -260,6 +260,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_hdcp.o \
 	i915-display/intel_hdcp_gsc_message.o \
 	i915-display/intel_hdmi.o \
+	i915-display/intel_histogram.o \
 	i915-display/intel_hotplug.o \
 	i915-display/intel_hotplug_irq.o \
 	i915-display/intel_hti.o \
Signature · 1 line
Jani Nikula, Intel
#10 lore raw

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

Quoted 67 lines

drivers/gpu/drm/i915/display/intel_histogram.c line 39

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +8 -0
+static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
+	struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+	struct intel_histogram *histogram = intel_crtc->histogram;
+	int pipe = intel_crtc->pipe;
+	u64 res;
+	u32 gbandthreshold;
+
+	if (!histogram->can_enable) {

intel_crtc->histogram may be NULL. Ditto everywhere.

drivers/gpu/drm/i915/display/intel_histogram.c line 42

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +3 -0
+		drm_err(&i915->drm,
+			"Histogram not supported, compute config failed\n");
+		return -EINVAL;

Seems iffy to log that as an error.

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+	}
+
+	if (histogram->enable)
+		return 0;
+

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +10 -0
+	/* Pipe Dithering should be enabled with GLOBAL_HIST */
+	intel_histogram_enable_dithering(i915, pipe);
+
+	/*
+	 * enable DPST_CTL Histogram mode
+	 * Clear DPST_CTL Bin Reg function select to TC
+	 */
+	intel_de_rmw(i915, DPST_CTL(pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE |

DPST_CTL_IE_TABLE_VALUE_FORMAT,

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +11 -0
+		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+		     DPST_CTL_HIST_MODE_HSV |
+		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+
+	/* Re-Visit: check if wait for one vblank is required */
+	drm_crtc_wait_one_vblank(&intel_crtc->base);
+
+	/* TODO: one time programming: Program GuardBand Threshold */
+	res = (intel_crtc->config->hw.adjusted_mode.vtotal *
+				intel_crtc->config->hw.adjusted_mode.htotal);
+	gbandthreshold = (res *

HISTOGRAM_GUARDBAND_THRESHOLD_DEFAULT) /

Quoted 1 line

+

	HISTOGRAM_GUARDBAND_PRECISION_FACTOR;

drivers/gpu/drm/i915/display/intel_histogram.c

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +5 -0
+
+	/* Enable histogram interrupt mode */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_THRESHOLD_GB_MASK |
+		     DPST_GUARD_INTERRUPT_DELAY_MASK |

DPST_GUARD_HIST_INT_EN,

Review

Quoted 2 lines
(quoted diff) +2 -0
+		     DPST_GUARD_THRESHOLD_GB(gbandthreshold) |
+

DPST_GUARD_INTERRUPT_DELAY(HISTOGRAM_DEFAULT_GUARDBAND_DELAY) |

drivers/gpu/drm/i915/display/intel_histogram.c line 83

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_histogram.c new file +7 -0
+		     DPST_GUARD_HIST_INT_EN);
+
+	/* Clear pending interrupts has to be done on separate write */
+	intel_de_rmw(i915, DPST_GUARD(pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	histogram->enable = true;

What do you need this for?

Quoted 3 lines

Compute config should be used to decide what to do.

Old and new state should be used to check whether it's already enabled.

This is used while reading histogram and writing IET values. In case of a spurious histogram or in case of writing IET when histogram is not enabled.

Will work on the remaining comments.

Thanks and Regards,
Arun R Murthy
--------------------

maintainer
#11 lore raw

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

In reply to Arun R Murthy
Quoted 26 lines · Arun R Murthy
drivers/gpu/drm/i915/display/intel_histogram.h new file +26 -0
+/* GLOBAL_HIST related registers */
+#define _DPST_CTL_A					0x490C0
+#define _DPST_CTL_B					0x491C0
+#define DPST_CTL(pipe)					_MMIO_PIPE(pipe, _DPST_CTL_A, _DPST_CTL_B)
+#define DPST_CTL_IE_HIST_EN				REG_BIT(31)
+#define DPST_CTL_RESTORE				REG_BIT(28)
+#define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
+#define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_ENHANCEMENT_MODE_MASK			REG_GENMASK(14, 13)
+#define DPST_CTL_EN_MULTIPLICATIVE			REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT			REG_BIT(15)
+#define DPST_CTL_BIN_REG_FUNC_SEL			REG_BIT(11)
+#define DPST_CTL_BIN_REG_FUNC_TC			REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 0)
+#define DPST_CTL_BIN_REG_FUNC_IE			REG_FIELD_PREP(DPST_CTL_BIN_REG_FUNC_SEL, 1)
+#define DPST_CTL_BIN_REG_MASK				REG_GENMASK(6, 0)
+#define DPST_CTL_BIN_REG_CLEAR				REG_FIELD_PREP(DPST_CTL_BIN_REG_MASK, 0)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC	REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC	REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
+#define DPST_CTL_HIST_MODE_YUV				REG_FIELD_PREP(DPST_CTL_HIST_MODE, 0)
+#define DPST_CTL_HIST_MODE_HSV				REG_FIELD_PREP(DPST_CTL_HIST_MODE, 1)
+
+#define _DPST_GUARD_A					0x490C8
+#define _DPST_GUARD_B					0x491C8
+#define DPST_GUARD(pipe)				_MMIO_PIPE(pipe, _DPST_GUARD_A, _DPST_GUARD_B)
+#define DPST_GUARD_HIST_INT_EN				REG_BIT(31)
+#define DPST_GUARD_HIST_EVENT_STATUS			REG_BIT(30)

drivers/gpu/drm/i915/display/intel_histogram.h line 49

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.h new file +10 -0
+#define DPST_GUARD_INTERRUPT_DELAY_MASK			REG_GENMASK(29, 22)
+#define DPST_GUARD_INTERRUPT_DELAY(val)			REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
+#define DPST_GUARD_THRESHOLD_GB_MASK			REG_GENMASK(21, 0)
+#define DPST_GUARD_THRESHOLD_GB(val)			REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)
+
+#define _DPST_BIN_A					0x490C4
+#define _DPST_BIN_B					0x491C4
+#define DPST_BIN(pipe)					_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
+#define DPST_BIN_DATA_MASK				REG_GENMASK(23, 0)
+#define DPST_BIN_BUSY					REG_BIT(31)

PS. The big comment about formatting register definitions at the top of i915_reg.h still applies.

Signature · 1 line
Jani Nikula, Intel
#12 lore raw

PATCH 2/5 drm/i915/display: histogram interrupt handling

In reply to Arun R Murthy

Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt.

---
 .../gpu/drm/i915/display/intel_display_irq.c  |  6 +-
 .../gpu/drm/i915/display/intel_histogram.c    | 93 +++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  3 +
 drivers/gpu/drm/i915/i915_reg.h               |  5 +-
 4 files changed, 104 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_irq.c +5 -1
index 5219ba295c74..42fa2226b69e 100644
@@ -17,6 +17,7 @@
 #include "intel_fdi_regs.h"
 #include "intel_fifo_underrun.h"
 #include "intel_gmbus.h"
+#include "intel_histogram.h"
 #include "intel_hotplug_irq.h"
 #include "intel_pipe_crc_regs.h"
 #include "intel_pmdemand.h"
@@ -1155,6 +1156,9 @@ void gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
 		if (iir & gen8_de_pipe_underrun_mask(dev_priv))
 			intel_cpu_fifo_underrun_irq_handler(dev_priv, pipe);
 
+		if (iir & GEN9_PIPE_HISTOGRAM_EVENT)
+			intel_histogram_irq_handler(dev_priv, pipe);
+
 		fault_errors = iir & gen8_de_pipe_fault_mask(dev_priv);
 		if (fault_errors)
 			drm_err_ratelimited(&dev_priv->drm,
@@ -1683,7 +1687,7 @@ void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
 	struct intel_uncore *uncore = &dev_priv->uncore;
 
 	u32 de_pipe_masked = gen8_de_pipe_fault_mask(dev_priv) |
-		GEN8_PIPE_CDCLK_CRC_DONE;
+		GEN8_PIPE_CDCLK_CRC_DONE | GEN9_PIPE_HISTOGRAM_EVENT;
 	u32 de_pipe_enables;
 	u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
 	u32 de_port_enables;
drivers/gpu/drm/i915/display/intel_histogram.c +93 -0

117 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_histogram.h +3 -0
index 632116c52882..f07683dde005 100644
@@ -76,6 +76,8 @@ enum intel_global_hist_lut {
 
 struct intel_histogram {
 	struct drm_i915_private *i915;
+	struct workqueue_struct *wq;
+	struct delayed_work handle_histogram_int_work;
 	bool enable;
 	bool can_enable;
 	enum pipe pipe;
@@ -83,6 +85,7 @@ struct intel_histogram {
 };
 
 int intel_histogram_can_enable(struct intel_crtc *intel_crtc);
+void intel_histogram_irq_handler(struct drm_i915_private *i915, enum pipe pipe);
 int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable);
 int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data);
 int intel_histogram_init(struct intel_crtc *intel_crtc);
drivers/gpu/drm/i915/i915_reg.h +3 -2
index 0e3d79227e3c..185d4b66cbb6 100644
@@ -1655,7 +1655,7 @@
 #define   PIPE_HOTPLUG_INTERRUPT_ENABLE		(1UL << 26)
 #define   PIPE_VSYNC_INTERRUPT_ENABLE		(1UL << 25)
 #define   PIPE_DISPLAY_LINE_COMPARE_ENABLE	(1UL << 24)
-#define   PIPE_DPST_EVENT_ENABLE		(1UL << 23)
+#define   PIPE_HISTOGRAM_EVENT_ENABLE		(1UL << 23)
 #define   SPRITE0_FLIP_DONE_INT_EN_VLV		(1UL << 22)
 #define   PIPE_LEGACY_BLC_EVENT_ENABLE		(1UL << 22)
 #define   PIPE_ODD_FIELD_INTERRUPT_ENABLE	(1UL << 21)
@@ -1678,7 +1678,7 @@
 #define   PIPE_HOTPLUG_INTERRUPT_STATUS		(1UL << 10)
 #define   PIPE_VSYNC_INTERRUPT_STATUS		(1UL << 9)
 #define   PIPE_DISPLAY_LINE_COMPARE_STATUS	(1UL << 8)
-#define   PIPE_DPST_EVENT_STATUS		(1UL << 7)
+#define   PIPE_HISTOGRAM_EVENT_STATUS		(1UL << 7)
 #define   PIPE_A_PSR_STATUS_VLV			(1UL << 6)
 #define   PIPE_LEGACY_BLC_EVENT_STATUS		(1UL << 6)
 #define   PIPE_ODD_FIELD_INTERRUPT_STATUS	(1UL << 5)
@@ -2515,6 +2515,7 @@
 #define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
 #define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
 #define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
+#define  GEN9_PIPE_HISTOGRAM_EVENT	REG_BIT(12) /* skl+ */
 #define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
 #define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
 #define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
Signature · 1 line
2.25.1
maintainer
#13 lore raw

Re: [PATCH 2/5] drm/i915/display: histogram interrupt handling

Quoted 48 lines · Arun R Murthy

Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt.

---
 .../gpu/drm/i915/display/intel_display_irq.c  |  6 +-
 .../gpu/drm/i915/display/intel_histogram.c    | 93 +++++++++++++++++++
 .../gpu/drm/i915/display/intel_histogram.h    |  3 +
 drivers/gpu/drm/i915/i915_reg.h               |  5 +-
 4 files changed, 104 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_irq.c +5 -1
index 5219ba295c74..42fa2226b69e 100644
@@ -17,6 +17,7 @@
 #include "intel_fdi_regs.h"
 #include "intel_fifo_underrun.h"
 #include "intel_gmbus.h"
+#include "intel_histogram.h"
 #include "intel_hotplug_irq.h"
 #include "intel_pipe_crc_regs.h"
 #include "intel_pmdemand.h"
@@ -1155,6 +1156,9 @@ void gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
 		if (iir & gen8_de_pipe_underrun_mask(dev_priv))
 			intel_cpu_fifo_underrun_irq_handler(dev_priv, pipe);
 
+		if (iir & GEN9_PIPE_HISTOGRAM_EVENT)
+			intel_histogram_irq_handler(dev_priv, pipe);
+
 		fault_errors = iir & gen8_de_pipe_fault_mask(dev_priv);
 		if (fault_errors)
 			drm_err_ratelimited(&dev_priv->drm,
@@ -1683,7 +1687,7 @@ void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
 	struct intel_uncore *uncore = &dev_priv->uncore;
 
 	u32 de_pipe_masked = gen8_de_pipe_fault_mask(dev_priv) |
-		GEN8_PIPE_CDCLK_CRC_DONE;
+		GEN8_PIPE_CDCLK_CRC_DONE | GEN9_PIPE_HISTOGRAM_EVENT;
 	u32 de_pipe_enables;
 	u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
 	u32 de_port_enables;
drivers/gpu/drm/i915/display/intel_histogram.c +0 -0
index 1a603445fc29..8fa3bc74e52b 100644

drivers/gpu/drm/i915/display/intel_histogram.c line 20

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c +7 -0
@@ -11,6 +11,85 @@
 #include "intel_de.h"
 #include "intel_histogram.h"
 
+static void intel_histogram_handle_int_work(struct work_struct *work)
+{
+	struct intel_histogram *histogram = container_of(work,
+		struct intel_histogram, handle_histogram_int_work.work);
+	struct drm_i915_private *i915 = histogram->i915;
+	struct intel_crtc *intel_crtc =
+		to_intel_crtc(drm_crtc_from_index(&i915->drm, histogram->pipe));

You could just store the intel_crtc backpointer to histogram instead.

Quoted 13 lines
drivers/gpu/drm/i915/display/intel_histogram.c +13 -0
+	char *histogram_event[] = {"HISTOGRAM=1", NULL};
+	u32 dpstbin;
+	int i, try = 0;
+
+	/*
+	 * TODO: PSR to be exited while reading the Histogram data
+	 * Set DPST_CTL Bin Reg function select to TC
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK, 0);
+
+	for (i = 0; i < HISTOGRAM_BIN_COUNT; i++) {

drivers/gpu/drm/i915/display/intel_histogram.c line 43

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c +10 -0
+		dpstbin = intel_de_read(i915, DPST_BIN(histogram->pipe));
+		if (dpstbin & DPST_BIN_BUSY) {
+			/*
+			 * If DPST_BIN busy bit is set, then set the
+			 * DPST_CTL bin reg index to 0 and proceed
+			 * from beginning.
+			 */
+			intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+				     DPST_CTL_BIN_REG_MASK, 0);
+			i = 0;

Please don't mess with the loop variables within the loop. It makes hard to see what's really going on.

In this case, this becomes an infinite loop that you only break out by getting DPST_BIN_BUSY six times, and you only get out of here by returning.

Quoted 21 lines
drivers/gpu/drm/i915/display/intel_histogram.c +21 -0
+			if (try++ == 5) {
+				drm_err(&i915->drm,
+					"Histogram block is busy, failed to read\n");
+				intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+					     DPST_GUARD_HIST_EVENT_STATUS, 1);
+				return;
+			}
+		}
+		histogram->bindata[i] = dpstbin & DPST_BIN_DATA_MASK;
+		drm_dbg_atomic(&i915->drm, "Histogram[%d]=%x\n",
+			       i, histogram->bindata[i]);
+	}
+
+	/* Notify user for Histogram rediness */
+	if (kobject_uevent_env(&i915->drm.primary->kdev->kobj, KOBJ_CHANGE,
+			       histogram_event))
+		drm_err(&i915->drm, "sending HISTOGRAM event failed\n");
+
+	/* Enable histogram interrupt */
+	intel_de_rmw(i915, DPST_GUARD(histogram->pipe), DPST_GUARD_HIST_INT_EN,
+		     DPST_GUARD_HIST_INT_EN);

drivers/gpu/drm/i915/display/intel_histogram.c line 74

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c +10 -0
+
+	/* Clear histogram interrupt by setting histogram interrupt status bit*/
+	intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+
+	drm_property_replace_global_blob(&i915->drm,
+			&intel_crtc->config->histogram,
+			sizeof(histogram->bindata),
+			histogram->bindata, &intel_crtc->base.base,
+			intel_crtc->histogram_property);

So you first notify and then replace the property, creating a race?

Quoted 30 lines
drivers/gpu/drm/i915/display/intel_histogram.c +19 -0
+}
+
+void intel_histogram_irq_handler(struct drm_i915_private *i915, enum pipe pipe)
+{
+	struct intel_crtc *intel_crtc =
+		to_intel_crtc(drm_crtc_from_index(&i915->drm, pipe));
+	struct intel_histogram *histogram = intel_crtc->histogram;
+
+	if (!histogram->enable) {
+		drm_err(&i915->drm,
+			"spurious interrupt, histogram not enabled\n");
+		return;
+	}
+
+	queue_delayed_work(histogram->wq,
+			   &histogram->handle_histogram_int_work, 0);
+}
+
 int intel_histogram_can_enable(struct intel_crtc *intel_crtc)
 {
 	struct intel_histogram *histogram = intel_crtc->histogram;
@@ -102,6 +181,7 @@ static void intel_histogram_disable(struct intel_crtc *intel_crtc)
 	intel_de_rmw(i915, DPST_CTL(pipe),
 		     DPST_CTL_IE_HIST_EN, 0);
 
+	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
 }
 

drivers/gpu/drm/i915/display/intel_histogram.c void intel_histogram_deinit(struct intel_crtc *intel_crtc) · line 243

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
@@ -160,6 +240,8 @@ void intel_histogram_deinit(struct intel_crtc *intel_crtc)
 {
 	struct intel_histogram *histogram = intel_crtc->histogram;
 
+	cancel_delayed_work(&histogram->handle_histogram_int_work);

Probably want sync.

drivers/gpu/drm/i915/display/intel_histogram.c int intel_histogram_init(struct intel_crtc *intel_crtc) · line 266

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c +3 -0
+	destroy_workqueue(histogram->wq);
 	kfree(histogram);
 }
 
@@ -180,6 +262,17 @@ int intel_histogram_init(struct intel_crtc *intel_crtc)
 	intel_crtc->histogram = histogram;
 	histogram->pipe = intel_crtc->pipe;
 	histogram->can_enable = false;
+	histogram->wq = alloc_ordered_workqueue("histogram_wq",
+						WQ_MEM_RECLAIM);

Please don't add new workqueues, we have too many.

Quoted 63 lines
drivers/gpu/drm/i915/display/intel_histogram.c +9 -0
+	if (!histogram->wq) {
+		drm_err(&i915->drm,
+			"failed to create work queue\n");
+		kfree(histogram);
+		return -ENOMEM;
+	}
+
+	INIT_DEFERRABLE_WORK(&histogram->handle_histogram_int_work,
+			     intel_histogram_handle_int_work);
 
 	histogram->i915 = i915;
 
drivers/gpu/drm/i915/display/intel_histogram.h +3 -0
index 632116c52882..f07683dde005 100644
@@ -76,6 +76,8 @@ enum intel_global_hist_lut {
 
 struct intel_histogram {
 	struct drm_i915_private *i915;
+	struct workqueue_struct *wq;
+	struct delayed_work handle_histogram_int_work;
 	bool enable;
 	bool can_enable;
 	enum pipe pipe;
@@ -83,6 +85,7 @@ struct intel_histogram {
 };
 
 int intel_histogram_can_enable(struct intel_crtc *intel_crtc);
+void intel_histogram_irq_handler(struct drm_i915_private *i915, enum pipe pipe);
 int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable);
 int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data);
 int intel_histogram_init(struct intel_crtc *intel_crtc);
drivers/gpu/drm/i915/i915_reg.h +3 -2
index 0e3d79227e3c..185d4b66cbb6 100644
@@ -1655,7 +1655,7 @@
 #define   PIPE_HOTPLUG_INTERRUPT_ENABLE		(1UL << 26)
 #define   PIPE_VSYNC_INTERRUPT_ENABLE		(1UL << 25)
 #define   PIPE_DISPLAY_LINE_COMPARE_ENABLE	(1UL << 24)
-#define   PIPE_DPST_EVENT_ENABLE		(1UL << 23)
+#define   PIPE_HISTOGRAM_EVENT_ENABLE		(1UL << 23)
 #define   SPRITE0_FLIP_DONE_INT_EN_VLV		(1UL << 22)
 #define   PIPE_LEGACY_BLC_EVENT_ENABLE		(1UL << 22)
 #define   PIPE_ODD_FIELD_INTERRUPT_ENABLE	(1UL << 21)
@@ -1678,7 +1678,7 @@
 #define   PIPE_HOTPLUG_INTERRUPT_STATUS		(1UL << 10)
 #define   PIPE_VSYNC_INTERRUPT_STATUS		(1UL << 9)
 #define   PIPE_DISPLAY_LINE_COMPARE_STATUS	(1UL << 8)
-#define   PIPE_DPST_EVENT_STATUS		(1UL << 7)
+#define   PIPE_HISTOGRAM_EVENT_STATUS		(1UL << 7)
 #define   PIPE_A_PSR_STATUS_VLV			(1UL << 6)
 #define   PIPE_LEGACY_BLC_EVENT_STATUS		(1UL << 6)
 #define   PIPE_ODD_FIELD_INTERRUPT_STATUS	(1UL << 5)
@@ -2515,6 +2515,7 @@
 #define  GEN11_PIPE_PLANE7_FLIP_DONE	REG_BIT(18) /* icl/tgl */
 #define  GEN11_PIPE_PLANE6_FLIP_DONE	REG_BIT(17) /* icl/tgl */
 #define  GEN11_PIPE_PLANE5_FLIP_DONE	REG_BIT(16) /* icl+ */
+#define  GEN9_PIPE_HISTOGRAM_EVENT	REG_BIT(12) /* skl+ */
 #define  GEN9_PIPE_CURSOR_FAULT		REG_BIT(11) /* skl+ */
 #define  GEN9_PIPE_PLANE4_FAULT		REG_BIT(10) /* skl+ */
 #define  GEN8_PIPE_CURSOR_FAULT		REG_BIT(10) /* bdw */
Signature · 1 line
Jani Nikula, Intel
#14 lore raw

PATCH 3/5 Add crtc properties for global histogram

In reply to Arun R Murthy

CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly.
"Histogram" is a crtc property to read the binary histogram data. "Global IET" is a crtc property to write the IET binary LUT data.

---
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 ++
 .../drm/i915/display/intel_display_types.h    |  17 ++
 .../gpu/drm/i915/display/intel_histogram.c    |   1 +
 6 files changed, 242 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_atomic.c +5 -0
index 76aa10b6f647..693a22089937 100644
@@ -246,6 +246,8 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->uapi);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_get(crtc_state->global_iet);
 	/* copy color blobs */
 	if (crtc_state->hw.degamma_lut)
 		drm_property_blob_get(crtc_state->hw.degamma_lut);
@@ -277,6 +279,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->fb_bits = 0;
 	crtc_state->update_planes = 0;
 	crtc_state->dsb = NULL;
+	crtc_state->histogram_en_changed = false;
 
 	return &crtc_state->uapi;
 }
@@ -312,6 +315,8 @@ intel_crtc_destroy_state(struct drm_crtc *crtc,
 
 	drm_WARN_ON(crtc->dev, crtc_state->dsb);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_put(crtc_state->global_iet);
 	__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 	intel_crtc_free_hw_state(crtc_state);
 	if (crtc_state->dp_tunnel_ref.tunnel)
drivers/gpu/drm/i915/display/intel_crtc.c +201 -1

241 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_crtc.h +5 -0
index b615b7ab5ccd..56c6b7c6037e 100644
@@ -7,6 +7,7 @@
 #define _INTEL_CRTC_H_
 
 #include <linux/types.h>
+#include <drm/drm_crtc.h>
 
 enum i9xx_plane_id;
 enum pipe;
@@ -49,4 +50,8 @@ void intel_wait_for_vblank_if_active(struct drm_i915_private *i915,
 				     enum pipe pipe);
 void intel_crtc_wait_for_next_vblank(struct intel_crtc *crtc);
 
+int intel_crtc_add_property(struct intel_crtc *intel_crtc);
+void intel_attach_histogram_en_property(struct intel_crtc *intel_crtc);
+void intel_attach_global_iet_property(struct intel_crtc *intel_crtc);
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc);
 #endif
drivers/gpu/drm/i915/display/intel_display.c +13 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct intel_atomic_state *state,
 	if (ret)
 		return ret;
 
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }
 
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state->dsb);
+
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);
+		if (new_crtc_state->global_iet_changed)
+			intel_histogram_set_iet_lut(crtc,
+						    (u32 *)new_crtc_state->global_iet->data);
 	}
 
 	/* Underruns don't always raise interrupts, so check manually */
drivers/gpu/drm/i915/display/intel_display_types.h +17 -0
index e0a9c6d8c9b2..e7c33eb76a7e 100644
@@ -99,6 +99,12 @@ enum intel_broadcast_rgb {
 	INTEL_BROADCAST_RGB_LIMITED,
 };
 
+/* HISTOGRAM property */
+enum intel_histogram_en_prop {
+	INTEL_HISTOGRAM_PROP_DISABLE,
+	INTEL_HISTOGRAM_PROP_ENABLE,
+};
+
 struct intel_fb_view {
 	/*
 	 * The remap information used in the remapped and rotated views to
@@ -1431,6 +1437,13 @@ struct intel_crtc_state {
 
 	/* LOBF flag */
 	bool has_lobf;
+
+	/* HISTOGRAM data */
+	int histogram_en;
+	struct drm_property_blob *global_iet;
+	struct drm_property_blob *histogram;
+	bool global_iet_changed;
+	bool histogram_en_changed;
 };
 
 enum intel_pipe_crc_source {
@@ -1539,6 +1552,10 @@ struct intel_crtc {
 
 	/* histogram data */
 	struct intel_histogram *histogram;
+	/* HISTOGRAM properties */
+	struct drm_property *histogram_en_property;
+	struct drm_property *global_iet_property;
+	struct drm_property *histogram_property;
 
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
index 8fa3bc74e52b..740019fdf0df 100644
@@ -183,6 +183,7 @@ static void intel_histogram_disable(struct intel_crtc *intel_crtc)
 
 	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
+	intel_crtc->config->histogram_en = false;
 }
 
 int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable)
Signature · 1 line
2.25.1
#15 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 10 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 3/5] Add crtc properties for global histogram

Quoted 6 lines

CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data.
"HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly.
"Histogram" is a crtc property to read the binary histogram data. "Global IET" is a crtc property to write the IET binary LUT data.

+ CC'ing Abhinav from QC

Hi Abhinav,
As discussed in Display Hackfest, can you please share your thoughts and inputs on this series.

Thanks & Regards,
Uma Shankar

Quoted 423 lines
---
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 ++
 .../drm/i915/display/intel_display_types.h    |  17 ++
 .../gpu/drm/i915/display/intel_histogram.c    |   1 +
 6 files changed, 242 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_atomic.c +5 -0
index 76aa10b6f647..693a22089937 100644
@@ -246,6 +246,8 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->uapi);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_get(crtc_state->global_iet);
 	/* copy color blobs */
 	if (crtc_state->hw.degamma_lut)
 		drm_property_blob_get(crtc_state->hw.degamma_lut);
@@ -277,6 +279,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->fb_bits = 0;
 	crtc_state->update_planes = 0;
 	crtc_state->dsb = NULL;
+	crtc_state->histogram_en_changed = false;
 
 	return &crtc_state->uapi;
 }
@@ -312,6 +315,8 @@ intel_crtc_destroy_state(struct drm_crtc *crtc,
 
 	drm_WARN_ON(crtc->dev, crtc_state->dsb);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_put(crtc_state->global_iet);
 	__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 	intel_crtc_free_hw_state(crtc_state);
 	if (crtc_state->dp_tunnel_ref.tunnel)
drivers/gpu/drm/i915/display/intel_crtc.c +97 -0
index 1b578cad2813..24f160359422 100644
@@ -10,6 +10,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank_work.h>
+#include <drm/drm_atomic_uapi.h>
 
 #include "i915_vgpu.h"
 #include "i9xx_plane.h"
@@ -26,6 +27,7 @@
 #include "intel_drrs.h"
 #include "intel_dsi.h"
 #include "intel_fifo_underrun.h"
+#include "intel_histogram.h"
 #include "intel_pipe_crc.h"
 #include "intel_psr.h"
 #include "intel_sprite.h"
@@ -201,6 +203,7 @@ static struct intel_crtc *intel_crtc_alloc(void)  static void
 intel_crtc_free(struct intel_crtc *crtc)  {
 	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	intel_histogram_deinit(crtc);
 	kfree(crtc);
 }
 
@@ -220,6 +223,100 @@ static int intel_crtc_late_register(struct drm_crtc
 *crtc)
 	return 0;
 }
 
+static int intel_crtc_get_property(struct drm_crtc *crtc,
+				   const struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   uint64_t *val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	const struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+
+	if (property == intel_crtc->histogram_en_property) {
+		*val = intel_crtc_state->histogram_en;
+	} else if (property == intel_crtc->global_iet_property) {
+		*val = (intel_crtc_state->global_iet) ?
+			intel_crtc_state->global_iet->base.id : 0;
+	} else if (property == intel_crtc->histogram_property) {
+		*val = (intel_crtc_state->histogram) ?
+			intel_crtc_state->histogram->base.id : 0;
+	} else {
+		drm_err(&i915->drm,
+			"Unknown property [PROP:%d:%s]\n",
+			property->base.id, property->name);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int
+intel_atomic_replace_property_blob_from_id(struct drm_device *dev,
+					   struct drm_property_blob **blob,
+					   u64 blob_id,
+					   ssize_t expected_size,
+					   ssize_t expected_elem_size,
+					   bool *replaced)
+{
+	struct drm_property_blob *new_blob = NULL;
+
+	if (blob_id != 0) {
+		new_blob = drm_property_lookup_blob(dev, blob_id);
+		if (!new_blob)
+			return -EINVAL;
+
+		if (expected_size > 0 &&
+		    new_blob->length != expected_size) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+		if (expected_elem_size > 0 &&
+		    new_blob->length % expected_elem_size != 0) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+	}
+
+	*replaced |= drm_property_replace_blob(blob, new_blob);
+	drm_property_blob_put(new_blob);
+
+	return 0;
+}
+
+static int intel_crtc_set_property(struct drm_crtc *crtc,
+				   struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   u64 val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+	bool replaced = false;
+
+	if (property == intel_crtc->histogram_en_property) {
+		intel_crtc_state->histogram_en = val;
+		intel_crtc_state->histogram_en_changed = true;
+		return 0;
+	}
+
+	if (property == intel_crtc->global_iet_property) {
+		intel_atomic_replace_property_blob_from_id(crtc->dev,
+							   &intel_crtc_state-
 >global_iet,
+							   val,
+							   sizeof(uint32_t) *
 HISTOGRAM_IET_LENGTH,
+							   -1, &replaced);
+		if (replaced)
+			intel_crtc_state->global_iet_changed = true;
+		return 0;
+	}
+
+	drm_dbg_atomic(&i915->drm, "Unknown property [PROP:%d:%s]\n",
+		       property->base.id, property->name);
+	return -EINVAL;
+}
+

#define INTEL_CRTC_FUNCS \

drivers/gpu/drm/i915/display/intel_crtc.c +7 -1
 	.set_config = drm_atomic_helper_set_config, \
 	.destroy = intel_crtc_destroy, \
@@ -229,7 +326,9 @@ static int intel_crtc_late_register(struct drm_crtc *crtc)
 	.set_crc_source = intel_crtc_set_crc_source, \
 	.verify_crc_source = intel_crtc_verify_crc_source, \
 	.get_crc_sources = intel_crtc_get_crc_sources, \
-	.late_register = intel_crtc_late_register
+	.late_register = intel_crtc_late_register, \
+	.atomic_set_property = intel_crtc_set_property, \
+	.atomic_get_property = intel_crtc_get_property
 
 static const struct drm_crtc_funcs bdw_crtc_funcs = {
 	INTEL_CRTC_FUNCS,
@@ -374,6 +473,10 @@ int intel_crtc_init(struct drm_i915_private *dev_priv,
 enum pipe pipe)
 	intel_color_crtc_init(crtc);
 	intel_drrs_crtc_init(crtc);
 	intel_crtc_crc_init(crtc);
+	intel_histogram_init(crtc);
+
+	/* Initialize crtc properties */
+	intel_crtc_add_property(crtc);
 
 	cpu_latency_qos_add_request(&crtc->vblank_pm_qos,

PM_QOS_DEFAULT_VALUE);

drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
@@ -690,3 +793,100 @@ void intel_pipe_update_end(struct intel_atomic_state
 *state,
 out:
 	intel_psr_unlock(new_crtc_state);
 }
+
+static const struct drm_prop_enum_list histogram_en_names[] = {
+	{ INTEL_HISTOGRAM_DISABLE, "Disable" },
+	{ INTEL_HISTOGRAM_ENABLE, "Enable" },
+};
+
+/**
+ * intel_attach_histogram_en_property() - add property to
+enable/disable histogram
+ * @intel_crtc: pointer to the struct intel_crtc on which the global histogram is

to
+ * be enabled/disabled
+ *
+ * "HISTOGRAM_EN" is the crtc propety to enable/disable global

drivers/gpu/drm/i915/display/intel_crtc.c +12 -0
+histogram  */ void intel_attach_histogram_en_property(struct intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->histogram_en_property;
+	if (!prop) {
+		prop = drm_property_create_enum(dev, 0,
+						"HISTOGRAM_EN",
+						histogram_en_names,
+
	ARRAY_SIZE(histogram_en_names));
drivers/gpu/drm/i915/display/intel_crtc.c +24 -0
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_en_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_global_iet_property() - add property to write Image
+Enhancement data
+ * @intel_crtc: pointer to the struct intel_crtc on which global
+histogram is enabled
+ *
+ * "Global IET" is the crtc property to write the Image Enhancement LUT
+binary data  */ void intel_attach_global_iet_property(struct intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->global_iet_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB |

DRM_MODE_PROP_ATOMIC,

drivers/gpu/drm/i915/display/intel_crtc.c +33 -0
+					   "Global IET", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->global_iet_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_histogram_property() - crtc property to read the histogram.
+ * @intel_crtc: pointer to the struct intel_crtc on which the global histogram
+ *		was enabled.
+ * "Global Histogram" is the crtc property to read the binary histogram data.
+ */
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+	struct drm_property_blob *blob;
+
+	prop = intel_crtc->histogram_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB |
+					   DRM_MODE_PROP_ATOMIC |
+					   DRM_MODE_PROP_IMMUTABLE,
+					   "Global Histogram", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_property = prop;
+	}
+	blob = drm_property_create_blob(dev, sizeof(uint32_t) *

HISTOGRAM_BIN_COUNT, NULL);

drivers/gpu/drm/i915/display/intel_crtc.c +11 -0
+	intel_crtc->config->histogram = blob;
+
+	drm_object_attach_property(&crtc->base, prop, blob->base.id); }
+
+int intel_crtc_add_property(struct intel_crtc *intel_crtc) {
+	intel_attach_histogram_en_property(intel_crtc);
+	intel_attach_histogram_property(intel_crtc);
+	intel_attach_global_iet_property(intel_crtc);
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_crtc.h +5 -0
index b615b7ab5ccd..56c6b7c6037e 100644
@@ -7,6 +7,7 @@
 #define _INTEL_CRTC_H_
 
 #include <linux/types.h>
+#include <drm/drm_crtc.h>
 
 enum i9xx_plane_id;
 enum pipe;
@@ -49,4 +50,8 @@ void intel_wait_for_vblank_if_active(struct
 drm_i915_private *i915,
 				     enum pipe pipe);
 void intel_crtc_wait_for_next_vblank(struct intel_crtc *crtc);
 
+int intel_crtc_add_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_en_property(struct intel_crtc *intel_crtc); void
+intel_attach_global_iet_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_property(struct intel_crtc *intel_crtc);

#endif

drivers/gpu/drm/i915/display/intel_display.c +13 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct
 intel_atomic_state *state,
 	if (ret)
 		return ret;
 
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state->dsb);
+
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);
+		if (new_crtc_state->global_iet_changed)
+			intel_histogram_set_iet_lut(crtc,
+						    (u32 *)new_crtc_state-
 >global_iet->data);
 	}

/* Underruns don't always raise interrupts, so check manually */ diff --git
a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index e0a9c6d8c9b2..e7c33eb76a7e 100644

drivers/gpu/drm/i915/display/intel_display_types.h +17 -0
@@ -99,6 +99,12 @@ enum intel_broadcast_rgb {
 	INTEL_BROADCAST_RGB_LIMITED,
 };
 
+/* HISTOGRAM property */
+enum intel_histogram_en_prop {
+	INTEL_HISTOGRAM_PROP_DISABLE,
+	INTEL_HISTOGRAM_PROP_ENABLE,
+};
+
 struct intel_fb_view {
 	/*
 	 * The remap information used in the remapped and rotated views to
@@ -1431,6 +1437,13 @@ struct intel_crtc_state {
 
 	/* LOBF flag */
 	bool has_lobf;
+
+	/* HISTOGRAM data */
+	int histogram_en;
+	struct drm_property_blob *global_iet;
+	struct drm_property_blob *histogram;
+	bool global_iet_changed;
+	bool histogram_en_changed;
 };
 
 enum intel_pipe_crc_source {
@@ -1539,6 +1552,10 @@ struct intel_crtc {
 
 	/* histogram data */
 	struct intel_histogram *histogram;
+	/* HISTOGRAM properties */
+	struct drm_property *histogram_en_property;
+	struct drm_property *global_iet_property;
+	struct drm_property *histogram_property;
 
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
index 8fa3bc74e52b..740019fdf0df 100644
@@ -183,6 +183,7 @@ static void intel_histogram_disable(struct intel_crtc
 *intel_crtc)
 
 	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
+	intel_crtc->config->histogram_en = false;
 }
 

int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable)
--
2.25.1

#16 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

In reply to Arun R Murthy
Quoted 368 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 3/5] Add crtc properties for global histogram

CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data.
"HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly.
"Histogram" is a crtc property to read the binary histogram data. "Global IET" is a crtc property to write the IET binary LUT data.

---
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 ++
 .../drm/i915/display/intel_display_types.h    |  17 ++
 .../gpu/drm/i915/display/intel_histogram.c    |   1 +
 6 files changed, 242 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_atomic.c +5 -0
index 76aa10b6f647..693a22089937 100644
@@ -246,6 +246,8 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->uapi);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_get(crtc_state->global_iet);
 	/* copy color blobs */
 	if (crtc_state->hw.degamma_lut)
 		drm_property_blob_get(crtc_state->hw.degamma_lut);
@@ -277,6 +279,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->fb_bits = 0;
 	crtc_state->update_planes = 0;
 	crtc_state->dsb = NULL;
+	crtc_state->histogram_en_changed = false;
 
 	return &crtc_state->uapi;
 }
@@ -312,6 +315,8 @@ intel_crtc_destroy_state(struct drm_crtc *crtc,
 
 	drm_WARN_ON(crtc->dev, crtc_state->dsb);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_put(crtc_state->global_iet);
 	__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 	intel_crtc_free_hw_state(crtc_state);
 	if (crtc_state->dp_tunnel_ref.tunnel)
drivers/gpu/drm/i915/display/intel_crtc.c +93 -0
index 1b578cad2813..24f160359422 100644
@@ -10,6 +10,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank_work.h>
+#include <drm/drm_atomic_uapi.h>
 
 #include "i915_vgpu.h"
 #include "i9xx_plane.h"
@@ -26,6 +27,7 @@
 #include "intel_drrs.h"
 #include "intel_dsi.h"
 #include "intel_fifo_underrun.h"
+#include "intel_histogram.h"
 #include "intel_pipe_crc.h"
 #include "intel_psr.h"
 #include "intel_sprite.h"
@@ -201,6 +203,7 @@ static struct intel_crtc *intel_crtc_alloc(void)  static
 void intel_crtc_free(struct intel_crtc *crtc)  {
 	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	intel_histogram_deinit(crtc);
 	kfree(crtc);
 }
 
@@ -220,6 +223,100 @@ static int intel_crtc_late_register(struct drm_crtc
 *crtc)
 	return 0;
 }
 
+static int intel_crtc_get_property(struct drm_crtc *crtc,
+				   const struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   uint64_t *val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	const struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+
+	if (property == intel_crtc->histogram_en_property) {
+		*val = intel_crtc_state->histogram_en;
+	} else if (property == intel_crtc->global_iet_property) {
+		*val = (intel_crtc_state->global_iet) ?
+			intel_crtc_state->global_iet->base.id : 0;
+	} else if (property == intel_crtc->histogram_property) {
+		*val = (intel_crtc_state->histogram) ?
+			intel_crtc_state->histogram->base.id : 0;
+	} else {
+		drm_err(&i915->drm,
+			"Unknown property [PROP:%d:%s]\n",
+			property->base.id, property->name);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int
+intel_atomic_replace_property_blob_from_id(struct drm_device *dev,
+					   struct drm_property_blob **blob,
+					   u64 blob_id,
+					   ssize_t expected_size,
+					   ssize_t expected_elem_size,
+					   bool *replaced)
+{
+	struct drm_property_blob *new_blob = NULL;
+
+	if (blob_id != 0) {
+		new_blob = drm_property_lookup_blob(dev, blob_id);
+		if (!new_blob)
+			return -EINVAL;
+
+		if (expected_size > 0 &&
+		    new_blob->length != expected_size) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+		if (expected_elem_size > 0 &&
+		    new_blob->length % expected_elem_size != 0) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+	}
+
+	*replaced |= drm_property_replace_blob(blob, new_blob);
+	drm_property_blob_put(new_blob);
+
+	return 0;
+}
+
+static int intel_crtc_set_property(struct drm_crtc *crtc,
+				   struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   u64 val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+	bool replaced = false;
+
+	if (property == intel_crtc->histogram_en_property) {
+		intel_crtc_state->histogram_en = val;
+		intel_crtc_state->histogram_en_changed = true;
+		return 0;
+	}
+
+	if (property == intel_crtc->global_iet_property) {
+		intel_atomic_replace_property_blob_from_id(crtc->dev,
+							   &intel_crtc_state-
 >global_iet,
+							   val,
+							   sizeof(uint32_t) *
 HISTOGRAM_IET_LENGTH,
+							   -1, &replaced);
+		if (replaced)
+			intel_crtc_state->global_iet_changed = true;
+		return 0;
+	}
+
+	drm_dbg_atomic(&i915->drm, "Unknown property

[PROP:%d:%s]\n",

drivers/gpu/drm/i915/display/intel_crtc.c +7 -1
+		       property->base.id, property->name);
+	return -EINVAL;
+}
+
 #define INTEL_CRTC_FUNCS \
 	.set_config = drm_atomic_helper_set_config, \
 	.destroy = intel_crtc_destroy, \
@@ -229,7 +326,9 @@ static int intel_crtc_late_register(struct drm_crtc
 *crtc)
 	.set_crc_source = intel_crtc_set_crc_source, \
 	.verify_crc_source = intel_crtc_verify_crc_source, \
 	.get_crc_sources = intel_crtc_get_crc_sources, \
-	.late_register = intel_crtc_late_register
+	.late_register = intel_crtc_late_register, \
+	.atomic_set_property = intel_crtc_set_property, \
+	.atomic_get_property = intel_crtc_get_property
 
 static const struct drm_crtc_funcs bdw_crtc_funcs = {
drivers/gpu/drm/i915/display/intel_crtc.c +4 -0
 	INTEL_CRTC_FUNCS,
@@ -374,6 +473,10 @@ int intel_crtc_init(struct drm_i915_private
 *dev_priv, enum pipe pipe)
 	intel_color_crtc_init(crtc);
 	intel_drrs_crtc_init(crtc);
 	intel_crtc_crc_init(crtc);
+	intel_histogram_init(crtc);
+
+	/* Initialize crtc properties */
+	intel_crtc_add_property(crtc);
 
 	cpu_latency_qos_add_request(&crtc->vblank_pm_qos,

PM_QOS_DEFAULT_VALUE);

drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
@@ -690,3 +793,100 @@ void intel_pipe_update_end(struct
 intel_atomic_state *state,
 out:
 	intel_psr_unlock(new_crtc_state);
 }
+
+static const struct drm_prop_enum_list histogram_en_names[] = {
+	{ INTEL_HISTOGRAM_DISABLE, "Disable" },
+	{ INTEL_HISTOGRAM_ENABLE, "Enable" },
+};
+
+/**
+ * intel_attach_histogram_en_property() - add property to
+enable/disable histogram
+ * @intel_crtc: pointer to the struct intel_crtc on which the global histogram

is to
+ * be enabled/disabled
+ *
+ * "HISTOGRAM_EN" is the crtc propety to enable/disable global

drivers/gpu/drm/i915/display/intel_crtc.c +12 -0
+histogram  */ void intel_attach_histogram_en_property(struct intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->histogram_en_property;
+	if (!prop) {
+		prop = drm_property_create_enum(dev, 0,
+						"HISTOGRAM_EN",
+						histogram_en_names,
+
	ARRAY_SIZE(histogram_en_names));
drivers/gpu/drm/i915/display/intel_crtc.c +24 -0
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_en_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_global_iet_property() - add property to write Image
+Enhancement data
+ * @intel_crtc: pointer to the struct intel_crtc on which global
+histogram is enabled
+ *
+ * "Global IET" is the crtc property to write the Image Enhancement LUT
+binary data  */ void intel_attach_global_iet_property(struct intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->global_iet_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

| DRM_MODE_PROP_ATOMIC,

drivers/gpu/drm/i915/display/intel_crtc.c +24 -0
+					   "Global IET", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->global_iet_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_histogram_property() - crtc property to read the histogram.
+ * @intel_crtc: pointer to the struct intel_crtc on which the global histogram
+ *		was enabled.
+ * "Global Histogram" is the crtc property to read the binary histogram data.
+ */
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+	struct drm_property_blob *blob;
+
+	prop = intel_crtc->histogram_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

|

drivers/gpu/drm/i915/display/intel_crtc.c +9 -0
+					   DRM_MODE_PROP_ATOMIC |
+					   DRM_MODE_PROP_IMMUTABLE,
+					   "Global Histogram", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_property = prop;
+	}
+	blob = drm_property_create_blob(dev, sizeof(uint32_t) *

HISTOGRAM_BIN_COUNT, NULL);

drivers/gpu/drm/i915/display/intel_crtc.c +11 -0
+	intel_crtc->config->histogram = blob;
+
+	drm_object_attach_property(&crtc->base, prop, blob->base.id); }
+
+int intel_crtc_add_property(struct intel_crtc *intel_crtc) {
+	intel_attach_histogram_en_property(intel_crtc);
+	intel_attach_histogram_property(intel_crtc);
+	intel_attach_global_iet_property(intel_crtc);
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_crtc.h +5 -0
index b615b7ab5ccd..56c6b7c6037e 100644
@@ -7,6 +7,7 @@
 #define _INTEL_CRTC_H_
 
 #include <linux/types.h>
+#include <drm/drm_crtc.h>
 
 enum i9xx_plane_id;
 enum pipe;
@@ -49,4 +50,8 @@ void intel_wait_for_vblank_if_active(struct
 drm_i915_private *i915,
 				     enum pipe pipe);
 void intel_crtc_wait_for_next_vblank(struct intel_crtc *crtc);
 
+int intel_crtc_add_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_en_property(struct intel_crtc *intel_crtc); void
+intel_attach_global_iet_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_property(struct intel_crtc *intel_crtc);

#endif

drivers/gpu/drm/i915/display/intel_display.c +5 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct
 intel_atomic_state *state,
 	if (ret)
 		return ret;
 
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct · line 7513

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
 >dsb);
+

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct intel_atomic_state *state) · line 7515

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);

Is there any particular reason that this code is not part of pre plane update?

Quoted 66 lines
drivers/gpu/drm/i915/display/intel_display.c +3 -0
+		if (new_crtc_state->global_iet_changed)
+			intel_histogram_set_iet_lut(crtc,
+						    (u32 *)new_crtc_state-
 >global_iet->data);
drivers/gpu/drm/i915/display/intel_display.c +0 -1
 	}
 
 	/* Underruns don't always raise interrupts, so check manually */ diff
--git a/drivers/gpu/drm/i915/display/intel_display_types.h

b/drivers/gpu/drm/i915/display/intel_display_types.h index e0a9c6d8c9b2..e7c33eb76a7e 100644

drivers/gpu/drm/i915/display/intel_display_types.h +17 -0
@@ -99,6 +99,12 @@ enum intel_broadcast_rgb {
 	INTEL_BROADCAST_RGB_LIMITED,
 };
 
+/* HISTOGRAM property */
+enum intel_histogram_en_prop {
+	INTEL_HISTOGRAM_PROP_DISABLE,
+	INTEL_HISTOGRAM_PROP_ENABLE,
+};
+
 struct intel_fb_view {
 	/*
 	 * The remap information used in the remapped and rotated views to
@@ -1431,6 +1437,13 @@ struct intel_crtc_state {
 
 	/* LOBF flag */
 	bool has_lobf;
+
+	/* HISTOGRAM data */
+	int histogram_en;
+	struct drm_property_blob *global_iet;
+	struct drm_property_blob *histogram;
+	bool global_iet_changed;
+	bool histogram_en_changed;
 };
 
 enum intel_pipe_crc_source {
@@ -1539,6 +1552,10 @@ struct intel_crtc {
 
 	/* histogram data */
 	struct intel_histogram *histogram;
+	/* HISTOGRAM properties */
+	struct drm_property *histogram_en_property;
+	struct drm_property *global_iet_property;
+	struct drm_property *histogram_property;
 
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
index 8fa3bc74e52b..740019fdf0df 100644
@@ -183,6 +183,7 @@ static void intel_histogram_disable(struct intel_crtc
 *intel_crtc)
 
 	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
+	intel_crtc->config->histogram_en = false;
 }
 

int intel_histogram_update(struct intel_crtc *intel_crtc, bool enable)
--
2.25.1

#17 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 122 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Kulkarni, Vandita
Sent: Wednesday, September 11, 2024 10:46 AM
To: Murthy, Arun R <[email protected]>; intel- [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 111 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 3/5] Add crtc properties for global histogram

CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly.
"Histogram" is a crtc property to read the binary histogram data. "Global IET" is a crtc property to write the IET binary LUT data.

---
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 ++
 .../drm/i915/display/intel_display_types.h    |  17 ++
 .../gpu/drm/i915/display/intel_histogram.c    |   1 +
 6 files changed, 242 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_atomic.c +2 -0
index 76aa10b6f647..693a22089937 100644
@@ -246,6 +246,8 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state-
 uapi);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_get(crtc_state->global_iet);
 	/* copy color blobs */
 	if (crtc_state->hw.degamma_lut)
drivers/gpu/drm/i915/display/intel_atomic.c +3 -0
 		drm_property_blob_get(crtc_state->hw.degamma_lut);
@@ -277,6 +279,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->fb_bits = 0;
 	crtc_state->update_planes = 0;
 	crtc_state->dsb = NULL;
+	crtc_state->histogram_en_changed = false;
 
 	return &crtc_state->uapi;
 }
@@ -312,6 +315,8 @@ intel_crtc_destroy_state(struct drm_crtc *crtc,
 
 	drm_WARN_ON(crtc->dev, crtc_state->dsb);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_put(crtc_state->global_iet);
 	__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 	intel_crtc_free_hw_state(crtc_state);
 	if (crtc_state->dp_tunnel_ref.tunnel)
drivers/gpu/drm/i915/display/intel_crtc.c +3 -0
index 1b578cad2813..24f160359422 100644
@@ -10,6 +10,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank_work.h>
+#include <drm/drm_atomic_uapi.h>
 
 #include "i915_vgpu.h"
 #include "i9xx_plane.h"
@@ -26,6 +27,7 @@
 #include "intel_drrs.h"
 #include "intel_dsi.h"
 #include "intel_fifo_underrun.h"
+#include "intel_histogram.h"
 #include "intel_pipe_crc.h"
 #include "intel_psr.h"
 #include "intel_sprite.h"
@@ -201,6 +203,7 @@ static struct intel_crtc *intel_crtc_alloc(void)
 static void intel_crtc_free(struct intel_crtc *crtc)  {
 	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	intel_histogram_deinit(crtc);
 	kfree(crtc);
 }
 
@@ -220,6 +223,100 @@ static int intel_crtc_late_register(struct

drm_crtc
*crtc)

drivers/gpu/drm/i915/display/intel_crtc.c +20 -0
 	return 0;
 }
 
+static int intel_crtc_get_property(struct drm_crtc *crtc,
+				   const struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   uint64_t *val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	const struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+
+	if (property == intel_crtc->histogram_en_property) {
+		*val = intel_crtc_state->histogram_en;
+	} else if (property == intel_crtc->global_iet_property) {
+		*val = (intel_crtc_state->global_iet) ?
+			intel_crtc_state->global_iet->base.id : 0;
+	} else if (property == intel_crtc->histogram_property) {
+		*val = (intel_crtc_state->histogram) ?
+			intel_crtc_state->histogram->base.id : 0;
+	} else {
+		drm_err(&i915->drm,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 253

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_crtc.c +8 -0
+			"Unknown property [PROP:%d:%s]\n",
+			property->base.id, property->name);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+

Also to me the below function looks like drm_property_replace_blob_from_id, why are we not using that, am I missing something here..

Thanks,
Vandita

Quoted 338 lines
Quoted 158 lines
drivers/gpu/drm/i915/display/intel_crtc.c +53 -0
+static int
+intel_atomic_replace_property_blob_from_id(struct drm_device *dev,
+					   struct drm_property_blob **blob,
+					   u64 blob_id,
+					   ssize_t expected_size,
+					   ssize_t expected_elem_size,
+					   bool *replaced)
+{
+	struct drm_property_blob *new_blob = NULL;
+
+	if (blob_id != 0) {
+		new_blob = drm_property_lookup_blob(dev, blob_id);
+		if (!new_blob)
+			return -EINVAL;
+
+		if (expected_size > 0 &&
+		    new_blob->length != expected_size) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+		if (expected_elem_size > 0 &&
+		    new_blob->length % expected_elem_size != 0) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+	}
+
+	*replaced |= drm_property_replace_blob(blob, new_blob);
+	drm_property_blob_put(new_blob);
+
+	return 0;
+}
+
+static int intel_crtc_set_property(struct drm_crtc *crtc,
+				   struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   u64 val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+	bool replaced = false;
+
+	if (property == intel_crtc->histogram_en_property) {
+		intel_crtc_state->histogram_en = val;
+		intel_crtc_state->histogram_en_changed = true;
+		return 0;
+	}
+
+	if (property == intel_crtc->global_iet_property) {
+		intel_atomic_replace_property_blob_from_id(crtc->dev,
+							   &intel_crtc_state-
Quoted 1 line

global_iet,

drivers/gpu/drm/i915/display/intel_crtc.c +2 -0
+							   val,
+							   sizeof(uint32_t) *

HISTOGRAM_IET_LENGTH,

drivers/gpu/drm/i915/display/intel_crtc.c +7 -0
+							   -1, &replaced);
+		if (replaced)
+			intel_crtc_state->global_iet_changed = true;
+		return 0;
+	}
+
+	drm_dbg_atomic(&i915->drm, "Unknown property

[PROP:%d:%s]\n",

drivers/gpu/drm/i915/display/intel_crtc.c +4 -0
+		       property->base.id, property->name);
+	return -EINVAL;
+}
+
 #define INTEL_CRTC_FUNCS \
 	.set_config = drm_atomic_helper_set_config, \
 	.destroy = intel_crtc_destroy, \
@@ -229,7 +326,9 @@ static int intel_crtc_late_register(struct

drm_crtc
*crtc)

drivers/gpu/drm/i915/display/intel_crtc.c +7 -1
 	.set_crc_source = intel_crtc_set_crc_source, \
 	.verify_crc_source = intel_crtc_verify_crc_source, \
 	.get_crc_sources = intel_crtc_get_crc_sources, \
-	.late_register = intel_crtc_late_register
+	.late_register = intel_crtc_late_register, \
+	.atomic_set_property = intel_crtc_set_property, \
+	.atomic_get_property = intel_crtc_get_property
 
 static const struct drm_crtc_funcs bdw_crtc_funcs = {
 	INTEL_CRTC_FUNCS,
@@ -374,6 +473,10 @@ int intel_crtc_init(struct drm_i915_private
 *dev_priv, enum pipe pipe)
 	intel_color_crtc_init(crtc);
 	intel_drrs_crtc_init(crtc);
 	intel_crtc_crc_init(crtc);
+	intel_histogram_init(crtc);
+
+	/* Initialize crtc properties */
+	intel_crtc_add_property(crtc);
 
 	cpu_latency_qos_add_request(&crtc->vblank_pm_qos,

PM_QOS_DEFAULT_VALUE);

drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
@@ -690,3 +793,100 @@ void intel_pipe_update_end(struct
 intel_atomic_state *state,
 out:
 	intel_psr_unlock(new_crtc_state);
 }
+
+static const struct drm_prop_enum_list histogram_en_names[] = {
+	{ INTEL_HISTOGRAM_DISABLE, "Disable" },
+	{ INTEL_HISTOGRAM_ENABLE, "Enable" }, };
+
+/**
+ * intel_attach_histogram_en_property() - add property to
+enable/disable histogram
+ * @intel_crtc: pointer to the struct intel_crtc on which the global
+histogram

is to
+ * be enabled/disabled
+ *
+ * "HISTOGRAM_EN" is the crtc propety to enable/disable global

drivers/gpu/drm/i915/display/intel_crtc.c +13 -0
+histogram  */ void intel_attach_histogram_en_property(struct
+intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->histogram_en_property;
+	if (!prop) {
+		prop = drm_property_create_enum(dev, 0,
+						"HISTOGRAM_EN",
+						histogram_en_names,
+
	ARRAY_SIZE(histogram_en_names));
drivers/gpu/drm/i915/display/intel_crtc.c +25 -0
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_en_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_global_iet_property() - add property to write Image
+Enhancement data
+ * @intel_crtc: pointer to the struct intel_crtc on which global
+histogram is enabled
+ *
+ * "Global IET" is the crtc property to write the Image Enhancement
+LUT binary data  */ void intel_attach_global_iet_property(struct
+intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->global_iet_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

| DRM_MODE_PROP_ATOMIC,

drivers/gpu/drm/i915/display/intel_crtc.c +1 -0
+					   "Global IET", 0);

drivers/gpu/drm/i915/display/intel_crtc.c void intel_pipe_update_end(struct intel_atomic_state *state,

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
+		if (!prop)
+			return;
+
+		intel_crtc->global_iet_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_histogram_property() - crtc property to read the

histogram.

Quoted 1 line

+ * @intel_crtc: pointer to the struct intel_crtc on which the global

histogram

Quoted 2 lines

+ * was enabled.
+ * "Global Histogram" is the crtc property to read the binary histogram

data.

Quoted 81 lines

+ */

drivers/gpu/drm/i915/display/intel_crtc.c +9 -0
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+	struct drm_property_blob *blob;
+
+	prop = intel_crtc->histogram_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

|

drivers/gpu/drm/i915/display/intel_crtc.c +9 -0
+					   DRM_MODE_PROP_ATOMIC |
+					   DRM_MODE_PROP_IMMUTABLE,
+					   "Global Histogram", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_property = prop;
+	}
+	blob = drm_property_create_blob(dev, sizeof(uint32_t) *

HISTOGRAM_BIN_COUNT, NULL);

drivers/gpu/drm/i915/display/intel_crtc.c +11 -0
+	intel_crtc->config->histogram = blob;
+
+	drm_object_attach_property(&crtc->base, prop, blob->base.id); }
+
+int intel_crtc_add_property(struct intel_crtc *intel_crtc) {
+	intel_attach_histogram_en_property(intel_crtc);
+	intel_attach_histogram_property(intel_crtc);
+	intel_attach_global_iet_property(intel_crtc);
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_crtc.h +5 -0
index b615b7ab5ccd..56c6b7c6037e 100644
@@ -7,6 +7,7 @@
 #define _INTEL_CRTC_H_
 
 #include <linux/types.h>
+#include <drm/drm_crtc.h>
 
 enum i9xx_plane_id;
 enum pipe;
@@ -49,4 +50,8 @@ void intel_wait_for_vblank_if_active(struct
 drm_i915_private *i915,
 				     enum pipe pipe);
 void intel_crtc_wait_for_next_vblank(struct intel_crtc *crtc);
 
+int intel_crtc_add_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_en_property(struct intel_crtc *intel_crtc);
+void intel_attach_global_iet_property(struct intel_crtc *intel_crtc);
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc);

#endif

drivers/gpu/drm/i915/display/intel_display.c +5 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct
 intel_atomic_state *state,
 	if (ret)
 		return ret;
 
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct · line 7513

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
 >dsb);
+

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct intel_atomic_state *state) · line 7515

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);

Is there any particular reason that this code is not part of pre plane update?

Quoted 68 lines
drivers/gpu/drm/i915/display/intel_display.c +3 -0
+		if (new_crtc_state->global_iet_changed)
+			intel_histogram_set_iet_lut(crtc,
+						    (u32 *)new_crtc_state-
 >global_iet->data);
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	}
 
 	/* Underruns don't always raise interrupts, so check manually */
drivers/gpu/drm/i915/display/intel_display_types.h +17 -0
index e0a9c6d8c9b2..e7c33eb76a7e 100644
@@ -99,6 +99,12 @@ enum intel_broadcast_rgb {
 	INTEL_BROADCAST_RGB_LIMITED,
 };
 
+/* HISTOGRAM property */
+enum intel_histogram_en_prop {
+	INTEL_HISTOGRAM_PROP_DISABLE,
+	INTEL_HISTOGRAM_PROP_ENABLE,
+};
+
 struct intel_fb_view {
 	/*
 	 * The remap information used in the remapped and rotated views to
@@ -1431,6 +1437,13 @@ struct intel_crtc_state {
 
 	/* LOBF flag */
 	bool has_lobf;
+
+	/* HISTOGRAM data */
+	int histogram_en;
+	struct drm_property_blob *global_iet;
+	struct drm_property_blob *histogram;
+	bool global_iet_changed;
+	bool histogram_en_changed;
 };
 
 enum intel_pipe_crc_source {
@@ -1539,6 +1552,10 @@ struct intel_crtc {
 
 	/* histogram data */
 	struct intel_histogram *histogram;
+	/* HISTOGRAM properties */
+	struct drm_property *histogram_en_property;
+	struct drm_property *global_iet_property;
+	struct drm_property *histogram_property;
 
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
drivers/gpu/drm/i915/display/intel_histogram.c +0 -0
index 8fa3bc74e52b..740019fdf0df 100644
@@ -183,6 +183,7 @@ static void intel_histogram_disable(struct

intel_crtc
*intel_crtc)

drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
 	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
+	intel_crtc->config->histogram_en = false;
 }
 
 int intel_histogram_update(struct intel_crtc *intel_crtc, bool

enable)
--
2.25.1

#18 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 182 lines

-----Original Message-----
From: Kulkarni, Vandita <[email protected]>
Sent: Wednesday, September 11, 2024 2:20 PM
To: Kulkarni, Vandita <[email protected]>; Murthy, Arun R <[email protected]>; [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 122 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Kulkarni, Vandita
Sent: Wednesday, September 11, 2024 10:46 AM
To: Murthy, Arun R <[email protected]>; intel- [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 111 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Arun R Murthy
Sent: Friday, July 5, 2024 3:26 PM
To: [email protected]
Cc: Murthy, Arun R <[email protected]>
Subject: [PATCH 3/5] Add crtc properties for global histogram

CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly. "Histogram" is a crtc property to read the binary histogram data. "Global IET" is a crtc property to write the IET binary LUT data.

---
 drivers/gpu/drm/i915/display/intel_atomic.c   |   5 +
 drivers/gpu/drm/i915/display/intel_crtc.c     | 202 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_crtc.h     |   5 +
 drivers/gpu/drm/i915/display/intel_display.c  |  13 ++
 .../drm/i915/display/intel_display_types.h    |  17 ++
 .../gpu/drm/i915/display/intel_histogram.c    |   1 +
 6 files changed, 242 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_atomic.c +2 -0
index 76aa10b6f647..693a22089937 100644
@@ -246,6 +246,8 @@ intel_crtc_duplicate_state(struct drm_crtc
 *crtc)
 
 	__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state- uapi);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_get(crtc_state->global_iet);
 	/* copy color blobs */
 	if (crtc_state->hw.degamma_lut)
drivers/gpu/drm/i915/display/intel_atomic.c +3 -0
 		drm_property_blob_get(crtc_state->hw.degamma_lut);
@@ -277,6 +279,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->fb_bits = 0;
 	crtc_state->update_planes = 0;
 	crtc_state->dsb = NULL;
+	crtc_state->histogram_en_changed = false;
 
 	return &crtc_state->uapi;
 }
@@ -312,6 +315,8 @@ intel_crtc_destroy_state(struct drm_crtc *crtc,
 
 	drm_WARN_ON(crtc->dev, crtc_state->dsb);
 
+	if (crtc_state->global_iet)
+		drm_property_blob_put(crtc_state->global_iet);
 	__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 	intel_crtc_free_hw_state(crtc_state);
 	if (crtc_state->dp_tunnel_ref.tunnel)
drivers/gpu/drm/i915/display/intel_crtc.c +3 -0
index 1b578cad2813..24f160359422 100644
@@ -10,6 +10,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank_work.h>
+#include <drm/drm_atomic_uapi.h>
 
 #include "i915_vgpu.h"
 #include "i9xx_plane.h"
@@ -26,6 +27,7 @@
 #include "intel_drrs.h"
 #include "intel_dsi.h"
 #include "intel_fifo_underrun.h"
+#include "intel_histogram.h"
 #include "intel_pipe_crc.h"
 #include "intel_psr.h"
 #include "intel_sprite.h"
@@ -201,6 +203,7 @@ static struct intel_crtc *intel_crtc_alloc(void)
 static void intel_crtc_free(struct intel_crtc *crtc)  {
 	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	intel_histogram_deinit(crtc);
 	kfree(crtc);
 }
 
@@ -220,6 +223,100 @@ static int intel_crtc_late_register(struct

drm_crtc
*crtc)

drivers/gpu/drm/i915/display/intel_crtc.c +20 -0
 	return 0;
 }
 
+static int intel_crtc_get_property(struct drm_crtc *crtc,
+				   const struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   uint64_t *val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	const struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+
+	if (property == intel_crtc->histogram_en_property) {
+		*val = intel_crtc_state->histogram_en;
+	} else if (property == intel_crtc->global_iet_property) {
+		*val = (intel_crtc_state->global_iet) ?
+			intel_crtc_state->global_iet->base.id : 0;
+	} else if (property == intel_crtc->histogram_property) {
+		*val = (intel_crtc_state->histogram) ?
+			intel_crtc_state->histogram->base.id : 0;
+	} else {
+		drm_err(&i915->drm,
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 253

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_crtc.c +8 -0
+			"Unknown property [PROP:%d:%s]\n",
+			property->base.id, property->name);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+

Also to me the below function looks like drm_property_replace_blob_from_id, why are we not using that, am I missing something here..

Thanks,
Vandita

Quoted 38 lines
Quoted 38 lines
drivers/gpu/drm/i915/display/intel_crtc.c +38 -0
+static int
+intel_atomic_replace_property_blob_from_id(struct drm_device *dev,
+					   struct drm_property_blob **blob,
+					   u64 blob_id,
+					   ssize_t expected_size,
+					   ssize_t expected_elem_size,
+					   bool *replaced)
+{
+	struct drm_property_blob *new_blob = NULL;
+
+	if (blob_id != 0) {
+		new_blob = drm_property_lookup_blob(dev, blob_id);
+		if (!new_blob)
+			return -EINVAL;
+
+		if (expected_size > 0 &&
+		    new_blob->length != expected_size) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+		if (expected_elem_size > 0 &&
+		    new_blob->length % expected_elem_size != 0) {
+			drm_property_blob_put(new_blob);
+			return -EINVAL;
+		}
+	}
+
+	*replaced |= drm_property_replace_blob(blob, new_blob);
+	drm_property_blob_put(new_blob);
+
+	return 0;
+}
+
+static int intel_crtc_set_property(struct drm_crtc *crtc,
+				   struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   u64 val)
+{
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 299

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_crtc.c +8 -0
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+	bool replaced = false;
+
+	if (property == intel_crtc->histogram_en_property) {
+		intel_crtc_state->histogram_en = val;

Should this not be set only if the value changes, rather than setting it to true always?

Quoted 196 lines
Quoted 196 lines
Quoted 112 lines
drivers/gpu/drm/i915/display/intel_crtc.c +7 -0
+		intel_crtc_state->histogram_en_changed = true;
+		return 0;
+	}
+
+	if (property == intel_crtc->global_iet_property) {
+		intel_atomic_replace_property_blob_from_id(crtc->dev,
+							   &intel_crtc_state-
Quoted 1 line

global_iet,

drivers/gpu/drm/i915/display/intel_crtc.c +2 -0
+							   val,
+							   sizeof(uint32_t) *

HISTOGRAM_IET_LENGTH,

drivers/gpu/drm/i915/display/intel_crtc.c +7 -0
+							   -1, &replaced);
+		if (replaced)
+			intel_crtc_state->global_iet_changed = true;
+		return 0;
+	}
+
+	drm_dbg_atomic(&i915->drm, "Unknown property

[PROP:%d:%s]\n",

drivers/gpu/drm/i915/display/intel_crtc.c +4 -0
+		       property->base.id, property->name);
+	return -EINVAL;
+}
+
 #define INTEL_CRTC_FUNCS \
 	.set_config = drm_atomic_helper_set_config, \
 	.destroy = intel_crtc_destroy, \
@@ -229,7 +326,9 @@ static int intel_crtc_late_register(struct

drm_crtc
*crtc)

drivers/gpu/drm/i915/display/intel_crtc.c +7 -1
 	.set_crc_source = intel_crtc_set_crc_source, \
 	.verify_crc_source = intel_crtc_verify_crc_source, \
 	.get_crc_sources = intel_crtc_get_crc_sources, \
-	.late_register = intel_crtc_late_register
+	.late_register = intel_crtc_late_register, \
+	.atomic_set_property = intel_crtc_set_property, \
+	.atomic_get_property = intel_crtc_get_property
 
 static const struct drm_crtc_funcs bdw_crtc_funcs = {
 	INTEL_CRTC_FUNCS,
@@ -374,6 +473,10 @@ int intel_crtc_init(struct drm_i915_private
 *dev_priv, enum pipe pipe)
 	intel_color_crtc_init(crtc);
 	intel_drrs_crtc_init(crtc);
 	intel_crtc_crc_init(crtc);
+	intel_histogram_init(crtc);
+
+	/* Initialize crtc properties */
+	intel_crtc_add_property(crtc);
 
 	cpu_latency_qos_add_request(&crtc->vblank_pm_qos,

PM_QOS_DEFAULT_VALUE);

drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
@@ -690,3 +793,100 @@ void intel_pipe_update_end(struct
 intel_atomic_state *state,
 out:
 	intel_psr_unlock(new_crtc_state);
 }
+
+static const struct drm_prop_enum_list histogram_en_names[] = {
+	{ INTEL_HISTOGRAM_DISABLE, "Disable" },
+	{ INTEL_HISTOGRAM_ENABLE, "Enable" }, };
+
+/**
+ * intel_attach_histogram_en_property() - add property to
+enable/disable histogram
+ * @intel_crtc: pointer to the struct intel_crtc on which the
+global histogram

is to
+ * be enabled/disabled
+ *
+ * "HISTOGRAM_EN" is the crtc propety to enable/disable global

drivers/gpu/drm/i915/display/intel_crtc.c +13 -0
+histogram  */ void intel_attach_histogram_en_property(struct
+intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->histogram_en_property;
+	if (!prop) {
+		prop = drm_property_create_enum(dev, 0,
+						"HISTOGRAM_EN",
+						histogram_en_names,
+
	ARRAY_SIZE(histogram_en_names));
drivers/gpu/drm/i915/display/intel_crtc.c +25 -0
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_en_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_global_iet_property() - add property to write Image
+Enhancement data
+ * @intel_crtc: pointer to the struct intel_crtc on which global
+histogram is enabled
+ *
+ * "Global IET" is the crtc property to write the Image Enhancement
+LUT binary data  */ void intel_attach_global_iet_property(struct
+intel_crtc
+*intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+
+	prop = intel_crtc->global_iet_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

| DRM_MODE_PROP_ATOMIC,

drivers/gpu/drm/i915/display/intel_crtc.c +1 -0
+					   "Global IET", 0);

drivers/gpu/drm/i915/display/intel_crtc.c void intel_pipe_update_end(struct intel_atomic_state *state,

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_crtc.c +10 -0
+		if (!prop)
+			return;
+
+		intel_crtc->global_iet_property = prop;
+	}
+
+	drm_object_attach_property(&crtc->base, prop, 0); }
+
+/**
+ * intel_attach_histogram_property() - crtc property to read the

histogram.

Quoted 2 lines

+ * @intel_crtc: pointer to the struct intel_crtc on which the
+ global

histogram

Quoted 3 lines

+ * was enabled.
+ * "Global Histogram" is the crtc property to read the binary
+ histogram

data.

Quoted 66 lines

+ */

drivers/gpu/drm/i915/display/intel_crtc.c +9 -0
+void intel_attach_histogram_property(struct intel_crtc *intel_crtc) {
+	struct drm_crtc *crtc = &intel_crtc->base;
+	struct drm_device *dev = crtc->dev;
+	struct drm_property *prop;
+	struct drm_property_blob *blob;
+
+	prop = intel_crtc->histogram_property;
+	if (!prop) {
+		prop = drm_property_create(dev, DRM_MODE_PROP_BLOB

|

drivers/gpu/drm/i915/display/intel_crtc.c +9 -0
+					   DRM_MODE_PROP_ATOMIC |
+					   DRM_MODE_PROP_IMMUTABLE,
+					   "Global Histogram", 0);
+		if (!prop)
+			return;
+
+		intel_crtc->histogram_property = prop;
+	}
+	blob = drm_property_create_blob(dev, sizeof(uint32_t) *

HISTOGRAM_BIN_COUNT, NULL);

drivers/gpu/drm/i915/display/intel_crtc.c +11 -0
+	intel_crtc->config->histogram = blob;
+
+	drm_object_attach_property(&crtc->base, prop, blob->base.id); }
+
+int intel_crtc_add_property(struct intel_crtc *intel_crtc) {
+	intel_attach_histogram_en_property(intel_crtc);
+	intel_attach_histogram_property(intel_crtc);
+	intel_attach_global_iet_property(intel_crtc);
+
+	return 0;
+}
drivers/gpu/drm/i915/display/intel_crtc.h +6 -0
index b615b7ab5ccd..56c6b7c6037e 100644
@@ -7,6 +7,7 @@
 #define _INTEL_CRTC_H_
 
 #include <linux/types.h>
+#include <drm/drm_crtc.h>
 
 enum i9xx_plane_id;
 enum pipe;
@@ -49,4 +50,8 @@ void intel_wait_for_vblank_if_active(struct
 drm_i915_private *i915,
 				     enum pipe pipe);
 void intel_crtc_wait_for_next_vblank(struct intel_crtc *crtc);
 
+int intel_crtc_add_property(struct intel_crtc *intel_crtc); void
+intel_attach_histogram_en_property(struct intel_crtc *intel_crtc);
+void intel_attach_global_iet_property(struct intel_crtc
+*intel_crtc); void intel_attach_histogram_property(struct
+intel_crtc *intel_crtc);
 #endif
drivers/gpu/drm/i915/display/intel_display.c +1 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_display.c static int intel_crtc_atomic_check(struct · line 4328

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct
 intel_atomic_state *state,
 	if (ret)
 		return ret;
 

I see that you may have kept it for future use, but I cannot see any practical use for this in this series. And what could be the future use is not mentioned either.

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct · line 7513

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
 >dsb);
+

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

I have couple of more comments here, since you setting histogram_en_changed to true always, the disable code inside histogram_update will get executed always until someone resets this flag.

Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct intel_atomic_state *state) · line 7515

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);

Is there any particular reason that this code is not part of pre plane update?

Had missed couple of comments in the previous reply. Have added it here. Sorry for multiple emails. Thanks
Vandita

Quoted 68 lines
Quoted 68 lines
Quoted 68 lines
drivers/gpu/drm/i915/display/intel_display.c +3 -0
+		if (new_crtc_state->global_iet_changed)
+			intel_histogram_set_iet_lut(crtc,
+						    (u32 *)new_crtc_state-
 >global_iet->data);
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	}
 
 	/* Underruns don't always raise interrupts, so check manually */
drivers/gpu/drm/i915/display/intel_display_types.h +17 -0
index e0a9c6d8c9b2..e7c33eb76a7e 100644
@@ -99,6 +99,12 @@ enum intel_broadcast_rgb {
 	INTEL_BROADCAST_RGB_LIMITED,
 };
 
+/* HISTOGRAM property */
+enum intel_histogram_en_prop {
+	INTEL_HISTOGRAM_PROP_DISABLE,
+	INTEL_HISTOGRAM_PROP_ENABLE,
+};
+
 struct intel_fb_view {
 	/*
 	 * The remap information used in the remapped and rotated views to
@@ -1431,6 +1437,13 @@ struct intel_crtc_state {
 
 	/* LOBF flag */
 	bool has_lobf;
+
+	/* HISTOGRAM data */
+	int histogram_en;
+	struct drm_property_blob *global_iet;
+	struct drm_property_blob *histogram;
+	bool global_iet_changed;
+	bool histogram_en_changed;
 };
 
 enum intel_pipe_crc_source {
@@ -1539,6 +1552,10 @@ struct intel_crtc {
 
 	/* histogram data */
 	struct intel_histogram *histogram;
+	/* HISTOGRAM properties */
+	struct drm_property *histogram_en_property;
+	struct drm_property *global_iet_property;
+	struct drm_property *histogram_property;
 
 #ifdef CONFIG_DEBUG_FS
 	struct intel_pipe_crc pipe_crc;
drivers/gpu/drm/i915/display/intel_histogram.c +0 -0
index 8fa3bc74e52b..740019fdf0df 100644
@@ -183,6 +183,7 @@ static void intel_histogram_disable(struct

intel_crtc
*intel_crtc)

drivers/gpu/drm/i915/display/intel_histogram.c +1 -0
 	cancel_delayed_work(&histogram->handle_histogram_int_work);
 	histogram->enable = false;
+	intel_crtc->config->histogram_en = false;
 }
 
 int intel_histogram_update(struct intel_crtc *intel_crtc, bool

enable)
--
2.25.1

#19 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

Quoted 16 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_crtc.c +5 -0
+static int intel_crtc_set_property(struct drm_crtc *crtc,
+				   struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   u64 val)
+{
Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 299

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_crtc.c +8 -0
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+	bool replaced = false;
+
+	if (property == intel_crtc->histogram_en_property) {
+		intel_crtc_state->histogram_en = val;

Should this not be set only if the value changes, rather than setting it to true always?

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 300

Quoted 1 line
drivers/gpu/drm/i915/display/intel_crtc.c +1 -0
+		intel_crtc_state->histogram_en_changed = true;

This is to flag that user has requested for a change and the value 'true' is used for that.

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
index c2c388212e2e..94e9f7a71a90 100644
@@ -93,6 +93,7 @@
 #include "intel_fifo_underrun.h"
 #include "intel_frontbuffer.h"
 #include "intel_hdmi.h"
+#include "intel_histogram.h"
 #include "intel_hotplug.h"
 #include "intel_link_bw.h"
 #include "intel_lvds.h"
@@ -4324,6 +4325,10 @@ static int intel_crtc_atomic_check(struct
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines

drivers/gpu/drm/i915/display/intel_display.c static int intel_crtc_atomic_check(struct intel_atomic_state *state, · line 4327

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 intel_atomic_state *state,
 	if (ret)
 		return ret;
 

I see that you may have kept it for future use, but I cannot see any practical use for this in this series.
And what could be the future use is not mentioned either.

The selective fetch series of patch is expected to follow up this series of patches. Here we will have to validate the co-ordinates in atomic check.

Quoted 16 lines
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_display.c +5 -0
+	/* HISTOGRAM changed */
+	if (crtc_state->histogram_en_changed)
+		return intel_histogram_can_enable(crtc);
+
 	return 0;
 }
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
 >dsb);
+
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

I have couple of more comments here, since you setting histogram_en_changed to true always, the disable code inside histogram_update will get executed always until someone resets this flag.

In crtc_duplicate_state the flag is reset to false.

Quoted 9 lines
Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct intel_atomic_state *state) · line 7515

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
+		/* Re-Visit: HISTOGRAM related stuff */
+		if (new_crtc_state->histogram_en_changed)
+			intel_histogram_update(crtc,
+					       new_crtc_state->histogram_en);

Is there any particular reason that this code is not part of pre plane update?

Had missed couple of comments in the previous reply. Have added it here. Sorry for multiple emails.

The reason for not having this is pre_plane update is this is a crtc feature and to be enabled at the end.

Thanks and Regards,
Arun R Murthy
--------------------

#20 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

In reply to Kulkarni, Vandita
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
drivers/gpu/drm/i915/display/intel_crtc.c +22 -0
+static int intel_crtc_get_property(struct drm_crtc *crtc,
+				   const struct drm_crtc_state *state,
+				   struct drm_property *property,
+				   uint64_t *val)
+{
+	struct drm_i915_private *i915 = to_i915(crtc->dev);
+	const struct intel_crtc_state *intel_crtc_state =
+		to_intel_crtc_state(state);
+	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+
+	if (property == intel_crtc->histogram_en_property) {
+		*val = intel_crtc_state->histogram_en;
+	} else if (property == intel_crtc->global_iet_property) {
+		*val = (intel_crtc_state->global_iet) ?
+			intel_crtc_state->global_iet->base.id : 0;
+	} else if (property == intel_crtc->histogram_property) {
+		*val = (intel_crtc_state->histogram) ?
+			intel_crtc_state->histogram->base.id : 0;
+	} else {
+		drm_err(&i915->drm,
+			"Unknown property [PROP:%d:%s]\n",
+			property->base.id, property->name);
Quoted 9 lines
Quoted 6 lines

drivers/gpu/drm/i915/display/intel_crtc.c static int intel_crtc_late_register(struct drm_crtc *crtc) · line 253

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_crtc.c +6 -0
+		return -EINVAL;
+	}
+
+	return 0;
+}
+

Also to me the below function looks like drm_property_replace_blob_from_id, why are we not using that, am I missing something here..

This function was not exposed from drm when this patch was initially developed. Thanks will make us of this function.

Thanks and Regards,
Arun R Murthy
--------------------

#21 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

In reply to Kulkarni, Vandita
Quoted 11 lines

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct · line 7513

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
 >dsb);
+

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

This wait is for all the platforms and is required after enabling histogram and before programming the guardband registers. User space will have no impact as this histogram event is not generated immediately. It's a statistics of 'n' number of frames.

Thanks and Regards,
Arun R Murthy
--------------------

#22 lore raw

RE: [PATCH 3/5] Add crtc properties for global histogram

In reply to Kulkarni, Vandita
Quoted 11 lines

drivers/gpu/drm/i915/display/intel_display.c static void intel_atomic_commit_tail(struct · line 7513

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
 intel_atomic_state *state)
 		 * FIXME get rid of this funny new->old swapping
 		 */
 		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
 >dsb);
+

Since there is a wait_for_vblank in this for older platforms only, what is the expected user space behaviour here for enabling histogram and updating the iets.

This wait is for all the platforms and is required after enabling histogram and before programming the guardband registers. User space will have no impact as this histogram event is not generated immediately. It's a statistics of 'n' number of frames.

Thanks and Regards,
Arun R Murthy
--------------------

#23 lore raw

PATCH 4/5 drm/i915/histogram: histogram delay counter doesnt reset

In reply to Arun R Murthy

The delay counter for histogram does not reset and as a result the histogram bin never gets updated. Woraround would be to use save and restore histogram register.

---
 drivers/gpu/drm/i915/display/intel_histogram.c | 17 +++++++++++++++++
 drivers/gpu/drm/i915/display/intel_histogram.h |  1 +
 2 files changed, 18 insertions(+)
drivers/gpu/drm/i915/display/intel_histogram.c +17 -0
index 740019fdf0df..61a8cd623f19 100644
@@ -22,6 +22,11 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 	u32 dpstbin;
 	int i, try = 0;
 
+	/* Wa: 14014889975 */
+	if (IS_DISPLAY_VER(i915, 12, 13))
+		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+			     DPST_CTL_RESTORE, 0);
+
 	/*
 	 * TODO: PSR to be exited while reading the Histogram data
 	 * Set DPST_CTL Bin Reg function select to TC
@@ -59,6 +64,12 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 			       histogram_event))
 		drm_err(&i915->drm, "sending HISTOGRAM event failed\n");
 
+	/* Wa: 14014889975 */
+	if (IS_DISPLAY_VER(i915, 12, 13))
+		/* Write the value read from DPST_CTL to DPST_CTL.Interrupt Delay Counter(bit 23:16) */
+		intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
+			       DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);
+
 	/* Enable histogram interrupt */
 	intel_de_rmw(i915, DPST_GUARD(histogram->pipe), DPST_GUARD_HIST_INT_EN,
 		     DPST_GUARD_HIST_INT_EN);
@@ -127,6 +138,12 @@ static int intel_histogram_enable(struct intel_crtc *intel_crtc)
 	/* Pipe Dithering should be enabled with GLOBAL_HIST */
 	intel_histogram_enable_dithering(i915, pipe);
 
+	/* Wa: 14014889975 */
+	if (IS_DISPLAY_VER(i915, 12, 13))
+		/* Write the value read from DPST_CTL to DPST_CTL.Interrupt Delay Counter(bit 23:16) */
+		intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
+			       DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);
+
 	/*
 	 * enable DPST_CTL Histogram mode
 	 * Clear DPST_CTL Bin Reg function select to TC
drivers/gpu/drm/i915/display/intel_histogram.h +1 -0
index f07683dde005..88942564fdc0 100644
@@ -19,6 +19,7 @@
 #define DPST_CTL_RESTORE				REG_BIT(28)
 #define DPST_CTL_IE_MODI_TABLE_EN			REG_BIT(27)
 #define DPST_CTL_HIST_MODE				REG_BIT(24)
+#define DPST_CTL_GUARDBAND_INTERRUPT_DELAY_CNT		REG_GENMASK(23, 16)
 #define DPST_CTL_ENHANCEMENT_MODE_MASK			REG_GENMASK(14, 13)
 #define DPST_CTL_EN_MULTIPLICATIVE			REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
 #define DPST_CTL_IE_TABLE_VALUE_FORMAT			REG_BIT(15)
Signature · 1 line
2.25.1
#24 lore raw

PATCH 5/5 drm/i915/display/histogram: Histogram changes for Display LNL+

In reply to Arun R Murthy

In LNL+, histogram/IE data and index registers are added which was included in the control registers in the legacy platforms. The new registers are used for reading histogram and writing the IET LUT data.

---
 .../gpu/drm/i915/display/intel_histogram.c    | 174 +++++++++++++-----
 .../gpu/drm/i915/display/intel_histogram.h    |  25 +++
 2 files changed, 153 insertions(+), 46 deletions(-)
drivers/gpu/drm/i915/display/intel_histogram.c +128 -46
index 61a8cd623f19..46832ca78ee3 100644
@@ -11,29 +11,47 @@
 #include "intel_de.h"
 #include "intel_histogram.h"
 
-static void intel_histogram_handle_int_work(struct work_struct *work)
+static void intel_histogram_read_data(struct intel_histogram *histogram)
 {
-	struct intel_histogram *histogram = container_of(work,
-		struct intel_histogram, handle_histogram_int_work.work);
 	struct drm_i915_private *i915 = histogram->i915;
-	struct intel_crtc *intel_crtc =
-		to_intel_crtc(drm_crtc_from_index(&i915->drm, histogram->pipe));
-	char *histogram_event[] = {"HISTOGRAM=1", NULL};
 	u32 dpstbin;
 	int i, try = 0;
 
-	/* Wa: 14014889975 */
-	if (IS_DISPLAY_VER(i915, 12, 13))
-		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
-			     DPST_CTL_RESTORE, 0);
+	/* Set index to zero */
+	intel_de_rmw(i915, DPST_HIST_INDEX(histogram->pipe),
+		     DPST_HIST_BIN_INDEX_MASK, DPST_HIST_BIN_INDEX(0));
 
-	/*
-	 * TODO: PSR to be exited while reading the Histogram data
-	 * Set DPST_CTL Bin Reg function select to TC
-	 * Set DPST_CTL Bin Register Index to 0
-	 */
-	intel_de_rmw(i915, DPST_CTL(histogram->pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK, 0);
+	for (i = 0; i < HISTOGRAM_BIN_COUNT; i++) {
+		dpstbin = intel_de_read(i915, DPST_HIST_BIN(histogram->pipe));
+		if (dpstbin & DPST_BIN_BUSY) {
+			/*
+			 * If DPST_BIN busy bit is set, then set the
+			 * DPST_CTL bin reg index to 0 and proceed
+			 * from beginning.
+			 */
+			intel_de_rmw(i915, DPST_HIST_INDEX(histogram->pipe),
+				     DPST_HIST_BIN_INDEX_MASK,
+				     DPST_HIST_BIN_INDEX(0));
+			i = 0;
+			if (try++ == 5) {
+				drm_err(&i915->drm,
+					"Histogram block is busy, failed to read\n");
+				intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+					     DPST_GUARD_HIST_EVENT_STATUS, 1);
+				return;
+			}
+		}
+		histogram->bindata[i] = dpstbin & DPST_HIST_BIN_DATA_MASK;
+		drm_dbg_atomic(&i915->drm, "Histogram[%d]=%x\n",
+			       i, histogram->bindata[i]);
+	}
+}
+
+static void intel_histogram_read_data_legacy(struct intel_histogram *histogram)
+{
+	struct drm_i915_private *i915 = histogram->i915;
+	u32 dpstbin;
+	int i, try = 0;
 
 	for (i = 0; i < HISTOGRAM_BIN_COUNT; i++) {
 		dpstbin = intel_de_read(i915, DPST_BIN(histogram->pipe));
@@ -58,6 +76,41 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 		drm_dbg_atomic(&i915->drm, "Histogram[%d]=%x\n",
 			       i, histogram->bindata[i]);
 	}
+}
+
+static void intel_histogram_get_data(struct intel_histogram *histogram)
+{
+	struct drm_i915_private *i915 = histogram->i915;
+
+	/*
+	 * TODO: PSR to be exited while reading the Histogram data
+	 * Set DPST_CTL Bin Reg function select to TC
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	if (DISPLAY_VER(i915) >= 20) {
+		intel_histogram_read_data(histogram);
+	} else {
+		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK, 0);
+		intel_histogram_read_data_legacy(histogram);
+	}
+}
+
+static void intel_histogram_handle_int_work(struct work_struct *work)
+{
+	struct intel_histogram *histogram = container_of(work,
+		struct intel_histogram, handle_histogram_int_work.work);
+	struct drm_i915_private *i915 = histogram->i915;
+	struct intel_crtc *intel_crtc =
+		to_intel_crtc(drm_crtc_from_index(&i915->drm, histogram->pipe));
+	char *histogram_event[] = {"HISTOGRAM=1", NULL};
+
+	/* Wa: 14014889975 */
+	if (IS_DISPLAY_VER(i915, 12, 13))
+		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+			     DPST_CTL_RESTORE, 0);
+
+	intel_histogram_get_data(histogram);
 
 	/* Notify user for Histogram rediness */
 	if (kobject_uevent_env(&i915->drm.primary->kdev->kobj, KOBJ_CHANGE,
@@ -70,13 +123,16 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 		intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
 			       DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);
 
-	/* Enable histogram interrupt */
-	intel_de_rmw(i915, DPST_GUARD(histogram->pipe), DPST_GUARD_HIST_INT_EN,
-		     DPST_GUARD_HIST_INT_EN);
+	if (DISPLAY_VER(i915) <= 14) {
+		/* Enable histogram interrupt */
+		intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+			     DPST_GUARD_HIST_INT_EN,
+			     DPST_GUARD_HIST_INT_EN);
 
-	/* Clear histogram interrupt by setting histogram interrupt status bit*/
-	intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
-		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+		/* Clear histogram interrupt by setting histogram interrupt status bit*/
+		intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+			     DPST_GUARD_HIST_EVENT_STATUS, 1);
+	}
 
 	drm_property_replace_global_blob(&i915->drm,
 			&intel_crtc->config->histogram,
@@ -148,12 +204,19 @@ static int intel_histogram_enable(struct intel_crtc *intel_crtc)
 	 * enable DPST_CTL Histogram mode
 	 * Clear DPST_CTL Bin Reg function select to TC
 	 */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
-		     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
-		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
-		     DPST_CTL_HIST_MODE_HSV |
-		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+	if (DISPLAY_VER(i915) >= 20)
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE,
+			     DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE_HSV);
+	else
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
+			     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE_HSV |
+			     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
 
 	/* Re-Visit: check if wait for one vblank is required */
 	drm_crtc_wait_one_vblank(&intel_crtc->base);
@@ -233,24 +296,43 @@ int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data)
 	 * Set DPST_CTL Bin Reg function select to IE
 	 * Set DPST_CTL Bin Register Index to 0
 	 */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK,
-		     DPST_CTL_BIN_REG_FUNC_IE | DPST_CTL_BIN_REG_CLEAR);
-
-	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
-		intel_de_rmw(i915, DPST_BIN(pipe),
-			     DPST_BIN_DATA_MASK, data[i]);
-		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i, data[i]);
+	if (DISPLAY_VER(i915) >= 20) {
+		/* Set index to zero */
+		intel_de_rmw(i915, DPST_IE_INDEX(histogram->pipe),
+			     DPST_IE_BIN_INDEX_MASK, DPST_IE_BIN_INDEX(0));
+		for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+			intel_de_rmw(i915, DPST_IE_BIN(pipe),
+				     DPST_IE_BIN_DATA_MASK,
+				     DPST_IE_BIN_DATA(data[i]));
+			drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n",
+				       i, data[i]);
+		}
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_ENHANCEMENT_MODE_MASK |
+			     DPST_CTL_IE_MODI_TABLE_EN,
+			     DPST_CTL_EN_MULTIPLICATIVE |
+			     DPST_CTL_IE_MODI_TABLE_EN);
+	} else {
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK,
+			     DPST_CTL_BIN_REG_FUNC_IE | DPST_CTL_BIN_REG_CLEAR);
+		for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+			intel_de_rmw(i915, DPST_BIN(pipe),
+				     DPST_BIN_DATA_MASK, data[i]);
+			drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n",
+				       i, data[i]);
+		}
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_ENHANCEMENT_MODE_MASK |
+			     DPST_CTL_IE_MODI_TABLE_EN,
+			     DPST_CTL_EN_MULTIPLICATIVE |
+			     DPST_CTL_IE_MODI_TABLE_EN);
+
+		/* Once IE is applied, change DPST CTL to TC */
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL,
+			     DPST_CTL_BIN_REG_FUNC_TC);
 	}
-
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_ENHANCEMENT_MODE_MASK | DPST_CTL_IE_MODI_TABLE_EN,
-		     DPST_CTL_EN_MULTIPLICATIVE | DPST_CTL_IE_MODI_TABLE_EN);
-
-	/* Once IE is applied, change DPST CTL to TC */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL, DPST_CTL_BIN_REG_FUNC_TC);
-
 	return 0;
 }
 
drivers/gpu/drm/i915/display/intel_histogram.h +25 -0
index 88942564fdc0..7583b421164a 100644
@@ -47,8 +47,33 @@
 #define _DPST_BIN_B					0x491C4
 #define DPST_BIN(pipe)					_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
 #define DPST_BIN_DATA_MASK				REG_GENMASK(23, 0)
+#define DPST_BIN_DATA					REG_FIELD_PREP(DPST_BIN_DATA_MASK, val)
 #define DPST_BIN_BUSY					REG_BIT(31)
 
+#define _DPST_HIST_INDEX_A				0x490D8
+#define _DPST_HIST_INDEX_B				0x491D8
+#define DPST_HIST_INDEX(pipe)				_MMIO_PIPE(pipe, _DPST_HIST_INDEX_A, _DPST_HIST_INDEX_B)
+#define DPST_HIST_BIN_INDEX_MASK			REG_GENMASK(4, 0)
+#define DPST_HIST_BIN_INDEX(val)			REG_FIELD_PREP(DPST_HIST_BIN_INDEX_MASK, val)
+
+#define _DPST_HIST_BIN_A				0x490C4
+#define _DPST_HIST_BIN_B				0x491C4
+#define DPST_HIST_BIN(pipe)				_MMIO_PIPE(pipe, _DPST_HIST_BIN_A, _DPST_HIST_BIN_B)
+#define DPST_HIST_BIN_BUSY				REG_BIT(31)
+#define DPST_HIST_BIN_DATA_MASK				REG_GENMASK(30, 0)
+
+#define _DPST_IE_BIN_A					0x490CC
+#define _DPST_IE_BIN_B					0x491CC
+#define DPST_IE_BIN(pipe)				_MMIO_PIPE(pipe, _DPST_IE_BIN_A, _DPST_IE_BIN_B)
+#define	DPST_IE_BIN_DATA_MASK				REG_GENMASK(9, 0)
+#define DPST_IE_BIN_DATA(val)				REG_FIELD_PREP(DPST_IE_BIN_DATA_MASK, val)
+
+#define _DPST_IE_INDEX_A				0x490DC
+#define _DPST_IE_INDEX_B				0x491DC
+#define DPST_IE_INDEX(pipe)				_MMIO_PIPE(pipe, _DPST_IE_INDEX_A, _DPST_IE_INDEX_B)
+#define DPST_IE_BIN_INDEX_MASK				REG_GENMASK(6, 0)
+#define DPST_IE_BIN_INDEX(val)				REG_FIELD_PREP(DPST_IE_BIN_INDEX_MASK, val)
+
 #define INTEL_HISTOGRAM_PIPEA			0x90000000
 #define INTEL_HISTOGRAM_PIPEB			0x90000002
 #define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
Signature · 1 line
2.25.1
maintainer
#25 lore raw

Re: [PATCH 5/5] drm/i915/display/histogram: Histogram changes for Display LNL+

Quoted 60 lines · Arun R Murthy

In LNL+, histogram/IE data and index registers are added which was included in the control registers in the legacy platforms. The new registers are used for reading histogram and writing the IET LUT data.

---
 .../gpu/drm/i915/display/intel_histogram.c    | 174 +++++++++++++-----
 .../gpu/drm/i915/display/intel_histogram.h    |  25 +++
 2 files changed, 153 insertions(+), 46 deletions(-)
drivers/gpu/drm/i915/display/intel_histogram.c +19 -17
index 61a8cd623f19..46832ca78ee3 100644
@@ -11,29 +11,47 @@
 #include "intel_de.h"
 #include "intel_histogram.h"
 
-static void intel_histogram_handle_int_work(struct work_struct *work)
+static void intel_histogram_read_data(struct intel_histogram *histogram)
 {
-	struct intel_histogram *histogram = container_of(work,
-		struct intel_histogram, handle_histogram_int_work.work);
 	struct drm_i915_private *i915 = histogram->i915;
-	struct intel_crtc *intel_crtc =
-		to_intel_crtc(drm_crtc_from_index(&i915->drm, histogram->pipe));
-	char *histogram_event[] = {"HISTOGRAM=1", NULL};
 	u32 dpstbin;
 	int i, try = 0;
 
-	/* Wa: 14014889975 */
-	if (IS_DISPLAY_VER(i915, 12, 13))
-		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
-			     DPST_CTL_RESTORE, 0);
+	/* Set index to zero */
+	intel_de_rmw(i915, DPST_HIST_INDEX(histogram->pipe),
+		     DPST_HIST_BIN_INDEX_MASK, DPST_HIST_BIN_INDEX(0));
 
-	/*
-	 * TODO: PSR to be exited while reading the Histogram data
-	 * Set DPST_CTL Bin Reg function select to TC
-	 * Set DPST_CTL Bin Register Index to 0
-	 */
-	intel_de_rmw(i915, DPST_CTL(histogram->pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK, 0);
+	for (i = 0; i < HISTOGRAM_BIN_COUNT; i++) {
+		dpstbin = intel_de_read(i915, DPST_HIST_BIN(histogram->pipe));
+		if (dpstbin & DPST_BIN_BUSY) {
+			/*
+			 * If DPST_BIN busy bit is set, then set the
+			 * DPST_CTL bin reg index to 0 and proceed
+			 * from beginning.
+			 */
+			intel_de_rmw(i915, DPST_HIST_INDEX(histogram->pipe),
+				     DPST_HIST_BIN_INDEX_MASK,
+				     DPST_HIST_BIN_INDEX(0));
+			i = 0;
+			if (try++ == 5) {
+				drm_err(&i915->drm,
+					"Histogram block is busy, failed to read\n");

drivers/gpu/drm/i915/display/intel_histogram.c line 48

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_histogram.c +10 -0
+				intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+					     DPST_GUARD_HIST_EVENT_STATUS, 1);
+				return;
+			}
+		}
+		histogram->bindata[i] = dpstbin & DPST_HIST_BIN_DATA_MASK;
+		drm_dbg_atomic(&i915->drm, "Histogram[%d]=%x\n",
+			       i, histogram->bindata[i]);
+	}
+}

Please figure out a way to not duplicate the logic. Now you have the infinite loop in two places.

Quoted 199 lines
drivers/gpu/drm/i915/display/intel_histogram.c +99 -29
+
+static void intel_histogram_read_data_legacy(struct intel_histogram *histogram)
+{
+	struct drm_i915_private *i915 = histogram->i915;
+	u32 dpstbin;
+	int i, try = 0;
 
 	for (i = 0; i < HISTOGRAM_BIN_COUNT; i++) {
 		dpstbin = intel_de_read(i915, DPST_BIN(histogram->pipe));
@@ -58,6 +76,41 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 		drm_dbg_atomic(&i915->drm, "Histogram[%d]=%x\n",
 			       i, histogram->bindata[i]);
 	}
+}
+
+static void intel_histogram_get_data(struct intel_histogram *histogram)
+{
+	struct drm_i915_private *i915 = histogram->i915;
+
+	/*
+	 * TODO: PSR to be exited while reading the Histogram data
+	 * Set DPST_CTL Bin Reg function select to TC
+	 * Set DPST_CTL Bin Register Index to 0
+	 */
+	if (DISPLAY_VER(i915) >= 20) {
+		intel_histogram_read_data(histogram);
+	} else {
+		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK, 0);
+		intel_histogram_read_data_legacy(histogram);
+	}
+}
+
+static void intel_histogram_handle_int_work(struct work_struct *work)
+{
+	struct intel_histogram *histogram = container_of(work,
+		struct intel_histogram, handle_histogram_int_work.work);
+	struct drm_i915_private *i915 = histogram->i915;
+	struct intel_crtc *intel_crtc =
+		to_intel_crtc(drm_crtc_from_index(&i915->drm, histogram->pipe));
+	char *histogram_event[] = {"HISTOGRAM=1", NULL};
+
+	/* Wa: 14014889975 */
+	if (IS_DISPLAY_VER(i915, 12, 13))
+		intel_de_rmw(i915, DPST_CTL(histogram->pipe),
+			     DPST_CTL_RESTORE, 0);
+
+	intel_histogram_get_data(histogram);
 
 	/* Notify user for Histogram rediness */
 	if (kobject_uevent_env(&i915->drm.primary->kdev->kobj, KOBJ_CHANGE,
@@ -70,13 +123,16 @@ static void intel_histogram_handle_int_work(struct work_struct *work)
 		intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
 			       DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);
 
-	/* Enable histogram interrupt */
-	intel_de_rmw(i915, DPST_GUARD(histogram->pipe), DPST_GUARD_HIST_INT_EN,
-		     DPST_GUARD_HIST_INT_EN);
+	if (DISPLAY_VER(i915) <= 14) {
+		/* Enable histogram interrupt */
+		intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+			     DPST_GUARD_HIST_INT_EN,
+			     DPST_GUARD_HIST_INT_EN);
 
-	/* Clear histogram interrupt by setting histogram interrupt status bit*/
-	intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
-		     DPST_GUARD_HIST_EVENT_STATUS, 1);
+		/* Clear histogram interrupt by setting histogram interrupt status bit*/
+		intel_de_rmw(i915, DPST_GUARD(histogram->pipe),
+			     DPST_GUARD_HIST_EVENT_STATUS, 1);
+	}
 
 	drm_property_replace_global_blob(&i915->drm,
 			&intel_crtc->config->histogram,
@@ -148,12 +204,19 @@ static int intel_histogram_enable(struct intel_crtc *intel_crtc)
 	 * enable DPST_CTL Histogram mode
 	 * Clear DPST_CTL Bin Reg function select to TC
 	 */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
-		     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
-		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
-		     DPST_CTL_HIST_MODE_HSV |
-		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
+	if (DISPLAY_VER(i915) >= 20)
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE,
+			     DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE_HSV);
+	else
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE | DPST_CTL_IE_TABLE_VALUE_FORMAT,
+			     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
+			     DPST_CTL_HIST_MODE_HSV |
+			     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
 
 	/* Re-Visit: check if wait for one vblank is required */
 	drm_crtc_wait_one_vblank(&intel_crtc->base);
@@ -233,24 +296,43 @@ int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc, u32 *data)
 	 * Set DPST_CTL Bin Reg function select to IE
 	 * Set DPST_CTL Bin Register Index to 0
 	 */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK,
-		     DPST_CTL_BIN_REG_FUNC_IE | DPST_CTL_BIN_REG_CLEAR);
-
-	for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
-		intel_de_rmw(i915, DPST_BIN(pipe),
-			     DPST_BIN_DATA_MASK, data[i]);
-		drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n", i, data[i]);
+	if (DISPLAY_VER(i915) >= 20) {
+		/* Set index to zero */
+		intel_de_rmw(i915, DPST_IE_INDEX(histogram->pipe),
+			     DPST_IE_BIN_INDEX_MASK, DPST_IE_BIN_INDEX(0));
+		for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+			intel_de_rmw(i915, DPST_IE_BIN(pipe),
+				     DPST_IE_BIN_DATA_MASK,
+				     DPST_IE_BIN_DATA(data[i]));
+			drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n",
+				       i, data[i]);
+		}
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_ENHANCEMENT_MODE_MASK |
+			     DPST_CTL_IE_MODI_TABLE_EN,
+			     DPST_CTL_EN_MULTIPLICATIVE |
+			     DPST_CTL_IE_MODI_TABLE_EN);
+	} else {
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_BIN_REG_MASK,
+			     DPST_CTL_BIN_REG_FUNC_IE | DPST_CTL_BIN_REG_CLEAR);
+		for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
+			intel_de_rmw(i915, DPST_BIN(pipe),
+				     DPST_BIN_DATA_MASK, data[i]);
+			drm_dbg_atomic(&i915->drm, "iet_lut[%d]=%x\n",
+				       i, data[i]);
+		}
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_ENHANCEMENT_MODE_MASK |
+			     DPST_CTL_IE_MODI_TABLE_EN,
+			     DPST_CTL_EN_MULTIPLICATIVE |
+			     DPST_CTL_IE_MODI_TABLE_EN);
+
+		/* Once IE is applied, change DPST CTL to TC */
+		intel_de_rmw(i915, DPST_CTL(pipe),
+			     DPST_CTL_BIN_REG_FUNC_SEL,
+			     DPST_CTL_BIN_REG_FUNC_TC);
 	}
-
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_ENHANCEMENT_MODE_MASK | DPST_CTL_IE_MODI_TABLE_EN,
-		     DPST_CTL_EN_MULTIPLICATIVE | DPST_CTL_IE_MODI_TABLE_EN);
-
-	/* Once IE is applied, change DPST CTL to TC */
-	intel_de_rmw(i915, DPST_CTL(pipe),
-		     DPST_CTL_BIN_REG_FUNC_SEL, DPST_CTL_BIN_REG_FUNC_TC);
-
 	return 0;
 }
 
drivers/gpu/drm/i915/display/intel_histogram.h +25 -0
index 88942564fdc0..7583b421164a 100644
@@ -47,8 +47,33 @@
 #define _DPST_BIN_B					0x491C4
 #define DPST_BIN(pipe)					_MMIO_PIPE(pipe, _DPST_BIN_A, _DPST_BIN_B)
 #define DPST_BIN_DATA_MASK				REG_GENMASK(23, 0)
+#define DPST_BIN_DATA					REG_FIELD_PREP(DPST_BIN_DATA_MASK, val)
 #define DPST_BIN_BUSY					REG_BIT(31)
 
+#define _DPST_HIST_INDEX_A				0x490D8
+#define _DPST_HIST_INDEX_B				0x491D8
+#define DPST_HIST_INDEX(pipe)				_MMIO_PIPE(pipe, _DPST_HIST_INDEX_A, _DPST_HIST_INDEX_B)
+#define DPST_HIST_BIN_INDEX_MASK			REG_GENMASK(4, 0)
+#define DPST_HIST_BIN_INDEX(val)			REG_FIELD_PREP(DPST_HIST_BIN_INDEX_MASK, val)
+
+#define _DPST_HIST_BIN_A				0x490C4
+#define _DPST_HIST_BIN_B				0x491C4
+#define DPST_HIST_BIN(pipe)				_MMIO_PIPE(pipe, _DPST_HIST_BIN_A, _DPST_HIST_BIN_B)
+#define DPST_HIST_BIN_BUSY				REG_BIT(31)
+#define DPST_HIST_BIN_DATA_MASK				REG_GENMASK(30, 0)
+
+#define _DPST_IE_BIN_A					0x490CC
+#define _DPST_IE_BIN_B					0x491CC
+#define DPST_IE_BIN(pipe)				_MMIO_PIPE(pipe, _DPST_IE_BIN_A, _DPST_IE_BIN_B)
+#define	DPST_IE_BIN_DATA_MASK				REG_GENMASK(9, 0)
+#define DPST_IE_BIN_DATA(val)				REG_FIELD_PREP(DPST_IE_BIN_DATA_MASK, val)
+
+#define _DPST_IE_INDEX_A				0x490DC
+#define _DPST_IE_INDEX_B				0x491DC
+#define DPST_IE_INDEX(pipe)				_MMIO_PIPE(pipe, _DPST_IE_INDEX_A, _DPST_IE_INDEX_B)
+#define DPST_IE_BIN_INDEX_MASK				REG_GENMASK(6, 0)
+#define DPST_IE_BIN_INDEX(val)				REG_FIELD_PREP(DPST_IE_BIN_INDEX_MASK, val)
+
 #define INTEL_HISTOGRAM_PIPEA			0x90000000
 #define INTEL_HISTOGRAM_PIPEB			0x90000002
 #define INTEL_HISTOGRAM_EVENT(pipe)		PIPE(pipe, \
Signature · 1 line
Jani Nikula, Intel
#26 lore raw

✗ Fi.CI.CHECKPATCH: warning for Display Global Histogram

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: Display Global Histogram
URL : https://patchwork.freedesktop.org/series/135793/
State : warning

== Summary ==

Error: dim checkpatch failed
9b4d0f8ed82e drm/i915/display: Add support for histogram
-:42: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #42:
new file mode 100644

-:240: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_histogram.h', please use '/*' instead #240: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:1:
+// SPDX-License-Identifier: MIT

-:240: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #240: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:1:
+// SPDX-License-Identifier: MIT

-:262: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #262: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:23:
+#define DPST_CTL_EN_MULTIPLICATIVE REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)

-:269: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #269: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:30:
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)

-:270: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #270: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:31:
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)

-:276: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #276: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:37:
+#define DPST_GUARD(pipe) _MMIO_PIPE(pipe, _DPST_GUARD_A, _DPST_GUARD_B)

-:280: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #280: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:41:
+#define DPST_GUARD_INTERRUPT_DELAY(val) REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)

-:282: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #282: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:43:
+#define DPST_GUARD_THRESHOLD_GB(val) REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)

total: 0 errors, 9 warnings, 0 checks, 301 lines checked a6329355571c drm/i915/display: histogram interrupt handling
-:6: WARNING:TYPO_SPELLING: 'trigerred' may be misspelled - perhaps 'triggered'? #6:
Upon enabling histogram an interrupt is trigerred after the generation

                                        ^^^^^^^^^

-:58: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #58: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:21:
+ char *histogram_event[] = {"HISTOGRAM=1", NULL};

-:108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #108: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:71:
+ drm_property_replace_global_blob(&i915->drm,
+ &intel_crtc->config->histogram,

total: 0 errors, 2 warnings, 1 checks, 179 lines checked 3297a20f1fb7 Add crtc properties for global histogram 42b88e298bf7 drm/i915/histogram: histogram delay counter doesnt reset -:4: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #4:
Subject: [PATCH] drm/i915/histogram: histogram delay counter doesnt reset

                                                             ^^^^^^

-:34: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns #34: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:69:
+ /* Write the value read from DPST_CTL to DPST_CTL.Interrupt Delay Counter(bit 23:16) */

-:36: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #36: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:71:
+ intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
+ DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);

-:47: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns #47: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:143:
+ /* Write the value read from DPST_CTL to DPST_CTL.Interrupt Delay Counter(bit 23:16) */

-:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #49: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:145:
+ intel_de_write(i915, DPST_CTL(histogram->pipe), intel_de_read(i915,
+ DPST_CTL(histogram->pipe)) | DPST_CTL_RESTORE);

total: 0 errors, 3 warnings, 2 checks, 42 lines checked
a56de5ec6295 drm/i915/display/histogram: Histogram changes for Display LNL+ -:113: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #113: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:106:
+ char *histogram_event[] = {"HISTOGRAM=1", NULL};

-:247: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #247: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:55:
+#define DPST_HIST_INDEX(pipe) _MMIO_PIPE(pipe, _DPST_HIST_INDEX_A, _DPST_HIST_INDEX_B)

-:249: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #249: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:57:
+#define DPST_HIST_BIN_INDEX(val) REG_FIELD_PREP(DPST_HIST_BIN_INDEX_MASK, val)

-:253: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #253: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:61:
+#define DPST_HIST_BIN(pipe) _MMIO_PIPE(pipe, _DPST_HIST_BIN_A, _DPST_HIST_BIN_B)

-:259: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #259: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:67:
+#define DPST_IE_BIN(pipe) _MMIO_PIPE(pipe, _DPST_IE_BIN_A, _DPST_IE_BIN_B)

-:265: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #265: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:73:
+#define DPST_IE_INDEX(pipe) _MMIO_PIPE(pipe, _DPST_IE_INDEX_A, _DPST_IE_INDEX_B)

total: 0 errors, 6 warnings, 0 checks, 245 lines checked

#27 lore raw

✗ Fi.CI.SPARSE: warning for Display Global Histogram

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: Display Global Histogram
URL : https://patchwork.freedesktop.org/series/135793/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced sym

#28 lore raw

✓ Fi.CI.BAT: success for Display Global Histogram

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: Display Global Histogram
URL : https://patchwork.freedesktop.org/series/135793/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_15036 -> Patchwork_135793v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/index.html

Participating hosts (40 -> 37)
------------------------------

Additional (2): bat-adlp-9 bat-adlp-6
Missing (5): bat-dg1-7 fi-snb-2520m fi-cfl-8109u bat-dg2-11 bat-arlh-2

Known issues
------------

Here are the changes found in Patchwork_135793v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-adlp-9: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][2] ([i915#9318])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- bat-adlp-9: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- bat-adlp-6: NOTRUN -> [SKIP][4] ([i915#4613]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-adlp-6: NOTRUN -> [SKIP][5] ([i915#3282])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@gem_tiled_pread_basic.html
- bat-adlp-9: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@gem_tiled_pread_basic.html

* igt@i915_pm_rps@basic-api:
- bat-adlp-9: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-adlp-9: NOTRUN -> [SKIP][9] ([i915#4103]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-6: NOTRUN -> [SKIP][10] ([i915#4103]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-adlp-6: NOTRUN -> [SKIP][11] ([i915#3555] / [i915#3840])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]
- bat-adlp-9: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#3840])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-6: NOTRUN -> [SKIP][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]
- bat-adlp-9: NOTRUN -> [SKIP][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-arls-2: [PASS][15] -> [DMESG-WARN][16] ([i915#7507])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/bat-arls-2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-arls-2/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- bat-adlp-9: NOTRUN -> [SKIP][17] ([i915#9812])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@kms_psr@psr-sprite-plane-onoff:
- bat-adlp-9: NOTRUN -> [SKIP][18] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-9: NOTRUN -> [SKIP][19] ([i915#3555])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][20] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-9: NOTRUN -> [SKIP][21] ([i915#3291] / [i915#3708]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-9/igt@[email protected]
- bat-adlp-6: NOTRUN -> [SKIP][22] ([i915#3291] / [i915#3708]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/bat-adlp-6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#7507]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812

Build changes
-------------

* Linux: CI_DRM_15036 -> Patchwork_135793v1

CI-20190529: 20190529
CI_DRM_15036: cdd1a80a2d16d5213af20a29eb7570a7651db7dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7916: 971cfc9d6afc8242db25d1eabd4ae00890d9144a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_135793v1: cdd1a80a2d16d5213af20a29eb7570a7651db7dc @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/index.html

#29 lore raw

✗ Fi.CI.IGT: failure for Display Global Histogram

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: Display Global Histogram
URL : https://patchwork.freedesktop.org/series/135793/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15036_full -> Patchwork_135793v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_135793v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_135793v1_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_135793v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_big@single:
- shard-tglu: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-tglu-3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-9/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_135793v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_bb@blit-reloc-keep-cache:
- shard-dg1: NOTRUN -> [SKIP][3] ([i915#8411])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@device_reset@cold-reset-bound:
- shard-tglu: NOTRUN -> [SKIP][4] ([i915#11078])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@device_reset@unbind-cold-reset-rebind:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#11078])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@device_reset@unbind-reset-rebind:
- shard-dg1: NOTRUN -> [ABORT][6] ([i915#9413])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-18/igt@[email protected]

* igt@drm_fdinfo@busy-idle@bcs0:
- shard-dg2: NOTRUN -> [SKIP][7] ([i915#8414]) +6 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@busy-idle@vcs1:
- shard-dg1: NOTRUN -> [SKIP][8] ([i915#8414]) +5 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@drm_fdinfo@[email protected]

* igt@gem_ccs@block-copy-compressed:
- shard-tglu: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#9323])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@gem_close_race@multigpu-basic-process:
- shard-mtlp: NOTRUN -> [SKIP][10] ([i915#7697])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gem_ctx_persistence@hang:
- shard-mtlp: NOTRUN -> [SKIP][11] ([i915#8555])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gem_ctx_persistence@saturated-hostile-nopreempt@ccs0:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#5882]) +6 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@gem_ctx_persistence@[email protected]

* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglu: NOTRUN -> [SKIP][13] ([i915#280])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][14] -> [FAIL][15] ([i915#5784])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg1-17/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-15/igt@[email protected]

* igt@gem_exec_balancer@bonded-pair:
- shard-dg2: NOTRUN -> [SKIP][16] ([i915#4771])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][17] ([i915#4771])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_exec_balancer@parallel-dmabuf-import-out-fence:
- shard-rkl: NOTRUN -> [SKIP][18] ([i915#4525]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#4473] / [i915#4771])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@[email protected]

* igt@gem_exec_fair@basic-none:
- shard-dg1: NOTRUN -> [SKIP][20] ([i915#3539] / [i915#4852]) +5 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: NOTRUN -> [FAIL][21] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglu: NOTRUN -> [FAIL][22] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace:
- shard-dg1: NOTRUN -> [SKIP][23] ([i915#3539])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][24] ([i915#3539])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#2842])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-glk4/igt@gem_exec_fair@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk8/igt@gem_exec_fair@[email protected]
- shard-rkl: [PASS][27] -> [FAIL][28] ([i915#2842])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-6/igt@gem_exec_fair@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: NOTRUN -> [FAIL][29] ([i915#2842]) +2 other tests fail
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-uc-ro-default:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#3539] / [i915#4852]) +2 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@gem_exec_reloc@basic-cpu:
- shard-dg2: NOTRUN -> [SKIP][31] ([i915#3281]) +2 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@gem_exec_reloc@basic-gtt-cpu:
- shard-rkl: NOTRUN -> [SKIP][32] ([i915#3281]) +8 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@gem_exec_reloc@basic-wc-read:
- shard-dg1: NOTRUN -> [SKIP][33] ([i915#3281]) +5 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_exec_schedule@deep@rcs0:
- shard-mtlp: NOTRUN -> [SKIP][34] ([i915#4537])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts:
- shard-dg1: NOTRUN -> [SKIP][35] ([i915#4812]) +1 other test skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#4537] / [i915#4812])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][37] ([i915#7975] / [i915#8213])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@gem_exec_suspend@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#4860])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_gtt_cpu_tlb:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#4077])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@gem_gtt_cpu_tlb.html

* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-glk: NOTRUN -> [SKIP][40] ([i915#4613]) +1 other test skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk3/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi@lmem0:
- shard-dg1: NOTRUN -> [FAIL][41] ([i915#10378])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0:
- shard-dg1: NOTRUN -> [SKIP][42] ([i915#4565]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@gem_lmem_swapping@[email protected]
- shard-dg2: NOTRUN -> [FAIL][43] ([i915#10446])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#4613]) +2 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_media_fill@media-fill:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#8289])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#4077]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gem_mmap_wc@copy:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#4083]) +2 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@gem_mmap_wc@set-cache-level:
- shard-mtlp: NOTRUN -> [SKIP][48] ([i915#4083])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@[email protected]

* igt@gem_mmap_wc@write-cpu-read-wc-unflushed:
- shard-dg1: NOTRUN -> [SKIP][49] ([i915#4083]) +7 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads-uncached:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#3282]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@[email protected]

* igt@gem_pread@bench:
- shard-rkl: NOTRUN -> [SKIP][51] ([i915#3282]) +6 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_pwrite_snooped:
- shard-dg1: NOTRUN -> [SKIP][52] ([i915#3282]) +1 other test skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@gem_pwrite_snooped.html

* igt@gem_pxp@create-valid-protected-context:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#4270]) +2 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#4270]) +3 other tests skip
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-tglu: NOTRUN -> [SKIP][55] ([i915#4270])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-dg1: NOTRUN -> [SKIP][56] ([i915#4270]) +3 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#8428]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#5190] / [i915#8428]) +2 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- shard-dg1: NOTRUN -> [SKIP][59] ([i915#4079]) +1 other test skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-rkl: NOTRUN -> [SKIP][60] ([i915#8411]) +2 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-rkl: NOTRUN -> [SKIP][61] ([i915#3297] / [i915#3323])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-rkl: NOTRUN -> [SKIP][62] ([i915#3297]) +2 other tests skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-dg1: NOTRUN -> [SKIP][63] ([i915#3297])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-mtlp: NOTRUN -> [SKIP][64] ([i915#3297])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gen7_exec_parse@chained-batch:
- shard-mtlp: NOTRUN -> [SKIP][65] +4 other tests skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@gen9_exec_parse@bb-chained:
- shard-dg1: NOTRUN -> [SKIP][66] ([i915#2527]) +3 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@gen9_exec_parse@bb-start-param:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#2856]) +1 other test skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@gen9_exec_parse@unaligned-jump:
- shard-tglu: NOTRUN -> [SKIP][68] ([i915#2527] / [i915#2856])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@gen9_exec_parse@valid-registers:
- shard-rkl: NOTRUN -> [SKIP][69] ([i915#2527]) +3 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@i915_fb_tiling:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#4881])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@i915_fb_tiling.html
- shard-dg1: NOTRUN -> [SKIP][71] ([i915#4881])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@i915_fb_tiling.html

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [PASS][72] -> [ABORT][73] ([i915#9820])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg1-15/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]
- shard-tglu: [PASS][74] -> [ABORT][75] ([i915#9820])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-tglu-10/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-10/igt@[email protected]
- shard-mtlp: [PASS][76] -> [ABORT][77] ([i915#10131] / [i915#10887] / [i915#9820])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-mtlp-8/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-3/igt@[email protected]

* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-rkl: NOTRUN -> [SKIP][78] ([i915#6590])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@i915_pm_freq_mult@[email protected]

* igt@i915_pm_rps@basic-api:
- shard-dg1: NOTRUN -> [SKIP][79] ([i915#6621])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][80] ([i915#6621])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@i915_pm_rps@thresholds-park@gt0:
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#8925])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@i915_pm_rps@[email protected]
- shard-dg2: NOTRUN -> [SKIP][82] ([i915#8925])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@i915_pm_rps@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-tglu: NOTRUN -> [SKIP][83] ([i915#4387])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@i915_power@sanity:
- shard-mtlp: [PASS][84] -> [SKIP][85] ([i915#7984])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-mtlp-1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-2/igt@[email protected]

* igt@i915_query@query-topology-coherent-slice-mask:
- shard-mtlp: NOTRUN -> [SKIP][86] ([i915#6188])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@i915_selftest@live@workarounds:
- shard-dg2: [PASS][87] -> [DMESG-FAIL][88] ([i915#9500])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-7/igt@i915_selftest@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@i915_selftest@[email protected]

* igt@intel_hwmon@hwmon-write:
- shard-rkl: NOTRUN -> [SKIP][89] ([i915#7707])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- shard-mtlp: NOTRUN -> [SKIP][90] ([i915#4212])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_addfb_basic@basic-x-tiled-legacy:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#4212])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#4212])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-rkl: NOTRUN -> [SKIP][93] ([i915#3826])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][94] ([i915#8709]) +3 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc.html

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#8709]) +11 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-10/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-edp-1-4-rc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][96] ([i915#8709]) +2 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [PASS][97] -> [FAIL][98] ([i915#5138])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-mtlp-8/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-1/igt@[email protected]

* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-dg1: NOTRUN -> [SKIP][99] ([i915#4538] / [i915#5286]) +3 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb:
- shard-rkl: NOTRUN -> [SKIP][100] ([i915#5286]) +3 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglu: NOTRUN -> [SKIP][101] ([i915#5286]) +1 other test skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][102] ([i915#3638]) +2 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][103] ([i915#3638]) +2 other tests skip
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_big_fb@y-tiled-addfb-size-overflow:
- shard-mtlp: NOTRUN -> [SKIP][104] ([i915#6187])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-dg2: NOTRUN -> [SKIP][105] ([i915#4538] / [i915#5190]) +3 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][106] +16 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#5190])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-dg1: NOTRUN -> [SKIP][108] ([i915#4538]) +5 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_joiner@basic:
- shard-tglu: NOTRUN -> [SKIP][109] ([i915#10656])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_big_joiner@basic-force-joiner:
- shard-dg2: NOTRUN -> [SKIP][110] ([i915#10656]) +1 other test skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][111] ([i915#10656])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-dg1: NOTRUN -> [SKIP][112] ([i915#10656])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_ccs@bad-aux-stride-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#6095]) +107 other tests skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@kms_ccs@[email protected]

* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][114] ([i915#10307] / [i915#10434] / [i915#6095]) +8 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_ccs@[email protected]

* igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#10307] / [i915#6095]) +214 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][116] ([i915#6095]) +65 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][117] ([i915#6095]) +11 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@kms_ccs@[email protected]

* igt@kms_ccs@random-ccs-data-y-tiled-ccs@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#6095]) +11 other tests skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_ccs@[email protected]

* igt@kms_cdclk@mode-transition:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#3742])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#7213]) +3 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_cdclk@[email protected]

* igt@kms_cdclk@plane-scaling:
- shard-rkl: NOTRUN -> [SKIP][121] ([i915#3742])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][122] ([i915#4087]) +3 other tests skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-2/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_edid@dp-edid-change-during-suspend:
- shard-mtlp: NOTRUN -> [SKIP][123] ([i915#7828]) +2 other tests skip
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_chamelium_edid@hdmi-edid-change-during-suspend:
- shard-tglu: NOTRUN -> [SKIP][124] ([i915#7828]) +2 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-dg1: NOTRUN -> [SKIP][125] ([i915#7828]) +6 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-rkl: NOTRUN -> [SKIP][126] ([i915#7828]) +7 other tests skip
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-after-suspend:
- shard-dg2: NOTRUN -> [SKIP][127] ([i915#7828]) +3 other tests skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][128] ([i915#7118] / [i915#9424])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][129] ([i915#7118] / [i915#9424])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_content_protection@content-type-change:
- shard-dg2: NOTRUN -> [SKIP][130] ([i915#9424])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#9424])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-rkl: NOTRUN -> [SKIP][132] ([i915#3116])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-mtlp: NOTRUN -> [SKIP][133] ([i915#3299])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_content_protection@legacy@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][134] ([i915#7173])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@lic-type-1:
- shard-dg1: NOTRUN -> [SKIP][135] ([i915#9424]) +1 other test skip
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-mtlp: NOTRUN -> [SKIP][136] ([i915#3359]) +1 other test skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-128x42:
- shard-mtlp: NOTRUN -> [SKIP][137] ([i915#8814])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#3555]) +4 other tests skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-max-size:
- shard-dg2: NOTRUN -> [SKIP][139] ([i915#3555]) +2 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#3555]) +5 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#11453])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][142] ([i915#11453])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-mtlp: NOTRUN -> [SKIP][143] ([i915#9809]) +1 other test skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][144] -> [FAIL][145] ([i915#2346])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-glk2/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk1/igt@[email protected]

* igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot:
- shard-rkl: NOTRUN -> [SKIP][146] ([i915#9067])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-tglu: NOTRUN -> [SKIP][147] ([i915#4103])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#4103] / [i915#4213])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-dg2: NOTRUN -> [SKIP][149] ([i915#9833])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][150] ([i915#9723])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_display_modes@mst-extended-mode-negative:
- shard-rkl: NOTRUN -> [SKIP][151] ([i915#8588])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_dp_aux_dev:
- shard-dg2: [PASS][152] -> [SKIP][153] ([i915#1257])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@kms_dp_aux_dev.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@kms_dp_aux_dev.html

* igt@kms_dsc@dsc-with-output-formats:
- shard-dg2: NOTRUN -> [SKIP][154] ([i915#3555] / [i915#3840])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][155] ([i915#3555] / [i915#3840])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][156] ([i915#3555] / [i915#3840])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@[email protected]

* igt@kms_fbcon_fbt@psr:
- shard-rkl: NOTRUN -> [SKIP][157] ([i915#3955])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_feature_discovery@chamelium:
- shard-rkl: NOTRUN -> [SKIP][158] ([i915#4854])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_feature_discovery@display-3x:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#1839])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_feature_discovery@psr2:
- shard-dg1: NOTRUN -> [SKIP][160] ([i915#658]) +1 other test skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][161] ([i915#658])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][162] ([i915#3637])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [PASS][163] -> [FAIL][164] ([i915#2122])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-snb5/igt@kms_flip@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-snb7/igt@kms_flip@[email protected]

* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-tglu: NOTRUN -> [SKIP][165] ([i915#3637])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#9934]) +6 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_flip@flip-vs-absolute-wf_vblank@d-hdmi-a4:
- shard-dg1: [PASS][167] -> [FAIL][168] ([i915#2122])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg1-15/igt@kms_flip@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][169] ([i915#8810])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][170] ([i915#2672]) +1 other test skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][171] ([i915#2672]) +1 other test skip
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
- shard-dg1: NOTRUN -> [SKIP][172] ([i915#2587] / [i915#2672]) +2 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][173] ([i915#2672] / [i915#3555])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#5354]) +21 other tests skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][175] ([i915#8708]) +2 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-dg2: NOTRUN -> [SKIP][176] ([i915#10055])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-mtlp: NOTRUN -> [SKIP][177] ([i915#1825]) +7 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][178] ([i915#8708]) +14 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-dg1: NOTRUN -> [SKIP][179] +45 other tests skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][180] +66 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][181] ([i915#8708]) +5 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][182] ([i915#3458]) +4 other tests skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][183] ([i915#10433] / [i915#3458]) +2 other tests skip
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][184] ([i915#3023]) +17 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][185] ([i915#3458]) +17 other tests skip
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- shard-tglu: NOTRUN -> [SKIP][186] +21 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][187] ([i915#1825]) +36 other tests skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@[email protected]

* igt@kms_getfb@getfb-reject-ccs:
- shard-dg2: NOTRUN -> [SKIP][188] ([i915#6118])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-dg1: NOTRUN -> [SKIP][189] ([i915#433])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-tglu: NOTRUN -> [SKIP][190] ([i915#3555] / [i915#8228])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-dg1: NOTRUN -> [SKIP][191] ([i915#3555] / [i915#8228]) +1 other test skip
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_hdr@static-toggle-suspend:
- shard-rkl: NOTRUN -> [SKIP][192] ([i915#3555] / [i915#8228]) +1 other test skip
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_panel_fitting@atomic-fastset:
- shard-rkl: NOTRUN -> [SKIP][193] ([i915#6301]) +1 other test skip
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-dg2: NOTRUN -> [SKIP][194] +7 other tests skip
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][195] ([i915#10647]) +1 other test fail
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk3/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_plane_lowres@tiling-none@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][196] ([i915#10226] / [i915#3582]) +2 other tests skip
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_lowres@tiling-none@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][197] ([i915#3582])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][198] ([i915#9423]) +11 other tests skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-8/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-1.html

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][199] ([i915#9423]) +15 other tests skip
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-14/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][200] ([i915#9423]) +3 other tests skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][201] ([i915#5235] / [i915#9423]) +11 other tests skip
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-hdmi-a-3.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][202] ([i915#5235]) +15 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][203] ([i915#5235]) +5 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][204] ([i915#5235]) +2 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][205] ([i915#3555] / [i915#5235])
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_dc@dc5-psr:
- shard-tglu: NOTRUN -> [SKIP][206] ([i915#9685])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: NOTRUN -> [SKIP][207] ([i915#3361])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_pm_lpsp@kms-lpsp:
- shard-dg1: NOTRUN -> [SKIP][208] ([i915#9340])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_pm_lpsp@screens-disabled:
- shard-dg1: NOTRUN -> [SKIP][209] ([i915#8430])
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-mtlp: NOTRUN -> [SKIP][210] ([i915#9519])
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp:
- shard-rkl: NOTRUN -> [SKIP][211] ([i915#9519])
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][212] -> [SKIP][213] ([i915#9519]) +1 other test skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-7/igt@[email protected]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [PASS][214] -> [SKIP][215] ([i915#9519]) +1 other test skip
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-1/igt@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_pm_rpm@pm-caching:
- shard-dg1: NOTRUN -> [SKIP][216] ([i915#4077]) +6 other tests skip
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_prime@basic-modeset-hybrid:
- shard-rkl: NOTRUN -> [SKIP][217] ([i915#6524]) +1 other test skip
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_prime@d3hot:
- shard-dg1: NOTRUN -> [SKIP][218] ([i915#6524])
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@[email protected]
- shard-dg2: NOTRUN -> [SKIP][219] ([i915#6524] / [i915#6805])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-rkl: NOTRUN -> [SKIP][220] ([i915#11520]) +3 other tests skip
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-tglu: NOTRUN -> [SKIP][221] ([i915#11520])
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_psr2_sf@fbc-overlay-plane-update-continuous-sf:
- shard-dg2: NOTRUN -> [SKIP][222] ([i915#11520]) +2 other tests skip
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-dg1: NOTRUN -> [SKIP][223] ([i915#11520]) +3 other tests skip
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_psr@fbc-psr2-cursor-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][224] ([i915#1072] / [i915#9732]) +4 other tests skip
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@kms_psr@fbc-psr2-primary-blt:
- shard-rkl: NOTRUN -> [SKIP][225] ([i915#1072] / [i915#9732]) +19 other tests skip
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_psr@pr-basic:
- shard-mtlp: NOTRUN -> [SKIP][226] ([i915#9688]) +4 other tests skip
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@kms_psr@pr-cursor-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][227] ([i915#1072] / [i915#9673] / [i915#9732]) +5 other tests skip
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_psr@psr-sprite-mmap-gtt@edp-1:
- shard-mtlp: NOTRUN -> [SKIP][228] ([i915#4077] / [i915#9688])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@kms_psr@[email protected]

* igt@kms_psr@psr2-primary-render:
- shard-tglu: NOTRUN -> [SKIP][229] ([i915#9732]) +4 other tests skip
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_psr@psr2-sprite-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][230] ([i915#1072] / [i915#9732]) +21 other tests skip
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_rotation_crc@exhaust-fences:
- shard-dg1: NOTRUN -> [SKIP][231] ([i915#4884])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-tglu: NOTRUN -> [SKIP][232] ([i915#5289])
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-tglu-3/igt@[email protected]

* igt@kms_rotation_crc@primary-rotation-270:
- shard-dg2: NOTRUN -> [SKIP][233] ([i915#11131] / [i915#4235])
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-rkl: NOTRUN -> [SKIP][234] ([i915#5289]) +2 other tests skip
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-dg2: NOTRUN -> [SKIP][235] ([i915#11131] / [i915#4235] / [i915#5190])
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][236] ([i915#5289])
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-16/igt@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-snb: [PASS][237] -> [FAIL][238] ([i915#9196])
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-snb4/igt@kms_universal_plane@[email protected]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-snb4/igt@kms_universal_plane@[email protected]

* igt@kms_vrr@max-min:
- shard-dg1: NOTRUN -> [SKIP][239] ([i915#9906])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-virtual:
- shard-rkl: NOTRUN -> [SKIP][240] ([i915#9906])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@kms_writeback@writeback-check-output-xrgb2101010:
- shard-dg1: NOTRUN -> [SKIP][241] ([i915#2437] / [i915#9412])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][242] ([i915#2437])
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk3/igt@[email protected]

* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-mtlp: NOTRUN -> [SKIP][243] ([i915#2437] / [i915#9412])
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-6/igt@[email protected]

* igt@perf@global-sseu-config:
- shard-dg2: NOTRUN -> [SKIP][244] ([i915#7387])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: NOTRUN -> [FAIL][245] ([i915#9100])
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@perf@[email protected]

* igt@perf_pmu@busy-double-start@vecs1:
- shard-dg2: [PASS][246] -> [FAIL][247] ([i915#4349]) +3 other tests fail
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@perf_pmu@[email protected]
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-10/igt@perf_pmu@[email protected]

* igt@perf_pmu@rc6-all-gts:
- shard-rkl: NOTRUN -> [SKIP][248] ([i915#8516])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@prime_vgem@basic-read:
- shard-rkl: NOTRUN -> [SKIP][249] ([i915#3291] / [i915#3708])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@prime_vgem@fence-write-hang:
- shard-dg1: NOTRUN -> [SKIP][250] ([i915#3708])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-dg1: NOTRUN -> [SKIP][251] ([i915#4818])
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-17/igt@tools_test@sysfs_l3_parity.html
- shard-dg2: NOTRUN -> [SKIP][252] ([i915#4818])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [FAIL][253] ([i915#6268]) -> [PASS][254]
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-5/igt@[email protected]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-5/igt@[email protected]

* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [FAIL][255] ([i915#2842]) -> [PASS][256] +1 other test pass
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-3/igt@gem_exec_fair@[email protected]
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-6/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@basic@lmem0:
- shard-dg2: [FAIL][257] ([i915#10378]) -> [PASS][258]
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@gem_lmem_swapping@[email protected]
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@gem_lmem_swapping@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-edp-1-linear:
- shard-mtlp: [INCOMPLETE][259] -> [PASS][260]
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-mtlp-2/igt@kms_async_flips@[email protected]
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-mtlp-4/igt@kms_async_flips@[email protected]

* igt@kms_cursor_legacy@torture-move@pipe-a:
- shard-dg1: [DMESG-WARN][261] ([i915#10166]) -> [PASS][262]
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg1-16/igt@kms_cursor_legacy@[email protected]
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg1-18/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][263] ([i915#79]) -> [PASS][264]
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-glk3/igt@kms_flip@[email protected]
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_flip@dpms-vs-vblank-race@b-vga1:
- shard-snb: [FAIL][265] ([i915#10826]) -> [PASS][266]
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-snb7/igt@kms_flip@[email protected]
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-snb5/igt@kms_flip@[email protected]

* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][267] ([i915#9519]) -> [PASS][268]
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-2/igt@[email protected]
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-3/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg2: [SKIP][269] ([i915#9519]) -> [PASS][270] +3 other tests pass
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-7/igt@[email protected]
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-8/igt@[email protected]

#### Warnings ####

* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [ABORT][271] ([i915#9697]) -> [ABORT][272] ([i915#9820])
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-rkl-3/igt@[email protected]
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-rkl-4/igt@[email protected]

* igt@kms_content_protection@type1:
- shard-dg2: [SKIP][273] ([i915#7118] / [i915#7162] / [i915#9424]) -> [SKIP][274] ([i915#7118] / [i915#9424])
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@[email protected]
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-dg2: [SKIP][275] ([i915#11453] / [i915#3359]) -> [SKIP][276] ([i915#11453]) +1 other test skip
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@[email protected]
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2: [SKIP][277] ([i915#3458]) -> [SKIP][278] ([i915#10433] / [i915#3458])
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html

* igt@kms_psr@fbc-psr-primary-mmap-cpu:
- shard-dg2: [SKIP][279] ([i915#1072] / [i915#9732]) -> [SKIP][280] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-6/igt@[email protected]
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_psr@psr2-primary-mmap-gtt:
- shard-dg2: [SKIP][281] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][282] ([i915#1072] / [i915#9732]) +16 other tests skip
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@[email protected]
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-dg2: [SKIP][283] ([i915#11131] / [i915#4235] / [i915#5190]) -> [SKIP][284] ([i915#11131] / [i915#5190])
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-11/igt@[email protected]
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-6/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2: [SKIP][285] ([i915#11131]) -> [SKIP][286] ([i915#11131] / [i915#4235]) +2 other tests skip
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-dg2-6/igt@[email protected]
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-dg2-11/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern:
- shard-glk: [FAIL][287] ([i915#10959]) -> [SKIP][288]
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15036/shard-glk3/igt@[email protected]
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/shard-glk8/igt@[email protected]

[i915#10055]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10055
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10226]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10226
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10446]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10446
[i915#10647]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10647
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10826
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#10959]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10959
[i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#1257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1257
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3582
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3955]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4473]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4473
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4537]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4818
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4884
[i915#5138]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5138
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
[i915#5882]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5882
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6118
[i915#6187]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6187
[i915#6188]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6188
[i915#6268]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6805]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6805
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
[i915#7387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7387
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#7984]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7984
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8289
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8588]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8588
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8810]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8810
[i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
[i915#8925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8925
[i915#9067]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9067
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9413]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9697
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9809
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9833]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9833
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934

Build changes
-------------

* Linux: CI_DRM_15036 -> Patchwork_135793v1

CI-20190529: 20190529
CI_DRM_15036: cdd1a80a2d16d5213af20a29eb7570a7651db7dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7916: 971cfc9d6afc8242db25d1eabd4ae00890d9144a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_135793v1: cdd1a80a2d16d5213af20a29eb7570a7651db7dc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135793v1/index.html