Skip to contentSkip to conversation

ARM: dts: stm32: Describe PHY LEDs in DH STM32MP13xx DHCOR DHSBC board DT

PATCH In review Marek Vasut 2 participants 4 messages Jul 5, 2024 – Aug 30, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Describe PHY LEDs in DH STM32MP13xx DHCOR DHSBC board DT

The RTL8211 PHY on DH STM32MP13xx DHCOR DHSBC carrier board supports HW LED offload, the LEDs can be configured on link at 10/100/1000 line rate and on RXTX activity. There are two PHYs on this board, each only has two out of three LEDs connected to the PHY LED outputs. Describe this hardware configuration in DT.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Christophe Roullier <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 .../boot/dts/st/stm32mp135f-dhcor-dhsbc.dts   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts +38 -0
index 1b916c419e8e2..c80a6ecdb47a6 100644
@@ -100,6 +100,25 @@ ethphy1: ethernet-phy@1 {
 			reset-assert-us = <15000>;
 			reset-deassert-us = <55000>;
 			reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
+
+			leds {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				led@0 {
+					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_WAN;
+					linux,default-trigger = "netdev";
+				};
+
+				led@1 {
+					reg = <1>;
+					color = <LED_COLOR_ID_YELLOW>;
+					function = LED_FUNCTION_WAN;
+					linux,default-trigger = "netdev";
+				};
+			};
 		};
 	};
 };
@@ -130,6 +149,25 @@ ethphy2: ethernet-phy@1 {
 			reset-assert-us = <15000>;
 			reset-deassert-us = <55000>;
 			reset-gpios = <&gpiog 8 GPIO_ACTIVE_LOW>;
+
+			leds {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				led@0 {
+					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_LAN;
+					linux,default-trigger = "netdev";
+				};
+
+				led@1 {
+					reg = <1>;
+					color = <LED_COLOR_ID_YELLOW>;
+					function = LED_FUNCTION_LAN;
+					linux,default-trigger = "netdev";
+				};
+			};
 		};
 	};
 };
Signature · 1 line
2.43.0
maintainer
#1 lore raw

Hi Marek

Quoted 18 lines · Marek Vasut

The RTL8211 PHY on DH STM32MP13xx DHCOR DHSBC carrier board supports HW LED offload, the LEDs can be configured on link at 10/100/1000 line rate and on RXTX activity. There are two PHYs on this board, each only has two out of three LEDs connected to the PHY LED outputs. Describe this hardware configuration in DT.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Christophe Roullier <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Quoted 4 lines
---
  .../boot/dts/st/stm32mp135f-dhcor-dhsbc.dts   | 38 +++++++++++++++++++
  1 file changed, 38 insertions(+)

I have a yaml validation issue applying this patch.

DTC_CHK arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts', 'reg', 'reset-assert-us', 'reset-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: leds:led@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'netdev' is not one of ['backlight', 'default-on', 'heartbeat',
'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport']

	'netdev' does not match '^cpu[0-9]*$'
	'netdev' does not match '^hci[0-9]+-p

Can you have a look please ?

Quoted 56 lines
arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts +38 -0
index 1b916c419e8e2..c80a6ecdb47a6 100644
@@ -100,6 +100,25 @@ ethphy1: ethernet-phy@1 {
  			reset-assert-us = <15000>;
  			reset-deassert-us = <55000>;
  			reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
+
+			leds {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				led@0 {
+					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_WAN;
+					linux,default-trigger = "netdev";
+				};
+
+				led@1 {
+					reg = <1>;
+					color = <LED_COLOR_ID_YELLOW>;
+					function = LED_FUNCTION_WAN;
+					linux,default-trigger = "netdev";
+				};
+			};
  		};
  	};
  };
@@ -130,6 +149,25 @@ ethphy2: ethernet-phy@1 {
  			reset-assert-us = <15000>;
  			reset-deassert-us = <55000>;
  			reset-gpios = <&gpiog 8 GPIO_ACTIVE_LOW>;
+
+			leds {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				led@0 {
+					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_LAN;
+					linux,default-trigger = "netdev";
+				};
+
+				led@1 {
+					reg = <1>;
+					color = <LED_COLOR_ID_YELLOW>;
+					function = LED_FUNCTION_LAN;
+					linux,default-trigger = "netdev";
+				};
+			};
  		};
  	};
  };
#2 lore raw
Quoted 1 line · Alexandre TORGUE

Hi Marek

Hi,

Quoted 12 lines

I have a yaml validation issue applying this patch.

  DTC_CHK arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts', 'reg', 'reset-assert-us', 'reset-deassert-us', 'reset-gpios' were unexpected)
    from schema $id:
http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: leds:led@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
    'netdev' is not one of ['backlight', 'default-on', 'heartbeat',
'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport']
    'netdev' does not match '^cpu[0-9]*$'
    'netdev' does not match '^hci[0-9]+-p

Quoted 1 line

Can you have a look please ?

See this commit in linux-next, with that the validation should pass:

616dbed65485 ("dt-bindings: leds: Document "netdev" trigger")

maintainer
#3 lore raw
Quoted 15 lines · Marek Vasut
Quoted 1 line · Alexandre TORGUE

Hi Marek

Hi,

Quoted 10 lines

I have a yaml validation issue applying this patch.

   DTC_CHK arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts', 'reg', 'reset-assert-us', 'reset-deassert-us', 'reset-gpios' were unexpected) from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet-phy@1: leds:led@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
     'netdev' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport'] 'netdev' does not match '^cpu[0-9]*$'
     'netdev' does not match '^hci[0-9]+-p

Quoted 5 lines
Quoted 1 line

Can you have a look please ?

See this commit in linux-next, with that the validation should pass:

616dbed65485 ("dt-bindings: leds: Document "netdev" trigger")

Thanks Marek !!

Applied on stm32-next.

Cheers
Alex