Skip to contentSkip to conversation

hwrng: core - remove (un)register_miscdev()

PATCH In review Masahiro Yamada 2 participants 2 messages Jul 6, 2024 – Jul 12, 2024

Subsystems (2)
Crypto API Hardware random number generator core
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 hwrng: core - remove (un)register_miscdev()

These functions are redundant after commit 0daa7a0afd0f ("hwrng: Avoid manual device_create_file() calls").

Let's call misc_(de)register() directly.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/char/hw_random/core.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
drivers/char/hw_random/core.c +2 -12
index 4084df65c9fa..29a663db6909 100644
@@ -470,16 +470,6 @@ static struct attribute *rng_dev_attrs[] = {
 
 ATTRIBUTE_GROUPS(rng_dev);
 
-static void __exit unregister_miscdev(void)
-{
-	misc_deregister(&rng_miscdev);
-}
-
-static int __init register_miscdev(void)
-{
-	return misc_register(&rng_miscdev);
-}
-
 static int hwrng_fillfn(void *unused)
 {
 	size_t entropy, entropy_credit = 0; /* in 1/1024 of a bit */

@@ -668,7 +658,7 @@ static int __init hwrng_modinit(void)
 		return -ENOMEM;
 	}
 
-	ret = register_miscdev();
+	ret = misc_register(&rng_miscdev);
 	if (ret) {
 		kfree(rng_fillbuf);
 		kfree(rng_buffer);

@@ -685,7 +675,7 @@ static void __exit hwrng_modexit(void)
 	kfree(rng_fillbuf);
 	mutex_unlock(&rng_mutex);
 
-	unregister_miscdev();
+	misc_deregister(&rng_miscdev);
 }
 
 fs_initcall(hwrng_modinit); /* depends on misc_register() */
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 10 lines · Masahiro Yamada

These functions are redundant after commit 0daa7a0afd0f ("hwrng: Avoid manual device_create_file() calls").

Let's call misc_(de)register() directly.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/char/hw_random/core.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt