Skip to contentSkip to conversation

ARM: dts: qcom: apq8960: correct memory base

PATCH In review David Heidelberg 3 participants 4 messages Jul 6, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: qcom: apq8960: correct memory base

Bootloader will provide the information anyway to the kernel.

Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk

---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +2 -2
index a9c6d2dbb460..ebc43c5c6e5f 100644
@@ -47,9 +47,9 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@80000000 {
 		device_type = "memory";
-		reg = <0x0 0x0>;
+		reg = <0x80000000 0>;
 	};
 
 	cpu-pmu {
Signature · 1 line
2.45.2
maintainer
#2 lore raw
In reply to David Heidelberg
Quoted 1 line · David Heidelberg

Bootloader will provide the information anyway to the kernel.

How about we describe an actual problem here?

Perhaps this is the problem you're solving?:

"""
DeviceTree validation requires a unit address on the memory node, adjust the base to match [Ref] and use this as unit address.

The bootloader will update the information with the actual values during boot.
"""

I'd also prefer s/apq8960/msm8960/ in $subject, is there a reason why you did choose apq8960?

Regards,
Bjorn

Quoted 27 lines

Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk

---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +2 -2
index a9c6d2dbb460..ebc43c5c6e5f 100644
@@ -47,9 +47,9 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@80000000 {
 		device_type = "memory";
-		reg = <0x0 0x0>;
+		reg = <0x80000000 0>;
 	};
 
 	cpu-pmu {
Signature · 1 line
2.45.2
#3 lore raw

Hello Bjorn,

the apq8960 is just mental typo due to dealing with apq8064 code at same time. I sent properly named patch [1] with your description and Dmitry's R-b.

Thank you
David

[1] ARM: dts: qcom: msm8960: correct memory base

Quoted 46 lines · Bjorn Andersson
Quoted 1 line · David Heidelberg

Bootloader will provide the information anyway to the kernel.

How about we describe an actual problem here?

Perhaps this is the problem you're solving?:

"""
DeviceTree validation requires a unit address on the memory node, adjust the base to match [Ref] and use this as unit address.

The bootloader will update the information with the actual values during boot.
"""

I'd also prefer s/apq8960/msm8960/ in $subject, is there a reason why you did choose apq8960?

Regards,
Bjorn

Quoted 26 lines

Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk

---
  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +2 -2
index a9c6d2dbb460..ebc43c5c6e5f 100644
@@ -47,9 +47,9 @@ L2: l2-cache {
  		};
  	};
 
-	memory {
+	memory@80000000 {
  		device_type = "memory";
-		reg = <0x0 0x0>;
+		reg = <0x80000000 0>;
  	};
 
  	cpu-pmu {
Signature · 1 line
2.45.2
Signature · 1 line
David Heidelberg