Skip to contentSkip to conversation

net: ethernet: lantiq_etop: fix double free in detach

PATCH In review Aleksander Jan Bajkowski 2 participants 2 messages Jul 7, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: lantiq_etop: fix double free in detach

The number of the currently released descriptor is never incremented which results in the same skb being released multiple times.

---
 drivers/net/ethernet/lantiq_etop.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/lantiq_etop.c +1 -3
index 5352fee62d2b..6027e5a179b4 100644
@@ -217,9 +217,7 @@ ltq_etop_free_channel(struct net_device *dev, struct ltq_etop_chan *ch)
 	if (ch->dma.irq)
 		free_irq(ch->dma.irq, priv);
 	if (IS_RX(ch->idx)) {
-		int desc;
-
-		for (desc = 0; desc < LTQ_DESC_NUM; desc++)
+		for (ch->dma.desc = 0; ch->dma.desc < LTQ_DESC_NUM; ch->dma.desc++)
 			dev_kfree_skb_any(ch->skb[ch->dma.desc]);
 	}
 }
Signature · 1 line
2.39.2