net: ethernet: lantiq_etop: fix double free in detach
Subsystems (2)
PATCH 1/1 net: ethernet: lantiq_etop: fix double free in detach
The number of the currently released descriptor is never incremented which results in the same skb being released multiple times.
Reported-by Joe Perches <[email protected]>
Signed-off-by Aleksander Jan Bajkowski <[email protected]>
--- drivers/net/ethernet/lantiq_etop.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/lantiq_etop.c +1 -3
@@ -217,9 +217,7 @@ ltq_etop_free_channel(struct net_device *dev, struct ltq_etop_chan *ch)if (ch->dma.irq)free_irq (ch->dma.irq, priv);if (IS_RX (ch->idx)) { -int desc; - -for (desc =0 ; desc <LTQ_DESC_NUM ; desc++) +for (ch->dma.desc =0 ; ch->dma.desc <LTQ_DESC_NUM ; ch->dma.desc++)dev_kfree_skb_any (ch->skb[ch->dma.desc]); } }
Signature · 1 line
2.39.2
Quoted 6 lines · Aleksander Jan Bajkowski
The number of the currently released descriptor is never incremented which results in the same skb being released multiple times.
Reported-by Joe Perches <[email protected]>Signed-off-by Aleksander Jan Bajkowski <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Andrew