test: remove dead cfgfile tests
RFC 1/1 test: remove dead cfgfile tests
The tests for the cfgfile library were never built since the conversion to meson (in 2017). Remove the dead code and files, if someone wants to fix them then they can be restored later.
See commit b5dc795a8a55 ("test: build app with meson as dpdk-test")
--- MAINTAINERS | 2 - app/test/meson.build | 2 - app/test/resource.c | 276 --------------- app/test/resource.h | 106 ------ app/test/test_cfgfile.c | 334 ------------------ app/test/test_cfgfiles/etc/empty.ini | 0 .../test_cfgfiles/etc/empty_key_value.ini | 3 - .../test_cfgfiles/etc/invalid_section.ini | 3 - app/test/test_cfgfiles/etc/line_too_long.ini | 3 - .../test_cfgfiles/etc/missing_section.ini | 2 - .../test_cfgfiles/etc/realloc_sections.ini | 128 ------- app/test/test_cfgfiles/etc/sample1.ini | 12 - app/test/test_cfgfiles/etc/sample2.ini | 12 - 13 files changed, 883 deletions(-) delete mode 100644 app/test/resource.c delete mode 100644 app/test/resource.h delete mode 100644 app/test/test_cfgfile.c delete mode 100644 app/test/test_cfgfiles/etc/empty.ini delete mode 100644 app/test/test_cfgfiles/etc/empty_key_value.ini delete mode 100644 app/test/test_cfgfiles/etc/invalid_section.ini delete mode 100644 app/test/test_cfgfiles/etc/line_too_long.ini delete mode 100644 app/test/test_cfgfiles/etc/missing_section.ini delete mode 100644 app/test/test_cfgfiles/etc/realloc_sections.ini delete mode 100644 app/test/test_cfgfiles/etc/sample1.ini delete mode 100644 app/test/test_cfgfiles/etc/sample2.ini
MAINTAINERS +0 -2
@@ -1686,8 +1686,6 @@ F: app/test/test_argparse.c Configuration file M: Cristian Dumitrescu <[email protected]> F: lib/cfgfile/ -F: app/test/test_cfgfile.c -F: app/test/test_cfgfiles/ Interactive command line F: lib/cmdline/
app/test/meson.build +0 -2
@@ -36,7 +36,6 @@ source_file_deps = { 'test_bitratestats.c': ['metrics', 'bitratestats', 'ethdev'] + sample_packet_forward_deps, 'test_bpf.c': ['bpf', 'net'], 'test_byteorder.c': [], -# 'test_cfgfile.c': ['cfgfile'], 'test_cksum.c': ['net'], 'test_cksum_perf.c': ['net'], 'test_cmdline.c': [],
@@ -154,7 +153,6 @@ source_file_deps = { 'test_reciprocal_division_perf.c': [], 'test_red.c': ['sched'], 'test_reorder.c': ['reorder'], -# 'test_resource.c': [], 'test_rib.c': ['net', 'rib'], 'test_rib6.c': ['net', 'rib'], 'test_ring.c': ['ptr_compress'],
app/test/resource.c deleted +0 -276
276 lines not on this page · raw message
app/test/resource.h deleted +0 -106
106 lines not on this page · raw message
app/test/test_cfgfile.c deleted +0 -334
334 lines not on this page · raw message
app/test/test_cfgfiles/etc/empty.ini deleted +0 -0
app/test/test_cfgfiles/etc/empty_key_value.ini deleted +0 -3
@@ -1,3 +0,0 @@ -[section1] -; this is section 1 -key=
app/test/test_cfgfiles/etc/invalid_section.ini deleted +0 -3
@@ -1,3 +0,0 @@ -[invalid -; this is section 1 -key1=value1
app/test/test_cfgfiles/etc/line_too_long.ini deleted +0 -3
@@ -1,3 +0,0 @@ -[section1] -; this is section 1 -012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
app/test/test_cfgfiles/etc/missing_section.ini deleted +0 -2
@@ -1,2 +0,0 @@ -; no section -key=value
app/test/test_cfgfiles/etc/realloc_sections.ini deleted +0 -128
128 lines not on this page · raw message
app/test/test_cfgfiles/etc/sample1.ini deleted +0 -12
@@ -1,12 +0,0 @@ -; this is a global comment - -[section1] -; this is section 1 -key1=value1 - -[section2] -; this is section 2 -;key1=value1 -key2=value2 -key3=value3 ; this is key3 -ignore-missing-separator
app/test/test_cfgfiles/etc/sample2.ini deleted +0 -12
@@ -1,12 +0,0 @@ -# this is a global comment - -[section1] -# this is section 1 -key1=value1 - -[section2] -# this is section 2 -#key1=value1 -key2=value2 -key3=value3 # this is key3 -ignore-missing-separator
Signature · 1 line
2.43.0
08/07/2024 18:55, Stephen Hemminger:
Quoted 5 lines
The tests for the cfgfile library were never built since the conversion to meson (in 2017). Remove the dead code and files, if someone wants to fix them then they can be restored later.
See commitb5dc795a8a55("test: build app with meson as dpdk-test")
Quoted 7 lines
Signed-off-by Stephen Hemminger <[email protected]>--- MAINTAINERS | 2 - app/test/meson.build | 2 - app/test/resource.c | 276 --------------- app/test/resource.h | 106 ------ app/test/test_cfgfile.c | 334 ------------------
As far as I remember, resource tests are different of cfgfile.
What is the problem of building cfgfile tests? Many errors? Which kind of error?
Quoted 14 lines · Thomas Monjalon
08/07/2024 18:55, Stephen Hemminger:
Quoted 5 lines
The tests for the cfgfile library were never built since the conversion to meson (in 2017). Remove the dead code and files, if someone wants to fix them then they can be restored later.
See commitb5dc795a8a55("test: build app with meson as dpdk-test")Quoted 7 lines
Signed-off-by Stephen Hemminger <[email protected]>--- MAINTAINERS | 2 - app/test/meson.build | 2 - app/test/resource.c | 276 --------------- app/test/resource.h | 106 ------ app/test/test_cfgfile.c | 334 ------------------
Quoted 3 lines
As far as I remember, resource tests are different of cfgfile.
What is the problem of building cfgfile tests? Many errors? Which kind of error?
cfgfile tests use a dummy config file as a resource.
/Bruce