Skip to contentSkip to conversation

libxfs: remove duplicate rtalloc declarations in libxfs.h

PATCH In review Christoph Hellwig 3 participants 3 messages Jul 9, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libxfs: remove duplicate rtalloc declarations in libxfs.h

These already come from xfs_rtbitmap.h.

---

Changes since v1:
- now without spurious man page removal

 include/libxfs.h | 5 -----
 1 file changed, 5 deletions(-)
include/libxfs.h +0 -5
index fb8efb696..40e41ea77 100644
@@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
 		irec->br_state = XFS_EXT_NORM;
 }
 
-/* XXX: this is clearly a bug - a shared header needs to export this */
-/* xfs_rtalloc.c */
-int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
-bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
-
 #include "xfs_attr.h"
 #include "topology.h"
 
Signature · 1 line
2.43.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 16 lines · Christoph Hellwig

These already come from xfs_rtbitmap.h.

---

Changes since v1:
- now without spurious man page removal

 include/libxfs.h | 5 -----
 1 file changed, 5 deletions(-)
include/libxfs.h +0 -0
index fb8efb696..40e41ea77 100644

include/libxfs.h libxfs_bmbt_disk_get_all( · line 224

Quoted 10 lines
include/libxfs.h +0 -5
@@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
 		irec->br_state = XFS_EXT_NORM;
 }
 
-/* XXX: this is clearly a bug - a shared header needs to export this */
-/* xfs_rtalloc.c */
-int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
-bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
-
 #include "xfs_attr.h"
 #include "topology.h"

Looks good now.

Signature · 2 lines
Dave Chinner
[email protected]
Reviewed-by on v2 1/1
#2 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

These already come from xfs_rtbitmap.h.

Looks good now,

--D

Quoted 28 lines

---

Changes since v1:
- now without spurious man page removal

 include/libxfs.h | 5 -----
 1 file changed, 5 deletions(-)
include/libxfs.h +0 -5
index fb8efb696..40e41ea77 100644
@@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
 		irec->br_state = XFS_EXT_NORM;
 }
 
-/* XXX: this is clearly a bug - a shared header needs to export this */
-/* xfs_rtalloc.c */
-int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
-bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
-
 #include "xfs_attr.h"
 #include "topology.h"
 
Signature · 1 line
2.43.0