xen: make multicall debug boot time selectable
Subsystems (3)
Juergen Gross
maintainerPATCH v2 1/1 xen: make multicall debug boot time selectable
Today Xen multicall debugging needs to be enabled via modifying a define in a source file for getting debug data of multicall errors encountered by users.
Switch multicall debugging to depend on a boot parameter "xen_mc_debug" instead, enabling affected users to boot with the new parameter set in order to get better diagnostics.
With debugging enabled print the following information in case at least one of the batched calls failed:
- all calls of the batch with operation, result and caller
- all parameters of each call
- all parameters stored in the multicall data for each call
---
V2:
- fixed argument printing, added parameter printing
- in debug case print entries without error, too
- rename struct member from debug to entries (Boris Ostrovsky)
- get rid of get_mc_debug_ptr() (Boris Ostrovsky)
--- .../admin-guide/kernel-parameters.txt | 6 + arch/x86/xen/multicalls.c | 125 ++++++++++++++---- 2 files changed, 108 insertions(+), 23 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +6 -0
@@ -7427,6 +7427,12 @@ Crash from Xen panic notifier, without executing late panic() code such as dumping handler. + xen_mc_debug [X86,XEN,EARLY] + Enable multicall debugging when running as a Xen PV guest. + Enabling this feature will reduce performance a little + bit, so it should only be enabled for obtaining extended + debug data in case of multicall errors. + xen_msr_safe= [X86,XEN,EARLY] Format: <bool> Select whether to always use non-faulting (safe) MSR
arch/x86/xen/multicalls.c +102 -23
179 lines not on this page · raw message
Signature · 1 line
2.43.0
Quoted 8 lines · Juergen Gross
Today Xen multicall debugging needs to be enabled via modifying a define in a source file for getting debug data of multicall errors encountered by users.
Switch multicall debugging to depend on a boot parameter "
xen_mc_debug" instead, enabling affected users to boot with the new parameter set in order to get better diagnostics.
Quoted 7 lines
With debugging enabled print the following information in case at least one of the batched calls failed:
- all calls of the batch with operation, result and caller
- all parameters of each call
- all parameters stored in the multicall data for each callSigned-off-by Juergen Gross <[email protected]>