Skip to contentSkip to conversation

dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma

PATCH Applied Frank Li 2 participants 2 messages Jul 10, 2024 – Aug 5, 2024

Subsystems (3)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v4 1/1 dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma

The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible string fallback to fsl,ls1021a-qdma.

The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs.

Fix below CHECK_DTB warning.
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long

---
Change from v3 to v4
- rebase to dmaengine/next
- Add Kryzy's review tag
Change from v2 to v3
- previous patch missed a dependent change.
https://lore.kernel.org/imx/[email protected]/T/#u
- Combine depedent change to one patch.

Change from v1 to v2
- Change maxItems: 5 to minItems: 5. because maxItems: 5 already restrict at top

interrupts:
minItems: 2
maxItems: 5
---

---
 Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/dma/fsl-qdma.yaml +8 -5
index 1b9ebdbe528a1..9401b1f6300d4 100644
@@ -11,11 +11,14 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,ls1021a-qdma
-      - fsl,ls1028a-qdma
-      - fsl,ls1043a-qdma
-      - fsl,ls1046a-qdma
+    oneOf:
+      - const: fsl,ls1021a-qdma
+      - items:
+          - enum:
+              - fsl,ls1028a-qdma
+              - fsl,ls1043a-qdma
+              - fsl,ls1046a-qdma
+          - const: fsl,ls1021a-qdma
 
   reg:
     items:
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Frank Li

The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible string fallback to fsl,ls1021a-qdma.

The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs.

Fix below CHECK_DTB warning.
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long

[...]

Applied, thanks!

[1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma

      commit: 0204485c5a1e2de00acfd83c3931bd9dc6493c64

Best regards,

Signature · 1 line
Vinod Koul <[email protected]>