tools/hex2hcd: fix musl compatibility
PATCH v3 1/1 tools/hex2hcd: fix musl compatibility
The call to basename() relies on a GNU extension
to take a const char * vs a char *. Let's define
a trivial helper function to ensure compatibility
with musl.
Downstream gentoo bug: https://bugs.gentoo.org/926344
Fixes: #843
--- tools/hex2hcd.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
tools/hex2hcd.c +8 -1
@@ -285,6 +285,13 @@ static void ver_parse_file(const char *pathname) prev->next = ver; } +static const char *helper_basename (const char *path) +{ +const char *base =strrchr (path,'/' ); + +return base ? base +1 : path; +} +static void ver_parse_entry (const char *pathname) {struct stat st;
@@ -302,7 +309,7 @@ static void ver_parse_entry(const char *pathname) }if (S_ISREG (st.st_mode)) { -ver_parse_file (basename (pathname)); +ver_parse_file (helper_basename (pathname)); goto done; }
Signature · 1 line
2.45.2
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=870206
---Test result---
Test Summary:
CheckPatch PASS 0.48 seconds GitLint PASS 0.33 seconds BuildEll PASS 25.03 seconds BluezMake PASS 1762.86 seconds MakeCheck PASS 13.34 seconds MakeDistcheck PASS 179.83 seconds CheckValgrind PASS 254.74 seconds CheckSmatch WARNING 360.47 seconds bluezmakeextell PASS 120.97 seconds IncrementalBuild PASS 1489.59 seconds ScanBuild PASS 1014.26 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:tools/hex2hcd.c:135:26: warning: Variable length array is used.
---
Regards,
Linux Bluetooth