Skip to contentSkip to conversation

ti-img-rogue-umlibs: ldflags update

PATCH New [email protected] 1 participant 3 messages Jul 10, 2024

lore
Share & tools
lore
#0 lore raw

cover ti-img-rogue-umlibs: ldflags update

From: Randolph Sapp <[email protected]>

Add ldflags to the INSANE_SKIP strings for all components. We now use the Yocto compiler for these packages but we do not use all of the yocto compiler flags.

As such, whenever the GCC version being used for these packages is equal to the version Yocto is currently on, we will trip the ldflags sanity check. This usually results in the following error:

File <> in package <> doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

Randolph Sapp (2):
ti-img-rogue-umlibs: fix libopencl-rogue-tools sanity
ti-img-rogue-umlibs_23: add ldflags to INSANE_SKIP

 .../powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb      | 6 ++++--
 .../powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb      | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.45.2
#1 lore raw

PATCH 1/2 ti-img-rogue-umlibs: fix libopencl-rogue-tools sanity

From: Randolph Sapp <[email protected]>

Add ldflags to INSANE_SKIP for the libopencl-rogue-tools package. For some reason I didn't catch this sooner, but this falls victim to the same issues the parent package faced earlier this year.

Just enough options enabled that Yocto wants to do a ldflags check, but the DDK will not be able to utilize all the build flags Yocto uses.

---
 .../powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb           | 1 +
 1 file changed, 1 insertion(+)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb +1 -0
index df781bea..57475cb4 100644
@@ -129,6 +129,7 @@ RDEPENDS:libopencl-rogue += "opencl-icd-loader"
 RRECOMMENDS:libopencl-rogue += "libopencl-rogue-tools"
 FILES:libopencl-rogue-tools += "${bindir}/ocl*"
 DEBIAN_NOAUTONAME:libopencl-rogue-tools = "1"
+INSANE_SKIP:libopencl-rogue-tools = "ldflags"
 
 # optional tools and tests
 FILES:${PN}-tools = "${bindir}/"
Signature · 1 line
2.45.2
#2 lore raw

PATCH 2/2 ti-img-rogue-umlibs_23: add ldflags to INSANE_SKIP

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Adding this sanity check here preemptively. Since these libraries were compiled with an older version of GCC than what is currently in use on scarthgap and master they won't trip the sanity check just yet, but if someone attempts to update them and uses a newer compiler (for some reason) it will trigger the sanity checks again.

This also keeps the DDK 23.3 and 24.1 recipe diff to a minimum.

---
 .../powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb +4 -2
index 288eb52b..40835439 100644
@@ -109,7 +109,7 @@ python __anonymous() {
         mlprefix = d.getVar("MLPREFIX")
         pkgs = " " + " ".join(mlprefix + x + suffix for x in p[1:])
         d.setVar("DEBIAN_NOAUTONAME:" + fullp, "1")
-        d.setVar("INSANE_SKIP:" + fullp, "dev-so")
+        d.setVar("INSANE_SKIP:" + fullp, "dev-so ldflags")
         d.appendVar("RRECOMMENDS:" + fullp, " ${MLPREFIX}ti-img-rogue-umlibs" + suffix)
 }
 
@@ -129,10 +129,12 @@ RDEPENDS:libopencl-rogue += "opencl-icd-loader"
 RRECOMMENDS:libopencl-rogue += "libopencl-rogue-tools"
 FILES:libopencl-rogue-tools += "${bindir}/ocl*"
 DEBIAN_NOAUTONAME:libopencl-rogue-tools = "1"
+INSANE_SKIP:libopencl-rogue-tools = "ldflags"
 
 # optional tools and tests
 FILES:${PN}-tools = "${bindir}/"
 RDEPENDS:${PN}-tools = "python3-core ${PN}"
+INSANE_SKIP:${PN}-tools = "ldflags"
 
 # required firmware
 FILES:${PN}-firmware = "${base_libdir}/firmware/*"
@@ -142,4 +144,4 @@ RRECOMMENDS:${PN} += " \
     ${PN}-tools \
 "
 
-INSANE_SKIP:${PN} += "already-stripped dev-so"
+INSANE_SKIP:${PN} += "already-stripped dev-so ldflags"
Signature · 1 line
2.45.2