Skip to contentSkip to conversation

package/tbtools: bump to version 0.4.1

PATCH In review Mika Westerberg 2 participants 6 messages Jun 18, 2024 – Jul 10, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/tbtools: bump to version 0.4.1

Update to the latest release of tbtools.

This should also get rid of the couple of build errors seen on sparc64 builds.

---
 package/tbtools/tbtools.hash | 2 +-
 package/tbtools/tbtools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/tbtools/tbtools.hash +1 -1
index 06705fc19d..85efbfa4ec 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  1276ded79276d42c06a16293e26de32566c023383416fb8c91f86d141acce691  tbtools-0.4.0-cargo2.tar.gz
+sha256  d35c50063b254a561d567926fe8e5280206f6144c12f3f82e832f87392b67510  tbtools-0.4.1-cargo2.tar.gz
 sha256  9b16a3add311d607af8d9b348a842a37840d0f47dfcc6cf2a7756ee02c24ed69  LICENSE
package/tbtools/tbtools.mk +1 -1
index fc5ffc4215..15766b67c7 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-TBTOOLS_VERSION = 0.4.0
+TBTOOLS_VERSION = 0.4.1
 TBTOOLS_SITE = $(call github,intel,tbtools,v$(TBTOOLS_VERSION))
 TBTOOLS_LICENSE = MIT
 TBTOOLS_LICENSE_FILES = LICENSE
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 package/tbtools: Install bash completion files and scripts

Add hooks to install the bash completion files and scripts provided by the package.

---
 package/tbtools/tbtools.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)
package/tbtools/tbtools.mk +12 -0
index 15766b67c7..baba0e8a3b 100644
@@ -10,4 +10,16 @@ TBTOOLS_LICENSE = MIT
 TBTOOLS_LICENSE_FILES = LICENSE
 TBTOOLS_DEPENDENCIES = udev
 
+define TBTOOLS_INSTALL_SCRIPTS
+	$(MAKE) -C $(@D) PREFIX=$(TARGET_DIR)/usr install-scripts
+endef
+TBTOOLS_POST_INSTALL_TARGET_HOOKS += TBTOOLS_INSTALL_SCRIPTS
+
+ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
+define TBTOOLS_INSTALL_COMPLETION
+	$(MAKE) -C $(@D) PREFIX=$(TARGET_DIR)/usr install-completion
+endef
+TBTOOLS_POST_INSTALL_TARGET_HOOKS += TBTOOLS_INSTALL_COMPLETION
+endif
+
 $(eval $(cargo-package))
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/3] package/tbtools: Install bash completion files and scripts

package/tbtools/tbtools.mk TBTOOLS_LICENSE = MIT · line 16

Quoted 4 lines · On Tue, 18 Jun 2024 16:04:02 +0300 Mika Westerberg…
package/tbtools/tbtools.mk +4 -0
+define TBTOOLS_INSTALL_SCRIPTS
+	$(MAKE) -C $(@D) PREFIX=$(TARGET_DIR)/usr install-scripts
+endef
+TBTOOLS_POST_INSTALL_TARGET_HOOKS += TBTOOLS_INSTALL_SCRIPTS

PREFIX has a somewhat non-conventional semantic in tbtools Makefile, but fair enough it does the job, so patch applied, thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

PATCH 3/3 package/tbtools: Allow 32-bit builds

In reply to Mika Westerberg

With the latest tbtools 32-bit builds should work too so drop this limitation.

---
 package/tbtools/Config.in | 2 --
 1 file changed, 2 deletions(-)
package/tbtools/Config.in +0 -2
index 9c27bf0e30..0a649a9555 100644
@@ -3,8 +3,6 @@ config BR2_PACKAGE_TBTOOLS
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_PACKAGE_HAS_UDEV
-	# Fails to build on 32-bit systems
-	depends on BR2_ARCH_IS_64
 	select BR2_PACKAGE_HOST_RUSTC
 	help
 	  tbtools is a collection of tools for Linux Thunderbolt/USB4
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 3/3] package/tbtools: Allow 32-bit builds

Quoted 13 lines · On Tue, 18 Jun 2024 16:04:03 +0300 Mika Westerberg…

With the latest tbtools 32-bit builds should work too so drop this limitation.

---
 package/tbtools/Config.in | 2 --
 1 file changed, 2 deletions(-)
package/tbtools/Config.in +0 -0
index 9c27bf0e30..0a649a9555 100644

package/tbtools/Config.in config BR2_PACKAGE_TBTOOLS · line 7

Quoted 5 lines
package/tbtools/Config.in +0 -2
@@ -3,8 +3,6 @@ config BR2_PACKAGE_TBTOOLS
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_PACKAGE_HAS_UDEV
-	# Fails to build on 32-bit systems
-	depends on BR2_ARCH_IS_64

You had forgotten to drop the BR2_ARCH_IS_64 dependency in the Config.in comment in the same file, so I dropped it and applied. Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to Mika Westerberg

Hello Mika,

Thanks for the patch. One comment below.

Quoted 4 lines · On Tue, 18 Jun 2024 16:04:01 +0300 Mika Westerberg…

Update to the latest release of tbtools.

This should also get rid of the couple of build errors seen on sparc64 builds.

We really need more than "should" in commit logs, but guarantees :)

So practically speaking, we do expect you do to test that it fixes sparc64 builds, and if it does, include a reference to the autobuilder failures that are being fixed. I adjusted the commit log with the relevant information when committing:

https://gitlab.com/buildroot.org/buildroot/-/commit/f5251865413c6a50759d6f48b3300dc1be6122fb

Applied with that change. Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot