dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro)
Subsystems (2)
PATCH 1/2 dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro)
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Pro
this patch reflect the change in dt-bindings.
--- Documentation/devicetree/bindings/arm/amlogic.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/amlogic.yaml +1 -1
@@ -157,7 +157,7 @@ properties: - bananapi,bpi-m2s - khadas,vim3 - libretech,aml-a311d-cc - - radxa,zero2 + - radxa,zero-2pro - const: amlogic,a311d - const: amlogic,g12b
Signature · 7 lines
2.43.0 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
PATCH 2/2 arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Pro
this patch reflect the change in dts.
---
arch/arm64/boot/dts/amlogic/Makefile | 2 +-
...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
rename arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} (98%)arch/arm64/boot/dts/amlogic/Makefile +1 -1
@@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +3 -3
@@ -16,8 +16,8 @@ #include <dt-bindings/sound/meson-g12a-tohdmitx.h> / { - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; - model = "Radxa Zero2"; + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b"; + model = "Radxa ZERO 2 Pro"; aliases { serial0 = &uart_AO;
@@ -169,7 +169,7 @@ vddcpu_b: regulator-vddcpu-b { sound { compatible = "amlogic,axg-sound-card"; - model = "RADXA-ZERO2"; + model = "RADXA-ZERO-2PRO"; audio-aux-devs = <&tdmout_b>; audio-routing = "TDMOUT_B IN 0", "FRDDR_A OUT 1", "TDMOUT_B IN 1", "FRDDR_B OUT 1",
Signature · 7 lines
2.43.0 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
Quoted 35 lines · FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Prothis patch reflect the change in dts.
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/amlogic/Makefile | 2 +- ...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) rename arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} (98%)arch/arm64/boot/dts/amlogic/Makefile +1
-1@@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtbarch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +0
-0
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts line 19
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +1
-2@@ -16,8 +16,8 @@ #include <dt-bindings/sound/meson-g12a-tohdmitx.h> / { - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; - model = "Radxa Zero2"; + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
Keep old compatible.
Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
Hi,
thanks for your reply.
Quoted 38 lines · Krzysztof Kozlowski
Quoted 37 lines · FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Prothis patch reflect the change in dts.
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/amlogic/Makefile | 2 +- ...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)rename
arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts=>meson-g12b-radxa-zero-2pro.dts} (98%)arch/arm64/boot/dts/amlogic/Makefile +1
-1@@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtbarch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +0
-0@@ -16,8 +16,8 @@ #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts line 19
Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +1
-2/ { - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; - model = "Radxa Zero2"; + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";Keep old compatible.
which is better?
compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
or
compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (keep old one)
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 4 lines
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
Quoted 8 lines · FUKAUMI Naoki
Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts line 19
Quoted 5 lines
/ {arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +1
-2- compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; - model = "Radxa Zero2"; + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";Keep old compatible.
Quoted 6 lines
which is better?
compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
or
compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (keep old one)
I propose not to change anything, at least based on your explanations/rationale.
Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
Hi
Quoted 11 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts line 19
Quoted 5 lines
/ {arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts renamed from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts +1
-2- compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; - model = "Radxa Zero2"; + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";Keep old compatible.
which is better?
Quoted 7 lines
Quoted 4 lines
compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
or
compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (keep old one)I propose not to change anything, at least based on your explanations/rationale.
I see, I don't touch anything which already exists. then, can I add new "Radxa ZERO 2 Pro" product?
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 4 lines
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Quoted 8 lines · FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Prothis patch reflect the change in dt-bindings.
Signed-off-by FUKAUMI Naoki <[email protected]>
Compatible does not reflect product name changes. It should stay.
Best regards,
Krzysztof
Rob Herring (Arm)
maintainerQuoted 5 lines · FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Pro
Quoted 7 lines
this patch reflect the change in dt-bindings.
Signed-off-by FUKAUMI Naoki <[email protected]>--- Documentation/devicetree/bindings/arm/amlogic.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y amlogic/meson-g12b-radxa-zero-2pro.dtb' for [email protected]:
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dtb: sound: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-sound-card.yaml#arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dtb: sound: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'#clock-cells' is a required property
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#