damon: using pointer to access globally defined structures
Subsystems (2)
PATCH 1/1 damon: using pointer to access globally defined structures
From: Peng Hao <[email protected]>
When KASAN is enabled and built with clang:mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than] static int damon_lru_sort_apply_parameters(void)
^
1 error generated.
This is because using local variables to obtain some global structure variables takes up a large amount of stack space.
Changing to pointer access can solve it.
--- mm/damon/lru_sort.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
mm/damon/lru_sort.c +10 -10
@@ -148,10 +148,10 @@ static struct damon_target *target;static struct damos *damon_lru_sort_new_scheme (struct damos_access_pattern *pattern,enum damos_action action) { -struct damos_quota quota = damon_lru_sort_quota; +struct damos_quota *quota = &damon_lru_sort_quota;/* Use half of total quota for hot/cold pages sorting */ - quota.ms = quota.ms /2 ; + quota->ms = quota->ms /2 ;return damon_new_scheme ( /* find the pattern, and */
@@ -161,7 +161,7 @@ static struct damos *damon_lru_sort_new_scheme(/* for each aggregation interval */ 0 ,/* under the quota. */ - "a, + quota,/* (De)activate this according to the watermarks. */ &damon_lru_sort_wmarks); }
@@ -169,20 +169,20 @@ static struct damos *damon_lru_sort_new_scheme(/* Create a DAMON-based operation scheme for hot memory regions */ static struct damos *damon_lru_sort_new_hot_scheme (unsigned int hot_thres) { -struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; +struct damos_access_pattern *pattern = &damon_lru_sort_stub_pattern; - pattern.min_nr_accesses = hot_thres; -return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_PRIO ); + pattern->min_nr_accesses = hot_thres; +return damon_lru_sort_new_scheme (pattern,DAMOS_LRU_PRIO ); }/* Create a DAMON-based operation scheme for cold memory regions */ static struct damos *damon_lru_sort_new_cold_scheme (unsigned int cold_thres) { -struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; +struct damos_access_pattern *pattern = &damon_lru_sort_stub_pattern; - pattern.max_nr_accesses =0 ; - pattern.min_age_region = cold_thres; -return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_DEPRIO ); + pattern->max_nr_accesses =0 ; + pattern->min_age_region = cold_thres; +return damon_lru_sort_new_scheme (pattern,DAMOS_LRU_DEPRIO ); } static void damon_lru_sort_copy_quota_status(struct damos_quota *dst,
Signature · 1 line
2.27.0
SeongJae Park
maintainerHi Peng,
Thank you for this patch!
Quoted 10 lines · On Thu, 11 Jul 2024 16:10:51 +0800 [email protected] wrote:
From: Peng Hao <[email protected]>
When KASAN is enabled and built with clang:
mm/damon/lru_sort.c:199:12: error: stack frame size (2328) exceeds limit (2048) in 'damon_lru_sort_apply_parameters' [-Werror,-Wframe-larger-than] static intdamon_lru_sort_apply_parameters(void)^1 error generated.
This is because using local variables to obtain some global structure variables takes up a large amount of stack space.
checkpatch.pl complains this as below:
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #17:
This is because using local variables to obtain some global structure variables
Could you please wrap the line?
Quoted 7 lines
Changing to pointer access can solve it.
Signed-off-by Peng Hao <[email protected]>--- mm/damon/lru_sort.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
Also, I'd prefer having 'mm/damon/lru_sort: ' as the prefix of the subject of this patch, instead of 'damon: '. I think it makes the commit log easier to understand and be consistent with other commits for DAMON.
Quoted 6 lines
mm/damon/lru_sort.c +0
-0
mm/damon/lru_sort.c static struct damon_target *target; · line 154
Quoted 9 lines
mm/damon/lru_sort.c +2
-2@@ -148,10 +148,10 @@ static struct damon_target *target;static struct damos *damon_lru_sort_new_scheme (struct damos_access_pattern *pattern,enum damos_action action) { -struct damos_quota quota = damon_lru_sort_quota; +struct damos_quota *quota = &damon_lru_sort_quota;/* Use half of total quota for hot/cold pages sorting */ - quota.ms = quota.ms /2 ; + quota->ms = quota->ms /2 ;
This means that ->ms of damon_lru_sort_quota is changed. If damon_lru_sort_new_scheme() is called repeatedly before the user re-write the field via 'quota_ms' module parameter, the quota will continuously be reduced. Which is a behavior that the user would never expected.
The problem comes from the fact that we're allocating 'quota' as a local variable on stack. How about making 'quota' be pointer, but for a 'damos_quota' object that dynamically allocated here other than the global variable? Then we can copy damon_lru_sort_quota content to it like before and make more modification on the copy without making change to the global variable.
Quoted 27 lines
mm/damon/lru_sort.c +4
-4return damon_new_scheme ( /* find the pattern, and */@@ -161,7 +161,7 @@ static struct damos *damon_lru_sort_new_scheme(/* for each aggregation interval */ 0 ,/* under the quota. */ - "a, + quota,/* (De)activate this according to the watermarks. */ &damon_lru_sort_wmarks); }@@ -169,20 +169,20 @@ static struct damos *damon_lru_sort_new_scheme(/* Create a DAMON-based operation scheme for hot memory regions */ static struct damos *damon_lru_sort_new_hot_scheme (unsigned int hot_thres) { -struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; +struct damos_access_pattern *pattern = &damon_lru_sort_stub_pattern; - pattern.min_nr_accesses = hot_thres; -return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_PRIO ); + pattern->min_nr_accesses = hot_thres; +return damon_lru_sort_new_scheme (pattern,DAMOS_LRU_PRIO ); }/* Create a DAMON-based operation scheme for cold memory regions */ static struct damos *damon_lru_sort_new_cold_scheme (unsigned int cold_thres)
mm/damon/lru_sort.c static struct damos *damon_lru_sort_new_scheme( · line 185
Quoted 10 lines
mm/damon/lru_sort.c +4
-4{ -struct damos_access_pattern pattern = damon_lru_sort_stub_pattern; +struct damos_access_pattern *pattern = &damon_lru_sort_stub_pattern; - pattern.max_nr_accesses =0 ; - pattern.min_age_region = cold_thres; -return damon_lru_sort_new_scheme (&pattern,DAMOS_LRU_DEPRIO ); + pattern->max_nr_accesses =0 ; + pattern->min_age_region = cold_thres; +return damon_lru_sort_new_scheme (pattern,DAMOS_LRU_DEPRIO );
Again, above changes to two functions make damon_lru_sort_stub_pattern, which is a global variable that read by the two functions to be updated by them without awareness of others.
For example, if damon_lru_sort_new_hot_scheme() is called after damon_lru_sort_new_cold_scheme(), the pattern's max_nr_accesses would be not 'UNIT_MAX' but '0'. This is again not what user-expected behavior.
So I'd suggest to use dynamic allocation and stub's content copying similar to above.
Thanks,
SJ
Quoted 5 lines
mm/damon/lru_sort.c +0
-0} static void damon_lru_sort_copy_quota_status(struct damos_quota *dst,Signature · 1 line
2.27.0
Andrew Morton
maintainerQuoted 2 lines · On Thu, 11 Jul 2024 11:48:52 -0700 SeongJae Park <[email protected]> wrote:
So I'd suggest to use dynamic allocation and stub's content copying similar to above.
Yup. kmemdup() should work?