Bump pahole and tbb and remove sysdig
cover Bump pahole and tbb and remove sysdig
Hi,
With this contribution, I am bumping pahole and tbb to the latest available versions.
Also, I am removing package related to sysdig: falcosecurity-libs and sysdig itself.
On this point, I would like to have your opinion, hence the RFC label.
Maintaining sysdig has been complicated as this software changes really fast which has impact on the way to build it. Sadly, I cannot cope with this changes as fast as they arrive to be able to maintain it in buildroot.
So, rather than having a very outdated package, I think this is better to remove it.
Francis Laniel (4):
package/pahole: bump to version 1.27
package/tbb: bump to version 2021.12.0.
package/sysdig: remove package.
package/falcosecurity-libs: remove package.
DEVELOPERS | 3 - package/Config.in | 2 - ...cmake-Permit-setting-GRPC_CPP_PLUGIN.patch | 34 -------- package/falcosecurity-libs/Config.in | 32 -------- .../falcosecurity-libs.hash | 5 -- .../falcosecurity-libs/falcosecurity-libs.mk | 82 ------------------- package/pahole/pahole.hash | 2 +- package/pahole/pahole.mk | 2 +- package/sysdig/Config.in | 34 -------- package/sysdig/sysdig.hash | 3 - package/sysdig/sysdig.mk | 38 --------- package/tbb/tbb.hash | 2 +- package/tbb/tbb.mk | 2 +- 13 files changed, 4 insertions(+), 237 deletions(-) delete mode 100644 package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.patch delete mode 100644 package/falcosecurity-libs/Config.in delete mode 100644 package/falcosecurity-libs/falcosecurity-libs.hash delete mode 100644 package/falcosecurity-libs/falcosecurity-libs.mk delete mode 100644 package/sysdig/Config.in delete mode 100644 package/sysdig/sysdig.hash delete mode 100644 package/sysdig/sysdig.mk
Best regards.
--
2.34.1
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
RFC PATCH 1/4 package/pahole: bump to version 1.27
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/NEWS?h=v1.27
--- package/pahole/pahole.hash | 2 +- package/pahole/pahole.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/pahole/pahole.hash +1 -1
@@ -1,3 +1,3 @@ # Locally computed -sha256 db31d13c3dad8d9f4e38296bd35c4586e98b9c950e07dabba212985e6d051631 pahole-1.25.tar.gz +sha256 87223298d4f8f9ada9b3cc5cef1bedd7aeb447cd8295abc466e009a26accff13 pahole-1.27.tar.gz sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING
package/pahole/pahole.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -PAHOLE_VERSION = 1.25 +PAHOLE_VERSION = 1.27 PAHOLE_SITE = https://git.kernel.org/pub/scm/devel/pahole/pahole.git/snapshot HOST_PAHOLE_DEPENDENCIES = \ host-elfutils \
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [RFC PATCH v1 1/4] package/pahole: bump to version 1.27
Quoted 7 lines · On Mon, 17 Jun 2024 16:10:17 +0100 Francis Laniel…
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/NEWS?h=v1.27
Signed-off-by Francis Laniel <[email protected]>--- package/pahole/pahole.hash | 2 +- package/pahole/pahole.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
RFC PATCH 2/4 package/tbb: bump to version 2021.12.0.
In reply to Francis Laniel--- package/tbb/tbb.hash | 2 +- package/tbb/tbb.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/tbb/tbb.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 782ce0cab62df9ea125cdea253a50534862b563f1d85d4cda7ad4e77550ac363 tbb-2021.11.0.tar.gz +sha256 c7bb7aa69c254d91b8f0041a71c5bcc3936acb64408a1719aec0b2b7639dd84f tbb-2021.12.0.tar.gz sha256 c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4 LICENSE.txt
package/tbb/tbb.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -TBB_VERSION = 2021.11.0 +TBB_VERSION = 2021.12.0 TBB_SITE = $(call github,01org,tbb,v$(TBB_VERSION)) TBB_INSTALL_STAGING = YES TBB_LICENSE = Apache-2.0
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [RFC PATCH v1 2/4] package/tbb: bump to version 2021.12.0.
Quoted 5 lines · On Mon, 17 Jun 2024 16:10:18 +0100 Francis Laniel…
Signed-off-by Francis Laniel <[email protected]>--- package/tbb/tbb.hash | 2 +- package/tbb/tbb.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
RFC PATCH 3/4 package/sysdig: remove package.
In reply to Francis LanielBuilding sysdig within buildroot is a complicated task which has changed at each of their release.
As the package seems to not be really used in buildroot, it seems wise to remove it.
--- DEVELOPERS | 2 -- package/Config.in | 1 - package/sysdig/Config.in | 34 ---------------------------------- package/sysdig/sysdig.hash | 3 --- package/sysdig/sysdig.mk | 38 -------------------------------------- 5 files changed, 78 deletions(-) delete mode 100644 package/sysdig/Config.in delete mode 100644 package/sysdig/sysdig.hash delete mode 100644 package/sysdig/sysdig.mk
DEVELOPERS +0 -2
@@ -225,7 +225,6 @@ F: package/rtl8723ds-bt/ F: package/sam-ba/ F: package/sshguard/ F: package/sunwait/ -F: package/sysdig/ N: Andy Shevchenko <[email protected]> F: package/fb-test-app/
@@ -1105,7 +1104,6 @@ F: package/odhcploc/ N: Francis Laniel <[email protected]> F: package/falcosecurity-libs F: package/pahole/ -F: package/sysdig/ F: package/tbb/ N: Francisco Gonzalez <[email protected]>
package/Config.in +0 -1
@@ -153,7 +153,6 @@ menu "Debugging, profiling and benchmark" source "package/strace/Config.in" source "package/stress/Config.in" source "package/stress-ng/Config.in" - source "package/sysdig/Config.in" source "package/sysprof/Config.in" source "package/tbtools/Config.in" source "package/tcf-agent/Config.in"
package/sysdig/Config.in deleted +0 -34
@@ -1,34 +0,0 @@ -config BR2_PACKAGE_SYSDIG - bool "sysdig" - depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # falcosecurity-libs - depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # falcosecurity-libs - depends on BR2_LINUX_KERNEL # falcosecurity-libs - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # falcosecurity-libs -> grpc -> libabseil-cpp - depends on BR2_TOOLCHAIN_HAS_THREADS # falcosecurity-libs - depends on !BR2_STATIC_LIBS # falcosecurity-libs - depends on BR2_TOOLCHAIN_USES_GLIBC # falcosecurity-libs - depends on BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_5_1 # falcosecurity-libs - depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # falcosecurity-libs - select BR2_PACKAGE_FALCOSECURITY_LIBS - select BR2_PACKAGE_NCURSES - select BR2_PACKAGE_JSON_FOR_MODERN_CPP - select BR2_PACKAGE_YAML_CPP - help - Sysdig is open source, system-level exploration: - capture system state and activity from a running Linux - instance, then save, filter and analyze. - Think of it as strace + tcpdump + lsof + awesome sauce. - With a little Lua cherry on top. - - https://github.com/draios/sysdig/wiki - -comment "sysdig needs a glibc toolchain w/ C++, threads, gcc >= 8, dynamic library, a Linux kernel, and luajit or lua 5.1 to be built" - depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS - depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS - depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC - depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \ - || !BR2_TOOLCHAIN_HAS_THREADS \ - || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_STATIC_LIBS \ - || !BR2_TOOLCHAIN_USES_GLIBC \ - || !BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_5_1
package/sysdig/sysdig.hash deleted +0 -3
@@ -1,3 +0,0 @@ -# sha256 locally computed -sha256 6b96797859002ab69a2bed4fdba1c7fe8064ecf8661621ae7d8fbf8599ffa636 sysdig-0.29.3.tar.gz -sha256 a88fbf820b38b1c7fabc6efe291b8259e02ae21326f56fe31c6c9adf374b2702 COPYING
package/sysdig/sysdig.mk deleted +0 -38
@@ -1,38 +0,0 @@ -################################################################################ -# -# sysdig -# -################################################################################ - -SYSDIG_VERSION = 0.29.3 -SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION)) -SYSDIG_LICENSE = Apache-2.0 -SYSDIG_LICENSE_FILES = COPYING -SYSDIG_CPE_ID_VENDOR = sysdig -SYSDIG_CONF_OPTS = \ - -DENABLE_DKMS=OFF \ - -DUSE_BUNDLED_DEPS=OFF \ - -DCREATE_TEST_TARGETS=OFF -SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO - -SYSDIG_DEPENDENCIES = \ - falcosecurity-libs \ - ncurses \ - json-for-modern-cpp \ - yaml-cpp - -# Don't build the driver as part of the 'standard' procedure, it has been built -# by falcosecurity-libs.mk. -# grpc_cpp_plugin is needed to build falcosecurity libs, so we give the host -# one there. -SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR) \ - -DBUILD_DRIVER=OFF \ - -DGRPC_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin \ - -DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME) \ - -DENABLE_DKMS=OFF \ - -DUSE_BUNDLED_DEPS=OFF \ - -DWITH_CHISEL=ON \ - -DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson \ - -DSYSDIG_VERSION=$(SYSDIG_VERSION) - -$(eval $(cmake-package))
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [RFC PATCH v1 3/4] package/sysdig: remove package.
Hello Francis,
I'm adding in Cc: Angelo who is also listed as a maintainer for this package in our DEVELOPERS file. Angelo, any feedback?
See below.
Quoted 2 lines · On Mon, 17 Jun 2024 16:10:19 +0100 Francis Laniel…
Building sysdig within buildroot is a complicated task which has changed at each of their release.
But the package is working right now, isn't it? Did you try to update it to a newer version and encountered some specific issues? If so, which issues?
Maybe those issues should be communicated back to upstream, so that they can improve how sysdig is provided/delivered? If something like Buildroot can't package sysdig, maybe they will be interested in hearing why?
Quoted 2 lines
As the package seems to not be really used in buildroot, it seems wise to remove it.
How can you say it is "not really used"? We have no usage metrics for packages, so really we have no idea of who uses sysdig.
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [RFC PATCH v1 3/4] package/sysdig: remove package.
Il gio 11 lug 2024, 20:00 Thomas Petazzoni via buildroot < [email protected]> ha scritto:
Quoted 7 lines
Hello Francis,
I'm adding in Cc: Angelo who is also listed as a maintainer for this package in our DEVELOPERS file. Angelo, any feedback?
See below.
Quoted 7 lines
Quoted 2 lines · On Mon, 17 Jun 2024 16:10:19 +0100 Francis Laniel…
Building sysdig within buildroot is a complicated task which has changed at each of their release.
But the package is working right now, isn't it?
To my knowledge it is, I have used it in the past, even if it's not updated.
Did you try to update
Quoted 3 lines
it to a newer version and encountered some specific issues? If so, which issues?
Francis sent several iteration of the bumping patches but from my knowledge, they were never good enough to be included.
I promised myself to look again at it, but really never found the time.
Quoted 5 lines
Maybe those issues should be communicated back to upstream, so that they can improve how sysdig is provided/delivered? If something like Buildroot can't package sysdig, maybe they will be interested in hearing why?
I fixed several things in the past in the build system, I think they are still open to proper fixes.
Quoted 6 lines
Quoted 2 lines
As the package seems to not be really used in buildroot, it seems wise to remove it.
How can you say it is "not really used"? We have no usage metrics for packages, so really we have no idea of who uses sysdig.
Indeed. It is a wonderful tool in my opinion to not to have in buildroot.
Quoted 10 lines
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list [email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
RFC PATCH 4/4 package/falcosecurity-libs: remove package.
In reply to Francis LanielLike sysdig, building this library in buildroot is complicated. Moreover, the build process has shown to change at each release of the upstream project which complexifies maintainability.
--- DEVELOPERS | 1 - package/Config.in | 1 - ...cmake-Permit-setting-GRPC_CPP_PLUGIN.patch | 34 -------- package/falcosecurity-libs/Config.in | 32 -------- .../falcosecurity-libs.hash | 5 -- .../falcosecurity-libs/falcosecurity-libs.mk | 82 ------------------- 6 files changed, 155 deletions(-) delete mode 100644 package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.patch delete mode 100644 package/falcosecurity-libs/Config.in delete mode 100644 package/falcosecurity-libs/falcosecurity-libs.hash delete mode 100644 package/falcosecurity-libs/falcosecurity-libs.mk
DEVELOPERS +0 -1
@@ -1102,7 +1102,6 @@ F: package/ipmitool/ F: package/odhcploc/ N: Francis Laniel <[email protected]> -F: package/falcosecurity-libs F: package/pahole/ F: package/tbb/
package/Config.in +0 -1
@@ -2122,7 +2122,6 @@ menu "Other" source "package/eigen/Config.in" source "package/elfutils/Config.in" source "package/ell/Config.in" - source "package/falcosecurity-libs/Config.in" source "package/fftw/Config.in" source "package/flann/Config.in" source "package/flatbuffers/Config.in"
package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.patch deleted +0 -34
@@ -1,34 +0,0 @@ -From 2e8a50cd4975df3ab60ee07c9675831cd5ad397f Mon Sep 17 00:00:00 2001 -From: Francis Laniel <[email protected]> -Date: Tue, 12 Apr 2022 19:54:11 +0100 -Subject: [PATCH] cmake: Permit setting GRPC_CPP_PLUGIN. - -This patch enables users to set GRPC_CPP_PLUGIN while calling cmake with: -cmake -DGRPC_CPP_PLUGIN=/path - -Signed-off-by: Francis Laniel <[email protected]> ---- - cmake/modules/grpc.cmake | 6 ++++-- - 1 file changed, 4 insertions(+), 2 deletions(-) - -diff --git a/cmake/modules/grpc.cmake b/cmake/modules/grpc.cmake -index e5fd16b8..9d8f5934 100644 ---- a/cmake/modules/grpc.cmake -+++ b/cmake/modules/grpc.cmake -@@ -12,9 +12,11 @@ elseif(NOT USE_BUNDLED_GRPC) - set(GRPCPP_LIB gRPC::grpc++) - - # gRPC C++ plugin -- get_target_property(GRPC_CPP_PLUGIN gRPC::grpc_cpp_plugin LOCATION) - if(NOT GRPC_CPP_PLUGIN) -- message(FATAL_ERROR "System grpc_cpp_plugin not found") -+ get_target_property(GRPC_CPP_PLUGIN gRPC::grpc_cpp_plugin LOCATION) -+ if(NOT GRPC_CPP_PLUGIN) -+ message(FATAL_ERROR "System grpc_cpp_plugin not found") -+ endif() - endif() - - # gRPC include dir + properly handle grpc{++,pp} --- -2.25.1 -
package/falcosecurity-libs/Config.in deleted +0 -32
@@ -1,32 +0,0 @@ -config BR2_PACKAGE_FALCOSECURITY_LIBS - bool - depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc - depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf - depends on BR2_LINUX_KERNEL - depends on BR2_INSTALL_LIBSTDCPP # jsoncpp, protobuf, tbb - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # grpc -> libabseil-cpp - depends on BR2_TOOLCHAIN_HAS_THREADS # jq, protobuf, tbb - depends on !BR2_STATIC_LIBS # protobuf, tbb - depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc - depends on BR2_TOOLCHAIN_USES_GLIBC # tbb - depends on BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_5_1 - select BR2_PACKAGE_C_ARES - select BR2_PACKAGE_ELFUTILS - select BR2_PACKAGE_GRPC - select BR2_PACKAGE_GTEST - select BR2_PACKAGE_HOST_GRPC - select BR2_PACKAGE_HOST_PROTOBUF - select BR2_PACKAGE_JQ - select BR2_PACKAGE_JSONCPP - select BR2_PACKAGE_LIBB64 - select BR2_PACKAGE_LIBCURL - select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_PROTOBUF - select BR2_PACKAGE_TBB - select BR2_PACKAGE_VALIJSON - select BR2_PACKAGE_ZLIB - help - falcosecurity/libs provides libsinsp, libscap, the kernel - module driver and the eBPF driver sources. - - https://github.com/falcosecurity/libs
package/falcosecurity-libs/falcosecurity-libs.hash deleted +0 -5
@@ -1,5 +0,0 @@ -# sha256 locally computed -sha256 80903bc57b7f9c5f24298ecf1531cf66ef571681b4bd1e05f6e4db704ffb380b falcosecurity-libs-e5c53d648f3c4694385bbe488e7d47eaa36c229a.tar.gz -sha256 21ec9433a87459b3477faf542bacec419dc03af841309eac35edeffe481cf10b COPYING -sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 driver/GPL2.txt -sha256 f17d3f2c2d565a74a7d5bf96f880c43701e141897e8dff0c8aa13e5d07aaf226 driver/MIT.txt
package/falcosecurity-libs/falcosecurity-libs.mk deleted +0 -82
82 lines not on this page · raw message
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot