Skip to contentSkip to conversation

Enumerate all pixels formats

PATCH Superseded Benjamin Gaignard 3 participants 8 messages Jul 12, 2024 – Jul 15, 2024

Subsystems (3)

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Benjamin Gaignard

author maintainer
#0 lore raw

v3 cover Enumerate all pixels formats

The goal of this series is to let userland applications enumerate all the supported pixels formats of a stateless decoder without setting all the possible codec-dependent control.
That offer a simplest solution for applications to discover supported pixels formats and possibly let them doing smarter choice between stateless decoders.

An example of how it can be used in GStreamer to discover the supported pixels formats for stateless decoder is available here:
https://gitlab.freedesktop.org/benjamin.gaignard1/gstreamer/-/commits/v4l2codecs_enum_all_supported_formats?ref_type=heads

changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

changes in version 2:
- Clarify documentation.
- Only keep V4L2_FMT_FLAG_ALL_FORMATS flag in ioctl.

Benjamin

Benjamin Gaignard (2):
media: videodev2: Add flags to unconditionnaly enumerate pixels
formats
media: verisilicon: Use V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag

 .../media/v4l/dev-stateless-decoder.rst          |  6 ++++++
 .../userspace-api/media/v4l/vidioc-enum-fmt.rst  |  9 +++++++++
 .../media/videodev2.h.rst.exceptions             |  2 ++
 drivers/media/platform/verisilicon/hantro_v4l2.c | 16 +++++++++++++---
 drivers/media/v4l2-core/v4l2-ioctl.c             |  3 +++
 include/uapi/linux/videodev2.h                   |  2 ++
 6 files changed, 35 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0
author maintainer
#1 lore raw

PATCH v3 1/2 media: videodev2: Add flags to unconditionnaly enumerate pixels formats

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl. When this V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag is set drivers must ignore the configuration and return the hardware supported pixel formats for the specified queue.
To distinguish this particular enumeration case V4L2_FMT_FLAG_ALL_FORMATS flag must be set by the drivers to highlight support of this feature to user space applications.
This will permit to discover which pixel formats are supported without setting codec-specific information so userland can more easily know if the driver suits its needs well.
The main target are stateless decoders so update the documentation about how to use this flag.

---
changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

 .../userspace-api/media/v4l/dev-stateless-decoder.rst    | 6 ++++++
 .../userspace-api/media/v4l/vidioc-enum-fmt.rst          | 9 +++++++++
 .../userspace-api/media/videodev2.h.rst.exceptions       | 2 ++
 drivers/media/v4l2-core/v4l2-ioctl.c                     | 3 +++
 include/uapi/linux/videodev2.h                           | 2 ++
 5 files changed, 22 insertions(+)
Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst +6 -0
index 35ed05f2695e..b0b657de910d 100644
@@ -58,6 +58,12 @@ Querying capabilities
      default values for these controls being used, and a returned set of formats
      that may not be usable for the media the client is trying to decode.
 
+   * If the ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS`` flag is set the driver must enumerate
+     all the supported formats without taking care of codec-dependent controls
+     set on the ``OUTPUT`` queue. To indicate that the driver has take care of this
+     flag it must set ``V4L2_FMT_FLAG_ALL_FORMATS`` flag for each format while
+     enumerating.
+
 3. The client may use :c:func:`VIDIOC_ENUM_FRAMESIZES` to detect supported
    resolutions for a given format, passing desired pixel format in
    :c:type:`v4l2_frmsizeenum`'s ``pixel_format``.
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +9 -0
index 3adb3d205531..0399e0fc09b3 100644
@@ -234,6 +234,15 @@ the ``mbus_code`` field is handled differently:
 	valid. The buffer consists of ``height`` lines, each having ``width``
 	Data Units of data and the offset (in bytes) between the beginning of
 	each two consecutive lines is ``bytesperline``.
+    * - ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS``
+      - 0x0400
+      - Set by userland applications to enumerate all possible pixel formats
+        without taking care of any OUTPUT or CAPTURE queue configuration.
+    * - ``V4L2_FMT_FLAG_ALL_FORMATS``
+      - 0x0800
+      - Set by the driver to indicated that format have been enumerated because
+        :ref:`V4L2_FMT_FLAG_ENUM_ALL_FORMATS <v4l2-pix-fmt-flag-set-csc>` has
+        been set by the userland application.
 
 Return Value
 ============
Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 -0
index bdc628e8c1d6..7a3a1e9dc055 100644
@@ -216,6 +216,8 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
 replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
 replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
 replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
+replace define V4L2_FMT_FLAG_ENUM_ALL_FORMATS fmtdesc-flags
+replace define V4L2_FMT_FLAG_ALL_FORMATS fmtdesc-flags
 
 # V4L2 timecode types
 replace define V4L2_TC_TYPE_24FPS timecode-type
drivers/media/v4l2-core/v4l2-ioctl.c +3 -0
index 4c76d17b4629..5785a98b6ba2 100644
@@ -1569,6 +1569,7 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
 	int ret = check_fmt(file, p->type);
 	u32 mbus_code;
 	u32 cap_mask;
+	u32 flags;
 
 	if (ret)
 		return ret;
@@ -1578,8 +1579,10 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
 		p->mbus_code = 0;
 
 	mbus_code = p->mbus_code;
+	flags = p->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS;
 	memset_after(p, 0, type);
 	p->mbus_code = mbus_code;
+	p->flags = flags;
 
 	switch (p->type) {
 	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
include/uapi/linux/videodev2.h +2 -0
index fe6b67e83751..b6a5da79ba21 100644
@@ -886,6 +886,8 @@ struct v4l2_fmtdesc {
 #define V4L2_FMT_FLAG_CSC_HSV_ENC		V4L2_FMT_FLAG_CSC_YCBCR_ENC
 #define V4L2_FMT_FLAG_CSC_QUANTIZATION		0x0100
 #define V4L2_FMT_FLAG_META_LINE_BASED		0x0200
+#define V4L2_FMT_FLAG_ENUM_ALL_FORMATS		0x0400
+#define V4L2_FMT_FLAG_ALL_FORMATS		0x0800
 
 	/* Frame Size and frame rate enumeration */
 /*
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH v3 1/2] media: videodev2: Add flags to unconditionnaly enumerate pixels formats

Hi Benjamin

Quoted 48 lines · Benjamin Gaignard

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl. When this V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag is set drivers must ignore the configuration and return the hardware supported pixel formats for the specified queue.
To distinguish this particular enumeration case V4L2_FMT_FLAG_ALL_FORMATS flag must be set by the drivers to highlight support of this feature to user space applications.
This will permit to discover which pixel formats are supported without setting codec-specific information so userland can more easily know if the driver suits its needs well.
The main target are stateless decoders so update the documentation about how to use this flag.

---
changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

 .../userspace-api/media/v4l/dev-stateless-decoder.rst    | 6 ++++++
 .../userspace-api/media/v4l/vidioc-enum-fmt.rst          | 9 +++++++++
 .../userspace-api/media/videodev2.h.rst.exceptions       | 2 ++
 drivers/media/v4l2-core/v4l2-ioctl.c                     | 3 +++
 include/uapi/linux/videodev2.h                           | 2 ++
 5 files changed, 22 insertions(+)
Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst +6 -0
index 35ed05f2695e..b0b657de910d 100644
@@ -58,6 +58,12 @@ Querying capabilities
      default values for these controls being used, and a returned set of formats
      that may not be usable for the media the client is trying to decode.
 
+   * If the ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS`` flag is set the driver must enumerate
+     all the supported formats without taking care of codec-dependent controls
+     set on the ``OUTPUT`` queue. To indicate that the driver has take care of this
+     flag it must set ``V4L2_FMT_FLAG_ALL_FORMATS`` flag for each format while
+     enumerating.
+
 3. The client may use :c:func:`VIDIOC_ENUM_FRAMESIZES` to detect supported
    resolutions for a given format, passing desired pixel format in
    :c:type:`v4l2_frmsizeenum`'s ``pixel_format``.
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +0 -0
index 3adb3d205531..0399e0fc09b3 100644

Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst the ``mbus_code`` field is handled differently: · line 240

Quoted 7 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +4 -0
@@ -234,6 +234,15 @@ the ``mbus_code`` field is handled differently:
 	valid. The buffer consists of ``height`` lines, each having ``width``
 	Data Units of data and the offset (in bytes) between the beginning of
 	each two consecutive lines is ``bytesperline``.
+    * - ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS``
+      - 0x0400
+      - Set by userland applications to enumerate all possible pixel formats
+        without taking care of any OUTPUT or CAPTURE queue configuration.

This seems to be only relevant for codecs and m2m devices.

For 'regular' capture (and I presume output) devices isn't the default behaviour to enumerate all pixel formats, and userspace can decide to restrict them by providing a media bus code (if the device reports the V4L2_CAP_IO_MC capability)

Quoted 61 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +5 -0
+    * - ``V4L2_FMT_FLAG_ALL_FORMATS``
+      - 0x0800
+      - Set by the driver to indicated that format have been enumerated because
+        :ref:`V4L2_FMT_FLAG_ENUM_ALL_FORMATS <v4l2-pix-fmt-flag-set-csc>` has
+        been set by the userland application.
 
 Return Value
 ============
Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 -0
index bdc628e8c1d6..7a3a1e9dc055 100644
@@ -216,6 +216,8 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
 replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
 replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
 replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
+replace define V4L2_FMT_FLAG_ENUM_ALL_FORMATS fmtdesc-flags
+replace define V4L2_FMT_FLAG_ALL_FORMATS fmtdesc-flags
 
 # V4L2 timecode types
 replace define V4L2_TC_TYPE_24FPS timecode-type
drivers/media/v4l2-core/v4l2-ioctl.c +3 -0
index 4c76d17b4629..5785a98b6ba2 100644
@@ -1569,6 +1569,7 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
 	int ret = check_fmt(file, p->type);
 	u32 mbus_code;
 	u32 cap_mask;
+	u32 flags;
 
 	if (ret)
 		return ret;
@@ -1578,8 +1579,10 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
 		p->mbus_code = 0;
 
 	mbus_code = p->mbus_code;
+	flags = p->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS;
 	memset_after(p, 0, type);
 	p->mbus_code = mbus_code;
+	p->flags = flags;
 
 	switch (p->type) {
 	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
include/uapi/linux/videodev2.h +2 -1
index fe6b67e83751..b6a5da79ba21 100644
@@ -886,6 +886,8 @@ struct v4l2_fmtdesc {
 #define V4L2_FMT_FLAG_CSC_HSV_ENC		V4L2_FMT_FLAG_CSC_YCBCR_ENC
 #define V4L2_FMT_FLAG_CSC_QUANTIZATION		0x0100
 #define V4L2_FMT_FLAG_META_LINE_BASED		0x0200
+#define V4L2_FMT_FLAG_ENUM_ALL_FORMATS		0x0400
+#define V4L2_FMT_FLAG_ALL_FORMATS		0x0800
 
 	/* Frame Size and frame rate enumeration */
 /*
--

2.43.0

author maintainer
#3 lore raw

Re: [PATCH v3 1/2] media: videodev2: Add flags to unconditionnaly enumerate pixels formats

Le 12/07/2024 à 18:31, Jacopo Mondi a écrit :

Quoted 60 lines

Hi Benjamin

Quoted 48 lines · Benjamin Gaignard

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl. When this V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag is set drivers must ignore the configuration and return the hardware supported pixel formats for the specified queue.
To distinguish this particular enumeration case V4L2_FMT_FLAG_ALL_FORMATS flag must be set by the drivers to highlight support of this feature to user space applications.
This will permit to discover which pixel formats are supported without setting codec-specific information so userland can more easily know if the driver suits its needs well.
The main target are stateless decoders so update the documentation about how to use this flag.

---
changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

  .../userspace-api/media/v4l/dev-stateless-decoder.rst    | 6 ++++++
  .../userspace-api/media/v4l/vidioc-enum-fmt.rst          | 9 +++++++++
  .../userspace-api/media/videodev2.h.rst.exceptions       | 2 ++
  drivers/media/v4l2-core/v4l2-ioctl.c                     | 3 +++
  include/uapi/linux/videodev2.h                           | 2 ++
  5 files changed, 22 insertions(+)
Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst +6 -0
index 35ed05f2695e..b0b657de910d 100644
@@ -58,6 +58,12 @@ Querying capabilities
       default values for these controls being used, and a returned set of formats
       that may not be usable for the media the client is trying to decode.
 
+   * If the ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS`` flag is set the driver must enumerate
+     all the supported formats without taking care of codec-dependent controls
+     set on the ``OUTPUT`` queue. To indicate that the driver has take care of this
+     flag it must set ``V4L2_FMT_FLAG_ALL_FORMATS`` flag for each format while
+     enumerating.
+
  3. The client may use :c:func:`VIDIOC_ENUM_FRAMESIZES` to detect supported
     resolutions for a given format, passing desired pixel format in
     :c:type:`v4l2_frmsizeenum`'s ``pixel_format``.
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +0 -0
index 3adb3d205531..0399e0fc09b3 100644

Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst the ``mbus_code`` field is handled differently: · line 240

Quoted 7 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +4 -0
@@ -234,6 +234,15 @@ the ``mbus_code`` field is handled differently:
  	valid. The buffer consists of ``height`` lines, each having ``width``
  	Data Units of data and the offset (in bytes) between the beginning of
  	each two consecutive lines is ``bytesperline``.
+    * - ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS``
+      - 0x0400
+      - Set by userland applications to enumerate all possible pixel formats
+        without taking care of any OUTPUT or CAPTURE queue configuration.

This seems to be only relevant for codecs and m2m devices.

Quoted 4 lines

For 'regular' capture (and I presume output) devices isn't the default behaviour to enumerate all pixel formats, and userspace can decide to restrict them by providing a media bus code (if the device reports the V4L2_CAP_IO_MC capability)

Yes is targeting codecs because they have two queues. When device have only one queue, like 'regular' capture devices, pixel enumeration doesn't have to take care of the other queue configuration because it doesn't exist.

Quoted 63 lines
Quoted 63 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +5 -0
+    * - ``V4L2_FMT_FLAG_ALL_FORMATS``
+      - 0x0800
+      - Set by the driver to indicated that format have been enumerated because
+        :ref:`V4L2_FMT_FLAG_ENUM_ALL_FORMATS <v4l2-pix-fmt-flag-set-csc>` has
+        been set by the userland application.
 
  Return Value
  ============
Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 -0
index bdc628e8c1d6..7a3a1e9dc055 100644
@@ -216,6 +216,8 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
  replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
  replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
  replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
+replace define V4L2_FMT_FLAG_ENUM_ALL_FORMATS fmtdesc-flags
+replace define V4L2_FMT_FLAG_ALL_FORMATS fmtdesc-flags
 
  # V4L2 timecode types
  replace define V4L2_TC_TYPE_24FPS timecode-type
drivers/media/v4l2-core/v4l2-ioctl.c +3 -0
index 4c76d17b4629..5785a98b6ba2 100644
@@ -1569,6 +1569,7 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
  	int ret = check_fmt(file, p->type);
  	u32 mbus_code;
  	u32 cap_mask;
+	u32 flags;
 
  	if (ret)
  		return ret;
@@ -1578,8 +1579,10 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
  		p->mbus_code = 0;
 
  	mbus_code = p->mbus_code;
+	flags = p->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS;
  	memset_after(p, 0, type);
  	p->mbus_code = mbus_code;
+	p->flags = flags;
 
  	switch (p->type) {
  	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
include/uapi/linux/videodev2.h +2 -1
index fe6b67e83751..b6a5da79ba21 100644
@@ -886,6 +886,8 @@ struct v4l2_fmtdesc {
  #define V4L2_FMT_FLAG_CSC_HSV_ENC		V4L2_FMT_FLAG_CSC_YCBCR_ENC
  #define V4L2_FMT_FLAG_CSC_QUANTIZATION		0x0100
  #define V4L2_FMT_FLAG_META_LINE_BASED		0x0200
+#define V4L2_FMT_FLAG_ENUM_ALL_FORMATS		0x0400
+#define V4L2_FMT_FLAG_ALL_FORMATS		0x0800
 
  	/* Frame Size and frame rate enumeration */
  /*
--

2.43.0

#4 lore raw

Re: [PATCH v3 1/2] media: videodev2: Add flags to unconditionnaly enumerate pixels formats

Hi Benjamin

Quoted 62 lines · Benjamin Gaignard

Le 12/07/2024 à 18:31, Jacopo Mondi a écrit :

Quoted 60 lines

Hi Benjamin

Quoted 48 lines · Benjamin Gaignard

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl. When this V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag is set drivers must ignore the configuration and return the hardware supported pixel formats for the specified queue.
To distinguish this particular enumeration case V4L2_FMT_FLAG_ALL_FORMATS flag must be set by the drivers to highlight support of this feature to user space applications.
This will permit to discover which pixel formats are supported without setting codec-specific information so userland can more easily know if the driver suits its needs well.
The main target are stateless decoders so update the documentation about how to use this flag.

---
changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

  .../userspace-api/media/v4l/dev-stateless-decoder.rst    | 6 ++++++
  .../userspace-api/media/v4l/vidioc-enum-fmt.rst          | 9 +++++++++
  .../userspace-api/media/videodev2.h.rst.exceptions       | 2 ++
  drivers/media/v4l2-core/v4l2-ioctl.c                     | 3 +++
  include/uapi/linux/videodev2.h                           | 2 ++
  5 files changed, 22 insertions(+)
Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst +6 -0
index 35ed05f2695e..b0b657de910d 100644
@@ -58,6 +58,12 @@ Querying capabilities
       default values for these controls being used, and a returned set of formats
       that may not be usable for the media the client is trying to decode.
 
+   * If the ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS`` flag is set the driver must enumerate
+     all the supported formats without taking care of codec-dependent controls
+     set on the ``OUTPUT`` queue. To indicate that the driver has take care of this
+     flag it must set ``V4L2_FMT_FLAG_ALL_FORMATS`` flag for each format while
+     enumerating.
+
  3. The client may use :c:func:`VIDIOC_ENUM_FRAMESIZES` to detect supported
     resolutions for a given format, passing desired pixel format in
     :c:type:`v4l2_frmsizeenum`'s ``pixel_format``.
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +0 -0
index 3adb3d205531..0399e0fc09b3 100644

Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst the ``mbus_code`` field is handled differently: · line 240

Quoted 7 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +4 -0
@@ -234,6 +234,15 @@ the ``mbus_code`` field is handled differently:
  	valid. The buffer consists of ``height`` lines, each having ``width``
  	Data Units of data and the offset (in bytes) between the beginning of
  	each two consecutive lines is ``bytesperline``.
+    * - ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS``
+      - 0x0400
+      - Set by userland applications to enumerate all possible pixel formats
+        without taking care of any OUTPUT or CAPTURE queue configuration.

This seems to be only relevant for codecs and m2m devices.

Quoted 6 lines
Quoted 4 lines

For 'regular' capture (and I presume output) devices isn't the default behaviour to enumerate all pixel formats, and userspace can decide to restrict them by providing a media bus code (if the device reports the V4L2_CAP_IO_MC capability)

Yes is targeting codecs because they have two queues.

Well, m2m devices in general then

Quoted 4 lines

When device have only one queue, like 'regular' capture devices, pixel enumeration doesn't have to take care of the other queue configuration because it doesn't exist.

This probably needs to be captured in the description here ? We already have flags which apply only to some device types, and that's specified in the flag description

* - ``V4L2_FMT_FLAG_CSC_QUANTIZATION``
- 0x0100
- The driver allows the application to try to change the default quantization. This flag is relevant only for capture devices.

Quoted 64 lines
Quoted 63 lines
Quoted 63 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +5 -0
+    * - ``V4L2_FMT_FLAG_ALL_FORMATS``
+      - 0x0800
+      - Set by the driver to indicated that format have been enumerated because
+        :ref:`V4L2_FMT_FLAG_ENUM_ALL_FORMATS <v4l2-pix-fmt-flag-set-csc>` has
+        been set by the userland application.
 
  Return Value
  ============
Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 -0
index bdc628e8c1d6..7a3a1e9dc055 100644
@@ -216,6 +216,8 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
  replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
  replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
  replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
+replace define V4L2_FMT_FLAG_ENUM_ALL_FORMATS fmtdesc-flags
+replace define V4L2_FMT_FLAG_ALL_FORMATS fmtdesc-flags
 
  # V4L2 timecode types
  replace define V4L2_TC_TYPE_24FPS timecode-type
drivers/media/v4l2-core/v4l2-ioctl.c +3 -0
index 4c76d17b4629..5785a98b6ba2 100644
@@ -1569,6 +1569,7 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
  	int ret = check_fmt(file, p->type);
  	u32 mbus_code;
  	u32 cap_mask;
+	u32 flags;
 
  	if (ret)
  		return ret;
@@ -1578,8 +1579,10 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
  		p->mbus_code = 0;
 
  	mbus_code = p->mbus_code;
+	flags = p->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS;
  	memset_after(p, 0, type);
  	p->mbus_code = mbus_code;
+	p->flags = flags;
 
  	switch (p->type) {
  	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
include/uapi/linux/videodev2.h +2 -1
index fe6b67e83751..b6a5da79ba21 100644
@@ -886,6 +886,8 @@ struct v4l2_fmtdesc {
  #define V4L2_FMT_FLAG_CSC_HSV_ENC		V4L2_FMT_FLAG_CSC_YCBCR_ENC
  #define V4L2_FMT_FLAG_CSC_QUANTIZATION		0x0100
  #define V4L2_FMT_FLAG_META_LINE_BASED		0x0200
+#define V4L2_FMT_FLAG_ENUM_ALL_FORMATS		0x0400
+#define V4L2_FMT_FLAG_ALL_FORMATS		0x0800
 
  	/* Frame Size and frame rate enumeration */
  /*
--

2.43.0

author maintainer
#5 lore raw

Re: [PATCH v3 1/2] media: videodev2: Add flags to unconditionnaly enumerate pixels formats

Le 15/07/2024 à 15:37, Jacopo Mondi a écrit :

Quoted 75 lines

Hi Benjamin

Quoted 61 lines · Benjamin Gaignard

Le 12/07/2024 à 18:31, Jacopo Mondi a écrit :

Quoted 60 lines

Hi Benjamin

Quoted 48 lines · Benjamin Gaignard

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl. When this V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag is set drivers must ignore the configuration and return the hardware supported pixel formats for the specified queue.
To distinguish this particular enumeration case V4L2_FMT_FLAG_ALL_FORMATS flag must be set by the drivers to highlight support of this feature to user space applications.
This will permit to discover which pixel formats are supported without setting codec-specific information so userland can more easily know if the driver suits its needs well.
The main target are stateless decoders so update the documentation about how to use this flag.

---
changes in version 3:
- Add a flag to inform userspace application that driver as take care of the flag.

   .../userspace-api/media/v4l/dev-stateless-decoder.rst    | 6 ++++++
   .../userspace-api/media/v4l/vidioc-enum-fmt.rst          | 9 +++++++++
   .../userspace-api/media/videodev2.h.rst.exceptions       | 2 ++
   drivers/media/v4l2-core/v4l2-ioctl.c                     | 3 +++
   include/uapi/linux/videodev2.h                           | 2 ++
   5 files changed, 22 insertions(+)
Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst +6 -0
index 35ed05f2695e..b0b657de910d 100644
@@ -58,6 +58,12 @@ Querying capabilities
        default values for these controls being used, and a returned set of formats
        that may not be usable for the media the client is trying to decode.
 
+   * If the ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS`` flag is set the driver must enumerate
+     all the supported formats without taking care of codec-dependent controls
+     set on the ``OUTPUT`` queue. To indicate that the driver has take care of this
+     flag it must set ``V4L2_FMT_FLAG_ALL_FORMATS`` flag for each format while
+     enumerating.
+
   3. The client may use :c:func:`VIDIOC_ENUM_FRAMESIZES` to detect supported
      resolutions for a given format, passing desired pixel format in
      :c:type:`v4l2_frmsizeenum`'s ``pixel_format``.
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +0 -0
index 3adb3d205531..0399e0fc09b3 100644

Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst the ``mbus_code`` field is handled differently: · line 240

Quoted 7 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +4 -0
@@ -234,6 +234,15 @@ the ``mbus_code`` field is handled differently:
   	valid. The buffer consists of ``height`` lines, each having ``width``
   	Data Units of data and the offset (in bytes) between the beginning of
   	each two consecutive lines is ``bytesperline``.
+    * - ``V4L2_FMT_FLAG_ENUM_ALL_FORMATS``
+      - 0x0400
+      - Set by userland applications to enumerate all possible pixel formats
+        without taking care of any OUTPUT or CAPTURE queue configuration.

This seems to be only relevant for codecs and m2m devices.

Quoted 5 lines
Quoted 4 lines

For 'regular' capture (and I presume output) devices isn't the default behaviour to enumerate all pixel formats, and userspace can decide to restrict them by providing a media bus code (if the device reports the V4L2_CAP_IO_MC capability)

Yes is targeting codecs because they have two queues.

Well, m2m devices in general then

Quoted 4 lines

When device have only one queue, like 'regular' capture devices, pixel enumeration doesn't have to take care of the other queue configuration because it doesn't exist.

Quoted 8 lines

This probably needs to be captured in the description here ? We already have flags which apply only to some device types, and that's specified in the flag description

* - ``V4L2_FMT_FLAG_CSC_QUANTIZATION``
- 0x0100
- The driver allows the application to try to change the default quantization. This flag is relevant only for capture devices.

That makes sense I will update the flags description in the next version.

Thanks,
Benjamin

Quoted 63 lines
Quoted 63 lines
Quoted 63 lines
Quoted 63 lines
Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst +5 -0
+    * - ``V4L2_FMT_FLAG_ALL_FORMATS``
+      - 0x0800
+      - Set by the driver to indicated that format have been enumerated because
+        :ref:`V4L2_FMT_FLAG_ENUM_ALL_FORMATS <v4l2-pix-fmt-flag-set-csc>` has
+        been set by the userland application.
 
   Return Value
   ============
Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 -0
index bdc628e8c1d6..7a3a1e9dc055 100644
@@ -216,6 +216,8 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
   replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
   replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
   replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
+replace define V4L2_FMT_FLAG_ENUM_ALL_FORMATS fmtdesc-flags
+replace define V4L2_FMT_FLAG_ALL_FORMATS fmtdesc-flags
 
   # V4L2 timecode types
   replace define V4L2_TC_TYPE_24FPS timecode-type
drivers/media/v4l2-core/v4l2-ioctl.c +3 -0
index 4c76d17b4629..5785a98b6ba2 100644
@@ -1569,6 +1569,7 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
   	int ret = check_fmt(file, p->type);
   	u32 mbus_code;
   	u32 cap_mask;
+	u32 flags;
 
   	if (ret)
   		return ret;
@@ -1578,8 +1579,10 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
   		p->mbus_code = 0;
 
   	mbus_code = p->mbus_code;
+	flags = p->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS;
   	memset_after(p, 0, type);
   	p->mbus_code = mbus_code;
+	p->flags = flags;
 
   	switch (p->type) {
   	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
include/uapi/linux/videodev2.h +2 -1
index fe6b67e83751..b6a5da79ba21 100644
@@ -886,6 +886,8 @@ struct v4l2_fmtdesc {
   #define V4L2_FMT_FLAG_CSC_HSV_ENC		V4L2_FMT_FLAG_CSC_YCBCR_ENC
   #define V4L2_FMT_FLAG_CSC_QUANTIZATION		0x0100
   #define V4L2_FMT_FLAG_META_LINE_BASED		0x0200
+#define V4L2_FMT_FLAG_ENUM_ALL_FORMATS		0x0400
+#define V4L2_FMT_FLAG_ALL_FORMATS		0x0800
 
   	/* Frame Size and frame rate enumeration */
   /*
--

2.43.0

#6 lore raw

Re: [PATCH v3 1/2] media: videodev2: Add flags to unconditionnaly enumerate pixels formats

In reply to Benjamin Gaignard
Quoted 1 line

Add new flags to enumerate all pixels formats when calling VIDIOC_ENUM_FMT ioctl.

…

Will the word “unconditionally” be more appropriate for the next summary phrase?

Regards,
Markus

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author maintainer
#7 lore raw

PATCH v3 2/2 media: verisilicon: Use V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag

In reply to Benjamin Gaignard

If V4L2_FMT_FLAG_ENUM_ALL_FORMATS flag has been set when calling VIDIOC_ENUM_FMT ignore depth match and returns all the hardware supported pixels formats. In this case all set V4L2_FMT_FLAG_ALL_FORMATS when returning the pixels formats.

---
version 3:
- Set V4L2_FMT_FLAG_ALL_FORMATS flag when needed.

 drivers/media/platform/verisilicon/hantro_v4l2.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/media/platform/verisilicon/hantro_v4l2.c +13 -3
index df6f2536263b..b995ad31cddc 100644
@@ -201,7 +201,13 @@ static int vidioc_enum_fmt(struct file *file, void *priv,
 	struct hantro_ctx *ctx = fh_to_ctx(priv);
 	const struct hantro_fmt *fmt, *formats;
 	unsigned int num_fmts, i, j = 0;
-	bool skip_mode_none;
+	bool skip_mode_none, ignore_depth_match;
+
+	/*
+	 * If V4L2_FMT_FLAG_ALL_FORMATS flag is set, we want to enumerate all
+	 * hardware supported pixels formats
+	 */
+	ignore_depth_match = !!(f->flags & V4L2_FMT_FLAG_ENUM_ALL_FORMATS);
 
 	/*
 	 * When dealing with an encoder:
@@ -222,10 +228,12 @@ static int vidioc_enum_fmt(struct file *file, void *priv,
 
 		if (skip_mode_none == mode_none)
 			continue;
-		if (!hantro_check_depth_match(fmt, ctx->bit_depth))
+		if (!hantro_check_depth_match(fmt, ctx->bit_depth) && !ignore_depth_match)
 			continue;
 		if (j == f->index) {
 			f->pixelformat = fmt->fourcc;
+			if (ignore_depth_match)
+				f->flags |= V4L2_FMT_FLAG_ALL_FORMATS;
 			return 0;
 		}
 		++j;
@@ -242,10 +250,12 @@ static int vidioc_enum_fmt(struct file *file, void *priv,
 	for (i = 0; i < num_fmts; i++) {
 		fmt = &formats[i];
 
-		if (!hantro_check_depth_match(fmt, ctx->bit_depth))
+		if (!hantro_check_depth_match(fmt, ctx->bit_depth) && !ignore_depth_match)
 			continue;
 		if (j == f->index) {
 			f->pixelformat = fmt->fourcc;
+			if (ignore_depth_match)
+				f->flags |= V4L2_FMT_FLAG_ALL_FORMATS;
 			return 0;
 		}
 		++j;
Signature · 1 line
2.43.0