Skip to contentSkip to conversation

arm64: tegra: Correct location of INA219 for IGX Orin

PATCH Superseded Jon Hunter 2 participants 3 messages Jul 12, 2024 – Aug 27, 2024

Subsystems (2)
Device tree bindings Tegra architecture support
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 arm64: tegra: Correct location of INA219 for IGX Orin

The INA219 power-sensor is located on the carrier board and not the module board and so update the IGX Orin device-tree files to fix this.

Fixes 9152ed09309d ("arm64: tegra: Add power-sensors for Tegra234 boards")
Signed-off-by Jon Hunter <[email protected]>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3701-0008.dtsi | 6 ------
 arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi | 8 ++++++++
 2 files changed, 8 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0008.dtsi +0 -6
index 553fa4ba1cd4..b58b9c496988 100644
@@ -69,12 +69,6 @@ input@2 {
 					shunt-resistor-micro-ohms = <2000>;
 				};
 			};
-
-			power-sensor@44 {
-				compatible = "ti,ina219";
-				reg = <0x44>;
-				shunt-resistor = <2000>;
-			};
 		};
 
 		rtc@c2a0000 {
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi +8 -0
index 527f2f3aee3a..03bdb71ae0cf 100644
@@ -183,6 +183,14 @@ usb@3610000 {
 			phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3",
 				"usb3-0", "usb3-1", "usb3-2";
 		};
+
+		i2c@c250000 {
+			power-sensor@44 {
+				compatible = "ti,ina219";
+				reg = <0x44>;
+				shunt-resistor = <2000>;
+			};
+		};
 	};
 
 	vdd_3v3_dp: regulator-vdd-3v3-dp {
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH v2 1/1 arm64: tegra: Correct location of power-sensors for IGX Orin

The power-sensors are located on the carrier board and not the module board and so update the IGX Orin device-tree files to fix this.

Fixes 9152ed09309d ("arm64: tegra: Add power-sensors for Tegra234 boards")
Signed-off-by Jon Hunter <[email protected]>

---
Changes since V1:
- Updated subject from "arm64: tegra: Correct location of INA219 for IGX Orin"
- Moved both the INA219 and INA3221 power-sensors

 .../boot/dts/nvidia/tegra234-p3701-0008.dtsi  | 33 -------------------
 .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 33 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0008.dtsi +0 -33
index 553fa4ba1cd4..62c4fdad0b60 100644
@@ -44,39 +44,6 @@ i2c@c240000 {
 			status = "okay";
 		};
 
-		i2c@c250000 {
-			power-sensor@41 {
-				compatible = "ti,ina3221";
-				reg = <0x41>;
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				input@0 {
-					reg = <0x0>;
-					label = "CVB_ATX_12V";
-					shunt-resistor-micro-ohms = <2000>;
-				};
-
-				input@1 {
-					reg = <0x1>;
-					label = "CVB_ATX_3V3";
-					shunt-resistor-micro-ohms = <2000>;
-				};
-
-				input@2 {
-					reg = <0x2>;
-					label = "CVB_ATX_5V";
-					shunt-resistor-micro-ohms = <2000>;
-				};
-			};
-
-			power-sensor@44 {
-				compatible = "ti,ina219";
-				reg = <0x44>;
-				shunt-resistor = <2000>;
-			};
-		};
-
 		rtc@c2a0000 {
 			status = "okay";
 		};
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi +33 -0
index 527f2f3aee3a..377f518bd3e5 100644
@@ -183,6 +183,39 @@ usb@3610000 {
 			phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3",
 				"usb3-0", "usb3-1", "usb3-2";
 		};
+
+		i2c@c250000 {
+			power-sensor@41 {
+				compatible = "ti,ina3221";
+				reg = <0x41>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				input@0 {
+					reg = <0x0>;
+					label = "CVB_ATX_12V";
+					shunt-resistor-micro-ohms = <2000>;
+				};
+
+				input@1 {
+					reg = <0x1>;
+					label = "CVB_ATX_3V3";
+					shunt-resistor-micro-ohms = <2000>;
+				};
+
+				input@2 {
+					reg = <0x2>;
+					label = "CVB_ATX_5V";
+					shunt-resistor-micro-ohms = <2000>;
+				};
+			};
+
+			power-sensor@44 {
+				compatible = "ti,ina219";
+				reg = <0x44>;
+				shunt-resistor = <2000>;
+			};
+		};
 	};
 
 	vdd_3v3_dp: regulator-vdd-3v3-dp {
Signature · 1 line
2.34.1
Applied
#2 lore raw

Re: [PATCH V2] arm64: tegra: Correct location of power-sensors for IGX Orin

From: Thierry Reding <[email protected]>

Quoted 4 lines · Jon Hunter

The power-sensors are located on the carrier board and not the module board and so update the IGX Orin device-tree files to fix this.

Applied, thanks!

[1/1] arm64: tegra: Correct location of power-sensors for IGX Orin

      commit: b93679b8f165467e1584f9b23055db83f45c32ce

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>