Skip to contentSkip to conversation

configs/stm32mp157c_dk2: bump Linux to 6.9

PATCH In review Raphael Gallais-Pou 2 participants 3 messages Jul 12, 2024 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/stm32mp157c_dk2: bump Linux to 6.9

Base config on latest kernel version available.

---
 configs/stm32mp157c_dk2_defconfig | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)
configs/stm32mp157c_dk2_defconfig +2 -18
index c48705b2fb..0e26042b90 100644
@@ -1,31 +1,17 @@
-# Architecture
 BR2_arm=y
 BR2_cortex_a7=y
-
-# Linux headers same as kernel, a 5.13 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y
-
-# System configuration
 BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
-
-# Kernel
 BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/stmicroelectronics/stm32mp157c-dk2/linux.config"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32mp157c-dk2"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="st/stm32mp157c-dk2"
 BR2_LINUX_KERNEL_INSTALL_TARGET=y
-
-# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
 # BR2_TARGET_ROOTFS_TAR is not set
-
-# Bootloaders
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_LATEST_LTS_2_8_VERSION=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="stm32mp1"
@@ -41,13 +27,11 @@ BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="stm32mp15_trusted"
-# BR2_TARGET_UBOOT_FORMAT_BIN is not set
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+# BR2_TARGET_UBOOT_FORMAT_BIN is not set
 BR2_TARGET_UBOOT_FORMAT_DTB=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-nodtb.bin"
 BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=stm32mp157c-dk2"
-
-# Additional tools
 BR2_PACKAGE_HOST_GENIMAGE=y
Signature · 6 lines
2.45.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Raphael,

Thanks for your patch. See below a review.

Quoted 12 lines · On Fri, 12 Jul 2024 20:27:12 +0200 Raphael Gallais-Pou <[email protected]>…

Base config on latest kernel version available.

---
 configs/stm32mp157c_dk2_defconfig | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)
configs/stm32mp157c_dk2_defconfig +0 -0
index c48705b2fb..0e26042b90 100644

configs/stm32mp157c_dk2_defconfig line 6

Quoted 6 lines
configs/stm32mp157c_dk2_defconfig +0 -4
@@ -1,31 +1,17 @@
-# Architecture
 BR2_arm=y
 BR2_cortex_a7=y
-
-# Linux headers same as kernel, a 5.13 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y

Please keep the comments and this option (but updated). It seems like you did a "make savedefconfig", without really worrying about what changed.

configs/stm32mp157c_dk2_defconfig line 15

Quoted 9 lines
configs/stm32mp157c_dk2_defconfig +0 -6
-
-# System configuration
 BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
-
-# Kernel
 BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"

We need to keep an explicit kernel version, so that it doesn't automatically uses the "latest".

I believe it would also make sense to update TF-A and U-Boot at the same time.

Could you fix up those details, and submit an updated version?

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Le 12/07/2024 à 21:11, Thomas Petazzoni a écrit :

Quoted 14 lines

Hello Raphael,

Thanks for your patch. See below a review.

Quoted 7 lines · On Fri, 12 Jul 2024 20:27:12 +0200 Raphael Gallais-Pou <[email protected]>…

Base config on latest kernel version available.

---
  configs/stm32mp157c_dk2_defconfig | 20 ++------------------
  1 file changed, 2 insertions(+), 18 deletions(-)
Quoted 16 lines

configs/stm32mp157c_dk2_defconfig line 6

Quoted 11 lines
configs/stm32mp157c_dk2_defconfig +0 -4
index c48705b2fb..0e26042b90 100644
@@ -1,31 +1,17 @@
-# Architecture
  BR2_arm=y
  BR2_cortex_a7=y
-
-# Linux headers same as kernel, a 5.13 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y

Please keep the comments and this option (but updated). It seems like you did a "make savedefconfig", without really worrying about what changed.

Hi Thomas,

Thanks for the quick review.

Indeed, this is exactly what I did. I (wrongly) did not compared with similar changes even though this was my first contribution to Buildroot.

My bad.

Quoted 4 lines
Quoted 4 lines
configs/stm32mp157c_dk2_defconfig +0 -2
-
-# System configuration
  BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
Quoted 8 lines

configs/stm32mp157c_dk2_defconfig line 15

Quoted 5 lines
configs/stm32mp157c_dk2_defconfig +0 -4
-
-# Kernel
  BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"

We need to keep an explicit kernel version, so that it doesn't automatically uses the "latest".

Makes sense in order not to introduce systematic uncontrolled breaks in the swarm of boards.

Quoted 5 lines

I believe it would also make sense to update TF-A and U-Boot at the same time.

Could you fix up those details, and submit an updated version?

Yes, I'll do some testing before and then send a v2.

Thanks,
Raphaël

Quoted 4 lines

Thanks a lot!

Thomas

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot