meson: Use -fno-sanitize=function when available
PATCH 1/1 meson: Use -fno-sanitize=function when available
Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in the other context. Move it to meson.build.
--- meson.build | 1 + .gitlab-ci.d/buildtest.yml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -0
@@ -609,6 +609,7 @@ if host_os != 'openbsd' and \ endif qemu_common_flags += cc.get_supported_arguments(hardening_flags) +qemu_common_flags += cc.get_supported_arguments('-fno-sanitize=function') add_global_arguments(qemu_common_flags, native: false, language: all_languages) add_global_link_arguments(qemu_ldflags, native: false, language: all_languages)
.gitlab-ci.d/buildtest.yml +0 -1
@@ -430,7 +430,6 @@ clang-system: IMAGE: fedora CONFIGURE_ARGS: --cc=clang --cxx=clang++ --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined - --extra-cflags=-fno-sanitize=function TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu s390x-softmmu MAKE_CHECK_ARGS: check-qtest check-tcg
---
base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
change-id: 20240714-function-7d32c723abbc
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>
Quoted 16 lines · Akihiko Odaki
Commit
23ef50ae2d0c(".gitlab-ci.d/buildtest.yml: Use(quoted diff) +0
-2-fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in theother context. Move it to meson.build.
Signed-off-by Akihiko Odaki <[email protected]>--- meson.build | 1 + .gitlab-ci.d/buildtest.yml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)meson.build +0
-0
meson.build if host_os != 'openbsd' and \ · line 613
Quoted 5 lines
meson.build +1
-0@@ -609,6 +609,7 @@ if host_os != 'openbsd' and \ endif qemu_common_flags += cc.get_supported_arguments(hardening_flags) +qemu_common_flags += cc.get_supported_arguments('-fno-sanitize=function')
What about checking the other hardening flags?
Quoted 21 lines
meson.build +0
-0add_global_arguments(qemu_common_flags, native: false, language: all_languages) add_global_link_arguments(qemu_ldflags, native: false, language: all_languages).gitlab-ci.d/buildtest.yml +0
-2@@ -430,7 +430,6 @@ clang-system: IMAGE: fedora CONFIGURE_ARGS: --cc=clang --cxx=clang++ --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined - --extra-cflags=-fno-sanitize=function TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu s390x-softmmu MAKE_CHECK_ARGS: check-qtest check-tcg ---base-commit:
f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
change-id: 20240714-function-7d32c723abbcBest regards,
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
Quoted 20 lines · Alex Bennée
Quoted 18 lines · Akihiko Odaki
Commit
23ef50ae2d0c(".gitlab-ci.d/buildtest.yml: Use(quoted diff) +0
-2-fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in theother context. Move it to meson.build.
Signed-off-by Akihiko Odaki <[email protected]>--- meson.build | 1 + .gitlab-ci.d/buildtest.yml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)meson.build +0
-0@@ -609,6 +609,7 @@ if host_os != 'openbsd' and \ endif
Quoted 5 lines
meson.build if host_os != 'openbsd' and \ · line 613
Quoted 3 lines
meson.build +1
-0qemu_common_flags += cc.get_supported_arguments(hardening_flags) +qemu_common_flags += cc.get_supported_arguments('-fno-sanitize=function')What about checking the other hardening flags?
-fsanitize=function is the only hardening flag that we decided to disable for now. Context:
https://lore.kernel.org/qemu-devel/[email protected]/
Paolo Bonzini
AppliedQueued, thanks.
Paolo