arm: exynos: Enable TRNG for E850-96 board
Subsystems (4)
v2 cover arm: exynos: Enable TRNG for E850-96 board
This series enables True Random Number Generator (TRNG) for E850-96 board. Here is a short breakdown of features implemented in this series:
1. Load LDFW (Loadable Firmware) on E850-96 board. It's needed to make TRNG SMC commands functional. To do so, add the default eMMC partition table and implement reading and applying LDFW in board_init().
2. Add Exynos TRNG driver
3. Enable Exynos TRNG driver on E850-96 board. It requires SSS clocks to be enabled, so add those clocks as well.
With this series it's possible to generate random numbers in U-Boot (e.g. using 'rng' command). The main reason for RNG enablement on E850-96 board -- it's needed for EFI_RNG_PROTOCOL and kaslr, so it's one of the requirements to enable EFI boot support on E850-96 board, which in turn is needed (among other things) for EBBR spec and SystemReady IR certification. With this series it's also possible to use TRNG in Linux kernel (which was recently added, see [1] for details), as Linux kernel Exynos TRNG driver also relies on LDFW firmware to be loaded in the bootloader.
Changes in v2:
- Addressed comments for [PATCH 4/5] rng: Add Exynos TRNG driver
[1] https://lore.kernel.org/all/[email protected]/T/#me6ba1762a254ca438a9715f011d32820babfe2d8
Sam Protsenko (5):
board: samsung: e850-96: Add default partitions
board: samsung: e850-96: Load LDFW firmware on board init
clk: exynos: Add SSS clocks for Exynos850
rng: Add Exynos TRNG driver
arm: exynos: Enable TRNG on E850-96 board
arch/arm/dts/exynos850-e850-96-u-boot.dtsi | 11 + arch/arm/mach-exynos/Kconfig | 2 + board/samsung/e850-96/Makefile | 4 +- board/samsung/e850-96/e850-96.c | 6 +- board/samsung/e850-96/e850-96.env | 26 ++ board/samsung/e850-96/fw.c | 131 ++++++++++ board/samsung/e850-96/fw.h | 12 + configs/e850-96_defconfig | 1 + drivers/clk/exynos/clk-exynos850.c | 10 + drivers/rng/Kconfig | 13 + drivers/rng/Makefile | 1 + drivers/rng/exynos-trng.c | 291 +++++++++++++++++++++ 12 files changed, 504 insertions(+), 4 deletions(-) create mode 100644 board/samsung/e850-96/e850-96.env create mode 100644 board/samsung/e850-96/fw.c create mode 100644 board/samsung/e850-96/fw.h create mode 100644 drivers/rng/exynos-trng.c
Signature · 1 line
2.39.2
PATCH v2 1/5 board: samsung: e850-96: Add default partitions
Add an environment file for E850-96 board with default eMMC partition list. It follows the Samsung's partition list used for Android-Q on Exynos850 devices. It was verified on E850-96 board with:
=> gpt verify mmc 0 "$partitions"
Verify GPT: success!
---
Changes in v2:
- (none)
board/samsung/e850-96/e850-96.env | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 board/samsung/e850-96/e850-96.env
board/samsung/e850-96/e850-96.env new file +26 -0
@@ -0,0 +1,26 @@ +partitions= + uuid_disk=${uuid_gpt_disk}; + name=efs,start=512K,size=20M,uuid=${uuid_gpt_efs}; + name=env,size=16K,uuid=${uuid_gpt_env}; + name=kernel,size=30M,uuid=${uuid_gpt_kernel}; + name=ramdisk,size=26M,uuid=${uuid_gpt_ramdisk}; + name=dtbo,size=1M,uuid=${uuid_gpt_dtbo}; + name=ldfw,size=4016K,uuid=${uuid_gpt_ldfw}; + name=keystorage,size=8K,uuid=${uuid_gpt_keystorage}; + name=tzsw,size=1M,uuid=${uuid_gpt_tzsw}; + name=harx,size=2M,uuid=${uuid_gpt_harx}; + name=harx_rkp,size=2M,uuid=${uuid_gpt_harx_rkp}; + name=logo,size=40M,uuid=${uuid_gpt_logo}; + name=super,size=3600M,uuid=${uuid_gpt_super}; + name=cache,size=300M,uuid=${uuid_gpt_cache}; + name=modem,size=100M,uuid=${uuid_gpt_modem}; + name=boot,size=100M,uuid=${uuid_gpt_boot}; + name=persist,size=30M,uuid=${uuid_gpt_persist}; + name=recovery,size=40M,uuid=${uuid_gpt_recovery}; + name=misc,size=40M,uuid=${uuid_gpt_misc}; + name=mnv,size=20M,uuid=${uuid_gpt_mnv}; + name=frp,size=512K,uuid=${uuid_gpt_frp}; + name=vbmeta,size=64K,uuid=${uuid_gpt_vbmeta}; + name=metadata,size=16M,uuid=${uuid_gpt_metadata}; + name=dtb,size=1M,uuid=${uuid_gpt_dtb}; + name=userdata,size=-,uuid=${uuid_gpt_userdata}
Signature · 1 line
2.39.2
PATCH v2 2/5 board: samsung: e850-96: Load LDFW firmware on board init
In reply to Sam ProtsenkoLDFW is a Loadable Firmware which provides additional security capabilities in EL3 monitor. For example, True Random Number Generator (TRNG) block registers can't be accessed from EL1 (where U-Boot and Linux kernel are running), but it's possible to access TRNG capabilities via corresponding SMC calls, which in turn are handled by LDFW. To do so, LDFW firmware has to be loaded first. It's stored on a raw eMMC partition, so it has to be read into NWD (Normal World) RAM buffer, and then loaded to SWD (Secure World) memory using the special SMC call to EL3 monitor program. EL3_MON will load LDFW to SWD memory, more specifically to the area starting at 0xbf700000 (with size of 7.5 MiB). That memory area is reserved in device tree, so there shouldn't be any collisions. After that LDFW becomes functional.
Implement LDFW firmware loading on board init. While at it, fix the copyright date in header comments, as this board support was actually added in 2024, not in 2020: it was probably a copy-paste mistake.
---
Changes in v2:
- (none)
board/samsung/e850-96/Makefile | 4 +- board/samsung/e850-96/e850-96.c | 6 +- board/samsung/e850-96/fw.c | 131 ++++++++++++++++++++++++++++++++ board/samsung/e850-96/fw.h | 12 +++ 4 files changed, 149 insertions(+), 4 deletions(-) create mode 100644 board/samsung/e850-96/fw.c create mode 100644 board/samsung/e850-96/fw.h
board/samsung/e850-96/Makefile +2 -2
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0+ # -# Copyright (C) 2020, Linaro Limited +# Copyright (C) 2024, Linaro Limited # Sam Protsenko <[email protected]> -obj-y := e850-96.o +obj-y := e850-96.o fw.o
board/samsung/e850-96/e850-96.c +4 -2
@@ -1,10 +1,11 @@// SPDX-License-Identifier: GPL-2.0+ /* -* Copyright (C) 2020, Linaro Limited -* Sam Protsenko <[email protected]> +* Copyright (c) 2024, Linaro Ltd. +* Author: Sam Protsenko <[email protected]> */ #include <init.h> +#include "fw.h" int dram_init (void ) {
@@ -18,5 +19,6 @@ int dram_init_banksize(void)int board_init (void ) { +load_ldfw ();return 0 ; }
board/samsung/e850-96/fw.c new file +131 -0
131 lines not on this page · raw message
board/samsung/e850-96/fw.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (c) 2024 Linaro Ltd. +* Sam Protsenko <[email protected]> +*/ + +#ifndef __E850_96_FW_H +#define __E850_96_FW_H + +int load_ldfw (void ); + +#endif /* __E850_96_FW_H */
Signature · 1 line
2.39.2
PATCH v2 3/5 clk: exynos: Add SSS clocks for Exynos850
In reply to Sam ProtsenkoAdd ACLK (operating clock) and PCLK (bus clock) for Security Sub System (SSS) in Exynos850. Those clocks are needed for RNG enablement.
---
Changes in v2:
- (none)
drivers/clk/exynos/clk-exynos850.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/clk/exynos/clk-exynos850.c +10 -0
@@ -323,14 +323,18 @@ U_BOOT_DRIVER(exynos850_cmu_peri) = {/* Register Offset definitions for CMU_CORE (0x12000000) */ #define PLL_CON0_MUX_CLKCMU_CORE_BUS_USER 0x0600#define PLL_CON0_MUX_CLKCMU_CORE_MMC_EMBD_USER 0x0620 +#define PLL_CON0_MUX_CLKCMU_CORE_SSS_USER 0x0630#define CLK_CON_DIV_DIV_CLK_CORE_BUSP 0x1800#define CLK_CON_GAT_GOUT_CORE_MMC_EMBD_I_ACLK 0x20e8#define CLK_CON_GAT_GOUT_CORE_MMC_EMBD_SDCLKIN 0x20ec +#define CLK_CON_GAT_GOUT_CORE_SSS_I_ACLK 0x2128 +#define CLK_CON_GAT_GOUT_CORE_SSS_I_PCLK 0x212c/* List of parent clocks for Muxes in CMU_CORE */ PNAME (mout_core_bus_user_p) = {"clock-oscclk" ,"dout_core_bus" };PNAME (mout_core_mmc_embd_user_p) = {"clock-oscclk" ,"dout_core_mmc_embd" }; +PNAME (mout_core_sss_user_p) = {"clock-oscclk" ,"dout_core_sss" };static const struct samsung_mux_clock core_mux_clks[] = { MUX(CLK_MOUT_CORE_BUS_USER, "mout_core_bus_user", mout_core_bus_user_p,
@@ -338,6 +342,8 @@ static const struct samsung_mux_clock core_mux_clks[] = {MUX_F (CLK_MOUT_CORE_MMC_EMBD_USER ,"mout_core_mmc_embd_user" , mout_core_mmc_embd_user_p,PLL_CON0_MUX_CLKCMU_CORE_MMC_EMBD_USER ,4 ,1 ,CLK_SET_RATE_PARENT ,0 ), +MUX (CLK_MOUT_CORE_SSS_USER ,"mout_core_sss_user" , mout_core_sss_user_p, + PLL_CON0_MUX_CLKCMU_CORE_SSS_USER, 4, 1), }; static const struct samsung_div_clock core_div_clks[] = {
@@ -351,6 +357,10 @@ static const struct samsung_gate_clock core_gate_clks[] = {GATE (CLK_GOUT_MMC_EMBD_SDCLKIN ,"gout_mmc_embd_sdclkin" ,"mout_core_mmc_embd_user" ,CLK_CON_GAT_GOUT_CORE_MMC_EMBD_SDCLKIN ,21 ,CLK_SET_RATE_PARENT ,0 ), +GATE (CLK_GOUT_SSS_ACLK ,"gout_sss_aclk" ,"mout_core_sss_user" , +CLK_CON_GAT_GOUT_CORE_SSS_I_ACLK ,21 ,0 ,0 ), +GATE (CLK_GOUT_SSS_PCLK ,"gout_sss_pclk" ,"dout_core_busp" , + CLK_CON_GAT_GOUT_CORE_SSS_I_PCLK, 21, 0, 0), }; static const struct samsung_clk_group core_cmu_clks[] = {
Signature · 1 line
2.39.2
PATCH v2 4/5 rng: Add Exynos TRNG driver
In reply to Sam ProtsenkoAdd True Random Number Generator (TRNG) driver for Exynos chips. This implementation is heavily based on Linux kernel's counterpart [1]. It also follows upstream dt-bindings [2].
TRNG block is usually a part of SSS (Security Sub System) IP-core on Exynos chips. Because SSS access on Exynos850 is protected by TZPC (TrustZone Protection Control), it's not possible to read/write TRNG registers from U-Boot, as it's running in EL1 mode. Instead, the corresponding SMC calls should be used to make the secure software running in EL3 mode access it for us. Those SMC calls are handled by LDFW (Loadable Firmware), which has to be loaded first. For example, for E850-96 board it's done in its board_init(), so by the time RNG capabilities are needed the LDFW should be already loaded and TRNG should be functional.
[1] drivers/char/hw_random/exynos-trng.c
[2] dts/upstream/Bindings/rng/samsung,exynos5250-trng.yaml
---
Changes in v2:
- Mentioned LDFW firmware in help section for RNG_EXYNOS config option
- Renamed struct exynos_trng -> struct exynos_trng_priv
- Added kernel-doc comments for struct exynos_trng_priv
- Added kernel-doc comments for struct exynos_trng_variant
- Fixed error codes in exynos_trng_of_to_plat()
- Renamed 'err' variable to 'ret' in exynos_trng_probe()
drivers/rng/Kconfig | 13 ++ drivers/rng/Makefile | 1 + drivers/rng/exynos-trng.c | 291 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 305 insertions(+) create mode 100644 drivers/rng/exynos-trng.c
drivers/rng/Kconfig +13 -0
@@ -120,4 +120,17 @@ config RNG_TURRIS_RWTM on other Armada-3700 devices (like EspressoBin) if Secure Firmware from CZ.NIC is used. +config RNG_EXYNOS + bool "Samsung Exynos True Random Number Generator support" + depends on DM_RNG + help + Enable support for True Random Number Generator (TRNG) available on + Exynos SoCs. + + On some chips (like Exynos850) TRNG registers are protected with TZPC + (TrustZone Protection Control). For such chips the driver provides an + implementation based on SMC calls to EL3 monitor program. In that + case the LDFW (Loadable Firmware) has to be loaded first, as it + actually implements TRNG SMC calls. + endif
drivers/rng/Makefile +1 -0
@@ -18,3 +18,4 @@ obj-$(CONFIG_RNG_ARM_RNDR) += arm_rndr.o obj-$(CONFIG_TPM_RNG) += tpm_rng.o obj-$(CONFIG_RNG_JH7110) += jh7110_rng.o obj-$(CONFIG_RNG_TURRIS_RWTM) += turris_rwtm_rng.o +obj-$(CONFIG_RNG_EXYNOS) += exynos-trng.o
drivers/rng/exynos-trng.c new file +291 -0
291 lines not on this page · raw message
Signature · 1 line
2.39.2
PATCH v2 5/5 arm: exynos: Enable TRNG on E850-96 board
In reply to Sam ProtsenkoEnable True Random Number Generator (TRNG) on E850-96 board. To do so:
1. Enable DM_RNG and RNG_EXYNOS for TARGET_E850_96
2. Add TRNG node to E850-96 device tree
3. Enable 'rng' command support for easy TRNG testing
TRNG node is already applied in Linux kernel device tree, but it hasn't appeared in upstream dts yet. Add it in U-Boot override dtsi file temporarily; it can be removed once it appears in upstream dts.
---
Changes in v2:
- (none)
arch/arm/dts/exynos850-e850-96-u-boot.dtsi | 11 +++++++++++ arch/arm/mach-exynos/Kconfig | 2 ++ configs/e850-96_defconfig | 1 + 3 files changed, 14 insertions(+)
arch/arm/dts/exynos850-e850-96-u-boot.dtsi +11 -0
@@ -3,6 +3,17 @@ * Copyright (c) 2023 Linaro Ltd. */ +&soc { + /* TODO: Remove this node once it appears in upstream dts */ + trng: rng@12081400 { + compatible = "samsung,exynos850-trng"; + reg = <0x12081400 0x100>; + clocks = <&cmu_core CLK_GOUT_SSS_ACLK>, + <&cmu_core CLK_GOUT_SSS_PCLK>; + clock-names = "secss", "pclk"; + }; +}; + &pmu_system_controller { bootph-all; samsung,uart-debug-1;
arch/arm/mach-exynos/Kconfig +2 -0
@@ -250,6 +250,8 @@ config TARGET_E850_96 select PINCTRL select PINCTRL_EXYNOS850 imply OF_UPSTREAM + imply DM_RNG + imply RNG_EXYNOS endchoice endif
configs/e850-96_defconfig +1 -0
@@ -14,6 +14,7 @@ CONFIG_ANDROID_BOOT_IMAGE=y # CONFIG_DISPLAY_CPUINFO is not set CONFIG_HUSH_PARSER=y CONFIG_CMD_ABOOTIMG=y +CONFIG_CMD_RNG=y CONFIG_CMD_CLK=y CONFIG_CMD_GPT=y CONFIG_CMD_MMC=y
Signature · 1 line
2.39.2
Hi Minkyu,
Can you please take a look at this series? And also my MMC series [1] has been pending for a while now, if it's ok with you -- can you please apply it?
Thanks!
[1] https://lists.denx.de/pipermail/u-boot/2024-July/559602.html
Quoted 55 lines · Sam Protsenko
This series enables True Random Number Generator (TRNG) for E850-96 board. Here is a short breakdown of features implemented in this series:
1. Load LDFW (Loadable Firmware) on E850-96 board. It's needed to make TRNG SMC commands functional. To do so, add the default eMMC partition table and implement reading and applying LDFW in
board_init().
2. Add Exynos TRNG driver
3. Enable Exynos TRNG driver on E850-96 board. It requires SSS clocks to be enabled, so add those clocks as well.With this series it's possible to generate random numbers in U-Boot (e.g. using 'rng' command). The main reason for RNG enablement on E850-96 board -- it's needed for
EFI_RNG_PROTOCOLand kaslr, so it's one of the requirements to enable EFI boot support on E850-96 board, which in turn is needed (among other things) for EBBR spec and SystemReady IR certification. With this series it's also possible to use TRNG in Linux kernel (which was recently added, see [1] for details), as Linux kernel Exynos TRNG driver also relies on LDFW firmware to be loaded in the bootloader.Changes in v2:
- Addressed comments for [PATCH 4/5] rng: Add Exynos TRNG driver[1] https://lore.kernel.org/all/[email protected]/T/#me6ba1762a254ca438a9715f011d32820babfe2d8
Sam Protsenko (5):
board: samsung: e850-96: Add default partitions
board: samsung: e850-96: Load LDFW firmware on board init
clk: exynos: Add SSS clocks for Exynos850
rng: Add Exynos TRNG driver
arm: exynos: Enable TRNG on E850-96 boardarch/arm/dts/exynos850-e850-96-u-boot.dtsi | 11 + arch/arm/mach-exynos/Kconfig | 2 + board/samsung/e850-96/Makefile | 4 +- board/samsung/e850-96/e850-96.c | 6 +- board/samsung/e850-96/e850-96.env | 26 ++ board/samsung/e850-96/fw.c | 131 ++++++++++ board/samsung/e850-96/fw.h | 12 + configs/e850-96_defconfig | 1 + drivers/clk/exynos/clk-exynos850.c | 10 + drivers/rng/Kconfig | 13 + drivers/rng/Makefile | 1 + drivers/rng/exynos-trng.c | 291 +++++++++++++++++++++ 12 files changed, 504 insertions(+), 4 deletions(-) create mode 100644 board/samsung/e850-96/e850-96.env create mode 100644 board/samsung/e850-96/fw.c create mode 100644 board/samsung/e850-96/fw.h create mode 100644 drivers/rng/exynos-trng.c--
2.39.2
Hi,
2024년 7월 23일 (화) 03:17, Sam Protsenko <[email protected]>님이 작성:
Quoted 34 lines
Hi Minkyu,
Can you please take a look at this series? And also my MMC series [1] has been pending for a while now, if it's ok with you -- can you please apply it?
Thanks!
[1] https://lists.denx.de/pipermail/u-boot/2024-July/559602.html
Quoted 22 lines · Sam Protsenko
This series enables True Random Number Generator (TRNG) for E850-96 board. Here is a short breakdown of features implemented in this series:
1. Load LDFW (Loadable Firmware) on E850-96 board. It's needed to make TRNG SMC commands functional. To do so, add the default eMMC partition table and implement reading and applying LDFW in
board_init().
2. Add Exynos TRNG driver
3. Enable Exynos TRNG driver on E850-96 board. It requires SSS clocks to be enabled, so add those clocks as well.With this series it's possible to generate random numbers in U-Boot (e.g. using 'rng' command). The main reason for RNG enablement on E850-96 board -- it's needed for
EFI_RNG_PROTOCOLand kaslr, so it's one of the requirements to enable EFI boot support on E850-96 board, which in turn is needed (among other things) for EBBR spec and SystemReady IR certification. With this series it's also possible to use TRNG in Linux kernel (which was recently added, see [1] for details), as Linux kernel Exynos TRNG driver also relies on LDFW firmware to be loaded in the bootloader.
Quoted 34 lines
Quoted 4 lines
Changes in v2:
- Addressed comments for [PATCH 4/5] rng: Add Exynos TRNG driver[1]
https://lore.kernel.org/all/[email protected]/T/#me6ba1762a254ca438a9715f011d32820babfe2d8
Quoted 29 lines
Sam Protsenko (5):
board: samsung: e850-96: Add default partitions
board: samsung: e850-96: Load LDFW firmware on board init
clk: exynos: Add SSS clocks for Exynos850
rng: Add Exynos TRNG driver
arm: exynos: Enable TRNG on E850-96 boardarch/arm/dts/exynos850-e850-96-u-boot.dtsi | 11 + arch/arm/mach-exynos/Kconfig | 2 + board/samsung/e850-96/Makefile | 4 +- board/samsung/e850-96/e850-96.c | 6 +- board/samsung/e850-96/e850-96.env | 26 ++ board/samsung/e850-96/fw.c | 131 ++++++++++ board/samsung/e850-96/fw.h | 12 + configs/e850-96_defconfig | 1 + drivers/clk/exynos/clk-exynos850.c | 10 + drivers/rng/Kconfig | 13 + drivers/rng/Makefile | 1 + drivers/rng/exynos-trng.c | 291 +++++++++++++++++++++ 12 files changed, 504 insertions(+), 4 deletions(-) create mode 100644 board/samsung/e850-96/e850-96.env create mode 100644 board/samsung/e850-96/fw.c create mode 100644 board/samsung/e850-96/fw.h create mode 100644 drivers/rng/exynos-trng.c--
2.39.2
Your patch was failed to apply to u-boot-samsung due to the e850-96_defconfig.
please rebase the patch.
and about mmc patches, those have delegated to mmc maintainers.
Thanks,
Minkyu Kang.
[snip]
Quoted 4 lines
Your patch was failed to apply to u-boot-samsung due to the e850-96_defconfig. please rebase the patch.
Just sent v3, please take a look.
Quoted 2 lines
and about mmc patches, those have delegated to mmc maintainers.
Do you know if I should I ask some specific MMC maintainer to apply that series? That series was pending for a while now and I really want to get it merged as soon as possible :)
Thanks!
Quoted 3 lines
Thanks,
Minkyu Kang.
Hi,
2024년 7월 24일 (수) 03:23, Sam Protsenko <[email protected]>님이 작성:
Quoted 8 lines
[snip]
Quoted 2 lines
Your patch was failed to apply to u-boot-samsung due to the
e850-96_defconfig.
Quoted 2 lines
please rebase the patch.
Quoted 8 lines
Just sent v3, please take a look.
Quoted 2 lines
and about mmc patches, those have delegated to mmc maintainers.
Do you know if I should I ask some specific MMC maintainer to apply that series? That series was pending for a while now and I really want to get it merged as soon as possible :)
Mr. Chung will check.
Quoted 7 lines
Thanks!
Quoted 3 lines
Thanks,
Minkyu Kang.