Skip to contentSkip to conversation

rockchip: theobroma: use HTTPS for git URLs and drop RK3368 Lion support

PATCH New Quentin Schulz 1 participant 3 messages Jul 17, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover rockchip: theobroma: use HTTPS for git URLs and drop RK3368 Lion support

Nobody at Theobroma has booted Lion since at least July 2021 and the last meaningful changes were made in February 2021.
The product isn't listed on our website anymore.

Therefore let's remove its support.

Additionally, migrate git URLs in MAINTAINERS to use https:// instead of
git:// as it's more user-friendly (and also that git:// was only supported for Puma repo until yesterday).

---
Changes in v2:
- removed lion from DT Makefile
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Quentin Schulz (2):
rockchip: theobroma-systems: migrate git URLs to HTTPS
rockchip: remove support for Theobroma Systems RK3368 Lion

 arch/arm/dts/Makefile                             |   1 -
 arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi       | 119 --------
 arch/arm/dts/rk3368-lion-haikou.dts               | 144 ----------
 arch/arm/dts/rk3368-lion.dtsi                     | 318 ----------------------
 arch/arm/mach-rockchip/rk3368/Kconfig             |  22 --
 board/theobroma-systems/jaguar_rk3588/MAINTAINERS |   2 +-
 board/theobroma-systems/lion_rk3368/Kconfig       |  18 --
 board/theobroma-systems/lion_rk3368/MAINTAINERS   |  10 -
 board/theobroma-systems/lion_rk3368/README        |  78 ------
 board/theobroma-systems/puma_rk3399/MAINTAINERS   |   2 +-
 board/theobroma-systems/ringneck_px30/MAINTAINERS |   2 +-
 board/theobroma-systems/tiger_rk3588/MAINTAINERS  |   2 +-
 configs/lion-rk3368_defconfig                     | 110 --------
 doc/board/rockchip/rockchip.rst                   |   1 -
 include/configs/lion_rk3368.h                     |  16 --
 15 files changed, 4 insertions(+), 841 deletions(-)

---
base-commit: af3c2166d54cdb71914baece900095bad5a44862
change-id: 20240620-tsd-http-git-clone-53c0ea69adbe

Best regards,

Signature · 1 line
Quentin Schulz <[email protected]>
#1 lore raw

PATCH v2 1/2 rockchip: theobroma-systems: migrate git URLs to HTTPS

From: Quentin Schulz <[email protected]>

It turns out only Puma had a working git:// URL. Though that is now fixed, having HTTPS URLs make it easier to directly reach our cgit webserver to check what's up without having to change the URL manually.

Depending on your terminal settings, this also makes it possible to open the link from it.

---
 board/theobroma-systems/jaguar_rk3588/MAINTAINERS | 2 +-
 board/theobroma-systems/puma_rk3399/MAINTAINERS   | 2 +-
 board/theobroma-systems/ringneck_px30/MAINTAINERS | 2 +-
 board/theobroma-systems/tiger_rk3588/MAINTAINERS  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
board/theobroma-systems/jaguar_rk3588/MAINTAINERS +1 -1
index ab7051b427f..370d0a1272a 100644
@@ -10,4 +10,4 @@ F:	include/configs/jaguar_rk3588.h
 F:	arch/arm/dts/rk3588-jaguar*
 F:	configs/jaguar-rk3588_defconfig
 W:	https://embedded.cherry.de/product/jaguar-sbc-rk3588/
-T:	git git://git.embedded.cherry.de/jaguar-u-boot.git
+T:	git https://git.embedded.cherry.de/jaguar-u-boot.git
board/theobroma-systems/puma_rk3399/MAINTAINERS +1 -1
index 2536e348887..1a5b78bf535 100644
@@ -9,4 +9,4 @@ F:	include/configs/puma_rk3399.h
 F:	arch/arm/dts/rk3399-puma*
 F:	configs/puma-rk3399_defconfig
 W:	https://embedded.cherry.de/product/puma-som-rk3399-q7/
-T:	git git://git.embedded.cherry.de/puma-u-boot.git
+T:	git https://git.embedded.cherry.de/puma-u-boot.git
board/theobroma-systems/ringneck_px30/MAINTAINERS +1 -1
index 2aff91f4207..4d4544a2a3e 100644
@@ -9,4 +9,4 @@ F:	include/configs/ringneck_px30.h
 F:	arch/arm/dts/px30-ringneck*
 F:	configs/ringneck-px30_defconfig
 W:	https://embedded.cherry.de/product/ringneck-som-px30-uq7/
-T:	git git://git.embedded.cherry.de/ringneck-u-boot.git
+T:	git https://git.embedded.cherry.de/ringneck-u-boot.git
board/theobroma-systems/tiger_rk3588/MAINTAINERS +1 -1
index e5aab4b29f3..a95135616ad 100644
@@ -10,4 +10,4 @@ F:	include/configs/tiger_rk3588.h
 F:	arch/arm/dts/rk3588-tiger*
 F:	configs/tiger-rk3588_defconfig
 W:	https://embedded.cherry.de/product/tiger-som-rk3588-q7/
-T:	git git://git.embedded.cherry.de/tiger-u-boot.git
+T:	git https://git.embedded.cherry.de/tiger-u-boot.git
Signature · 1 line
2.45.2
#2 lore raw

PATCH v2 2/2 rockchip: remove support for Theobroma Systems RK3368 Lion

In reply to Quentin Schulz

From: Quentin Schulz <[email protected]>

No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website.

This product is therefore unmaintained and it would be disingenuous to say the opposite, so drop support for RK3368 Lion.

If you're a user of Lion, feel free to revert this patch or contact our sales/support department.

---
 arch/arm/dts/Makefile                           |   1 -
 arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi     | 119 ---------
 arch/arm/dts/rk3368-lion-haikou.dts             | 144 -----------
 arch/arm/dts/rk3368-lion.dtsi                   | 318 ------------------------
 arch/arm/mach-rockchip/rk3368/Kconfig           |  22 --
 board/theobroma-systems/lion_rk3368/Kconfig     |  18 --
 board/theobroma-systems/lion_rk3368/MAINTAINERS |  10 -
 board/theobroma-systems/lion_rk3368/README      |  78 ------
 configs/lion-rk3368_defconfig                   | 110 --------
 doc/board/rockchip/rockchip.rst                 |   1 -
 include/configs/lion_rk3368.h                   |  16 --
 11 files changed, 837 deletions(-)
arch/arm/dts/Makefile +0 -1
index 4a4d5be2bd6..7265e554257 100644
@@ -83,7 +83,6 @@ dtb-$(CONFIG_ROCKCHIP_RK3288) += \
 	rk3288-vyasa.dtb
 
 dtb-$(CONFIG_ROCKCHIP_RK3368) += \
-	rk3368-lion-haikou.dtb \
 	rk3368-sheep.dtb \
 	rk3368-geekbox.dtb \
 	rk3368-px5-evb.dtb \
arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi deleted +0 -119

119 lines not on this page · raw message

arch/arm/dts/rk3368-lion-haikou.dts deleted +0 -144

144 lines not on this page · raw message

arch/arm/dts/rk3368-lion.dtsi deleted +0 -318

318 lines not on this page · raw message

arch/arm/mach-rockchip/rk3368/Kconfig +0 -22
index 3de695186ed..a7be30bbd89 100644
@@ -3,27 +3,6 @@ if ROCKCHIP_RK3368
 choice
 	prompt "RK3368 board"
 
-config TARGET_LION_RK3368
-        bool "Theobroma Systems RK3368-uQ7 (Lion) module"
-	select ARCH_EARLY_INIT_R
-	help
-	  The RK3368-uQ7 is a micro-Qseven form-factor (40mm x 70mm,
-	  MXM-230 connector) system-on-module designed by Theobroma
-	  Systems for industrial applications.
-
-	  It provides the following features:
-	   - 8x Cortex-A53 (in 2 clusters of 4 cores each)
-	   - (on-module) up to 4GB of DDR3 memory
-	   - (on-module) SPI-NOR flash
-	   - (on-module) eMMC
-	   - Gigabit Ethernet (with an on-module KSZ9031 PHY)
-	   - USB
-	   - HDMI
-	   - MIPI-DSI/single-channel LVDS (muxed on the 'LVDS-A' pin-group)
-	   - various 'slow' interfaces (e.g. UART, SPI, I2C, I2S, ...)
-	   - on-module STM32 providing CAN, RTC and fan-control
-	   - (optional on-module) EAL4+-certified security module
-
 config TARGET_SHEEP
 	bool "Sheep board"
 	help
@@ -62,7 +41,6 @@ config SPL_LIBCOMMON_SUPPORT
 config SPL_LIBGENERIC_SUPPORT
 	default y
 
-source "board/theobroma-systems/lion_rk3368/Kconfig"
 source "board/rockchip/sheep_rk3368/Kconfig"
 source "board/geekbuying/geekbox/Kconfig"
 source "board/rockchip/evb_px5/Kconfig"
board/theobroma-systems/lion_rk3368/Kconfig deleted +0 -18
deleted file mode 100644
index 537a2e7d9af..00000000000
@@ -1,18 +0,0 @@
-if TARGET_LION_RK3368
-
-config SYS_BOARD
-	default "lion_rk3368"
-
-config SYS_VENDOR
-	default "theobroma-systems"
-
-config SYS_CONFIG_NAME
-	default "lion_rk3368"
-
-config ENV_SIZE
-	default 0x2000
-
-config ENV_OFFSET
-	default 0x3c000 if ENV_IS_IN_SPI_FLASH
-
-endif
board/theobroma-systems/lion_rk3368/MAINTAINERS deleted +0 -10
deleted file mode 100644
index ed35fee6468..00000000000
@@ -1,10 +0,0 @@
-LION-RK3368 (RK3368-uQ7 system-on-module)
-M:	Quentin Schulz <[email protected]>
-M:	Klaus Goger <[email protected]>
-S:	Maintained
-F:	board/theobroma-systems/lion_rk3368
-F:	include/configs/lion_rk3368.h
-F:	arch/arm/dts/rk3368-lion.dts
-F:	configs/lion-rk3368_defconfig
-W:	https://www.theobroma-systems.com/rk3368-uq7/tech-specs
-T:	git git://git.theobroma-systems.com/lion-u-boot.git
board/theobroma-systems/lion_rk3368/README deleted +0 -78

78 lines not on this page · raw message

configs/lion-rk3368_defconfig deleted +0 -110

110 lines not on this page · raw message

doc/board/rockchip/rockchip.rst +0 -1
index eaf71673b7f..bac12f055bc 100644
@@ -72,7 +72,6 @@ List of mainline supported Rockchip boards:
      - GeekBox (geekbox)
      - PX5 EVB (evb-px5)
      - Rockchip Sheep (sheep-rk3368)
-     - Theobroma Systems RK3368-uQ7 SoM - Lion (lion-rk3368)
 * rk3399
      - 96boards RK3399 Ficus (ficus-rk3399)
      - 96boards Rock960 (rock960-rk3399)
include/configs/lion_rk3368.h deleted +0 -16
deleted file mode 100644
index 0d29e1ddc73..00000000000
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH
- */
-
-#ifndef __CONFIGS_LION_RK3368_H
-#define __CONFIGS_LION_RK3368_H
-
-#include <configs/rk3368_common.h>
-
-#define KERNEL_LOAD_ADDR		0x280000
-#define DTB_LOAD_ADDR			0x5600000
-#define INITRD_LOAD_ADDR		0x5bf0000
-/* PHY needs longer aneg time at 1G */
-
-#endif
Signature · 1 line
2.45.2