shmem_quota: Build the object file conditionally to the config option
Subsystems (3)
PATCH 1/1 shmem_quota: Build the object file conditionally to the config option
From: Carlos Maiolino <[email protected]>
Initially I added shmem-quota to obj-y, move it to the correct place and remove the uneeded full file #ifdef
Sugested-by Aristeu Rozanski <[email protected]>
Signed-off-by Carlos Maiolino <[email protected]>
--- mm/Makefile | 3 ++- mm/shmem_quota.c | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-)
mm/Makefile +2 -1
@@ -52,7 +52,7 @@ obj-y := filemap.o mempool.o oom_kill.o fadvise.o \ readahead.o swap.o truncate.o vmscan.o shrinker.o \ shmem.o util.o mmzone.o vmstat.o backing-dev.o \ mm_init.o percpu.o slab_common.o \ - compaction.o show_mem.o shmem_quota.o\ + compaction.o show_mem.o \ interval_tree.o list_lru.o workingset.o \ debug.o gup.o mmap_lock.o $(mmu-y)
@@ -139,3 +139,4 @@ obj-$(CONFIG_HAVE_BOOTMEM_INFO_NODE) += bootmem_info.o obj-$(CONFIG_GENERIC_IOREMAP) += ioremap.o obj-$(CONFIG_SHRINKER_DEBUG) += shrinker_debug.o obj-$(CONFIG_EXECMEM) += execmem.o +obj-$(CONFIG_TMPFS_QUOTA) += shmem_quota.o
mm/shmem_quota.c +0 -3
@@ -34,8 +34,6 @@#include <linux/quotaops.h> #include <linux/quota.h> -#ifdef CONFIG_TMPFS_QUOTA -/* * The following constants define the amount of time given a user * before the soft limits are treated as hard limits (usually resulting
@@ -351,4 +349,3 @@ const struct dquot_operations shmem_quota_operations = { .mark_dirty = shmem_mark_dquot_dirty, .get_next_id = shmem_get_next_id, }; -#endif /* CONFIG_TMPFS_QUOTA */
Signature · 1 line
2.45.2
Quoted 7 lines · On Wed 17-07-24 08:37:27, [email protected] wrote:
From: Carlos Maiolino <[email protected]>
Initially I added shmem-quota to obj-y, move it to the correct place and remove the uneeded full file #ifdef
Sugested-by Aristeu Rozanski <[email protected]>Signed-off-by Carlos Maiolino <[email protected]>
Sure. Looks good. Feel free to add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 44 lines
--- mm/Makefile | 3 ++- mm/shmem_quota.c | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-)mm/Makefile +2
-1@@ -52,7 +52,7 @@ obj-y := filemap.o mempool.o oom_kill.o fadvise.o \ readahead.o swap.o truncate.o vmscan.o shrinker.o \ shmem.o util.o mmzone.o vmstat.o backing-dev.o \ mm_init.o percpu.o slab_common.o \ - compaction.o show_mem.o shmem_quota.o\ + compaction.o show_mem.o \ interval_tree.o list_lru.o workingset.o \ debug.o gup.o mmap_lock.o $(mmu-y)@@ -139,3 +139,4 @@ obj-$(CONFIG_HAVE_BOOTMEM_INFO_NODE) += bootmem_info.o obj-$(CONFIG_GENERIC_IOREMAP) += ioremap.o obj-$(CONFIG_SHRINKER_DEBUG) += shrinker_debug.o obj-$(CONFIG_EXECMEM) += execmem.o +obj-$(CONFIG_TMPFS_QUOTA) += shmem_quota.omm/shmem_quota.c +0
-3@@ -34,8 +34,6 @@#include <linux/quotaops.h> #include <linux/quota.h> -#ifdef CONFIG_TMPFS_QUOTA -/* * The following constants define the amount of time given a user * before the soft limits are treated as hard limits (usually resulting @@ -351,4 +349,3 @@ const struct dquot_operations shmem_quota_operations = { .mark_dirty = shmem_mark_dquot_dirty, .get_next_id = shmem_get_next_id, }; -#endif /* CONFIG_TMPFS_QUOTA */ Signature · 1 line
2.45.2
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR