Skip to contentSkip to conversation

dt-bindings: PCI: altera: msi: Convert to YAML

PATCH Applied [email protected] 3 participants 6 messages Jul 17, 2024 – Sep 13, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: PCI: altera: msi: Convert to YAML

From: Matthew Gerlach <[email protected]>

Convert the device tree bindings for the Altera PCIe MSI controller from text to YAML.

---
 .../bindings/pci/altera-pcie-msi.txt          | 27 --------
 .../bindings/pci/altr,msi-controller.yaml     | 65 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 66 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pci/altera-pcie-msi.txt
 create mode 100644 Documentation/devicetree/bindings/pci/altr,msi-controller.yaml
Documentation/devicetree/bindings/pci/altera-pcie-msi.txt deleted +0 -27
deleted file mode 100644
index 9514c327d31b..000000000000
@@ -1,27 +0,0 @@
-* Altera PCIe MSI controller
-
-Required properties:
-- compatible:	should contain "altr,msi-1.0"
-- reg:		specifies the physical base address of the controller and
-		the length of the memory mapped region.
-- reg-names:	must include the following entries:
-		"csr": CSR registers
-		"vector_slave": vectors slave port region
-- interrupts:	specifies the interrupt source of the parent interrupt
-		controller. The format of the interrupt specifier depends on the
-		parent interrupt controller.
-- num-vectors:	number of vectors, range 1 to 32.
-- msi-controller:	indicates that this is MSI controller node
-
-
-Example
-msi0: msi@0xFF200000 {
-	compatible = "altr,msi-1.0";
-	reg = <0xFF200000 0x00000010
-		0xFF200010 0x00000080>;
-	reg-names = "csr", "vector_slave";
-	interrupt-parent = <&hps_0_arm_gic_0>;
-	interrupts = <0 42 4>;
-	msi-controller;
-	num-vectors = <32>;
-};
Documentation/devicetree/bindings/pci/altr,msi-controller.yaml new file +65 -0

65 lines not on this page · raw message

MAINTAINERS +1 -1
index f296a5ea2529..8a3424a03772 100644
@@ -17585,7 +17585,7 @@ PCI MSI DRIVER FOR ALTERA MSI IP
 M:	Joyce Ooi <[email protected]>
 L:	[email protected]
 S:	Supported
-F:	Documentation/devicetree/bindings/pci/altera-pcie-msi.txt
+F:	Documentation/devicetree/bindings/pci/altr,msi-controller.yaml
 F:	drivers/pci/controller/pcie-altera-msi.c
 
 PCI MSI DRIVER FOR APPLIEDMICRO XGENE
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Documentation/devicetree/bindings/pci/altr,msi-controller.yaml line 56

Quoted 5 lines · On Wed, Jul 17, 2024 at 01:17:56PM -0500, [email protected] wrote:
Quoted 1 line

+examples:

Documentation/devicetree/bindings/pci/altr,msi-controller.yaml new file +4 -0
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    msi0: msi@ff200000 {

nit: label is not used and should be dropped.

Thanks,
Conor.

#2 lore raw

Hello,

[...]

Quoted 7 lines

Documentation/devicetree/bindings/pci/altr,msi-controller.yaml line 56

Quoted 5 lines
Quoted 1 line

+examples:

Documentation/devicetree/bindings/pci/altr,msi-controller.yaml new file +4 -0
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    msi0: msi@ff200000 {

nit: label is not used and should be dropped.

Which bit specifically do you want amended? I will do it on the branch so we merge the final version.

Krzysztof

#3 lore raw
Quoted 9 lines · Krzysztof Wilczyński

Hello,

[...]

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

+examples:

Documentation/devicetree/bindings/pci/altr,msi-controller.yaml new file +4 -0
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    msi0: msi@ff200000 {
Quoted 7 lines
Quoted 1 line

nit: label is not used and should be dropped.

Which bit specifically do you want amended? I will do it on the branch so we merge the final version.

Krzysztof

The label, "msi0: " should be removed.

Thanks,
Matthew

#4 lore raw

Hello,

Quoted 8 lines
Quoted 7 lines
Quoted 1 line

nit: label is not used and should be dropped.

Which bit specifically do you want amended? I will do it on the branch so we merge the final version.

Krzysztof

The label, "msi0: " should be removed.

Done. Updated the branch directly. Thank you!

Krzysztof