Skip to contentSkip to conversation

wifi: rtw88: select WANT_DEV_COREDUMP

PATCH In review Ping-Ke Shih 2 participants 6 messages Jul 18, 2024 – Jul 31, 2024

Subsystems (2)
lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/2 wifi: rtw88: select WANT_DEV_COREDUMP

From: Zong-Zhe Yang <[email protected]>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

---
 drivers/net/wireless/realtek/rtw88/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/realtek/rtw88/Kconfig +1 -0
index 22838ede03cd..02b0d698413b 100644
@@ -12,6 +12,7 @@ if RTW88
 
 config RTW88_CORE
 	tristate
+	select WANT_DEV_COREDUMP
 
 config RTW88_PCI
 	tristate
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH 2/2 wifi: rtw89: select WANT_DEV_COREDUMP

From: Zong-Zhe Yang <[email protected]>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

---
 drivers/net/wireless/realtek/rtw89/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/realtek/rtw89/Kconfig +1 -0
index 3c9f864805b1..6278fd74e98e 100644
@@ -12,6 +12,7 @@ if RTW89
 
 config RTW89_CORE
 	tristate
+	select WANT_DEV_COREDUMP
 
 config RTW89_PCI
 	tristate
Signature · 1 line
2.25.1
#2 lore raw
In reply to Ping-Ke Shih
Quoted 7 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Should these two go to wireless tree? If yes, please assign the patches to me on patchwork. But rtw tree is fine for me as well, your call.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
author maintainer
#3 lore raw
Quoted 4 lines · Kalle Valo
Quoted 2 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

Quoted 8 lines
Quoted 5 lines

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Should these two go to wireless tree? If yes, please assign the patches to me on patchwork. But rtw tree is fine for me as well, your call.

For most distro, other drivers select this flag, so not urgent to have these two patches. Then they will go via rtw tree. Thanks.

#4 lore raw
Quoted 8 lines · Ping-Ke Shih
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Should these two go to wireless tree? If yes, please assign the patches to me on patchwork. But rtw tree is fine for me as well, your call.

For most distro, other drivers select this flag, so not urgent to have these two patches. Then they will go via rtw tree. Thanks.

Makes sense, thanks.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
author maintainer
#5 lore raw
In reply to Ping-Ke Shih
Quoted 7 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

2 patch(es) applied to rtw-next branch of rtw.git, thanks.

7e989b0c1e33 wifi: rtw88: select WANT_DEV_COREDUMP d523dc49d13e wifi: rtw89: select WANT_DEV_COREDUMP

---
https://github.com/pkshih/rtw.git