irqchip/gic-v3-its: Correctly fish out the DID for platform MSI
Subsystems (2)
Marc Zyngier
maintainerPATCH 1/1 irqchip/gic-v3-its: Correctly fish out the DID for platform MSI
Similarly to what we do for PCI where msi-map/msi-mask are used to compute the full RID (aka DID in ITS speak), we use msi-parent as the discovery mechanism, since there is no way a device can generally express its ID.
However, since we switched to a per-device MSI domain model, the domain passed to its_pmsi_prepare() is the wrong one, and points to the device's instead of the ITS'. Bad.
Use the parent domain instead, which is the ITS domain.
--- drivers/irqchip/irq-gic-v3-its-msi-parent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-gic-v3-its-msi-parent.c +1 -1
@@ -134,7 +134,7 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,int ret;if (dev->of_node) - ret =of_pmsi_get_dev_id (domain, dev, &dev_id); + ret =of_pmsi_get_dev_id (domain->parent, dev, &dev_id);else ret =iort_pmsi_get_dev_id (dev, &dev_id);if (ret)
Signature · 1 line
2.39.2
The following commit has been merged into the irq/msi branch of tip:
The following commit has been merged into the irq/msi branch of tip:
Commit-ID: c9b4f313f6b83ac80e9d51845d092c32513efdb4 Gitweb: https://git.kernel.org/tip/c9b4f313f6b83ac80e9d51845d092c32513efdb4 Author: Marc Zyngier <[email protected]> AuthorDate: Thu, 18 Jul 2024 08:58:04 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Thu, 18 Jul 2024 20:34:46 +02:00
irqchip/gic-v3-its: Correctly fish out the DID for platform MSI
Similarly to PCI where msi-map/msi-mask are used to compute the full RID (aka DID in ITS speak), use the msi-parent as the discovery mechanism, since there is no way a device can generally express its ID.
However, since switching to a per-device MSI domain model, the domain passed to its_pmsi_prepare() is the wrong one, and points to the device's instead of the ITS'. Bad.
Use the parent domain instead, which is the ITS domain.
--- drivers/irqchip/irq-gic-v3-its-msi-parent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-gic-v3-its-msi-parent.c +1 -1
@@ -134,7 +134,7 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,int ret;if (dev->of_node) - ret =of_pmsi_get_dev_id (domain, dev, &dev_id); + ret =of_pmsi_get_dev_id (domain->parent, dev, &dev_id);else ret =iort_pmsi_get_dev_id (dev, &dev_id);if (ret)