sunrpc: avoid -Wformat-security warning
Subsystems (4)
PATCH 1/1 sunrpc: avoid -Wformat-security warning
From: Arnd Bergmann <[email protected]>
Using a non-constant string as an sprintf-style is potentially dangerous:
net/sunrpc/svc.c: In function 'param_get_pool_mode':net/sunrpc/svc.c:164:32: error: format not a string literal and no format arguments [-Werror=format-security]
Use a literal "%s" format instead.
--- net/sunrpc/svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/svc.c +1 -1
@@ -161,7 +161,7 @@ param_get_pool_mode(char *buf, const struct kernel_param *kp) str[len] ='\n' ; str[len +1 ] ='\0' ; -return sysfs_emit (buf, str); +return sysfs_emit (buf,"%s" , str); } module_param_call(pool_mode, param_set_pool_mode, param_get_pool_mode,
Signature · 1 line
2.39.2
Quoted 20 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Using a non-constant string as an sprintf-style is potentially dangerous:
net/sunrpc/svc.c: In function 'param_get_pool_mode':net/sunrpc/svc.c:164:32: error: format not a string literal and no format arguments [-Werror=format-security]Use a literal "%s" format instead.
Fixes 5f71f3c32553 ("sunrpc: refactor pool_mode setting code")Signed-off-by Arnd Bergmann <[email protected]>--- net/sunrpc/svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/sunrpc/svc.c +0
-0
net/sunrpc/svc.c param_get_pool_mode(char *buf, const struct kernel_param *kp) · line 167
Quoted 8 lines
net/sunrpc/svc.c +1
-1@@ -161,7 +161,7 @@ param_get_pool_mode(char *buf, const struct kernel_param *kp) str[len] ='\n' ; str[len +1 ] ='\0' ; -return sysfs_emit (buf, str); +return sysfs_emit (buf,"%s" , str); } module_param_call(pool_mode, param_set_pool_mode, param_get_pool_mode,
Chuck Lever
AppliedQuoted 31 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Using a non-constant string as an sprintf-style is potentially dangerous:
net/sunrpc/svc.c: In function 'param_get_pool_mode':net/sunrpc/svc.c:164:32: error: format not a string literal and no format arguments [-Werror=format-security]Use a literal "%s" format instead.
Fixes 5f71f3c32553 ("sunrpc: refactor pool_mode setting code")Signed-off-by Arnd Bergmann <[email protected]>--- net/sunrpc/svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/sunrpc/svc.c +1
-1@@ -161,7 +161,7 @@ param_get_pool_mode(char *buf, const struct kernel_param *kp) str[len] ='\n' ; str[len +1 ] ='\0' ; -return sysfs_emit (buf, str); +return sysfs_emit (buf,"%s" , str); } module_param_call(pool_mode, param_set_pool_mode, param_get_pool_mode,Signature · 1 line
2.39.2
Applied to nfsd-fixes (for v6.11-rc). Thanks!
Signature · 1 line
Chuck Lever