Skip to contentSkip to conversation

VirtIO-GPU spec improvements

PATCH In review Dmitry Osipenko 4 participants 9 messages Jul 19, 2024 – Feb 26, 2025

lore
Share & tools
lore
#0 lore raw

v3 cover VirtIO-GPU spec improvements

Hi,

This is a repost of v2 to the new virtio-comment mailing list. Michael Tsirkin suggested to repost the patches, here they are.

Dmitry Osipenko (3):
virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
virtio-gpu: Update venus-protocol URL

 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Signature · 1 line
2.45.2
#1 lore raw

PATCH v3 1/3 virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN

Initially, the plan was to use a single GFXSTREAM context for all of GLES/GL/VK gfxstream sub-contexts. Over time the plan changed and GFXSTREAM context became used exclusively for Vulkan, while GLES/GL contexts were moved to a new own experimental virtio-gpu contexts. Rename GFXSTREAM capset to GFXSTREAM_VULKAN.

---
 device-types/gpu/description.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
device-types/gpu/description.tex +3 -3
index 443524851a05..4b8dd7733c31 100644
@@ -530,8 +530,8 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	the first edition of Virgl (Gallium OpenGL) protocol.
   \item \href{https://gitlab.freedesktop.org/virgl/virglrenderer/-/blob/master/src/virgl_hw.h#L550}{VIRTIO_GPU_CAPSET_VIRGL2} --
 	the second edition of Virgl (Gallium OpenGL) protocol after the capset fix.
-  \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/master/protocols/}{VIRTIO_GPU_CAPSET_GFXSTREAM} --
-	gfxtream's (mostly) autogenerated GLES and Vulkan streaming protocols.
+  \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/android13-release/protocols/vulkan/}{VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN} --
+	gfxtream's (mostly) autogenerated Vulkan streaming protocol.
   \item \href{https://gitlab.freedesktop.org/olv/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
@@ -547,7 +547,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 
 #define VIRTIO_GPU_CAPSET_VIRGL 1
 #define VIRTIO_GPU_CAPSET_VIRGL2 2
-#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
+#define VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN 3
 #define VIRTIO_GPU_CAPSET_VENUS 4
 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5
 struct virtio_gpu_resp_capset_info {
Signature · 1 line
2.45.2
#2 lore raw

PATCH v3 2/3 virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM

In reply to Dmitry Osipenko

Document VIRTIO_GPU_CAPSET_DRM that is capset for the DRM native context protocols which implement Linux DRM UAPIs over VirtIO-GPU, effectively exposing host GPU to a Linux guest like it's a native/baremetal GPU.

---
 device-types/gpu/description.tex | 3 +++
 1 file changed, 3 insertions(+)
device-types/gpu/description.tex +3 -0
index 4b8dd7733c31..29c8a97c3a3f 100644
@@ -536,6 +536,8 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
 	protocol for display virtualization via Wayland proxying.
+  \item \href{https://gitlab.freedesktop.org/virgl/virglrenderer/-/tree/master/src/drm}{VIRTIO_GPU_CAPSET_DRM} --
+	DRM native context protocols.
   \end{itemize*}
 
 \begin{lstlisting}
@@ -550,6 +552,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 #define VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN 3
 #define VIRTIO_GPU_CAPSET_VENUS 4
 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5
+#define VIRTIO_GPU_CAPSET_DRM 6
 struct virtio_gpu_resp_capset_info {
         struct virtio_gpu_ctrl_hdr hdr;
         le32 capset_id;
Signature · 1 line
2.45.2
#3 lore raw

PATCH v3 3/3 virtio-gpu: Update venus-protocol URL

In reply to Dmitry Osipenko

The venus-protocol was moved to the main virgl gitlab group a year ago. Update the link in the GPU documentation.

---
 device-types/gpu/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
device-types/gpu/description.tex +1 -1
index 29c8a97c3a3f..e633787aacad 100644
@@ -532,7 +532,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	the second edition of Virgl (Gallium OpenGL) protocol after the capset fix.
   \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/android13-release/protocols/vulkan/}{VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN} --
 	gfxtream's (mostly) autogenerated Vulkan streaming protocol.
-  \item \href{https://gitlab.freedesktop.org/olv/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
+  \item \href{https://gitlab.freedesktop.org/virgl/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
 	protocol for display virtualization via Wayland proxying.
Signature · 1 line
2.45.2
#5 lore raw
In reply to Dmitry Osipenko
Quoted 5 lines · Dmitry Osipenko

Hi,

This is a repost of v2 to the new virtio-comment mailing list. Michael Tsirkin suggested to repost the patches, here they are.

Quoted 8 lines

Dmitry Osipenko (3):
virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
virtio-gpu: Update venus-protocol URL

 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Signature · 2 lines
Best regards,
Dmitry
#6 lore raw
Quoted 11 lines · Dmitry Osipenko
Quoted 10 lines · Dmitry Osipenko

Hi,

This is a repost of v2 to the new virtio-comment mailing list. Michael Tsirkin suggested to repost the patches, here they are.

Dmitry Osipenko (3):
virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
virtio-gpu: Update venus-protocol URL

Quoted 6 lines
Quoted 3 lines
 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

I think what is missing is to explicitly request a vote as is explained in 2) at
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.

Thanks, Matias

#7 lore raw
Quoted 16 lines · Matias Ezequiel Vara Larsen
Quoted 15 lines · Dmitry Osipenko
Quoted 13 lines · Dmitry Osipenko

Hi,

This is a repost of v2 to the new virtio-comment mailing list. Michael Tsirkin suggested to repost the patches, here they are.

Dmitry Osipenko (3):
virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
virtio-gpu: Update venus-protocol URL

 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Quoted 7 lines
Quoted 2 lines

I think what is missing is to explicitly request a vote as is explained in 2) at
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.

Thanks, Matias

if a vote is already desired, then yes.

#8 lore raw
Quoted 19 lines · Michael S. Tsirkin
Quoted 18 lines · Matias Ezequiel Vara Larsen
Quoted 17 lines · Dmitry Osipenko
Quoted 5 lines · Dmitry Osipenko

Hi,

This is a repost of v2 to the new virtio-comment mailing list. Michael Tsirkin suggested to repost the patches, here they are.

Quoted 8 lines

Dmitry Osipenko (3):
virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
virtio-gpu: Update venus-protocol URL

 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Quoted 8 lines
Quoted 5 lines

I think what is missing is to explicitly request a vote as is explained in 2) at
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.

Thanks, Matias

if a vote is already desired, then yes.

Please open the vote.

Signature · 2 lines
Best regards,
Dmitry