Skip to contentSkip to conversation

ALSA: ump: Force 1 Group for MIDI1 FBs

PATCH New Takashi Iwai 1 participant 1 message Jul 22, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ump: Force 1 Group for MIDI1 FBs

When a Function Block declares it being a legacy MIDI1 device, it has to be only with a single UMP Group. Correct the attribute when a device declares it wrongly.

Fixes 37e0e14128e0 ("ALSA: ump: Support UMP Endpoint and Function Block parsing")
---
 sound/core/ump.c | 6 ++++++
 1 file changed, 6 insertions(+)
sound/core/ump.c +6 -0
index 3f61220c23b4..4b10aa5819bf 100644
@@ -733,6 +733,12 @@ static void fill_fb_info(struct snd_ump_endpoint *ump,
 		info->block_id, info->direction, info->active,
 		info->first_group, info->num_groups, info->midi_ci_version,
 		info->sysex8_streams, info->flags);
+
+	if ((info->flags & SNDRV_UMP_BLOCK_IS_MIDI1) && info->num_groups != 1) {
+		info->num_groups = 1;
+		ump_dbg(ump, "FB %d: corrected groups to 1 for MIDI1\n",
+			info->block_id);
+	}
 }
 
 /* check whether the FB info gets updated by the current message */
Signature · 1 line
2.43.0