Skip to contentSkip to conversation

doc: announce vhost changes to support asymmetric operation

PATCH In review Gowrishankar Muthukrishnan 2 participants 3 messages Jul 22, 2024 – Jul 25, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: announce vhost changes to support asymmetric operation

Announce vhost ABI changes to modify few functions to support asymmetric crypto operation.

--
RFC:
https://patches.dpdk.org/project/dpdk/patch/[email protected]/

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -0
index 6948641ff6..2f5c2c5a34 100644
@@ -147,3 +147,10 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* vhost: The function ``rte_vhost_crypto_create`` will accept a new parameter
+  to specify rte_mempool for asymmetric crypto session. The function
+  ``rte_vhost_crypto_finalize_requests`` will accept two new parameters,
+  where the first one is to specify vhost device id and other one is to specify
+  the virtio queue index. These two modifications are required to support
+  asymmetric crypto operation in vhost crypto and will break ABI.
Signature · 1 line
2.21.0
#1 lore raw
Quoted 8 lines · Gowrishankar Muthukrishnan

Announce vhost ABI changes to modify few functions to support asymmetric crypto operation.

--
RFC:
https://patches.dpdk.org/project/dpdk/patch/[email protected]/

Looks like in this case adding new arguments to function. Could you check ABI versing helps here? It seems like it can be easy manged with ABI versioning.

https://doc.dpdk.org/guides/contributing/abi_versioning.html

Quoted 22 lines
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -1
index 6948641ff6..2f5c2c5a34 100644
@@ -147,3 +147,10 @@ Deprecation Notices
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status.
+
+* vhost: The function ``rte_vhost_crypto_create`` will accept a new parameter
+  to specify rte_mempool for asymmetric crypto session. The function
+  ``rte_vhost_crypto_finalize_requests`` will accept two new parameters,
+  where the first one is to specify vhost device id and other one is to specify
+  the virtio queue index. These two modifications are required to support
+  asymmetric crypto operation in vhost crypto and will break ABI.
--

2.21.0

#2 lore raw

Sure Jerin. I’ll drop this proposal as ABI versioning could help. Thanks.

Looks like in this case adding new arguments to function. Could you

check ABI versing helps here? It seems like it can be easy manged with

ABI versioning.