Skip to contentSkip to conversation

cache: StarFive: Require a 64-bit system

PATCH Applied Palmer Dabbelt 3 participants 3 messages Jul 22, 2024 – Aug 1, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cache: StarFive: Require a 64-bit system

From: Palmer Dabbelt <[email protected]>

This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.

Fixes cabff60ca77d ("cache: Add StarFive StarLink cache management")

---
Changes since v1 <[email protected]>:

* Drop the STARLINK_CACHE_ADDRESS_RANGE_MASK chunk, it's meaningless without 32-bit support (as Emil pointed out on IRC).

---
 drivers/cache/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/cache/Kconfig +1 -0
index 94abd8f632a7..db51386c663a 100644
@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE
 	bool "StarFive StarLink Cache controller"
 	depends on RISCV
 	depends on ARCH_STARFIVE
+	depends on 64BIT
 	select RISCV_DMA_NONCOHERENT
 	select RISCV_NONSTANDARD_CACHE_OPS
 	help
Signature · 1 line
2.45.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Palmer Dabbelt

From: Palmer Dabbelt <[email protected]>

This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.

Fixes cabff60ca77d ("cache: Add StarFive StarLink cache management")
Quoted 24 lines

---
Changes since v1 <[email protected]>:

* Drop the STARLINK_CACHE_ADDRESS_RANGE_MASK chunk, it's meaningless without 32-bit support (as Emil pointed out on IRC).

---
 drivers/cache/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/cache/Kconfig +1 -1
index 94abd8f632a7..db51386c663a 100644
@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE
        bool "StarFive StarLink Cache controller"
        depends on RISCV
        depends on ARCH_STARFIVE
+       depends on 64BIT
        select RISCV_DMA_NONCOHERENT
        select RISCV_NONSTANDARD_CACHE_OPS
        help
--

2.45.2

#2 lore raw
In reply to Palmer Dabbelt
This patch was applied to riscv/linux.git (fixes) by Palmer Dabbelt <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:

Quoted 11 lines · On Mon, 22 Jul 2024 08:45:20 -0700 you wrote:

From: Palmer Dabbelt <[email protected]>

This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.

Fixes cabff60ca77d ("cache: Add StarFive StarLink cache management")

[...]

Here is the summary with links:
- [v2] cache: StarFive: Require a 64-bit system

    https://git.kernel.org/riscv/c/57e5c814e915

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html