meson: build chardev trace files when have_block
PATCH 1/1 meson: build chardev trace files when have_block
The QSD depends on chardev code, and is built when have_tools is true. This means conditionalizing chardev trace on have_system is wrong, we need have_block which is set have_system || have_tools.
This latent bug was historically harmless because only the spice chardev included tracing, which wasn't built in a !have_system scenario.
--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This is an add-on needed for:
https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05068.html
since I discovered a tools-only build fails
meson.build +1 -1
@@ -3327,6 +3327,7 @@ if have_block trace_events_subdirs += [ 'authz', 'block', + 'chardev', 'io', 'nbd', 'scsi',
@@ -3338,7 +3339,6 @@ if have_system 'audio', 'backends', 'backends/tpm', - 'chardev', 'ebpf', 'hw/9pfs', 'hw/acpi',
Signature · 1 line
2.45.2
Quoted 10 lines · Daniel P. Berrangé
The QSD depends on chardev code, and is built when
have_toolsis true. This means conditionalizing chardev trace onhave_systemis wrong, we needhave_blockwhich is sethave_system||have_tools.This latent bug was historically harmless because only the spice chardev included tracing, which wasn't built in a !have_system scenario.
Signed-off-by Daniel P. Berrangé <[email protected]>
Quoted 34 lines
--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)This is an add-on needed for:
https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05068.html
since I discovered a tools-only build fails
meson.build +1
-2@@ -3327,6 +3327,7 @@ if have_block trace_events_subdirs += [ 'authz', 'block', + 'chardev', 'io', 'nbd', 'scsi',@@ -3338,7 +3339,6 @@ if have_system 'audio', 'backends', 'backends/tpm', - 'chardev', 'ebpf', 'hw/9pfs', 'hw/acpi', --2.45.2