Skip to contentSkip to conversation

mm: memcg: add cacheline padding after lruvec in mem_cgroup_per_node

PATCH Applied Roman Gushchin 2 participants 2 messages Jul 23, 2024

Subsystems (2)
lore
Share & tools
lore

Roman Gushchin

author maintainer
#0 lore raw

PATCH 1/1 mm: memcg: add cacheline padding after lruvec in mem_cgroup_per_node

Oliver Sand reported a performance regression caused by commit 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node"), which puts some fields of the mem_cgroup_per_node structure under the CONFIG_MEMCG_V1 config option. Apparently it causes a false cache sharing between lruvec and lru_zone_size members of the structure. Fix it by adding an explicit padding after the lruvec member.

Even though the padding is not required with CONFIG_MEMCG_V1 set, it seems like the introduced memory overhead is not significant enough to warrant another divergence in the mem_cgroup_per_node layout, so the padding is added unconditionally.

Fixes 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node")
---
 include/linux/memcontrol.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/memcontrol.h +1 -0
index 7e2eb091049a..0e5bf25d324f 100644
@@ -109,6 +109,7 @@ struct mem_cgroup_per_node {
 
 	/* Fields which get updated often at the end. */
 	struct lruvec		lruvec;
+	CACHELINE_PADDING(_pad2_);
 	unsigned long		lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS];
 	struct mem_cgroup_reclaim_iter	iter;
 };
Signature · 1 line
2.45.2.1089.g2a221341d9-goog
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Roman Gushchin

Oliver Sand

Oliver Sang

Quoted 13 lines

reported a performance regression caused by
commit 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node"), which puts some fields of the mem_cgroup_per_node structure under the CONFIG_MEMCG_V1 config option. Apparently it causes a false cache sharing between lruvec and lru_zone_size members of the structure. Fix it by adding an explicit padding after the lruvec member.

Even though the padding is not required with CONFIG_MEMCG_V1 set, it seems like the introduced memory overhead is not significant enough to warrant another divergence in the mem_cgroup_per_node layout, so the padding is added unconditionally.

Quoted 5 lines
Fixes 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node")