Skip to contentSkip to conversation

dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints

PATCH In review Rob Herring (Arm) 3 participants 4 messages Jul 23, 2024 – Jul 27, 2024

Subsystems (4)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints

The 'single-channel' property is an uint32, not an array, so 'items' is an incorrect constraint. This didn't matter until dtschema recently changed how properties are decoded. This results in this warning:

Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
channel@1:single-channel: 1 is not of type 'array'

Fixes caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +2 -3
index a03da9489ed9..190889c7b62a 100644
@@ -120,9 +120,8 @@ patternProperties:
         description:
           Positive input can be connected to pins AIN1 to AIN16 by choosing the
           appropriate value from 1 to 16. Negative input is connected to AINCOM.
-        items:
-          minimum: 1
-          maximum: 16
+        minimum: 1
+        maximum: 16
 
     oneOf:
       - required:
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Rob Herring (Arm)

The 'single-channel' property is an uint32, not an array, so 'items' is an incorrect constraint. This didn't matter until dtschema recently changed how properties are decoded. This results in this warning:

Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
channel@1:single-channel: 1 is not of type 'array'

Fixes caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
Quoted 24 lines
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +2 -3
index a03da9489ed9..190889c7b62a 100644
@@ -120,9 +120,8 @@ patternProperties:
         description:
           Positive input can be connected to pins AIN1 to AIN16 by choosing the
           appropriate value from 1 to 16. Negative input is connected to AINCOM.
-        items:
-          minimum: 1
-          maximum: 16
+        minimum: 1
+        maximum: 16
 
     oneOf:
       - required:
Signature · 1 line
2.43.0
author maintainer
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 4 lines · Rob Herring (Arm)

The 'single-channel' property is an uint32, not an array, so 'items' is an incorrect constraint. This didn't matter until dtschema recently changed how properties are decoded. This results in this warning:

Quoted 9 lines

Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
channel@1:single-channel: 1 is not of type 'array'

Fixes caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

I have other fixes for rc1 already, so I've applied this one.

Rob

maintainer Acked-by
#3 lore raw
Quoted 15 lines · On Fri, 26 Jul 2024 13:52:58 -0500 "Rob Herring (Arm)" <[email protected]> wrote:
Quoted 4 lines · Rob Herring (Arm)

The 'single-channel' property is an uint32, not an array, so 'items' is an incorrect constraint. This didn't matter until dtschema recently changed how properties are decoded. This results in this warning:

Quoted 9 lines

Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
channel@1:single-channel: 1 is not of type 'array'

Fixes caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 3 lines

I have other fixes for rc1 already, so I've applied this one.

Rob

Cool
For the record (no need to add to patch!)