Skip to contentSkip to conversation

configure: Respect relative prefix path

PATCH Applied Gabriel Krisman Bertazi 2 participants 2 messages Jul 23, 2024 – Jul 24, 2024 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Respect relative prefix path

When the user passes a relative path, we end up splitting the installation in multiple directories because it is relative to $CWD, which changes when we recurse into subdirectories.

A common idiom I use is:

  ./configure --prefix=install ; make ; make install

and that currently results in part of the installation inside prefix and part of it elsewhere:

 $ find . -type d  -name 'install'
  ./src/install
  ./install

Not biggy, but annoying. Let's use the path where the configure command was invoked as basedir, like other projects usually do.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index f6b590b..21a9356 100755
@@ -10,7 +10,7 @@ for opt do
   case "$opt" in
   --help|-h) show_help=yes
   ;;
-  --prefix=*) prefix="$optarg"
+  --prefix=*) prefix="$(realpath -s $optarg)"
   ;;
   --includedir=*) includedir="$optarg"
   ;;
Signature · 1 line
2.45.2
maintainer Applied
#1 lore raw
Quoted 9 lines · Gabriel Krisman Bertazi

When the user passes a relative path, we end up splitting the installation in multiple directories because it is relative to $CWD, which changes when we recurse into subdirectories.

A common idiom I use is:

  ./configure --prefix=install ; make ; make install

[...]

Applied, thanks!

[1/1] configure: Respect relative prefix path

      commit: 476a6a9e92f390b16d12a3d66c046d456b5783e3

Best regards,

Signature · 1 line
Jens Axboe