ublk: fix UBLK_CMD_DEL_DEV_ASYNC handling
Subsystems (2)
PATCH 1/1 ublk: fix UBLK_CMD_DEL_DEV_ASYNC handling
In ublk_ctrl_uring_cmd(), ioctl command NR should be used for matching _IOC_NR(cmd_op).
Fix it by adding one private macro, and this way is clean.
Fixes 13fe8e6825e4 ("ublk: add UBLK_CMD_DEL_DEV_ASYNC")
Signed-off-by Ming Lei <[email protected]>
--- drivers/block/ublk_drv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/block/ublk_drv.c +4 -1
@@ -48,6 +48,9 @@#define UBLK_MINORS (1U << MINORBITS) +/* private ioctl command mirror */ +#define UBLK_CMD_DEL_DEV_ASYNC _IOC_NR(UBLK_U_CMD_DEL_DEV_ASYNC) +/* All UBLK_F_* have to be included into UBLK_F_ALL */ #define UBLK_F_ALL (UBLK_F_SUPPORT_ZERO_COPY \ | UBLK_F_URING_CMD_COMP_IN_TASK \
@@ -2903,7 +2906,7 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd,case UBLK_CMD_DEL_DEV : ret =ublk_ctrl_del_dev (&ub, true);break ; -case UBLK_U_CMD_DEL_DEV_ASYNC : +case UBLK_CMD_DEL_DEV_ASYNC : ret =ublk_ctrl_del_dev (&ub, false);break ;case UBLK_CMD_GET_QUEUE_AFFINITY :
Signature · 1 line
2.45.2
Quoted 6 lines · Ming Lei
In
ublk_ctrl_uring_cmd(), ioctl command NR should be used for matching_IOC_NR(cmd_op).Fix it by adding one private macro, and this way is clean.
Applied, thanks!
[1/1] ublk: fix UBLK_CMD_DEL_DEV_ASYNC handling
commit: 55fbb9a5d64e0e590cad5eacc16c99f2482a008f
Best regards,
Signature · 1 line
Jens Axboe