mini-os: put sanity_check() under CONFIG_TEST
PATCH v2 1/1 mini-os: put sanity_check() under CONFIG_TEST
Hide the sanity_check() function, as it is used nowhere. By putting it under #ifdef CONFIG_TEST it will stay around, but it won't be included in normal production builds.
Call sanity_check() from the periodic thread of the test app, causing a sanity check every second.
Since any application linked with Mini-OS can't call sanity_check() (there is no EXPORT_SYMBOL for it), there is zero chance of breaking any use case.
---
V2:
- don't remove it, but just hide it (Samuel Thibault)
--- include/lib.h | 2 ++ mm.c | 2 ++ test.c | 1 + 3 files changed, 5 insertions(+)
include/lib.h +2 -0
@@ -152,8 +152,10 @@ do { \#define BUG_ON (x) ASSERT(!(x)) +#ifdef CONFIG_TEST /* Consistency check as much as possible. */ void sanity_check (void ); +#endif /* Get own domid. */ domid_t get_domid (void );
mm.c +2 -0
@@ -395,6 +395,7 @@ void fini_mm(void) { } +#ifdef CONFIG_TEST void sanity_check (void ) {int x;
@@ -410,3 +411,4 @@ void sanity_check(void) } } } +#endif
test.c +1 -0
@@ -185,6 +185,7 @@ static void periodic_thread(void *p) {gettimeofday (&tv,NULL );printk ("T(s=%ld us=%ld)\n" , tv.tv_sec, tv.tv_usec); +sanity_check ();msleep (1000 ); } }
Signature · 1 line
2.43.0
Juergen Gross, le jeu. 25 juil. 2024 08:42:54 +0200, a ecrit:
Quoted 4 lines
Hide the
sanity_check()function, as it is used nowhere. By putting it under #ifdefCONFIG_TESTit will stay around, but it won't be included in normal production builds.
Quoted 8 lines
Call
sanity_check()from the periodic thread of the test app, causing a sanity check every second.Since any application linked with Mini-OS can't call
sanity_check()(there is noEXPORT_SYMBOLfor it), there is zero chance of breaking any use case.Signed-off-by Juergen Gross <[email protected]>
Thanks!
Quoted 56 lines
---
V2:
- don't remove it, but just hide it (Samuel Thibault)--- include/lib.h | 2 ++ mm.c | 2 ++ test.c | 1 + 3 files changed, 5 insertions(+)include/lib.h +2
-0@@ -152,8 +152,10 @@ do { \#define BUG_ON (x) ASSERT(!(x)) +#ifdef CONFIG_TEST /* Consistency check as much as possible. */ void sanity_check (void ); +#endif /* Get own domid. */ domid_t get_domid (void );mm.c +2
-0@@ -395,6 +395,7 @@ void fini_mm(void) { } +#ifdef CONFIG_TEST void sanity_check (void ) {int x;@@ -410,3 +411,4 @@ void sanity_check(void) } } } +#endif test.c +1
-0@@ -185,6 +185,7 @@ static void periodic_thread(void *p) {gettimeofday (&tv,NULL );printk ("T(s=%ld us=%ld)\n" , tv.tv_sec, tv.tv_usec); +sanity_check ();msleep (1000 ); } }Signature · 1 line
2.43.0
Signature · 4 lines
Samuel `When you say "I wrote a program that crashed Windows", people just stare at you blankly and say "Hey, I got those with the system, *for free*".' (By Linus Torvalds)